Configure vfio-user build options with meson setup

ninja < 1.9 uses per-second granularity timestamps to check if build
options are reconfigured by "meson configure". This granularity is not
suffici

Configure vfio-user build options with meson setup

ninja < 1.9 uses per-second granularity timestamps to check if build
options are reconfigured by "meson configure". This granularity is not
sufficient if build.ninja is updated fast enough and which results in
ninja not applying reconfigured build options.

To fix this, commit 510f4c134a21b45ff3a5add9ebc6c6cf7e49aeab added 0.5 second
sleep between "meson setup" and "meson configure" but unfortunately it is not
sufficent and build fails sometimes.

Instead of adding sleep this patch proposes to configure build options with
"meson setup".

Change-Id: Idb66abccc3921873f5397ac4edf401ce7233ad0f
Signed-off-by: Swapnil Ingle <swapnil.ingle@nutanix.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19319
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: John Levon <levon@movementarian.org>
Community-CI: Mellanox Build Bot

show more ...

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date defa

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the 4 digit year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc). Contribution date used
"--follow -C95%" to get the most accurate date.

Note that several files in this patch didn't end the license/(c)
block with a blank comment line so these were added as the vast
majority of files do have this last blank line. Simply there for
consistency.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot

show more ...

vfiouserbuild: fix build when using dash

When /bin/sh is dash (such as on Ubuntu), the build now fails with:

/bin/sh: 2: Syntax error: Missing '))'

Avoid this problem by adding a space between the

vfiouserbuild: fix build when using dash

When /bin/sh is dash (such as on Ubuntu), the build now fails with:

/bin/sh: 2: Syntax error: Missing '))'

Avoid this problem by adding a space between the opening brackets.

Signed-off-by: John Levon <john.levon@nutanix.com>
Change-Id: I420788bcfaacfafc5f060fb56866edcfe2a0f1a8
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14392
Reviewed-by: Jonathan Davies <jonathan.davies@nutanix.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

Make libvfio-user build reliable on ninja < 1.9

Sadly, before v1.9.0, ninja used per-second granularity timestamps.
This had the unfortunate consequence that a "meson configure"
immediately followin

Make libvfio-user build reliable on ninja < 1.9

Sadly, before v1.9.0, ninja used per-second granularity timestamps.
This had the unfortunate consequence that a "meson configure"
immediately following a "meson setup" would not be picked up by ninja,
thinking that no regeneration of the build config was needed during
"meson compile". See https://github.com/mesonbuild/meson/issues/3992 for
background and general dismay.

This means that VFIO_USER_CFG_OPTS are ignored 50% of the time,
depending on the wall clock. Unlucky builds would therefore end up with
libvfio-user being built as a shared object (rather than a static
archive) and for installation in /usr/local/lib64 (rather than
/usr/local/lib, as per VFIO_USER_LIB_PREFIX).

This is worked around by injecting a sleep between "meson setup" and
"meson configure" when ninja < 1.9 is in use.

Note that ninja v1.8.2 ships in el8, so suffers from this problem.

Signed-off-by: Jonathan Davies <jonathan.davies@nutanix.com>
Change-Id: I4d555dcc5bc63df4475ec6fd6014e3502123e92b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14236
Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: John Levon <levon@movementarian.org>
Reviewed-by: Thanos Makatos <thanos.makatos@nutanix.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

libvfio-user: compile shared library based on CONFIG_SHARED flag

Fix #2556.

Change-Id: I843dace8408d09bdb9222a37731a95732736bb78
Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-on:

libvfio-user: compile shared library based on CONFIG_SHARED flag

Fix #2556.

Change-Id: I843dace8408d09bdb9222a37731a95732736bb78
Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13041
Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

Replace most BSD 3-clause license text with SPDX identifier.

Many open source projects have moved to using SPDX identifiers
to specify license information, reducing the amount of
boilerplate code in

Replace most BSD 3-clause license text with SPDX identifier.

Many open source projects have moved to using SPDX identifiers
to specify license information, reducing the amount of
boilerplate code in every source file. This patch replaces
the bulk of SPDK .c, .cpp and Makefiles with the BSD-3-Clause
identifier.

Almost all of these files share the exact same license text,
and this patch only modifies the files that contain the
most common license text. There can be slight variations
because the third clause contains company names - most say
"Intel Corporation", but there are instances for Nvidia,
Samsung, Eideticom and even "the copyright holder".

Used a bash script to automate replacement of the license text
with SPDX identifier which is checked into scripts/spdx.sh.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: Iaa88ab5e92ea471691dc298cfe41ebfb5d169780
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12904
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Dong Yi <dongx.yi@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: <qun.wan@intel.com>

show more ...