lib/trace: add extra check in trace parser when determining first entry

If we simply set _tsc_offset to the highest first_tsc out of
all reactors when none have overflowed its circular buffer,
it wi

lib/trace: add extra check in trace parser when determining first entry

If we simply set _tsc_offset to the highest first_tsc out of
all reactors when none have overflowed its circular buffer,
it will cut off the first few entries of the scheduler tracepoints.

For example, if we have 4 reactors with reactor 0 as the scheduling
reactor, reactor 0 will emit a SCHEDULING_PERIOD_START trace,
as well as its CORE_STATS and THREAD_STATS. Then reactors 1-3 will
do the same. When we parse the trace, the first
SCHEDULING_PERIOD_START, CORE_STATS, and THREAD_STATS of reactors
0, 1, and 2 will be erased because reactor 3 started last and
has the highest first_tsc.

Therefore, we need to check if any reactors have overflowed their
circular buffer before truncating the entries.

Change-Id: Ifae44a7e7d30b7d2f283a449318fe3083412dc8f
Signed-off-by: Anisa Su <anisa.su@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25043
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

add new trace BLOB_REQ_SET_START and BLOB_REQ_SET_COMPLETE.

Through the both new trace, the bdev_io trace of lvol and the bdev_io
trace of base bdev of blobstore can be connected in series. Like thi

add new trace BLOB_REQ_SET_START and BLOB_REQ_SET_COMPLETE.

Through the both new trace, the bdev_io trace of lvol and the bdev_io
trace of base bdev of blobstore can be connected in series. Like this:

RDMA_REQ_RDY_TO_EXECUTE id: r31
BDEV_IO_START size: 8 id: i2964 (r31)
BLOB_REQ_SET_START id: a11 (i2964)
BDEV_IO_START size: 8 id: i2965 (a11)
BDEV_NVME_IO_START id: N2957 (i2965)
NVME_PCIE_SUBMIT id: p2959 (N2957)
NVME_PCIE_COMPLETE id: p2959 (N2957)
BDEV_NVME_IO_DONE id: N2957 (i2965)
BDEV_IO_DONE id: i2965 (a11)
BLOB_REQ_SET_COMPLETE id: a11 (i2964)
BDEV_IO_DONE id: i2964 (r31)
RDMA_REQ_EXECUTED id: r31

Change-Id: I607428b094031814627ac4192b9e3defe7ed5337
Signed-off-by: Xupeng Mingtu <jingmamour@gmail.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24130
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

trace_parser: wrong parameter to sizeof() operator

The issue was detected by Coverity scan.

After changing spdk_trace_parser_entry structure layout,
checking size of the union was not modified, res

trace_parser: wrong parameter to sizeof() operator

The issue was detected by Coverity scan.

After changing spdk_trace_parser_entry structure layout,
checking size of the union was not modified, resulting in
wrong value used to determine if 'argoff' is still valid.
This in turn could lead to out-of-bound access to
pe->args[].u.string[] table as 'argoff' could be greater
than a table size.
The parameter passed to sizeof() operator shall be
'pe->args[0].u.string', not 'pe->args[0]'.

Change-Id: Ie1ea7cf051f178983e78b29f591e734245373826
Signed-off-by: Marcin Spiewak <marcin.spiewak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22719
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

trace_parser: add flag for arguments used for related objects

Some tracepoints have an argument that is a context pointer for some other
object type. The trace app already decode this information, s

trace_parser: add flag for arguments used for related objects

Some tracepoints have an argument that is a context pointer for some other
object type. The trace app already decode this information, showing the ID for
that related object.

Since the ID is already shown, the context pointer itself isn't useful, so
add a flag to note those arguments, so we can omit printing the context
pointer.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I3f6521ff5594cdc4c635c23a612c8f0d2f3717dd
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22102
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

trace_parser: put argument union into a struct

A future patch will add a per-argument field separate from the argument types,
so put that argument union into a struct now to prepare for that future

trace_parser: put argument union into a struct

A future patch will add a per-argument field separate from the argument types,
so put that argument union into a struct now to prepare for that future
patch.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Ia2aaa5b53332c2c04d731358a07ea99bd7e9ec44
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22101
Community-CI: Mellanox Build Bot
Reviewed-by: Seung yeon Shin <syeon.shin@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

trace: merge spdk_trace_flags into spdk_trace_file

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I8a070f986825de2470d5873eaeed3849d36bf1af
Reviewed-on: https://review.spdk.io/gerrit/

trace: merge spdk_trace_flags into spdk_trace_file

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I8a070f986825de2470d5873eaeed3849d36bf1af
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21790
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

trace: rename spdk_trace_histories to spdk_trace_file.

The new name is obviously a better fit for what this structure has
become.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I91e9

trace: rename spdk_trace_histories to spdk_trace_file.

The new name is obviously a better fit for what this structure has
become.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I91e96bea1d1d507b601e131e222f3181909f35de
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21826
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to preve

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components

Due to patch below being introduced after v24.01 code freeze,
bdev lib version should not be increased:
61623c5ca9 bdev: add spdk_bdev_io padding in place of io_submit_ch

Short reference to how the versions were changed:
MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)
for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \
sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; done
find . -name "Makefile" -exec \
sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I0166d6be6c17bbbf985d48b5dfcb36f1d4af1b48
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21582
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

so_ver: increase all major versions

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where

so_ver: increase all major versions

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

Disabled test for increasing SO version without ABI change, as
that is goal of this patch. This check shall be removed with SPDK 23.05
release.
Looks like this was left over from prior LTS, to avoid that
make sure it is only skipped when running against v23.01.x as latest
release.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components
- removes suppressions for ABI tests


Short reference to how the versions were changed:
MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)
for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \
sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; done
find . -name "Makefile" -exec \
sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +

Change-Id: I3e5681802c0a5ac6d7d652a18896997cd07cc8bf
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16419
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date defa

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the 4 digit year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc). Contribution date used
"--follow -C95%" to get the most accurate date.

Note that several files in this patch didn't end the license/(c)
block with a blank comment line so these were added as the vast
majority of files do have this last blank line. Simply there for
consistency.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot

show more ...