xref: /spdk/test/unit/lib/nvmf/ctrlr_discovery.c/ctrlr_discovery_ut.c (revision cc6920a4763d4b9a43aa40583c8397d8f14fa100)
1 /*-
2  *   BSD LICENSE
3  *
4  *   Copyright (c) Intel Corporation.
5  *   All rights reserved.
6  *   Copyright (c) 2021 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
7  *
8  *   Redistribution and use in source and binary forms, with or without
9  *   modification, are permitted provided that the following conditions
10  *   are met:
11  *
12  *     * Redistributions of source code must retain the above copyright
13  *       notice, this list of conditions and the following disclaimer.
14  *     * Redistributions in binary form must reproduce the above copyright
15  *       notice, this list of conditions and the following disclaimer in
16  *       the documentation and/or other materials provided with the
17  *       distribution.
18  *     * Neither the name of Intel Corporation nor the names of its
19  *       contributors may be used to endorse or promote products derived
20  *       from this software without specific prior written permission.
21  *
22  *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
23  *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
24  *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
25  *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
26  *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
27  *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
28  *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
29  *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
30  *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
31  *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
32  *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
33  */
34 
35 #include "spdk/stdinc.h"
36 
37 #include "spdk_cunit.h"
38 #include "spdk_internal/mock.h"
39 
40 #include "common/lib/test_env.c"
41 #include "spdk/bdev_module.h"
42 #include "nvmf/ctrlr_discovery.c"
43 #include "nvmf/subsystem.c"
44 
45 SPDK_LOG_REGISTER_COMPONENT(nvmf)
46 
47 DEFINE_STUB_V(spdk_bdev_module_release_bdev,
48 	      (struct spdk_bdev *bdev));
49 
50 DEFINE_STUB(spdk_bdev_get_block_size, uint32_t,
51 	    (const struct spdk_bdev *bdev), 512);
52 
53 DEFINE_STUB(spdk_nvmf_transport_stop_listen,
54 	    int,
55 	    (struct spdk_nvmf_transport *transport,
56 	     const struct spdk_nvme_transport_id *trid), 0);
57 
58 DEFINE_STUB(spdk_nvmf_transport_get_first,
59 	    struct spdk_nvmf_transport *,
60 	    (struct spdk_nvmf_tgt *tgt), NULL);
61 
62 DEFINE_STUB(spdk_nvmf_transport_get_next,
63 	    struct spdk_nvmf_transport *,
64 	    (struct spdk_nvmf_transport *transport), NULL);
65 
66 DEFINE_STUB_V(spdk_bdev_close, (struct spdk_bdev_desc *desc));
67 
68 DEFINE_STUB(nvmf_ctrlr_async_event_discovery_log_change_notice,
69 	    int,
70 	    (struct spdk_nvmf_ctrlr *ctrlr), 0);
71 
72 DEFINE_STUB(spdk_nvmf_qpair_disconnect, int,
73 	    (struct spdk_nvmf_qpair *qpair,
74 	     nvmf_qpair_disconnect_cb cb_fn, void *ctx), 0);
75 
76 DEFINE_STUB(spdk_bdev_open_ext, int,
77 	    (const char *bdev_name, bool write,	spdk_bdev_event_cb_t event_cb,
78 	     void *event_ctx, struct spdk_bdev_desc **desc), 0);
79 
80 DEFINE_STUB(spdk_bdev_desc_get_bdev, struct spdk_bdev *,
81 	    (struct spdk_bdev_desc *desc), NULL);
82 
83 DEFINE_STUB(spdk_bdev_get_md_size, uint32_t,
84 	    (const struct spdk_bdev *bdev), 0);
85 
86 DEFINE_STUB(spdk_bdev_is_md_interleaved, bool,
87 	    (const struct spdk_bdev *bdev), false);
88 
89 DEFINE_STUB(spdk_bdev_module_claim_bdev, int,
90 	    (struct spdk_bdev *bdev, struct spdk_bdev_desc *desc,
91 	     struct spdk_bdev_module *module), 0);
92 
93 DEFINE_STUB(spdk_bdev_io_type_supported, bool,
94 	    (struct spdk_bdev *bdev, enum spdk_bdev_io_type io_type), false);
95 
96 DEFINE_STUB_V(nvmf_ctrlr_reservation_notice_log,
97 	      (struct spdk_nvmf_ctrlr *ctrlr, struct spdk_nvmf_ns *ns,
98 	       enum spdk_nvme_reservation_notification_log_page_type type));
99 
100 DEFINE_STUB(spdk_nvmf_request_complete, int,
101 	    (struct spdk_nvmf_request *req), -1);
102 
103 DEFINE_STUB(nvmf_ctrlr_async_event_ana_change_notice, int,
104 	    (struct spdk_nvmf_ctrlr *ctrlr), 0);
105 
106 DEFINE_STUB(spdk_nvme_transport_id_trtype_str, const char *,
107 	    (enum spdk_nvme_transport_type trtype), NULL);
108 
109 const char *
110 spdk_bdev_get_name(const struct spdk_bdev *bdev)
111 {
112 	return "test";
113 }
114 
115 const struct spdk_uuid *
116 spdk_bdev_get_uuid(const struct spdk_bdev *bdev)
117 {
118 	return &bdev->uuid;
119 }
120 
121 int
122 spdk_nvme_transport_id_compare(const struct spdk_nvme_transport_id *trid1,
123 			       const struct spdk_nvme_transport_id *trid2)
124 {
125 	return !(trid1->trtype == trid2->trtype && strcasecmp(trid1->traddr, trid2->traddr) == 0 &&
126 		 strcasecmp(trid1->trsvcid, trid2->trsvcid) == 0);
127 }
128 
129 int
130 spdk_nvmf_transport_listen(struct spdk_nvmf_transport *transport,
131 			   const struct spdk_nvme_transport_id *trid, struct spdk_nvmf_listen_opts *opts)
132 {
133 	return 0;
134 }
135 
136 static struct spdk_nvmf_listener g_listener = {};
137 
138 struct spdk_nvmf_listener *
139 nvmf_transport_find_listener(struct spdk_nvmf_transport *transport,
140 			     const struct spdk_nvme_transport_id *trid)
141 {
142 	struct spdk_nvmf_listener *listener;
143 
144 	if (TAILQ_EMPTY(&transport->listeners)) {
145 		return &g_listener;
146 	}
147 
148 	TAILQ_FOREACH(listener, &transport->listeners, link) {
149 		if (spdk_nvme_transport_id_compare(&listener->trid, trid) == 0) {
150 			return listener;
151 		}
152 	}
153 
154 	return NULL;
155 }
156 
157 void
158 nvmf_transport_listener_discover(struct spdk_nvmf_transport *transport,
159 				 struct spdk_nvme_transport_id *trid,
160 				 struct spdk_nvmf_discovery_log_page_entry *entry)
161 {
162 	transport->ops->listener_discover(transport, trid, entry);
163 }
164 
165 static void
166 test_dummy_listener_discover(struct spdk_nvmf_transport *transport,
167 			     struct spdk_nvme_transport_id *trid, struct spdk_nvmf_discovery_log_page_entry *entry)
168 {
169 	entry->trtype = 42;
170 }
171 
172 struct spdk_nvmf_transport_ops g_transport_ops = { .listener_discover = test_dummy_listener_discover };
173 
174 static struct spdk_nvmf_transport g_transport = {
175 	.ops = &g_transport_ops
176 };
177 
178 struct spdk_nvmf_transport *
179 spdk_nvmf_transport_create(const char *transport_name,
180 			   struct spdk_nvmf_transport_opts *tprt_opts)
181 {
182 	if (strcasecmp(transport_name, spdk_nvme_transport_id_trtype_str(SPDK_NVME_TRANSPORT_RDMA))) {
183 		return &g_transport;
184 	}
185 
186 	return NULL;
187 }
188 
189 struct spdk_nvmf_subsystem *
190 spdk_nvmf_tgt_find_subsystem(struct spdk_nvmf_tgt *tgt, const char *subnqn)
191 {
192 	return NULL;
193 }
194 
195 DEFINE_RETURN_MOCK(spdk_nvmf_tgt_get_transport, struct spdk_nvmf_transport *);
196 struct spdk_nvmf_transport *
197 spdk_nvmf_tgt_get_transport(struct spdk_nvmf_tgt *tgt, const char *transport_name)
198 {
199 	HANDLE_RETURN_MOCK(spdk_nvmf_tgt_get_transport);
200 	return &g_transport;
201 }
202 
203 int
204 spdk_nvme_transport_id_parse_trtype(enum spdk_nvme_transport_type *trtype, const char *str)
205 {
206 	if (trtype == NULL || str == NULL) {
207 		return -EINVAL;
208 	}
209 
210 	if (strcasecmp(str, "PCIe") == 0) {
211 		*trtype = SPDK_NVME_TRANSPORT_PCIE;
212 	} else if (strcasecmp(str, "RDMA") == 0) {
213 		*trtype = SPDK_NVME_TRANSPORT_RDMA;
214 	} else {
215 		return -ENOENT;
216 	}
217 	return 0;
218 }
219 
220 void
221 nvmf_ctrlr_ns_changed(struct spdk_nvmf_ctrlr *ctrlr, uint32_t nsid)
222 {
223 }
224 
225 void
226 nvmf_ctrlr_destruct(struct spdk_nvmf_ctrlr *ctrlr)
227 {
228 }
229 
230 int
231 nvmf_poll_group_update_subsystem(struct spdk_nvmf_poll_group *group,
232 				 struct spdk_nvmf_subsystem *subsystem)
233 {
234 	return 0;
235 }
236 
237 int
238 nvmf_poll_group_add_subsystem(struct spdk_nvmf_poll_group *group,
239 			      struct spdk_nvmf_subsystem *subsystem,
240 			      spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg)
241 {
242 	return 0;
243 }
244 
245 void
246 nvmf_poll_group_remove_subsystem(struct spdk_nvmf_poll_group *group,
247 				 struct spdk_nvmf_subsystem *subsystem,
248 				 spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg)
249 {
250 }
251 
252 void
253 nvmf_poll_group_pause_subsystem(struct spdk_nvmf_poll_group *group,
254 				struct spdk_nvmf_subsystem *subsystem,
255 				uint32_t nsid,
256 				spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg)
257 {
258 }
259 
260 void
261 nvmf_poll_group_resume_subsystem(struct spdk_nvmf_poll_group *group,
262 				 struct spdk_nvmf_subsystem *subsystem,
263 				 spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg)
264 {
265 }
266 
267 static void
268 _subsystem_add_listen_done(void *cb_arg, int status)
269 {
270 	SPDK_CU_ASSERT_FATAL(status == 0);
271 }
272 
273 static void
274 test_gen_trid(struct spdk_nvme_transport_id *trid, enum spdk_nvme_transport_type trtype,
275 	      enum spdk_nvmf_adrfam adrfam, const char *tradd, const char *trsvcid)
276 {
277 	snprintf(trid->traddr, sizeof(trid->traddr), "%s", tradd);
278 	snprintf(trid->trsvcid, sizeof(trid->trsvcid), "%s", trsvcid);
279 	trid->adrfam = adrfam;
280 	trid->trtype = trtype;
281 	switch (trtype) {
282 	case SPDK_NVME_TRANSPORT_RDMA:
283 		snprintf(trid->trstring, SPDK_NVMF_TRSTRING_MAX_LEN, "%s", SPDK_NVME_TRANSPORT_NAME_RDMA);
284 		break;
285 	case SPDK_NVME_TRANSPORT_TCP:
286 		snprintf(trid->trstring, SPDK_NVMF_TRSTRING_MAX_LEN, "%s", SPDK_NVME_TRANSPORT_NAME_TCP);
287 		break;
288 	default:
289 		SPDK_CU_ASSERT_FATAL(0 && "not supported by test");
290 	}
291 }
292 
293 static void
294 test_discovery_log(void)
295 {
296 	struct spdk_nvmf_tgt tgt = {};
297 	struct spdk_nvmf_subsystem *subsystem;
298 	uint8_t buffer[8192];
299 	struct iovec iov;
300 	struct spdk_nvmf_discovery_log_page *disc_log;
301 	struct spdk_nvmf_discovery_log_page_entry *entry;
302 	struct spdk_nvme_transport_id trid = {};
303 	int rc;
304 
305 	iov.iov_base = buffer;
306 	iov.iov_len = 8192;
307 
308 	tgt.max_subsystems = 1024;
309 	tgt.subsystems = calloc(tgt.max_subsystems, sizeof(struct spdk_nvmf_subsystem *));
310 	SPDK_CU_ASSERT_FATAL(tgt.subsystems != NULL);
311 
312 	/* Add one subsystem and verify that the discovery log contains it */
313 	subsystem = spdk_nvmf_subsystem_create(&tgt, "nqn.2016-06.io.spdk:subsystem1",
314 					       SPDK_NVMF_SUBTYPE_NVME, 0);
315 	subsystem->flags.allow_any_host = true;
316 	SPDK_CU_ASSERT_FATAL(subsystem != NULL);
317 
318 	test_gen_trid(&trid, SPDK_NVME_TRANSPORT_RDMA, SPDK_NVMF_ADRFAM_IPV4, "1234", "5678");
319 	spdk_nvmf_subsystem_add_listener(subsystem, &trid, _subsystem_add_listen_done, NULL);
320 	subsystem->state = SPDK_NVMF_SUBSYSTEM_ACTIVE;
321 
322 	/* Get only genctr (first field in the header) */
323 	memset(buffer, 0xCC, sizeof(buffer));
324 	disc_log = (struct spdk_nvmf_discovery_log_page *)buffer;
325 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, sizeof(disc_log->genctr),
326 				    &trid);
327 	CU_ASSERT(disc_log->genctr == 2); /* one added subsystem and listener */
328 
329 	/* Get only the header, no entries */
330 	memset(buffer, 0xCC, sizeof(buffer));
331 	disc_log = (struct spdk_nvmf_discovery_log_page *)buffer;
332 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, sizeof(*disc_log),
333 				    &trid);
334 	CU_ASSERT(disc_log->genctr == 2);
335 	CU_ASSERT(disc_log->numrec == 1);
336 
337 	/* Offset 0, exact size match */
338 	memset(buffer, 0xCC, sizeof(buffer));
339 	disc_log = (struct spdk_nvmf_discovery_log_page *)buffer;
340 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0,
341 				    sizeof(*disc_log) + sizeof(disc_log->entries[0]), &trid);
342 	CU_ASSERT(disc_log->genctr != 0);
343 	CU_ASSERT(disc_log->numrec == 1);
344 	CU_ASSERT(disc_log->entries[0].trtype == 42);
345 
346 	/* Offset 0, oversize buffer */
347 	memset(buffer, 0xCC, sizeof(buffer));
348 	disc_log = (struct spdk_nvmf_discovery_log_page *)buffer;
349 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, sizeof(buffer), &trid);
350 	CU_ASSERT(disc_log->genctr != 0);
351 	CU_ASSERT(disc_log->numrec == 1);
352 	CU_ASSERT(disc_log->entries[0].trtype == 42);
353 	CU_ASSERT(spdk_mem_all_zero(buffer + sizeof(*disc_log) + sizeof(disc_log->entries[0]),
354 				    sizeof(buffer) - (sizeof(*disc_log) + sizeof(disc_log->entries[0]))));
355 
356 	/* Get just the first entry, no header */
357 	memset(buffer, 0xCC, sizeof(buffer));
358 	entry = (struct spdk_nvmf_discovery_log_page_entry *)buffer;
359 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1,
360 				    offsetof(struct spdk_nvmf_discovery_log_page, entries[0]), sizeof(*entry), &trid);
361 	CU_ASSERT(entry->trtype == 42);
362 	subsystem->state = SPDK_NVMF_SUBSYSTEM_INACTIVE;
363 	rc = spdk_nvmf_subsystem_destroy(subsystem, NULL, NULL);
364 	CU_ASSERT(rc == 0);
365 	free(tgt.subsystems);
366 }
367 
368 static void
369 test_rdma_discover(struct spdk_nvmf_transport *transport, struct spdk_nvme_transport_id *trid,
370 		   struct spdk_nvmf_discovery_log_page_entry *entry)
371 {
372 	entry->trtype = SPDK_NVMF_TRTYPE_RDMA;
373 	entry->adrfam = trid->adrfam;
374 	memcpy(entry->traddr, trid->traddr, sizeof(entry->traddr));
375 	memcpy(entry->trsvcid, trid->trsvcid, sizeof(entry->trsvcid));
376 }
377 
378 static void
379 test_tcp_discover(struct spdk_nvmf_transport *transport, struct spdk_nvme_transport_id *trid,
380 		  struct spdk_nvmf_discovery_log_page_entry *entry)
381 {
382 	entry->trtype = SPDK_NVMF_TRTYPE_TCP;
383 	entry->adrfam = trid->adrfam;
384 	memcpy(entry->traddr, trid->traddr, sizeof(entry->traddr));
385 	memcpy(entry->trsvcid, trid->trsvcid, sizeof(entry->trsvcid));
386 }
387 
388 static void
389 test_discovery_log_with_filters(void)
390 {
391 	struct spdk_nvmf_tgt tgt = {};
392 	struct spdk_nvmf_transport_ops rdma_tr_ops = { .listener_discover = test_rdma_discover }, tcp_tr_ops
393 		= { .listener_discover = test_tcp_discover };
394 	struct spdk_nvmf_transport rdma_tr = {.ops = &rdma_tr_ops }, tcp_tr = { .ops = &tcp_tr_ops };
395 	struct spdk_nvmf_subsystem *subsystem;
396 	uint8_t buffer[8192];
397 	struct iovec iov;
398 	struct spdk_nvmf_discovery_log_page *disc_log;
399 	struct spdk_nvmf_listener rdma_listener_1 = {}, rdma_listener_2 = {}, rdma_listener_3 = {},
400 	tcp_listener_1 = {}, tcp_listener_2 = {}, tcp_listener_3 = {};
401 	struct spdk_nvme_transport_id rdma_trid_1 = {}, rdma_trid_2 = {}, rdma_trid_3 = {}, tcp_trid_1 = {},
402 	tcp_trid_2 = {}, tcp_trid_3 = {};
403 
404 	iov.iov_base = buffer;
405 	iov.iov_len = 8192;
406 
407 	tgt.max_subsystems = 4;
408 	tgt.subsystems = calloc(tgt.max_subsystems, sizeof(struct spdk_nvmf_subsystem *));
409 	SPDK_CU_ASSERT_FATAL(tgt.subsystems != NULL);
410 
411 	subsystem = spdk_nvmf_subsystem_create(&tgt, "nqn.2016-06.io.spdk:subsystem1",
412 					       SPDK_NVMF_SUBTYPE_NVME, 0);
413 	subsystem->flags.allow_any_host = true;
414 	SPDK_CU_ASSERT_FATAL(subsystem != NULL);
415 
416 	test_gen_trid(&rdma_trid_1, SPDK_NVME_TRANSPORT_RDMA, SPDK_NVMF_ADRFAM_IPV4, "10.10.10.10", "4420");
417 	test_gen_trid(&rdma_trid_2, SPDK_NVME_TRANSPORT_RDMA, SPDK_NVMF_ADRFAM_IPV4, "11.11.11.11", "4420");
418 	test_gen_trid(&rdma_trid_3, SPDK_NVME_TRANSPORT_RDMA, SPDK_NVMF_ADRFAM_IPV4, "10.10.10.10", "4421");
419 	test_gen_trid(&tcp_trid_1, SPDK_NVME_TRANSPORT_TCP, SPDK_NVMF_ADRFAM_IPV4, "11.11.11.11", "4421");
420 	test_gen_trid(&tcp_trid_2, SPDK_NVME_TRANSPORT_TCP, SPDK_NVMF_ADRFAM_IPV4, "10.10.10.10", "4422");
421 	test_gen_trid(&tcp_trid_3, SPDK_NVME_TRANSPORT_TCP, SPDK_NVMF_ADRFAM_IPV4, "11.11.11.11", "4422");
422 
423 	rdma_listener_1.trid = rdma_trid_1;
424 	rdma_listener_2.trid = rdma_trid_2;
425 	rdma_listener_3.trid = rdma_trid_3;
426 	TAILQ_INIT(&rdma_tr.listeners);
427 	TAILQ_INSERT_TAIL(&rdma_tr.listeners, &rdma_listener_1, link);
428 	TAILQ_INSERT_TAIL(&rdma_tr.listeners, &rdma_listener_2, link);
429 	TAILQ_INSERT_TAIL(&rdma_tr.listeners, &rdma_listener_3, link);
430 
431 	tcp_listener_1.trid = tcp_trid_1;
432 	tcp_listener_2.trid = tcp_trid_2;
433 	tcp_listener_3.trid = tcp_trid_3;
434 	TAILQ_INIT(&tcp_tr.listeners);
435 	TAILQ_INSERT_TAIL(&tcp_tr.listeners, &tcp_listener_1, link);
436 	TAILQ_INSERT_TAIL(&tcp_tr.listeners, &tcp_listener_2, link);
437 	TAILQ_INSERT_TAIL(&tcp_tr.listeners, &tcp_listener_3, link);
438 
439 	MOCK_SET(spdk_nvmf_tgt_get_transport, &rdma_tr);
440 	spdk_nvmf_subsystem_add_listener(subsystem, &rdma_trid_1, _subsystem_add_listen_done, NULL);
441 	spdk_nvmf_subsystem_add_listener(subsystem, &rdma_trid_2, _subsystem_add_listen_done, NULL);
442 	spdk_nvmf_subsystem_add_listener(subsystem, &rdma_trid_3, _subsystem_add_listen_done, NULL);
443 	MOCK_SET(spdk_nvmf_tgt_get_transport, &tcp_tr);
444 	spdk_nvmf_subsystem_add_listener(subsystem, &tcp_trid_1, _subsystem_add_listen_done, NULL);
445 	spdk_nvmf_subsystem_add_listener(subsystem, &tcp_trid_2, _subsystem_add_listen_done, NULL);
446 	spdk_nvmf_subsystem_add_listener(subsystem, &tcp_trid_3, _subsystem_add_listen_done, NULL);
447 	MOCK_CLEAR(spdk_nvmf_tgt_get_transport);
448 
449 	subsystem->state = SPDK_NVMF_SUBSYSTEM_ACTIVE;
450 
451 	disc_log = (struct spdk_nvmf_discovery_log_page *)buffer;
452 	memset(buffer, 0, sizeof(buffer));
453 
454 	/* Test case 1 - check that all trids are reported */
455 	tgt.discovery_filter = SPDK_NVMF_TGT_DISCOVERY_MATCH_ANY;
456 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &rdma_trid_1);
457 	CU_ASSERT(disc_log->numrec == 6);
458 
459 	/* Test case 2 - check that only entries of the same transport type are returned */
460 	tgt.discovery_filter = SPDK_NVMF_TGT_DISCOVERY_MATCH_TRANSPORT_TYPE;
461 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &rdma_trid_1);
462 	CU_ASSERT(disc_log->numrec == 3);
463 	CU_ASSERT(disc_log->entries[0].trtype == rdma_trid_1.trtype);
464 	CU_ASSERT(disc_log->entries[1].trtype == rdma_trid_1.trtype);
465 	CU_ASSERT(disc_log->entries[2].trtype == rdma_trid_1.trtype);
466 
467 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &tcp_trid_1);
468 	CU_ASSERT(disc_log->numrec == 3);
469 	CU_ASSERT(disc_log->entries[0].trtype == tcp_trid_1.trtype);
470 	CU_ASSERT(disc_log->entries[1].trtype == tcp_trid_1.trtype);
471 	CU_ASSERT(disc_log->entries[2].trtype == tcp_trid_1.trtype);
472 
473 	/* Test case 3 - check that only entries of the same transport address are returned */
474 	tgt.discovery_filter = SPDK_NVMF_TGT_DISCOVERY_MATCH_TRANSPORT_ADDRESS;
475 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &rdma_trid_1);
476 	CU_ASSERT(disc_log->numrec == 3);
477 	/* one tcp and 2 rdma  */
478 	CU_ASSERT((disc_log->entries[0].trtype ^ disc_log->entries[1].trtype ^ disc_log->entries[2].trtype)
479 		  != 0);
480 	CU_ASSERT(strcasecmp(disc_log->entries[0].traddr, rdma_trid_1.traddr) == 0);
481 	CU_ASSERT(strcasecmp(disc_log->entries[1].traddr, rdma_trid_1.traddr) == 0);
482 	CU_ASSERT(strcasecmp(disc_log->entries[2].traddr, rdma_trid_1.traddr) == 0);
483 
484 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &tcp_trid_1);
485 	CU_ASSERT(disc_log->numrec == 3);
486 	/* one rdma and two tcp */
487 	CU_ASSERT((disc_log->entries[0].trtype ^ disc_log->entries[1].trtype ^ disc_log->entries[2].trtype)
488 		  != 0);
489 	CU_ASSERT(strcasecmp(disc_log->entries[0].traddr, tcp_trid_1.traddr) == 0);
490 	CU_ASSERT(strcasecmp(disc_log->entries[1].traddr, tcp_trid_1.traddr) == 0);
491 	CU_ASSERT(strcasecmp(disc_log->entries[2].traddr, tcp_trid_1.traddr) == 0);
492 
493 	/* Test case 4 - check that only entries of the same transport address and type returned */
494 	tgt.discovery_filter = SPDK_NVMF_TGT_DISCOVERY_MATCH_TRANSPORT_TYPE |
495 			       SPDK_NVMF_TGT_DISCOVERY_MATCH_TRANSPORT_ADDRESS;
496 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &rdma_trid_1);
497 	CU_ASSERT(disc_log->numrec == 2);
498 	CU_ASSERT(strcasecmp(disc_log->entries[0].traddr, rdma_trid_1.traddr) == 0);
499 	CU_ASSERT(strcasecmp(disc_log->entries[1].traddr, rdma_trid_1.traddr) == 0);
500 	CU_ASSERT(disc_log->entries[0].trtype == rdma_trid_1.trtype);
501 	CU_ASSERT(disc_log->entries[1].trtype == rdma_trid_1.trtype);
502 
503 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &rdma_trid_2);
504 	CU_ASSERT(disc_log->numrec == 1);
505 	CU_ASSERT(strcasecmp(disc_log->entries[0].traddr, rdma_trid_2.traddr) == 0);
506 	CU_ASSERT(disc_log->entries[0].trtype == rdma_trid_2.trtype);
507 
508 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &tcp_trid_1);
509 	CU_ASSERT(disc_log->numrec == 2);
510 	CU_ASSERT(strcasecmp(disc_log->entries[0].traddr, tcp_trid_1.traddr) == 0);
511 	CU_ASSERT(strcasecmp(disc_log->entries[1].traddr, tcp_trid_1.traddr) == 0);
512 	CU_ASSERT(disc_log->entries[0].trtype == tcp_trid_1.trtype);
513 	CU_ASSERT(disc_log->entries[1].trtype == tcp_trid_1.trtype);
514 
515 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &rdma_trid_2);
516 	CU_ASSERT(disc_log->numrec == 1);
517 	CU_ASSERT(strcasecmp(disc_log->entries[0].traddr, rdma_trid_2.traddr) == 0);
518 	CU_ASSERT(disc_log->entries[0].trtype == rdma_trid_2.trtype);
519 
520 	/* Test case 5 - check that only entries of the same transport address and type returned */
521 	tgt.discovery_filter = SPDK_NVMF_TGT_DISCOVERY_MATCH_TRANSPORT_TYPE |
522 			       SPDK_NVMF_TGT_DISCOVERY_MATCH_TRANSPORT_SVCID;
523 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &rdma_trid_1);
524 	CU_ASSERT(disc_log->numrec == 2);
525 	CU_ASSERT(strcasecmp(disc_log->entries[0].trsvcid, rdma_trid_1.trsvcid) == 0);
526 	CU_ASSERT(strcasecmp(disc_log->entries[1].trsvcid, rdma_trid_2.trsvcid) == 0);
527 	CU_ASSERT(disc_log->entries[0].trtype == rdma_trid_1.trtype);
528 	CU_ASSERT(disc_log->entries[1].trtype == rdma_trid_2.trtype);
529 
530 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &rdma_trid_3);
531 	CU_ASSERT(disc_log->numrec == 1);
532 	CU_ASSERT(strcasecmp(disc_log->entries[0].trsvcid, rdma_trid_3.trsvcid) == 0);
533 	CU_ASSERT(disc_log->entries[0].trtype == rdma_trid_3.trtype);
534 
535 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &tcp_trid_1);
536 	CU_ASSERT(disc_log->numrec == 1);
537 	CU_ASSERT(strcasecmp(disc_log->entries[0].trsvcid, tcp_trid_1.trsvcid) == 0);
538 	CU_ASSERT(disc_log->entries[0].trtype == tcp_trid_1.trtype);
539 
540 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &tcp_trid_2);
541 	CU_ASSERT(disc_log->numrec == 2);
542 	CU_ASSERT(strcasecmp(disc_log->entries[0].trsvcid, tcp_trid_2.trsvcid) == 0);
543 	CU_ASSERT(strcasecmp(disc_log->entries[1].trsvcid, tcp_trid_2.trsvcid) == 0);
544 	CU_ASSERT(disc_log->entries[0].trtype == tcp_trid_2.trtype);
545 	CU_ASSERT(disc_log->entries[1].trtype == tcp_trid_2.trtype);
546 
547 	/* Test case 6 - check that only entries of the same transport address and type returned.
548 	 * That also implies trtype since RDMA and TCP listeners can't occupy the same socket */
549 	tgt.discovery_filter = SPDK_NVMF_TGT_DISCOVERY_MATCH_TRANSPORT_ADDRESS |
550 			       SPDK_NVMF_TGT_DISCOVERY_MATCH_TRANSPORT_SVCID;
551 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &rdma_trid_1);
552 	CU_ASSERT(disc_log->numrec == 1);
553 	CU_ASSERT(strcasecmp(disc_log->entries[0].traddr, rdma_trid_1.traddr) == 0);
554 	CU_ASSERT(strcasecmp(disc_log->entries[0].trsvcid, rdma_trid_1.trsvcid) == 0);
555 	CU_ASSERT(disc_log->entries[0].trtype == rdma_trid_1.trtype);
556 
557 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &rdma_trid_2);
558 	CU_ASSERT(disc_log->numrec == 1);
559 	CU_ASSERT(strcasecmp(disc_log->entries[0].traddr, rdma_trid_2.traddr) == 0);
560 	CU_ASSERT(strcasecmp(disc_log->entries[0].trsvcid, rdma_trid_2.trsvcid) == 0);
561 	CU_ASSERT(disc_log->entries[0].trtype == rdma_trid_2.trtype);
562 
563 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &rdma_trid_3);
564 	CU_ASSERT(disc_log->numrec == 1);
565 	CU_ASSERT(strcasecmp(disc_log->entries[0].traddr, rdma_trid_3.traddr) == 0);
566 	CU_ASSERT(strcasecmp(disc_log->entries[0].trsvcid, rdma_trid_3.trsvcid) == 0);
567 	CU_ASSERT(disc_log->entries[0].trtype == rdma_trid_3.trtype);
568 
569 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &tcp_trid_1);
570 	CU_ASSERT(disc_log->numrec == 1);
571 	CU_ASSERT(strcasecmp(disc_log->entries[0].traddr, tcp_trid_1.traddr) == 0);
572 	CU_ASSERT(strcasecmp(disc_log->entries[0].trsvcid, tcp_trid_1.trsvcid) == 0);
573 	CU_ASSERT(disc_log->entries[0].trtype == tcp_trid_1.trtype);
574 
575 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &tcp_trid_2);
576 	CU_ASSERT(disc_log->numrec == 1);
577 	CU_ASSERT(strcasecmp(disc_log->entries[0].traddr, tcp_trid_2.traddr) == 0);
578 	CU_ASSERT(strcasecmp(disc_log->entries[0].trsvcid, tcp_trid_2.trsvcid) == 0);
579 	CU_ASSERT(disc_log->entries[0].trtype == tcp_trid_2.trtype);
580 
581 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &tcp_trid_3);
582 	CU_ASSERT(disc_log->numrec == 1);
583 	CU_ASSERT(strcasecmp(disc_log->entries[0].traddr, tcp_trid_3.traddr) == 0);
584 	CU_ASSERT(strcasecmp(disc_log->entries[0].trsvcid, tcp_trid_3.trsvcid) == 0);
585 	CU_ASSERT(disc_log->entries[0].trtype == tcp_trid_3.trtype);
586 
587 	/* Test case 7 - check that only entries of the same transport address, svcid and type returned */
588 	tgt.discovery_filter = SPDK_NVMF_TGT_DISCOVERY_MATCH_TRANSPORT_TYPE |
589 			       SPDK_NVMF_TGT_DISCOVERY_MATCH_TRANSPORT_ADDRESS |
590 			       SPDK_NVMF_TGT_DISCOVERY_MATCH_TRANSPORT_SVCID;
591 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &rdma_trid_1);
592 	CU_ASSERT(disc_log->numrec == 1);
593 	CU_ASSERT(strcasecmp(disc_log->entries[0].traddr, rdma_trid_1.traddr) == 0);
594 	CU_ASSERT(strcasecmp(disc_log->entries[0].trsvcid, rdma_trid_1.trsvcid) == 0);
595 	CU_ASSERT(disc_log->entries[0].trtype == rdma_trid_1.trtype);
596 
597 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &rdma_trid_2);
598 	CU_ASSERT(disc_log->numrec == 1);
599 	CU_ASSERT(strcasecmp(disc_log->entries[0].traddr, rdma_trid_2.traddr) == 0);
600 	CU_ASSERT(strcasecmp(disc_log->entries[0].trsvcid, rdma_trid_2.trsvcid) == 0);
601 	CU_ASSERT(disc_log->entries[0].trtype == rdma_trid_2.trtype);
602 
603 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &rdma_trid_3);
604 	CU_ASSERT(disc_log->numrec == 1);
605 	CU_ASSERT(strcasecmp(disc_log->entries[0].traddr, rdma_trid_3.traddr) == 0);
606 	CU_ASSERT(strcasecmp(disc_log->entries[0].trsvcid, rdma_trid_3.trsvcid) == 0);
607 	CU_ASSERT(disc_log->entries[0].trtype == rdma_trid_3.trtype);
608 
609 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &tcp_trid_1);
610 	CU_ASSERT(disc_log->numrec == 1);
611 	CU_ASSERT(strcasecmp(disc_log->entries[0].traddr, tcp_trid_1.traddr) == 0);
612 	CU_ASSERT(strcasecmp(disc_log->entries[0].trsvcid, tcp_trid_1.trsvcid) == 0);
613 	CU_ASSERT(disc_log->entries[0].trtype == tcp_trid_1.trtype);
614 
615 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &tcp_trid_2);
616 	CU_ASSERT(disc_log->numrec == 1);
617 	CU_ASSERT(strcasecmp(disc_log->entries[0].traddr, tcp_trid_2.traddr) == 0);
618 	CU_ASSERT(strcasecmp(disc_log->entries[0].trsvcid, tcp_trid_2.trsvcid) == 0);
619 	CU_ASSERT(disc_log->entries[0].trtype == tcp_trid_2.trtype);
620 
621 	nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, 8192, &tcp_trid_3);
622 	CU_ASSERT(disc_log->numrec == 1);
623 	CU_ASSERT(strcasecmp(disc_log->entries[0].traddr, tcp_trid_3.traddr) == 0);
624 	CU_ASSERT(strcasecmp(disc_log->entries[0].trsvcid, tcp_trid_3.trsvcid) == 0);
625 	CU_ASSERT(disc_log->entries[0].trtype == tcp_trid_3.trtype);
626 
627 	subsystem->state = SPDK_NVMF_SUBSYSTEM_INACTIVE;
628 	spdk_nvmf_subsystem_destroy(subsystem, NULL, NULL);
629 	free(tgt.subsystems);
630 }
631 
632 int main(int argc, char **argv)
633 {
634 	CU_pSuite	suite = NULL;
635 	unsigned int	num_failures;
636 
637 	CU_set_error_action(CUEA_ABORT);
638 	CU_initialize_registry();
639 
640 	suite = CU_add_suite("nvmf", NULL, NULL);
641 
642 	CU_ADD_TEST(suite, test_discovery_log);
643 	CU_ADD_TEST(suite, test_discovery_log_with_filters);
644 
645 	CU_basic_set_mode(CU_BRM_VERBOSE);
646 	CU_basic_run_tests();
647 	num_failures = CU_get_number_of_failures();
648 	CU_cleanup_registry();
649 	return num_failures;
650 }
651