build: don't create symlinks inside isa-l dirsFor some reason, isa-l doesn't put its headers under isa-l directory inits repo, but installs them that way (e.g. include/crc.h gets installedas isa-
build: don't create symlinks inside isa-l dirsFor some reason, isa-l doesn't put its headers under isa-l directory inits repo, but installs them that way (e.g. include/crc.h gets installedas isa-l/crc.h). So, to make the #includes work, we used to put asymlink inside the isa-l repo called "isa-l" that would point to thedirectory with the headers. It worked, but caused the isa-l directoryto always show up as having untracked content in git, which is a pain.Instead, the symlink is now moved inside the isalbuild directory andisalbuild is added to our include paths. All of the above also appliesto isa-l-crypto, as it used to work identically.Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>Change-Id: I22110f61b253bbdf0bbea2fbe3b533cb56d8632bReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22123Reviewed-by: Michal Berger <michal.berger@intel.com>Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Ben Walker <ben@nvidia.com>Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
show more ...
isal: If using ISA-L submodule, install it during 'make install'Change-Id: I6934c3c23969bfce6365e67397147c1837b7f515Signed-off-by: Ben Walker <ben@nvidia.com>Reviewed-on: https://review.spdk.io/g
isal: If using ISA-L submodule, install it during 'make install'Change-Id: I6934c3c23969bfce6365e67397147c1837b7f515Signed-off-by: Ben Walker <ben@nvidia.com>Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21386Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>Reviewed-by: Jim Harris <jim.harris@samsung.com>Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins <sys_sgci@intel.com>
update Intel copyright noticesper Intel policy to include file commit date using git cmdbelow. The policy does not apply to non-Intel (C) notices.git log --follow -C90% --format=%ad --date defa
update Intel copyright noticesper Intel policy to include file commit date using git cmdbelow. The policy does not apply to non-Intel (C) notices.git log --follow -C90% --format=%ad --date default <file> | tail -1and then pull just the 4 digit year from the result.Intel copyrights were not added to files where Intel either hadno contribution ot the contribution lacked substance (ie licenseheader updates, formatting changes, etc). Contribution date used"--follow -C95%" to get the most accurate date.Note that several files in this patch didn't end the license/(c)block with a blank comment line so these were added as the vastmajority of files do have this last blank line. Simply there forconsistency.Signed-off-by: paul luse <paul.e.luse@intel.com>Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Jim Harris <james.r.harris@intel.com>Reviewed-by: Ben Walker <benjamin.walker@intel.com>Community-CI: Mellanox Build Bot
Replace most BSD 3-clause license text with SPDX identifier.Many open source projects have moved to using SPDX identifiersto specify license information, reducing the amount ofboilerplate code in
Replace most BSD 3-clause license text with SPDX identifier.Many open source projects have moved to using SPDX identifiersto specify license information, reducing the amount ofboilerplate code in every source file. This patch replacesthe bulk of SPDK .c, .cpp and Makefiles with the BSD-3-Clauseidentifier.Almost all of these files share the exact same license text,and this patch only modifies the files that contain themost common license text. There can be slight variationsbecause the third clause contains company names - most say"Intel Corporation", but there are instances for Nvidia,Samsung, Eideticom and even "the copyright holder".Used a bash script to automate replacement of the license textwith SPDX identifier which is checked into scripts/spdx.sh.Signed-off-by: Jim Harris <james.r.harris@intel.com>Change-Id: Iaa88ab5e92ea471691dc298cfe41ebfb5d169780Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12904Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>Reviewed-by: Dong Yi <dongx.yi@intel.com>Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>Reviewed-by: Paul Luse <paul.e.luse@intel.com>Reviewed-by: <qun.wan@intel.com>
isalbuild: Fix highlight context in Makefile.Here should be tab. Though it doesn't impacton the result. But it's a fault.Signed-off-by: yidong0635 <dongx.yi@intel.com>Change-Id: I0f127c6210c4e8
isalbuild: Fix highlight context in Makefile.Here should be tab. Though it doesn't impacton the result. But it's a fault.Signed-off-by: yidong0635 <dongx.yi@intel.com>Change-Id: I0f127c6210c4e801adb8b1cb8fadc1d4554b99a4Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12752Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>Community-CI: Mellanox Build BotReviewed-by: Changpeng Liu <changpeng.liu@intel.com>Reviewed-by: GangCao <gang.cao@intel.com>Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Makefile: don't override MAKEFLAGS in submakeApparently make doesn't like it:make[2]: warning: -jN forced in submake: disabling jobserver mode.We only did it because of scan-build - it detects a
Makefile: don't override MAKEFLAGS in submakeApparently make doesn't like it:make[2]: warning: -jN forced in submake: disabling jobserver mode.We only did it because of scan-build - it detects a tonof issues (or false positives) in our dependencies. Todisable it, we don't have to override MAKEFLAGS, butjust CC - that's what we'll do now.Fixes #896Change-Id: I5eea984d6bbfbf4caabdd704850fac840fed3524Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/927Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Makefile: Add possibility to uninstall spdk.Add uninstall target to makefiles to be able to performreverse of install target.Fixes #464This patch adds 'uninstall' target to makefile.'make unin
Makefile: Add possibility to uninstall spdk.Add uninstall target to makefiles to be able to performreverse of install target.Fixes #464This patch adds 'uninstall' target to makefile.'make uninstall' will remove spdk_tgt app, headers, librariesand shared libraries from system directories defined by $DESTDIR.Additionaly, if there will be any empty directories left afterthis operation, they will be removed as well.Signed-off-by: Piotr Pelplinski <piotr.pelplinski@intel.com>Change-Id: I7b07fb4b81081d3914ff09165991fbe3a26b9067Signed-off-by: Pawel Kaminski <pawelx.kaminski@intel.com>Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/431471Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Ben Walker <benjamin.walker@intel.com>Reviewed-by: Jim Harris <james.r.harris@intel.com>
isalbuild: fixed make clean issue.Symbol-link about isa-l, usually rm -f is enough, but some case it changed. And report errors:Clean up report error:rm: cannot remove 'spdk/isa-l/isa-l': Is a di
isalbuild: fixed make clean issue.Symbol-link about isa-l, usually rm -f is enough, but some case it changed. And report errors:Clean up report error:rm: cannot remove 'spdk/isa-l/isa-l': Is a directory.orrm: cannot remove '/home/vagrant/master/build-20190415032826/spdk/isa-l/isa-l': Is a directorymake[1]: *** [Makefile:53: clean] Error 1make: *** [/home/vagrant/master/build-20190415032826/spdk/mk/spdk.subdirs.mk:44: isalbuild] Error 2Change-Id: I7f64e2e9708392c8821e2699fdae26223f472689Signed-off-by: yidong0635 <dongx.yi@intel.com>Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/448967Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
bdev/crypto: add /include symlink for ISALCurrently we only include the dir just above ISA-L which allowsthe isal.h file includes to be found however DPDK can't findisa-l.h at that location becau
bdev/crypto: add /include symlink for ISALCurrently we only include the dir just above ISA-L which allowsthe isal.h file includes to be found however DPDK can't findisa-l.h at that location because its one level deeper.By adding a symlink in the isa-l subdir we can redirect DPDK tofind the isa-l header files.Change-Id: Ieeabd4273bade0241db5581764b2169103f9770fSigned-off-by: paul luse <paul.e.luse@intel.com>Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/445767Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Jim Harris <james.r.harris@intel.com>Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>Reviewed-by: Ben Walker <benjamin.walker@intel.com>
spdk: Add ISA-L support with related crc32 functionIn SPDK, we will build isa-l with no shared optionand then integrate it into SPDK. And we do not needto install isal in the system libaries.No
spdk: Add ISA-L support with related crc32 functionIn SPDK, we will build isa-l with no shared optionand then integrate it into SPDK. And we do not needto install isal in the system libaries.Note: ocf build in autobuild.sh now needs to buildinclude/spdk/config.h before building the ocf library,to ensure that header is available in a clean buildenvironment.Change-Id: I3f0ce6932b386de17a77cf5bfdfd738b22417e2dSigned-off-by: Ziye Yang <optimistyzy@gmail.com>Signed-off-by: paul luse <paul.e.luse@intel.com>Signed-off-by: Jim Harris <james.r.harris@intel.com>Reviewed-on: https://review.gerrithub.io/c/441279Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>Reviewed-by: Chunyang Hui <chunyang.hui@intel.com>