test/unit: use spdk_ut_run_tests()Replaced direct calls to the CUnit's functions to run the tests withspdk_ut_run_tests(). That way, each test will have the ability to runa specific test case.
test/unit: use spdk_ut_run_tests()Replaced direct calls to the CUnit's functions to run the tests withspdk_ut_run_tests(). That way, each test will have the ability to runa specific test case.The blob.c unit test wasn't changed, because it runs all tests multipletimes with different parameter combinations, so it cannot be easilyconverted. In the future, each such combination could be split into aseparate test suite, which would make it compatible withspdk_ut_run_tests().Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>Change-Id: I4463f808f89844e9bf32b5b31eda197c5d729d1dReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19288Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>Community-CI: Mellanox Build BotReviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
show more ...
test/unit: move spdk_cunit.h to include/spdk_internalIt'll make it easier to include this file outside of unit tests.Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>Change-Id: I171ddb864
test/unit: move spdk_cunit.h to include/spdk_internalIt'll make it easier to include this file outside of unit tests.Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>Change-Id: I171ddb8649f67b5786f08647560e2907603d0574Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19284Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
histogram_data: check bucket_shift when mergingWhen merging data from one spdk_histogram_data toanother, the merging is only valid if the bucket_shiftfor each structure is the same. Otherwise we
histogram_data: check bucket_shift when mergingWhen merging data from one spdk_histogram_data toanother, the merging is only valid if the bucket_shiftfor each structure is the same. Otherwise we arecombining data points that cover different rangesof values.So check that the bucket_shifts are the same beforemerging. Change the return type to int toreturn -EINVAL if structures with differentbucket_shifts are attempted to be merged.Signed-off-by: Jim Harris <james.r.harris@intel.com>Change-Id: If98e2d03384d85f478965956da2a42cfcff4713dReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15813Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Community-CI: Mellanox Build BotReviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
update Intel copyright noticesper Intel policy to include file commit date using git cmdbelow. The policy does not apply to non-Intel (C) notices.git log --follow -C90% --format=%ad --date defa
update Intel copyright noticesper Intel policy to include file commit date using git cmdbelow. The policy does not apply to non-Intel (C) notices.git log --follow -C90% --format=%ad --date default <file> | tail -1and then pull just the 4 digit year from the result.Intel copyrights were not added to files where Intel either hadno contribution ot the contribution lacked substance (ie licenseheader updates, formatting changes, etc). Contribution date used"--follow -C95%" to get the most accurate date.Note that several files in this patch didn't end the license/(c)block with a blank comment line so these were added as the vastmajority of files do have this last blank line. Simply there forconsistency.Signed-off-by: paul luse <paul.e.luse@intel.com>Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Jim Harris <james.r.harris@intel.com>Reviewed-by: Ben Walker <benjamin.walker@intel.com>Community-CI: Mellanox Build Bot
Replace most BSD 3-clause license text with SPDX identifier.Many open source projects have moved to using SPDX identifiersto specify license information, reducing the amount ofboilerplate code in
Replace most BSD 3-clause license text with SPDX identifier.Many open source projects have moved to using SPDX identifiersto specify license information, reducing the amount ofboilerplate code in every source file. This patch replacesthe bulk of SPDK .c, .cpp and Makefiles with the BSD-3-Clauseidentifier.Almost all of these files share the exact same license text,and this patch only modifies the files that contain themost common license text. There can be slight variationsbecause the third clause contains company names - most say"Intel Corporation", but there are instances for Nvidia,Samsung, Eideticom and even "the copyright holder".Used a bash script to automate replacement of the license textwith SPDX identifier which is checked into scripts/spdx.sh.Signed-off-by: Jim Harris <james.r.harris@intel.com>Change-Id: Iaa88ab5e92ea471691dc298cfe41ebfb5d169780Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12904Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>Reviewed-by: Dong Yi <dongx.yi@intel.com>Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>Reviewed-by: Paul Luse <paul.e.luse@intel.com>Reviewed-by: <qun.wan@intel.com>
test: optimize unit test .gitignore filesJust add a single .gitignore file in test/unitthat covers *_ut. That allows us to eliminate100 .gitignore files in the test/unit directoryhierarchy.Si
test: optimize unit test .gitignore filesJust add a single .gitignore file in test/unitthat covers *_ut. That allows us to eliminate100 .gitignore files in the test/unit directoryhierarchy.Signed-off-by: Jim Harris <james.r.harris@intel.com>Change-Id: Ia190587b4d5c6f1847471be27550cbfb843dc01eReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9235Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
test/unit: remove duplicate mk/spdk.common.mk includesmk/spdk.unittest.mk already includes mk/spdk.common.mk, so it'snot needed. This also fixes an issue where touching an included.mk file would
test/unit: remove duplicate mk/spdk.common.mk includesmk/spdk.unittest.mk already includes mk/spdk.common.mk, so it'snot needed. This also fixes an issue where touching an included.mk file would not trigger unit tests to rebuild if they hadthis duplicated mk/spdk.common.mk include.Signed-off-by: Jim Harris <james.r.harris@intel.com>Change-Id: I41a04eb77ce468849cb9b53bd1f76df6fec06e46Reviewed-on: https://review.gerrithub.io/c/443980Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
build: remove duplicate spdk.app.mk includesspdk.unittest.mk includes spdk.app.mk, but some unit testMakefiles include both spdk.unittest.mk and spdk.app.mk,meaning spdk.app.mk gets included twic
build: remove duplicate spdk.app.mk includesspdk.unittest.mk includes spdk.app.mk, but some unit testMakefiles include both spdk.unittest.mk and spdk.app.mk,meaning spdk.app.mk gets included twice. Fix that.This hasn't been an issue because spdk.app.mk currentlyonly includes variables - but no rules.Signed-off-by: Jim Harris <james.r.harris@intel.com>Change-Id: I23d39e8084f79442fb06ae9b5a6a68d6134adff4Reviewed-on: https://review.gerrithub.io/434281Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>Reviewed-by: Ben Walker <benjamin.walker@intel.com>
histograms: add unit tests for histogram mergeSigned-off-by: Piotr Pelplinski <piotr.pelplinski@intel.com>Change-Id: I36eed5fdd593eb3df15859a3e29c600be0913899Reviewed-on: https://review.gerrithu
histograms: add unit tests for histogram mergeSigned-off-by: Piotr Pelplinski <piotr.pelplinski@intel.com>Change-Id: I36eed5fdd593eb3df15859a3e29c600be0913899Reviewed-on: https://review.gerrithub.io/432559Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Jim Harris <james.r.harris@intel.com>Reviewed-by: Ben Walker <benjamin.walker@intel.com>
test: use spdk.unittest.mk for histogram_data.h unit testsSigned-off-by: Jim Harris <james.r.harris@intel.com>Change-Id: Ic3b1856ebb76fd50e44815157be996e78bc785ccReviewed-on: https://review.gerr
test: use spdk.unittest.mk for histogram_data.h unit testsSigned-off-by: Jim Harris <james.r.harris@intel.com>Change-Id: Ic3b1856ebb76fd50e44815157be996e78bc785ccReviewed-on: https://review.gerrithub.io/399761Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
test: add histogram unit testsSigned-off-by: Jim Harris <james.r.harris@intel.com>Change-Id: I79c2c30e15b8254c3cb75af5615dfafee84a9abdReviewed-on: https://review.gerrithub.io/392709Reviewed-by:
test: add histogram unit testsSigned-off-by: Jim Harris <james.r.harris@intel.com>Change-Id: I79c2c30e15b8254c3cb75af5615dfafee84a9abdReviewed-on: https://review.gerrithub.io/392709Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>Reviewed-by: Ben Walker <benjamin.walker@intel.com>