1 /*- 2 * BSD LICENSE 3 * 4 * Copyright (c) Intel Corporation. 5 * All rights reserved. 6 * 7 * Redistribution and use in source and binary forms, with or without 8 * modification, are permitted provided that the following conditions 9 * are met: 10 * 11 * * Redistributions of source code must retain the above copyright 12 * notice, this list of conditions and the following disclaimer. 13 * * Redistributions in binary form must reproduce the above copyright 14 * notice, this list of conditions and the following disclaimer in 15 * the documentation and/or other materials provided with the 16 * distribution. 17 * * Neither the name of Intel Corporation nor the names of its 18 * contributors may be used to endorse or promote products derived 19 * from this software without specific prior written permission. 20 * 21 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 22 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 23 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 24 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 25 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 26 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 27 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 28 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 29 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 30 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 31 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 32 */ 33 34 #include "spdk/stdinc.h" 35 36 #include "spdk_cunit.h" 37 #include "spdk_internal/mock.h" 38 39 #include "common/lib/test_env.c" 40 #include "nvmf/ctrlr.c" 41 42 SPDK_LOG_REGISTER_COMPONENT("nvmf", SPDK_LOG_NVMF) 43 44 struct spdk_bdev { 45 int ut_mock; 46 uint64_t blockcnt; 47 }; 48 49 DEFINE_STUB(spdk_nvmf_tgt_find_subsystem, 50 struct spdk_nvmf_subsystem *, 51 (struct spdk_nvmf_tgt *tgt, const char *subnqn), 52 NULL); 53 54 DEFINE_STUB(spdk_nvmf_poll_group_create, 55 struct spdk_nvmf_poll_group *, 56 (struct spdk_nvmf_tgt *tgt), 57 NULL); 58 59 DEFINE_STUB_V(spdk_nvmf_poll_group_destroy, 60 (struct spdk_nvmf_poll_group *group)); 61 62 DEFINE_STUB_V(spdk_nvmf_transport_qpair_fini, 63 (struct spdk_nvmf_qpair *qpair)); 64 65 DEFINE_STUB(spdk_nvmf_poll_group_add, 66 int, 67 (struct spdk_nvmf_poll_group *group, struct spdk_nvmf_qpair *qpair), 68 0); 69 70 DEFINE_STUB(spdk_nvmf_subsystem_get_sn, 71 const char *, 72 (const struct spdk_nvmf_subsystem *subsystem), 73 NULL); 74 75 DEFINE_STUB(spdk_nvmf_subsystem_get_ns, 76 struct spdk_nvmf_ns *, 77 (struct spdk_nvmf_subsystem *subsystem, uint32_t nsid), 78 NULL); 79 80 DEFINE_STUB(spdk_nvmf_subsystem_get_first_ns, 81 struct spdk_nvmf_ns *, 82 (struct spdk_nvmf_subsystem *subsystem), 83 NULL); 84 85 DEFINE_STUB(spdk_nvmf_subsystem_get_next_ns, 86 struct spdk_nvmf_ns *, 87 (struct spdk_nvmf_subsystem *subsystem, struct spdk_nvmf_ns *prev_ns), 88 NULL); 89 90 DEFINE_STUB(spdk_nvmf_subsystem_host_allowed, 91 bool, 92 (struct spdk_nvmf_subsystem *subsystem, const char *hostnqn), 93 true); 94 95 DEFINE_STUB(spdk_nvmf_subsystem_add_ctrlr, 96 int, 97 (struct spdk_nvmf_subsystem *subsystem, struct spdk_nvmf_ctrlr *ctrlr), 98 0); 99 100 DEFINE_STUB_V(spdk_nvmf_subsystem_remove_ctrlr, 101 (struct spdk_nvmf_subsystem *subsystem, struct spdk_nvmf_ctrlr *ctrlr)); 102 103 DEFINE_STUB(spdk_nvmf_subsystem_get_ctrlr, 104 struct spdk_nvmf_ctrlr *, 105 (struct spdk_nvmf_subsystem *subsystem, uint16_t cntlid), 106 NULL); 107 108 DEFINE_STUB(spdk_nvmf_ctrlr_dsm_supported, 109 bool, 110 (struct spdk_nvmf_ctrlr *ctrlr), 111 false); 112 113 DEFINE_STUB(spdk_nvmf_ctrlr_write_zeroes_supported, 114 bool, 115 (struct spdk_nvmf_ctrlr *ctrlr), 116 false); 117 118 DEFINE_STUB_V(spdk_nvmf_get_discovery_log_page, 119 (struct spdk_nvmf_tgt *tgt, void *buffer, uint64_t offset, uint32_t length)); 120 121 DEFINE_STUB(spdk_nvmf_request_complete, 122 int, 123 (struct spdk_nvmf_request *req), 124 -1); 125 126 DEFINE_STUB(spdk_nvmf_request_free, 127 int, 128 (struct spdk_nvmf_request *req), 129 -1); 130 131 DEFINE_STUB(spdk_nvmf_qpair_get_listen_trid, 132 int, 133 (struct spdk_nvmf_qpair *qpair, struct spdk_nvme_transport_id *trid), 134 0); 135 136 DEFINE_STUB(spdk_nvmf_subsystem_listener_allowed, 137 bool, 138 (struct spdk_nvmf_subsystem *subsystem, struct spdk_nvme_transport_id *trid), 139 true); 140 141 static void 142 ctrlr_ut_pass_msg(spdk_thread_fn fn, void *ctx, void *thread_ctx) 143 { 144 fn(ctx); 145 } 146 147 void 148 spdk_nvmf_bdev_ctrlr_identify_ns(struct spdk_nvmf_ns *ns, struct spdk_nvme_ns_data *nsdata) 149 { 150 uint64_t num_blocks; 151 152 SPDK_CU_ASSERT_FATAL(ns->bdev != NULL); 153 num_blocks = ns->bdev->blockcnt; 154 nsdata->nsze = num_blocks; 155 nsdata->ncap = num_blocks; 156 nsdata->nuse = num_blocks; 157 nsdata->nlbaf = 0; 158 nsdata->flbas.format = 0; 159 nsdata->lbaf[0].lbads = spdk_u32log2(512); 160 } 161 162 static void 163 test_get_log_page(void) 164 { 165 struct spdk_nvmf_subsystem subsystem = {}; 166 struct spdk_nvmf_request req = {}; 167 struct spdk_nvmf_qpair qpair = {}; 168 struct spdk_nvmf_ctrlr ctrlr = {}; 169 union nvmf_h2c_msg cmd = {}; 170 union nvmf_c2h_msg rsp = {}; 171 char data[4096]; 172 173 subsystem.subtype = SPDK_NVMF_SUBTYPE_NVME; 174 175 ctrlr.subsys = &subsystem; 176 177 qpair.ctrlr = &ctrlr; 178 179 req.qpair = &qpair; 180 req.cmd = &cmd; 181 req.rsp = &rsp; 182 req.data = &data; 183 req.length = sizeof(data); 184 185 /* Get Log Page - all valid */ 186 memset(&cmd, 0, sizeof(cmd)); 187 memset(&rsp, 0, sizeof(rsp)); 188 cmd.nvme_cmd.opc = SPDK_NVME_OPC_GET_LOG_PAGE; 189 cmd.nvme_cmd.cdw10 = SPDK_NVME_LOG_ERROR | (req.length / 4 - 1) << 16; 190 CU_ASSERT(spdk_nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 191 CU_ASSERT(req.rsp->nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 192 CU_ASSERT(req.rsp->nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS); 193 194 /* Get Log Page with invalid log ID */ 195 memset(&cmd, 0, sizeof(cmd)); 196 memset(&rsp, 0, sizeof(rsp)); 197 cmd.nvme_cmd.opc = SPDK_NVME_OPC_GET_LOG_PAGE; 198 cmd.nvme_cmd.cdw10 = 0; 199 CU_ASSERT(spdk_nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 200 CU_ASSERT(req.rsp->nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 201 CU_ASSERT(req.rsp->nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD); 202 203 /* Get Log Page with invalid offset (not dword aligned) */ 204 memset(&cmd, 0, sizeof(cmd)); 205 memset(&rsp, 0, sizeof(rsp)); 206 cmd.nvme_cmd.opc = SPDK_NVME_OPC_GET_LOG_PAGE; 207 cmd.nvme_cmd.cdw10 = SPDK_NVME_LOG_ERROR | (req.length / 4 - 1) << 16; 208 cmd.nvme_cmd.cdw12 = 2; 209 CU_ASSERT(spdk_nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 210 CU_ASSERT(req.rsp->nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 211 CU_ASSERT(req.rsp->nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD); 212 213 /* Get Log Page without data buffer */ 214 memset(&cmd, 0, sizeof(cmd)); 215 memset(&rsp, 0, sizeof(rsp)); 216 req.data = NULL; 217 cmd.nvme_cmd.opc = SPDK_NVME_OPC_GET_LOG_PAGE; 218 cmd.nvme_cmd.cdw10 = SPDK_NVME_LOG_ERROR | (req.length / 4 - 1) << 16; 219 CU_ASSERT(spdk_nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 220 CU_ASSERT(req.rsp->nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 221 CU_ASSERT(req.rsp->nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD); 222 req.data = data; 223 } 224 225 static void 226 test_process_fabrics_cmd(void) 227 { 228 struct spdk_nvmf_request req = {}; 229 int ret; 230 struct spdk_nvmf_qpair req_qpair = {}; 231 union nvmf_h2c_msg req_cmd = {}; 232 union nvmf_c2h_msg req_rsp = {}; 233 234 req.qpair = &req_qpair; 235 req.cmd = &req_cmd; 236 req.rsp = &req_rsp; 237 req.qpair->ctrlr = NULL; 238 239 /* No ctrlr and invalid command check */ 240 req.cmd->nvmf_cmd.fctype = SPDK_NVMF_FABRIC_COMMAND_PROPERTY_GET; 241 ret = spdk_nvmf_ctrlr_process_fabrics_cmd(&req); 242 CU_ASSERT_EQUAL(req.rsp->nvme_cpl.status.sc, SPDK_NVME_SC_COMMAND_SEQUENCE_ERROR); 243 CU_ASSERT_EQUAL(ret, SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 244 } 245 246 static bool 247 nvme_status_success(const struct spdk_nvme_status *status) 248 { 249 return status->sct == SPDK_NVME_SCT_GENERIC && status->sc == SPDK_NVME_SC_SUCCESS; 250 } 251 252 static void 253 test_connect(void) 254 { 255 struct spdk_nvmf_fabric_connect_data connect_data; 256 struct spdk_thread *thread; 257 struct spdk_nvmf_poll_group group; 258 struct spdk_nvmf_transport transport; 259 struct spdk_nvmf_subsystem subsystem; 260 struct spdk_nvmf_request req; 261 struct spdk_nvmf_qpair admin_qpair; 262 struct spdk_nvmf_qpair qpair; 263 struct spdk_nvmf_qpair qpair2; 264 struct spdk_nvmf_ctrlr ctrlr; 265 struct spdk_nvmf_tgt tgt; 266 union nvmf_h2c_msg cmd; 267 union nvmf_c2h_msg rsp; 268 const uint8_t hostid[16] = { 269 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 270 0x08, 0x09, 0x0A, 0x0B, 0x0C, 0x0D, 0x0E, 0x0F 271 }; 272 const char subnqn[] = "nqn.2016-06.io.spdk:subsystem1"; 273 const char hostnqn[] = "nqn.2016-06.io.spdk:host1"; 274 int rc; 275 276 thread = spdk_allocate_thread(ctrlr_ut_pass_msg, NULL, NULL, NULL, "ctrlr_ut"); 277 SPDK_CU_ASSERT_FATAL(thread != NULL); 278 279 memset(&group, 0, sizeof(group)); 280 group.thread = thread; 281 282 memset(&ctrlr, 0, sizeof(ctrlr)); 283 ctrlr.subsys = &subsystem; 284 ctrlr.qpair_mask = spdk_bit_array_create(3); 285 SPDK_CU_ASSERT_FATAL(ctrlr.qpair_mask != NULL); 286 ctrlr.vcprop.cc.bits.en = 1; 287 ctrlr.vcprop.cc.bits.iosqes = 6; 288 ctrlr.vcprop.cc.bits.iocqes = 4; 289 290 memset(&admin_qpair, 0, sizeof(admin_qpair)); 291 admin_qpair.group = &group; 292 293 memset(&tgt, 0, sizeof(tgt)); 294 memset(&transport, 0, sizeof(transport)); 295 transport.opts.max_queue_depth = 64; 296 transport.opts.max_qpairs_per_ctrlr = 3; 297 transport.tgt = &tgt; 298 299 memset(&qpair, 0, sizeof(qpair)); 300 qpair.transport = &transport; 301 qpair.group = &group; 302 303 memset(&connect_data, 0, sizeof(connect_data)); 304 memcpy(connect_data.hostid, hostid, sizeof(hostid)); 305 connect_data.cntlid = 0xFFFF; 306 snprintf(connect_data.subnqn, sizeof(connect_data.subnqn), "%s", subnqn); 307 snprintf(connect_data.hostnqn, sizeof(connect_data.hostnqn), "%s", hostnqn); 308 309 memset(&subsystem, 0, sizeof(subsystem)); 310 subsystem.thread = thread; 311 subsystem.id = 1; 312 TAILQ_INIT(&subsystem.ctrlrs); 313 subsystem.tgt = &tgt; 314 subsystem.subtype = SPDK_NVMF_SUBTYPE_NVME; 315 snprintf(subsystem.subnqn, sizeof(subsystem.subnqn), "%s", subnqn); 316 317 memset(&cmd, 0, sizeof(cmd)); 318 cmd.connect_cmd.opcode = SPDK_NVME_OPC_FABRIC; 319 cmd.connect_cmd.cid = 1; 320 cmd.connect_cmd.fctype = SPDK_NVMF_FABRIC_COMMAND_CONNECT; 321 cmd.connect_cmd.recfmt = 0; 322 cmd.connect_cmd.qid = 0; 323 cmd.connect_cmd.sqsize = 31; 324 cmd.connect_cmd.cattr = 0; 325 cmd.connect_cmd.kato = 120000; 326 327 memset(&req, 0, sizeof(req)); 328 req.qpair = &qpair; 329 req.length = sizeof(connect_data); 330 req.xfer = SPDK_NVME_DATA_HOST_TO_CONTROLLER; 331 req.data = &connect_data; 332 req.cmd = &cmd; 333 req.rsp = &rsp; 334 335 MOCK_SET(spdk_nvmf_tgt_find_subsystem, &subsystem); 336 MOCK_SET(spdk_nvmf_poll_group_create, &group); 337 338 /* Valid admin connect command */ 339 memset(&rsp, 0, sizeof(rsp)); 340 rc = spdk_nvmf_ctrlr_connect(&req); 341 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS); 342 CU_ASSERT(nvme_status_success(&rsp.nvme_cpl.status)); 343 CU_ASSERT(qpair.ctrlr != NULL); 344 spdk_bit_array_free(&qpair.ctrlr->qpair_mask); 345 free(qpair.ctrlr); 346 qpair.ctrlr = NULL; 347 348 /* Invalid data length */ 349 memset(&rsp, 0, sizeof(rsp)); 350 req.length = sizeof(connect_data) - 1; 351 rc = spdk_nvmf_ctrlr_connect(&req); 352 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 353 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 354 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD); 355 CU_ASSERT(qpair.ctrlr == NULL); 356 req.length = sizeof(connect_data); 357 358 /* Invalid recfmt */ 359 memset(&rsp, 0, sizeof(rsp)); 360 cmd.connect_cmd.recfmt = 1234; 361 rc = spdk_nvmf_ctrlr_connect(&req); 362 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 363 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 364 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INCOMPATIBLE_FORMAT); 365 CU_ASSERT(qpair.ctrlr == NULL); 366 cmd.connect_cmd.recfmt = 0; 367 368 /* Unterminated subnqn */ 369 memset(&rsp, 0, sizeof(rsp)); 370 memset(connect_data.subnqn, 'a', sizeof(connect_data.subnqn)); 371 rc = spdk_nvmf_ctrlr_connect(&req); 372 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 373 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 374 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 375 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 1); 376 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 256); 377 CU_ASSERT(qpair.ctrlr == NULL); 378 snprintf(connect_data.subnqn, sizeof(connect_data.subnqn), "%s", subnqn); 379 380 /* Subsystem not found */ 381 memset(&rsp, 0, sizeof(rsp)); 382 MOCK_SET(spdk_nvmf_tgt_find_subsystem, NULL); 383 rc = spdk_nvmf_ctrlr_connect(&req); 384 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 385 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 386 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 387 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 1); 388 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 256); 389 CU_ASSERT(qpair.ctrlr == NULL); 390 MOCK_SET(spdk_nvmf_tgt_find_subsystem, &subsystem); 391 392 /* Unterminated hostnqn */ 393 memset(&rsp, 0, sizeof(rsp)); 394 memset(connect_data.hostnqn, 'b', sizeof(connect_data.hostnqn)); 395 rc = spdk_nvmf_ctrlr_connect(&req); 396 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 397 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 398 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 399 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 1); 400 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 512); 401 CU_ASSERT(qpair.ctrlr == NULL); 402 snprintf(connect_data.hostnqn, sizeof(connect_data.hostnqn), "%s", hostnqn); 403 404 /* Host not allowed */ 405 memset(&rsp, 0, sizeof(rsp)); 406 MOCK_SET(spdk_nvmf_subsystem_host_allowed, false); 407 rc = spdk_nvmf_ctrlr_connect(&req); 408 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 409 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 410 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_HOST); 411 CU_ASSERT(qpair.ctrlr == NULL); 412 MOCK_SET(spdk_nvmf_subsystem_host_allowed, true); 413 414 /* Invalid sqsize == 0 */ 415 memset(&rsp, 0, sizeof(rsp)); 416 cmd.connect_cmd.sqsize = 0; 417 rc = spdk_nvmf_ctrlr_connect(&req); 418 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 419 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 420 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 421 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0); 422 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 44); 423 CU_ASSERT(qpair.ctrlr == NULL); 424 cmd.connect_cmd.sqsize = 31; 425 426 /* Invalid sqsize > max_queue_depth */ 427 memset(&rsp, 0, sizeof(rsp)); 428 cmd.connect_cmd.sqsize = 64; 429 rc = spdk_nvmf_ctrlr_connect(&req); 430 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 431 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 432 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 433 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0); 434 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 44); 435 CU_ASSERT(qpair.ctrlr == NULL); 436 cmd.connect_cmd.sqsize = 31; 437 438 /* Invalid cntlid for admin queue */ 439 memset(&rsp, 0, sizeof(rsp)); 440 connect_data.cntlid = 0x1234; 441 rc = spdk_nvmf_ctrlr_connect(&req); 442 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 443 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 444 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 445 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 1); 446 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 16); 447 CU_ASSERT(qpair.ctrlr == NULL); 448 connect_data.cntlid = 0xFFFF; 449 450 ctrlr.admin_qpair = &admin_qpair; 451 ctrlr.subsys = &subsystem; 452 453 /* Valid I/O queue connect command */ 454 memset(&rsp, 0, sizeof(rsp)); 455 MOCK_SET(spdk_nvmf_subsystem_get_ctrlr, &ctrlr); 456 cmd.connect_cmd.qid = 1; 457 rc = spdk_nvmf_ctrlr_connect(&req); 458 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS); 459 CU_ASSERT(nvme_status_success(&rsp.nvme_cpl.status)); 460 CU_ASSERT(qpair.ctrlr == &ctrlr); 461 qpair.ctrlr = NULL; 462 463 /* Non-existent controller */ 464 memset(&rsp, 0, sizeof(rsp)); 465 MOCK_SET(spdk_nvmf_subsystem_get_ctrlr, NULL); 466 rc = spdk_nvmf_ctrlr_connect(&req); 467 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS); 468 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 469 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 470 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 1); 471 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 16); 472 CU_ASSERT(qpair.ctrlr == NULL); 473 MOCK_SET(spdk_nvmf_subsystem_get_ctrlr, &ctrlr); 474 475 /* I/O connect to discovery controller */ 476 memset(&rsp, 0, sizeof(rsp)); 477 subsystem.subtype = SPDK_NVMF_SUBTYPE_DISCOVERY; 478 rc = spdk_nvmf_ctrlr_connect(&req); 479 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS); 480 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 481 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 482 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0); 483 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 42); 484 CU_ASSERT(qpair.ctrlr == NULL); 485 subsystem.subtype = SPDK_NVMF_SUBTYPE_NVME; 486 487 /* I/O connect to disabled controller */ 488 memset(&rsp, 0, sizeof(rsp)); 489 ctrlr.vcprop.cc.bits.en = 0; 490 rc = spdk_nvmf_ctrlr_connect(&req); 491 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS); 492 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 493 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 494 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0); 495 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 42); 496 CU_ASSERT(qpair.ctrlr == NULL); 497 ctrlr.vcprop.cc.bits.en = 1; 498 499 /* I/O connect with invalid IOSQES */ 500 memset(&rsp, 0, sizeof(rsp)); 501 ctrlr.vcprop.cc.bits.iosqes = 3; 502 rc = spdk_nvmf_ctrlr_connect(&req); 503 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS); 504 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 505 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 506 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0); 507 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 42); 508 CU_ASSERT(qpair.ctrlr == NULL); 509 ctrlr.vcprop.cc.bits.iosqes = 6; 510 511 /* I/O connect with invalid IOCQES */ 512 memset(&rsp, 0, sizeof(rsp)); 513 ctrlr.vcprop.cc.bits.iocqes = 3; 514 rc = spdk_nvmf_ctrlr_connect(&req); 515 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS); 516 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 517 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM); 518 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0); 519 CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 42); 520 CU_ASSERT(qpair.ctrlr == NULL); 521 ctrlr.vcprop.cc.bits.iocqes = 4; 522 523 /* I/O connect with too many existing qpairs */ 524 memset(&rsp, 0, sizeof(rsp)); 525 spdk_bit_array_set(ctrlr.qpair_mask, 0); 526 spdk_bit_array_set(ctrlr.qpair_mask, 1); 527 spdk_bit_array_set(ctrlr.qpair_mask, 2); 528 rc = spdk_nvmf_ctrlr_connect(&req); 529 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS); 530 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 531 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_QUEUE_IDENTIFIER); 532 CU_ASSERT(qpair.ctrlr == NULL); 533 spdk_bit_array_clear(ctrlr.qpair_mask, 0); 534 spdk_bit_array_clear(ctrlr.qpair_mask, 1); 535 spdk_bit_array_clear(ctrlr.qpair_mask, 2); 536 537 /* I/O connect with duplicate queue ID */ 538 memset(&rsp, 0, sizeof(rsp)); 539 memset(&qpair2, 0, sizeof(qpair2)); 540 qpair2.group = &group; 541 qpair2.qid = 1; 542 spdk_bit_array_set(ctrlr.qpair_mask, 1); 543 cmd.connect_cmd.qid = 1; 544 rc = spdk_nvmf_ctrlr_connect(&req); 545 CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS); 546 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC); 547 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_QUEUE_IDENTIFIER); 548 CU_ASSERT(qpair.ctrlr == NULL); 549 550 /* Clean up globals */ 551 MOCK_CLEAR(spdk_nvmf_tgt_find_subsystem); 552 MOCK_CLEAR(spdk_nvmf_poll_group_create); 553 554 spdk_bit_array_free(&ctrlr.qpair_mask); 555 spdk_free_thread(); 556 } 557 558 static void 559 test_get_ns_id_desc_list(void) 560 { 561 struct spdk_nvmf_subsystem subsystem; 562 struct spdk_nvmf_qpair qpair; 563 struct spdk_nvmf_ctrlr ctrlr; 564 struct spdk_nvmf_request req; 565 struct spdk_nvmf_ns *ns_ptrs[1]; 566 struct spdk_nvmf_ns ns; 567 union nvmf_h2c_msg cmd; 568 union nvmf_c2h_msg rsp; 569 struct spdk_bdev bdev; 570 uint8_t buf[4096]; 571 572 memset(&subsystem, 0, sizeof(subsystem)); 573 ns_ptrs[0] = &ns; 574 subsystem.ns = ns_ptrs; 575 subsystem.max_nsid = 1; 576 subsystem.subtype = SPDK_NVMF_SUBTYPE_NVME; 577 578 memset(&ns, 0, sizeof(ns)); 579 ns.opts.nsid = 1; 580 ns.bdev = &bdev; 581 582 memset(&qpair, 0, sizeof(qpair)); 583 qpair.ctrlr = &ctrlr; 584 585 memset(&ctrlr, 0, sizeof(ctrlr)); 586 ctrlr.subsys = &subsystem; 587 ctrlr.vcprop.cc.bits.en = 1; 588 589 memset(&req, 0, sizeof(req)); 590 req.qpair = &qpair; 591 req.cmd = &cmd; 592 req.rsp = &rsp; 593 req.xfer = SPDK_NVME_DATA_CONTROLLER_TO_HOST; 594 req.data = buf; 595 req.length = sizeof(buf); 596 597 memset(&cmd, 0, sizeof(cmd)); 598 cmd.nvme_cmd.opc = SPDK_NVME_OPC_IDENTIFY; 599 cmd.nvme_cmd.cdw10 = SPDK_NVME_IDENTIFY_NS_ID_DESCRIPTOR_LIST; 600 601 /* Invalid NSID */ 602 cmd.nvme_cmd.nsid = 0; 603 memset(&rsp, 0, sizeof(rsp)); 604 CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 605 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 606 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_NAMESPACE_OR_FORMAT); 607 608 /* Valid NSID, but ns has no IDs defined */ 609 cmd.nvme_cmd.nsid = 1; 610 memset(&rsp, 0, sizeof(rsp)); 611 CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 612 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 613 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS); 614 CU_ASSERT(spdk_mem_all_zero(buf, sizeof(buf))); 615 616 /* Valid NSID, only EUI64 defined */ 617 ns.opts.eui64[0] = 0x11; 618 ns.opts.eui64[7] = 0xFF; 619 memset(&rsp, 0, sizeof(rsp)); 620 CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 621 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 622 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS); 623 CU_ASSERT(buf[0] == SPDK_NVME_NIDT_EUI64); 624 CU_ASSERT(buf[1] == 8); 625 CU_ASSERT(buf[4] == 0x11); 626 CU_ASSERT(buf[11] == 0xFF); 627 CU_ASSERT(buf[13] == 0); 628 629 /* Valid NSID, only NGUID defined */ 630 memset(ns.opts.eui64, 0, sizeof(ns.opts.eui64)); 631 ns.opts.nguid[0] = 0x22; 632 ns.opts.nguid[15] = 0xEE; 633 memset(&rsp, 0, sizeof(rsp)); 634 CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 635 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 636 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS); 637 CU_ASSERT(buf[0] == SPDK_NVME_NIDT_NGUID); 638 CU_ASSERT(buf[1] == 16); 639 CU_ASSERT(buf[4] == 0x22); 640 CU_ASSERT(buf[19] == 0xEE); 641 CU_ASSERT(buf[21] == 0); 642 643 /* Valid NSID, both EUI64 and NGUID defined */ 644 ns.opts.eui64[0] = 0x11; 645 ns.opts.eui64[7] = 0xFF; 646 ns.opts.nguid[0] = 0x22; 647 ns.opts.nguid[15] = 0xEE; 648 memset(&rsp, 0, sizeof(rsp)); 649 CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 650 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 651 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS); 652 CU_ASSERT(buf[0] == SPDK_NVME_NIDT_EUI64); 653 CU_ASSERT(buf[1] == 8); 654 CU_ASSERT(buf[4] == 0x11); 655 CU_ASSERT(buf[11] == 0xFF); 656 CU_ASSERT(buf[12] == SPDK_NVME_NIDT_NGUID); 657 CU_ASSERT(buf[13] == 16); 658 CU_ASSERT(buf[16] == 0x22); 659 CU_ASSERT(buf[31] == 0xEE); 660 CU_ASSERT(buf[33] == 0); 661 662 /* Valid NSID, EUI64, NGUID, and UUID defined */ 663 ns.opts.eui64[0] = 0x11; 664 ns.opts.eui64[7] = 0xFF; 665 ns.opts.nguid[0] = 0x22; 666 ns.opts.nguid[15] = 0xEE; 667 ns.opts.uuid.u.raw[0] = 0x33; 668 ns.opts.uuid.u.raw[15] = 0xDD; 669 memset(&rsp, 0, sizeof(rsp)); 670 CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 671 CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); 672 CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS); 673 CU_ASSERT(buf[0] == SPDK_NVME_NIDT_EUI64); 674 CU_ASSERT(buf[1] == 8); 675 CU_ASSERT(buf[4] == 0x11); 676 CU_ASSERT(buf[11] == 0xFF); 677 CU_ASSERT(buf[12] == SPDK_NVME_NIDT_NGUID); 678 CU_ASSERT(buf[13] == 16); 679 CU_ASSERT(buf[16] == 0x22); 680 CU_ASSERT(buf[31] == 0xEE); 681 CU_ASSERT(buf[32] == SPDK_NVME_NIDT_UUID); 682 CU_ASSERT(buf[33] == 16); 683 CU_ASSERT(buf[36] == 0x33); 684 CU_ASSERT(buf[51] == 0xDD); 685 CU_ASSERT(buf[53] == 0); 686 } 687 688 static void 689 test_identify_ns(void) 690 { 691 struct spdk_nvmf_subsystem subsystem = {}; 692 struct spdk_nvmf_transport transport = {}; 693 struct spdk_nvmf_qpair admin_qpair = { .transport = &transport}; 694 struct spdk_nvmf_ctrlr ctrlr = { .subsys = &subsystem, .admin_qpair = &admin_qpair }; 695 struct spdk_nvme_cmd cmd = {}; 696 struct spdk_nvme_cpl rsp = {}; 697 struct spdk_nvme_ns_data nsdata = {}; 698 struct spdk_bdev bdev[3] = {{.blockcnt = 1234}, {.blockcnt = 0}, {.blockcnt = 5678}}; 699 struct spdk_nvmf_ns ns[3] = {{.bdev = &bdev[0]}, {.bdev = NULL}, {.bdev = &bdev[2]}}; 700 struct spdk_nvmf_ns *ns_arr[3] = {&ns[0], NULL, &ns[2]}; 701 702 subsystem.ns = ns_arr; 703 subsystem.max_nsid = SPDK_COUNTOF(ns_arr); 704 705 /* Invalid NSID 0 */ 706 cmd.nsid = 0; 707 memset(&nsdata, 0, sizeof(nsdata)); 708 memset(&rsp, 0, sizeof(rsp)); 709 CU_ASSERT(spdk_nvmf_ctrlr_identify_ns(&ctrlr, &cmd, &rsp, 710 &nsdata) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 711 CU_ASSERT(rsp.status.sct == SPDK_NVME_SCT_GENERIC); 712 CU_ASSERT(rsp.status.sc == SPDK_NVME_SC_INVALID_NAMESPACE_OR_FORMAT); 713 CU_ASSERT(spdk_mem_all_zero(&nsdata, sizeof(nsdata))); 714 715 /* Valid NSID 1 */ 716 cmd.nsid = 1; 717 memset(&nsdata, 0, sizeof(nsdata)); 718 memset(&rsp, 0, sizeof(rsp)); 719 CU_ASSERT(spdk_nvmf_ctrlr_identify_ns(&ctrlr, &cmd, &rsp, 720 &nsdata) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 721 CU_ASSERT(rsp.status.sct == SPDK_NVME_SCT_GENERIC); 722 CU_ASSERT(rsp.status.sc == SPDK_NVME_SC_SUCCESS); 723 CU_ASSERT(nsdata.nsze == 1234); 724 725 /* Valid but inactive NSID 2 */ 726 cmd.nsid = 2; 727 memset(&nsdata, 0, sizeof(nsdata)); 728 memset(&rsp, 0, sizeof(rsp)); 729 CU_ASSERT(spdk_nvmf_ctrlr_identify_ns(&ctrlr, &cmd, &rsp, 730 &nsdata) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 731 CU_ASSERT(rsp.status.sct == SPDK_NVME_SCT_GENERIC); 732 CU_ASSERT(rsp.status.sc == SPDK_NVME_SC_SUCCESS); 733 CU_ASSERT(spdk_mem_all_zero(&nsdata, sizeof(nsdata))); 734 735 /* Valid NSID 3 */ 736 cmd.nsid = 3; 737 memset(&nsdata, 0, sizeof(nsdata)); 738 memset(&rsp, 0, sizeof(rsp)); 739 CU_ASSERT(spdk_nvmf_ctrlr_identify_ns(&ctrlr, &cmd, &rsp, 740 &nsdata) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 741 CU_ASSERT(rsp.status.sct == SPDK_NVME_SCT_GENERIC); 742 CU_ASSERT(rsp.status.sc == SPDK_NVME_SC_SUCCESS); 743 CU_ASSERT(nsdata.nsze == 5678); 744 745 /* Invalid NSID 4 */ 746 cmd.nsid = 4; 747 memset(&nsdata, 0, sizeof(nsdata)); 748 memset(&rsp, 0, sizeof(rsp)); 749 CU_ASSERT(spdk_nvmf_ctrlr_identify_ns(&ctrlr, &cmd, &rsp, 750 &nsdata) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 751 CU_ASSERT(rsp.status.sct == SPDK_NVME_SCT_GENERIC); 752 CU_ASSERT(rsp.status.sc == SPDK_NVME_SC_INVALID_NAMESPACE_OR_FORMAT); 753 CU_ASSERT(spdk_mem_all_zero(&nsdata, sizeof(nsdata))); 754 755 /* Invalid NSID 0xFFFFFFFF (NS management not supported) */ 756 cmd.nsid = 0xFFFFFFFF; 757 memset(&nsdata, 0, sizeof(nsdata)); 758 memset(&rsp, 0, sizeof(rsp)); 759 CU_ASSERT(spdk_nvmf_ctrlr_identify_ns(&ctrlr, &cmd, &rsp, 760 &nsdata) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); 761 CU_ASSERT(rsp.status.sct == SPDK_NVME_SCT_GENERIC); 762 CU_ASSERT(rsp.status.sc == SPDK_NVME_SC_INVALID_NAMESPACE_OR_FORMAT); 763 CU_ASSERT(spdk_mem_all_zero(&nsdata, sizeof(nsdata))); 764 } 765 766 int main(int argc, char **argv) 767 { 768 CU_pSuite suite = NULL; 769 unsigned int num_failures; 770 771 if (CU_initialize_registry() != CUE_SUCCESS) { 772 return CU_get_error(); 773 } 774 775 suite = CU_add_suite("nvmf", NULL, NULL); 776 if (suite == NULL) { 777 CU_cleanup_registry(); 778 return CU_get_error(); 779 } 780 781 if ( 782 CU_add_test(suite, "get_log_page", test_get_log_page) == NULL || 783 CU_add_test(suite, "process_fabrics_cmd", test_process_fabrics_cmd) == NULL || 784 CU_add_test(suite, "connect", test_connect) == NULL || 785 CU_add_test(suite, "get_ns_id_desc_list", test_get_ns_id_desc_list) == NULL || 786 CU_add_test(suite, "identify_ns", test_identify_ns) == NULL 787 ) { 788 CU_cleanup_registry(); 789 return CU_get_error(); 790 } 791 792 CU_basic_set_mode(CU_BRM_VERBOSE); 793 CU_basic_run_tests(); 794 num_failures = CU_get_number_of_failures(); 795 CU_cleanup_registry(); 796 return num_failures; 797 } 798