bdev_aio: only apply RWF_NOWAIT when it is supported

Older environment may not support RWF_NOWAIT, do not apply the flag if it is not supported.

Change-Id: I40e83ef52aa3842c63bc41f48c4c57eaecd48ac1

bdev_aio: only apply RWF_NOWAIT when it is supported

Older environment may not support RWF_NOWAIT, do not apply the flag if it is not supported.

Change-Id: I40e83ef52aa3842c63bc41f48c4c57eaecd48ac1
Signed-off-by: Jinlong Chen <chenjinlong.cjl@alibaba-inc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25372
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: GangCao <gang.cao@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>

show more ...

bdev_aio: apply RWF_NOWAIT flag for S_ISBLK() files

This ensures the reactor doesn't block if we've exceeded the number of
tags available on the queue.

We can now get -EAGAIN in the completion path

bdev_aio: apply RWF_NOWAIT flag for S_ISBLK() files

This ensures the reactor doesn't block if we've exceeded the number of
tags available on the queue.

We can now get -EAGAIN in the completion path. Translate these to
bdev ENOMEM status, instead of directly passing -EAGAIN to bdev layer.

Note that we can't use RWF_NOWAIT in all cases, so only try to use it
for block devices (using S_ISBLK).

Fixes issue #2868.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I03c257a1a31048da10d6eb38f6b0f94beca5dd74
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16406
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <ben@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

thread: allow users to pass NULL fn_ptr when registering interrupt

There are a lot of cases where the set_interrupt_mode callback
function is not needed for callers of spdk_poller_register_interrupt

thread: allow users to pass NULL fn_ptr when registering interrupt

There are a lot of cases where the set_interrupt_mode callback
function is not needed for callers of spdk_poller_register_interrupt().
Today, we force all callers to pass a function pointer, which in
most cases does nothing. So relax this restriction to simplify
calling code.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Ib4064722c4dbd9366363a86a0ba7ccb5640cd1f9
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24626
Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

bdev/aio: Add UUID to the bdev_aio_create function

Adds an optional UUID to the RPC call. The parameter is persisted upon
save_config call. This allows for the bdev to have a consistent UUID and
mea

bdev/aio: Add UUID to the bdev_aio_create function

Adds an optional UUID to the RPC call. The parameter is persisted upon
save_config call. This allows for the bdev to have a consistent UUID and
means it can be used with RAID bdev.

Change-Id: If6e7ab1fb327a958bba5a6aa583ba5a4943105f8
Signed-off-by: Mateusz Kozlowski <mateusz.kozlowski@solidigm.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24502
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to preve

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components

Due to patch below being introduced after v24.01 code freeze,
bdev lib version should not be increased:
61623c5ca9 bdev: add spdk_bdev_io padding in place of io_submit_ch

Short reference to how the versions were changed:
MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)
for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \
sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; done
find . -name "Makefile" -exec \
sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I0166d6be6c17bbbf985d48b5dfcb36f1d4af1b48
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21582
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

bdev/aio: support WRITE ZEROS

Support WRITE ZEROS by fallocate FALLOC_FL_ZERO_RANGE.

Change-Id: I2d660ad46f46c10ac77c16c71b9efcab07c35d84
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Reviewe

bdev/aio: support WRITE ZEROS

Support WRITE ZEROS by fallocate FALLOC_FL_ZERO_RANGE.

Change-Id: I2d660ad46f46c10ac77c16c71b9efcab07c35d84
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20455
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

bdev/aio: support UNMAP

Support UNMAP by fallocate FALLOC_FL_PUNCH_HOLE.

Note that fallocate() is synchronous syscall, reactor would block
until operations to disk complete. This could significantl

bdev/aio: support UNMAP

Support UNMAP by fallocate FALLOC_FL_PUNCH_HOLE.

Note that fallocate() is synchronous syscall, reactor would block
until operations to disk complete. This could significantly hurt
performance. For general purpose, AIO based UNMAP(even WRITE ZERO)
is *not* suggested to be used in production environment. Instead of
an entire NVMe bdev, we can test UNMAP in regular file based
development environment.

Suggested by Changpeng, support RPC command to enable *fallocate* for
a single AIO bdev(rather than enabling this feature for all the AIO
bdev at compiling step), this looks appropriate enough.

Change-Id: Iced8b9506e75744ad2e45cecc9995c77224d077b
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20454
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>

show more ...

bdev_aio: Add FreeBSD support

The FreeBSD kernel aio is built around kevent() system call.
Use it for polling, like it is done using io_getevents() on Linux side.

Change-Id: I558236081b8d6870f9a4a3

bdev_aio: Add FreeBSD support

The FreeBSD kernel aio is built around kevent() system call.
Use it for polling, like it is done using io_getevents() on Linux side.

Change-Id: I558236081b8d6870f9a4a3a937df60710045bce9
Signed-off-by: Fedor Uporov <fuporov.vstack@gmail.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18498
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>

show more ...

bdev/aio: add sysctl hint when io_setup fails

Kernel has fs.aio-max-nr limit for maximum number
of AIO requests on the whole system. It is possible
for SPDK to exceed this limit (default 64K) with

bdev/aio: add sysctl hint when io_setup fails

Kernel has fs.aio-max-nr limit for maximum number
of AIO requests on the whole system. It is possible
for SPDK to exceed this limit (default 64K) with
high core count applications and a lot of bdevs.
So provide ERRLOG hint to user when io_setup() fails,
to suggest increasing this limit.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: I7ebebd20c23dbf2abb41fc8afc56ac11bcd3e699
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18232
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

so_ver: increase all major versions

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where

so_ver: increase all major versions

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

Disabled test for increasing SO version without ABI change, as
that is goal of this patch. This check shall be removed with SPDK 23.05
release.
Looks like this was left over from prior LTS, to avoid that
make sure it is only skipped when running against v23.01.x as latest
release.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components
- removes suppressions for ABI tests


Short reference to how the versions were changed:
MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)
for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \
sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; done
find . -name "Makefile" -exec \
sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +

Change-Id: I3e5681802c0a5ac6d7d652a18896997cd07cc8bf
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16419
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date defa

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the 4 digit year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc). Contribution date used
"--follow -C95%" to get the most accurate date.

Note that several files in this patch didn't end the license/(c)
block with a blank comment line so these were added as the vast
majority of files do have this last blank line. Simply there for
consistency.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot

show more ...