Sync various games with NetBSD, in order to fix building with -fno-common.Namely, adventure(6), backgammon(6), battlestar(6), hack(6) and trek(6).-fno-common will be default in future compilers (
Sync various games with NetBSD, in order to fix building with -fno-common.Namely, adventure(6), backgammon(6), battlestar(6), hack(6) and trek(6).-fno-common will be default in future compilers (GCC 10, for example).
show more ...
Fix various grammatical issues in our messages, documentation etc. (2)
Fix various grammatical issues in our messages, documentation etc.
games: Add FALLTHROUGH where missing.
games: Fix -Wint-in-bool-context warnings.These cases were the last two in base.
Add __attribute__((__noreturn__)) to various function prototypes in games/.This general cleanup is useful in various ways. It helps the compileroptimize better and it also helps later GCCs detect
Add __attribute__((__noreturn__)) to various function prototypes in games/.This general cleanup is useful in various ways. It helps the compileroptimize better and it also helps later GCCs detect better when to give-Wimplicit-fallthrough warnings and when not.Found-with: -Wsuggest-attribute=noreturn
games: Make benefits for the glorious curses lib.Consolidate all private ncurses handling in top level Makefile.inc in games/.Will simplify upcoming base ncurses library update.While there, perf
games: Make benefits for the glorious curses lib.Consolidate all private ncurses handling in top level Makefile.inc in games/.Will simplify upcoming base ncurses library update.While there, perfom the same for private crypto lib even if it a single case.
backgammon(6): Avoid symbol issue with ncurses lib.The backgammon(6) has: back.k: extern int raw;while in ncurses tinfo/lib_raw.c: int raw(void){}.This breaks -flto -static link against LTO'ed l
backgammon(6): Avoid symbol issue with ncurses lib.The backgammon(6) has: back.k: extern int raw;while in ncurses tinfo/lib_raw.c: int raw(void){}.This breaks -flto -static link against LTO'ed libncurses.a.So just rename backgammon global raw to bgraw.Just for the fun of it, note that init.c: struct termios bgraw;NetBSD already have it fixed in games/backgammon/.Also still not clear how to do with c5e1790f6b.
Jailbreak games from Dungeon Master.TooManySecrets
Relocate readline and ncurses headers to /usr/include/privHaving public headers for private libraries can cause confusion forsoftware that assumes the presence of headers leads to the availability
Relocate readline and ncurses headers to /usr/include/privHaving public headers for private libraries can cause confusion forsoftware that assumes the presence of headers leads to the availabilityof the libraries.Discussed-with: dillon
LIBPRIV: Add common PRIVATELIB_LDFLAGS definitions.Simply being able to change it in two places is easier than everywhere.Also add PRIVATELIB_BLDFLAGS that is intended for bootsrapping only.While
LIBPRIV: Add common PRIVATELIB_LDFLAGS definitions.Simply being able to change it in two places is easier than everywhere.Also add PRIVATELIB_BLDFLAGS that is intended for bootsrapping only.While there, perform some cleanup for dup entries.
backgammon(6): Prevent LTO seeing details for now.init.c should contain "back.h" for types (TBI later).-flto gives lots of error: type of 'args' does not match original declaration [-Werror]/usr
backgammon(6): Prevent LTO seeing details for now.init.c should contain "back.h" for types (TBI later).-flto gives lots of error: type of 'args' does not match original declaration [-Werror]/usr/src/games/backgammon/backgammon/../common_source/back.h extern char *args[16]; /* args passed to teachgammon and back *//usr/src/games/backgammon/backgammon/../common_source/init.c char args[100];/usr/src/games/backgammon/backgammon/../common_source/back.h extern int old; /* original tty status *//usr/src/games/backgammon/backgammon/../common_source/init.c struct termios tty, old, noech, raw;/usr/src/games/backgammon/backgammon/../common_source/back.h extern int raw; /* raw tty status, no echo *//usr/src/games/backgammon/backgammon/../common_source/init.c struct termios tty, old, noech, raw;/usr/src/games/backgammon/backgammon/../common_source/back.h extern int noech; /* original tty status without echo *//usr/src/games/backgammon/backgammon/../common_source/init.c struct termios tty, old, noech, raw;lto1: all warnings being treated as errors
ncurses solidation: Remove all references to libtermcapThe termlib, termcap, and tinfo libraries are all symlinked to ncurseslibrary. There's no reason to have four aliases for the same libraryw
ncurses solidation: Remove all references to libtermcapThe termlib, termcap, and tinfo libraries are all symlinked to ncurseslibrary. There's no reason to have four aliases for the same librarywhen none of them are exposed outside base.termlib and tinfo aren't referenced anywhere, but libtermcap is.This commit changes all the references to libtermcap to libncurses,and removes the private aliases of ncurses.
privatize libncurses (touches many, many programs)The ncurses software produces 8 libraries: normal and wide versions ofncurses, forms, menu, and panel. The dragonfly base doesn't use formsor me
privatize libncurses (touches many, many programs)The ncurses software produces 8 libraries: normal and wide versions ofncurses, forms, menu, and panel. The dragonfly base doesn't use formsor menu at all so we can remove 4 libraries immediately and theirassociated man pages.The panel library is only used in one place, so technically libpanelwis no longer required, but let's keep building it anyway.While here, delete references to libcurses. It was just symlinked toncurses, so let's take the opportunity to only reference ncurses fromthis point forward and not install a private version of libcurses.
Clean up some more signal handlers in various places.
Remove some unused externs.
games: Fix -Werror for gcc47.* Remove unused variables and mark a few things __unused.* Properly use socklen_t.* Remove trek(6)'s undocumented -p option (which did nothing).
Remove some unnecessary inclusions of <sys/cdefs.h> across the tree.
Sweep-fix comparing pointers with 0 (and assigning 0 to pointers).For better readability, don't compare pointers with 0 or assign 0to them. Use NULL instead.The change was done with coccinelle.
games: Massive style(9) cleanup commit. Reduces differences to NetBSD.Submitted-by: Ulrich Spoerlein <uqs@spoerlein.net>
games - backgammon - use defined names instead of magic numbers.Submitted-by: Ulrich Spoerlein <uqs@spoerlein.net>
backgammon(6)/hack(6)/larn(6): replace sgtty with termiosCourtesy of FreeBSD ports.Also does some additional cleanup.Submitted-by: Ulrich Spoerlein <uqs@spoerlein.net>Dragonfly-bugs: <http:/
backgammon(6)/hack(6)/larn(6): replace sgtty with termiosCourtesy of FreeBSD ports.Also does some additional cleanup.Submitted-by: Ulrich Spoerlein <uqs@spoerlein.net>Dragonfly-bugs: <http://bugs.dragonflybsd.org/issue1491> <http://bugs.dragonflybsd.org/issue1492> <http://bugs.dragonflybsd.org/issue1493>
Use .Nm
Convert to mdoc.Obtained from (except for bs(6)): NetBSD
Move WARNS6 up into Makefile.inc for games/ and out of the individualMakefiles.
12