json: allow decoding arrays to a single buffer

Sometimes, it might be useful to decode a JSON array, but store the
result in a single place. For instance, one might want to decode a set
of flags pa

json: allow decoding arrays to a single buffer

Sometimes, it might be useful to decode a JSON array, but store the
result in a single place. For instance, one might want to decode a set
of flags passed as an array of strings and store them in a single
uint64_t, e.g.:

static int
decode_flag(const struct spdk_json_val *val, void *out)
{
uint64_t *flags = out;
char *flag = NULL;
int rc = 0;

spdk_json_decode_string(val, &flag);
if (strcmp(flag, "foo") == 0) {
*flags |= FLAG_FOO;
} else if (strcmp(flag, "bar") == 0) {
*flags |= FLAG_BAR;
} else {
rc = -1;
}

free(flag);
return rc;
}

uint64_t flags = 0;

spdk_json_decode_array(j, decode_flag, &flags, UINT32_MAX, &count, 0);

With this patch, it's possible to do this by passing stride=0 to
spdk_json_decode_array().

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I27b30dec85d3ccef5df1a307798d79b074768a99
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22020
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to preve

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components

Due to patch below being introduced after v24.01 code freeze,
bdev lib version should not be increased:
61623c5ca9 bdev: add spdk_bdev_io padding in place of io_submit_ch

Short reference to how the versions were changed:
MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)
for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \
sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; done
find . -name "Makefile" -exec \
sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I0166d6be6c17bbbf985d48b5dfcb36f1d4af1b48
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21582
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

json: return -1 on spdk_json_decode_uuid() failure

It makes it consistent with the other spdk_json_decode*() functions, as
they return -1, not errnos.

Signed-off-by: Konrad Sztyber <konrad.sztyber@

json: return -1 on spdk_json_decode_uuid() failure

It makes it consistent with the other spdk_json_decode*() functions, as
they return -1, not errnos.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I6579a0a7e77ff831742cb2f4c651f2c42d7268c1
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20532
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

json: add spdk_json_decode_uuid()

Similarly to spdk_json_write_uuid(), there are lots of places where we
need to decode a JSON string to spdk_uuid and each of them has to decode
and parse the string

json: add spdk_json_decode_uuid()

Similarly to spdk_json_write_uuid(), there are lots of places where we
need to decode a JSON string to spdk_uuid and each of them has to decode
and parse the string.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ia1e1b5e28b29b741295c318b642f533808f94296
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20474
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

json: add spdk_json_write_(named)?_uuid()

There are many places where we need to write out a UUID to JSON, so it's
useful to have a helper that will do it.

Signed-off-by: Konrad Sztyber <konrad.szt

json: add spdk_json_write_(named)?_uuid()

There are many places where we need to write out a UUID to JSON, so it's
useful to have a helper that will do it.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Id192990fb47e9253e96d0b17e85ac88d34769666
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20472
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

so_ver: increase all major versions

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where

so_ver: increase all major versions

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

Disabled test for increasing SO version without ABI change, as
that is goal of this patch. This check shall be removed with SPDK 23.05
release.
Looks like this was left over from prior LTS, to avoid that
make sure it is only skipped when running against v23.01.x as latest
release.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components
- removes suppressions for ABI tests


Short reference to how the versions were changed:
MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)
for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \
sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; done
find . -name "Makefile" -exec \
sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +

Change-Id: I3e5681802c0a5ac6d7d652a18896997cd07cc8bf
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16419
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

json: add spdk_json_write_named_double

Signed-off-by: Thanos Makatos <thanos.makatos@nutanix.com>
Suggested-by: Jim Harris <james.r.harris@intel.com>
Change-Id: I2439cd739240fb2d95c5cdaccc557ba9a8f6

json: add spdk_json_write_named_double

Signed-off-by: Thanos Makatos <thanos.makatos@nutanix.com>
Suggested-by: Jim Harris <james.r.harris@intel.com>
Change-Id: I2439cd739240fb2d95c5cdaccc557ba9a8f6501b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15490
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: John Levon <levon@movementarian.org>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date defa

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the 4 digit year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc). Contribution date used
"--follow -C95%" to get the most accurate date.

Note that several files in this patch didn't end the license/(c)
block with a blank comment line so these were added as the vast
majority of files do have this last blank line. Simply there for
consistency.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot

show more ...

json: fix parsing json problems when json config is invalid.

Add parsing json as invalid cases:
1.json content that not enclosed in {}, it should be parsed as invalid, e.g.

"abc":"not encloesed in