example/hello_sock: reduce spdk_sock_recv() logs on errors

When error is reported from spdk_sock_recv(),
we still let the hello_sock_recv_poll() poller to
execute for one more second via hello_sock_

example/hello_sock: reduce spdk_sock_recv() logs on errors

When error is reported from spdk_sock_recv(),
we still let the hello_sock_recv_poll() poller to
execute for one more second via hello_sock_close_timeout_poll().

Few cases where we perform negative tests with expected
failures, generates pretty long logs in order of megabytes.

This patch uses newly added SPDK_ERRLOG_RATELIMIT() to
limit to one error message per second.

While not completely necessary, prevent attempting to call
hello_sock_quit() multiple times while draining.

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: If1f8feecd0a0e0d0650e0feaf9230af40cb6c0f3
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22514
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

apps: set NULL as RPC address in some apps

Set opts.rpc_addr to NULL in SPDK applications that usually do not
benefit from starting RPC interface. These include programs in app,
examples and test di

apps: set NULL as RPC address in some apps

Set opts.rpc_addr to NULL in SPDK applications that usually do not
benefit from starting RPC interface. These include programs in app,
examples and test directories.

Some of the tests now require that we explicitly set RPC address,
because some apps no longer use the default SPDK address.

Change-Id: I417a3a756581f44c711257e6d2408d933b40386a
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22634
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

examples/hello_sock: free I/O buffer in main()

Do not depend on start of the application
to free the I/O buffer in closing poller.
Instead do that in main on every exit path.

There is a negative te

examples/hello_sock: free I/O buffer in main()

Do not depend on start of the application
to free the I/O buffer in closing poller.
Instead do that in main on every exit path.

There is a negative test case with hello_sock,
which shows mem leak when ASAN is enabled.
See test case:
test/iscsi_tgt/sock/sock.sh:126

Direct leak of 1024 byte(s) in 1 object(s) allocated from:
#0 0x7f48846ba097 in calloc (/usr/lib64/libasan.so.8+0xba097)
#1 0x408ffe in main /home/vagrant/spdk_repo/spdk/examples/sock/hello_world/hello_sock.c:562
#2 0x7f488370750f in __libc_start_call_main (/usr/lib64/libc.so.6+0x2750f)

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: Ib7dcad385e5c01128cab71d108832a8ac0594709
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20734
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

hello_sock: Use unhexlified PSK in global array.

Later in the series asynchronous TLS handshake is
introduced. This means that memory holding the
unhexlified PSK may be used outside hello_sock_conne

hello_sock: Use unhexlified PSK in global array.

Later in the series asynchronous TLS handshake is
introduced. This means that memory holding the
unhexlified PSK may be used outside hello_sock_connect()
function in which it was previously declared, so move
unhexlifying to hello_sock_parse_arg() and use binary
PSK in global array.

Additionally group impl_opts.* assignments together.

Change-Id: I7a93247bedb00e850c1f8a979f837603e35fd563
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19813
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot

show more ...

hello_sock: Handle EAGAIN errors.

Handle these types of errors, when writing to socket.
Additionally remove buf_out in hello_sock_writev_poll(),
because we can read the buffer directly from ctx->buf

hello_sock: Handle EAGAIN errors.

Handle these types of errors, when writing to socket.
Additionally remove buf_out in hello_sock_writev_poll(),
because we can read the buffer directly from ctx->buf
and move ctx->buf allocation to main(), as this field
is now used by both client and server.

Change-Id: Id6be8e0907382e12e21ab180469b7cec05fdc69b
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19717
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

hello_sock: fix iov_len check in callback.

Currently we assign value of `rc`, which is of type
signed integer, to `iov.iov_len`, which is of type
size_t (unsigned integer). If rc == -1, then
iov.iov

hello_sock: fix iov_len check in callback.

Currently we assign value of `rc`, which is of type
signed integer, to `iov.iov_len`, which is of type
size_t (unsigned integer). If rc == -1, then
iov.iov_len == UINT_MAX, which lets code enter
the if block, even when `spdk_sock_recv_next()`
failed.

Change-Id: I6ee83cf3f38660431385399ca28a02997ad1a701
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19464
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

examples/hello_world: Add check for fcntl retval

fcntl() returns -1 on error and sets errno.

Change-Id: I959a4e0277ce80d53ec81ab57f963cb956c7f2fd
Signed-off-by: Wojciech Panfil <wojciech.panfil@int

examples/hello_world: Add check for fcntl retval

fcntl() returns -1 on error and sets errno.

Change-Id: I959a4e0277ce80d53ec81ab57f963cb956c7f2fd
Signed-off-by: Wojciech Panfil <wojciech.panfil@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18927
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jacek Kalwas <jacek.kalwas@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

hello_sock: check if ctx->group is NULL

Fixed issue detected by Klocwork scan.
ctx->group must be checked for NULL before call to
spdk_sock_group_provide_buf(ctx->group, ...), otherwise
in this func

hello_sock: check if ctx->group is NULL

Fixed issue detected by Klocwork scan.
ctx->group must be checked for NULL before call to
spdk_sock_group_provide_buf(ctx->group, ...), otherwise
in this function we are dereferencing NULL pointer
in line:
STAILQ_INSERT_HEAD(&group->pool, provided, link);

Change-Id: I10d1d35d1026f12f7fa02b24639f6036e0a798f2
Signed-off-by: Marcin Spiewak <marcin.spiewak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18244
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

TCP: prepare for usage of supported cipher suites

Prepare for cipher suite selection introduced in the next patch.
Cipher suites are going to be selected based on size of provided
PSK in interchange

TCP: prepare for usage of supported cipher suites

Prepare for cipher suite selection introduced in the next patch.
Cipher suites are going to be selected based on size of provided
PSK in interchange format.

Choosing hash function for retained PSK will be
introduced in a future patch along with PSK interchange
format.

Use TLS_AES_128_GCM_SHA256 until information
about cipher suite can be derived from length of PSK
configured.

Cipher TLS_AES_256_GCM_SHA384 requires us to use newer
version of OpenSSL callbacks:
instead of setting them with SSL_set_psk_server_callback()
we'll need to use SSL_set_psk_find_session_callback() for
server callbacks. As a part of this patch introduce
required server side changes.

Change-Id: I3683f6366aab3fea71ab218dbf4e2589292120e2
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16125
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

sock: add TLS cipher suite field

Add a field to structure spdk_sock_impl_opts that will be set
with selected cipher suite for connecting side or cipher suite
list for listening side. Then set cipher

sock: add TLS cipher suite field

Add a field to structure spdk_sock_impl_opts that will be set
with selected cipher suite for connecting side or cipher suite
list for listening side. Then set cipher suite with
SSL_CTX_set_ciphersuites().

Cipher TLS_AES_256_GCM_SHA384 requires us to use newer
version of OpenSSL callbacks, which are incompatibilie
with TLS 1.2 and below:
- instead of setting them with SSL_set_psk_client_callback()
we'll need to use SSL_set_psk_use_session_callback for
client callbacks. As a part of this patch introduce
required client side changes.
- remove support for TLS 1.2 and below, as required
cipher suites are incompatibile with earlier TLS versions.

Change-Id: Id4e274ad2cc265f79d8dd02e65692678981926f2
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16672
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

hello_sock: Use zero copy receive for the server side

Change-Id: I188fc50202e111ef7b1f8811220b2a01915a4270
Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.spdk.io/g

hello_sock: Use zero copy receive for the server side

Change-Id: I188fc50202e111ef7b1f8811220b2a01915a4270
Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16610
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

nvme_tcp: generate retained PSK

Transform raw PSK into retained psk to be
stored inside TCP transport. The same transformation
has to be done on the NVMe driver's side, to later
derive the same TLS

nvme_tcp: generate retained PSK

Transform raw PSK into retained psk to be
stored inside TCP transport. The same transformation
has to be done on the NVMe driver's side, to later
derive the same TLS PSK. TLS PSK is going to be
introduced in the next patch.

To avoid supporting two types of PSKs (hexadecimal strings
and byte arrays) drop unhexlifying PSK in SSL socket code
and make sure other places (hello_sock app) that do not
use NVMe TCP driver are responsible for this transformation.

Since PSK is now stored as binary data rather than
char array, add a field "psk_size" to tcp_psk_entry
structure.

Change-Id: I921faa54714c333cf64c59c35cf96cf1f6eda6d6
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16246
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>

show more ...

examples/sock: close the right sock object

Change-Id: If26e4ace04e2ab6a950ebd270a46805ed8ca973d
Signed-off-by: GangCao <gang.cao@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1

examples/sock: close the right sock object

Change-Id: If26e4ace04e2ab6a950ebd270a46805ed8ca973d
Signed-off-by: GangCao <gang.cao@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15956
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

misc: Fix spelling mistakes

Found with misspell-fixer.

Signed-off-by: Michal Berger <michal.berger@intel.com>
Change-Id: If062df0189d92e4fb2da3f055fb981909780dc04
Reviewed-on: https://review.spdk.i

misc: Fix spelling mistakes

Found with misspell-fixer.

Signed-off-by: Michal Berger <michal.berger@intel.com>
Change-Id: If062df0189d92e4fb2da3f055fb981909780dc04
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15207
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date defa

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the 4 digit year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc). Contribution date used
"--follow -C95%" to get the most accurate date.

Note that several files in this patch didn't end the license/(c)
block with a blank comment line so these were added as the vast
majority of files do have this last blank line. Simply there for
consistency.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot

show more ...