app/trace: emit owner descriptions

Now that we have a real description for an event's owner, print those
descriptions instead of the old owner_type prefix + poller_id.

Note that we need to take the

app/trace: emit owner descriptions

Now that we have a real description for an event's owner, print those
descriptions instead of the old owner_type prefix + poller_id.

Note that we need to take the event's tsc into account, if it is older than
when the associated owner was registered we should not print the description
because it is for an owner that was unregistered after the event was
generated.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I9257306b5fe9fd7273abcb9b14e4fc136c417742
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22648
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

trace: rename trace_event's poller_id to owner_id

"poller_id" was sort of a very early and crude attempt at associating
trace events with who generated them. The new "owner" concept is replacing
tha

trace: rename trace_event's poller_id to owner_id

"poller_id" was sort of a very early and crude attempt at associating
trace events with who generated them. The new "owner" concept is replacing
that, so just rename the existing "poller_id" to "owner_id".

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Icd61e39c5225030690ef0238cd0b3a90846fcc6b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22647
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

app/trace: fix for trace_print()

This patch fixes issue introduced in patch 22642.

If lcore is defined in trace_print() and initialized with
SPDK_TRACE_MAX_LCORE, the 'if' statement inside 'for'
lo

app/trace: fix for trace_print()

This patch fixes issue introduced in patch 22642.

If lcore is defined in trace_print() and initialized with
SPDK_TRACE_MAX_LCORE, the 'if' statement inside 'for'
loop is always true and trace size is printed for
every lcore. This is not intended use of this
function - if the user passes the lcore number
as a command line parameter, only this lcore shall
be printed. We need to propagate lcore number from
main(), where it is parsed and assigned, to the
trace_print().

Change-Id: I5c84da7da7df39c88ac52ba4ffaea8a518de77c6
Signed-off-by: Marcin Spiewak <marcin.spiewak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22829
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

spdk_trace: refactor output format handling

Fix inappropriate output when json option is given.
For further flexibility, refactors output formatting process to switch
statement.
This would simplify

spdk_trace: refactor output format handling

Fix inappropriate output when json option is given.
For further flexibility, refactors output formatting process to switch
statement.
This would simplify adding new output format, such as Jaeger.

Fixes issue #3326.

Change-Id: Ibcf3e1821d16f20550a970f701b32ab79fc501a0
Signed-off-by: Yongjin Lee <yong7.lee@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22642
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

trace: rename owner to owner_type

We will be adding the real concept of an "owner" in upcoming patches. So change
the existing "owner" to "owner_type" which more accurate reflects its meaning.
For e

trace: rename owner to owner_type

We will be adding the real concept of an "owner" in upcoming patches. So change
the existing "owner" to "owner_type" which more accurate reflects its meaning.
For example, an "owner_type" can be OWNER_BDEV, but an actual "owner" would
be some specific bdev identified by its name.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Ieb25eb5a574a88b3812291f2345796e5bb66a54f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22645
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

spdk_trace: default on Linux to newest trace file in /dev/shm

It is kind of a pain to have to *always* have to specify the filename
or app parameters to spdk_trace, especially when you have the app

spdk_trace: default on Linux to newest trace file in /dev/shm

It is kind of a pain to have to *always* have to specify the filename
or app parameters to spdk_trace, especially when you have the app currently
running or the app just exited.

So use ntfw() to walk the files in /dev/shm when -f and -s are not specified,
and use the newest file (assuming one is found).

A few caveats:
1) This only works on Linux, mainly because FreeBSD does not have a /dev/shm
mount for shm files.
2) Search /dev/shm is not foolproof, since we don't know for sure whether a
file there is an SPDK trace file. But looking for the "_trace." substring
should be enough. It should guard against trying to use other non-trace
files.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: If130e6f5918a228b6f9d4576e16d37e05bfc4995
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22104
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

trace_parser: add flag for arguments used for related objects

Some tracepoints have an argument that is a context pointer for some other
object type. The trace app already decode this information, s

trace_parser: add flag for arguments used for related objects

Some tracepoints have an argument that is a context pointer for some other
object type. The trace app already decode this information, showing the ID for
that related object.

Since the ID is already shown, the context pointer itself isn't useful, so
add a flag to note those arguments, so we can omit printing the context
pointer.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I3f6521ff5594cdc4c635c23a612c8f0d2f3717dd
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22102
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

trace_parser: put argument union into a struct

A future patch will add a per-argument field separate from the argument types,
so put that argument union into a struct now to prepare for that future

trace_parser: put argument union into a struct

A future patch will add a per-argument field separate from the argument types,
so put that argument union into a struct now to prepare for that future
patch.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Ia2aaa5b53332c2c04d731358a07ea99bd7e9ec44
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22101
Community-CI: Mellanox Build Bot
Reviewed-by: Seung yeon Shin <syeon.shin@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

trace: merge spdk_trace_flags into spdk_trace_file

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I8a070f986825de2470d5873eaeed3849d36bf1af
Reviewed-on: https://review.spdk.io/gerrit/

trace: merge spdk_trace_flags into spdk_trace_file

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I8a070f986825de2470d5873eaeed3849d36bf1af
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21790
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

lib/trace : Display names for user created threads

Names for the user created threads are displayed in the
trace logs.

Change-Id: I0030df05276ab8c3583d10effdfb54bed6d3c28a
Signed-off-by: Krishna Ka

lib/trace : Display names for user created threads

Names for the user created threads are displayed in the
trace logs.

Change-Id: I0030df05276ab8c3583d10effdfb54bed6d3c28a
Signed-off-by: Krishna Kanth Reddy <krish.reddy@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21713
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

spdk_trace: align "N/A" similar to valid IDs

Without this change, output for trace points with
an unknown ID something like this (truncated to reduce
overall width):

TCP_REQ_RDY_TO_EXECUTE

spdk_trace: align "N/A" similar to valid IDs

Without this change, output for trace points with
an unknown ID something like this (truncated to reduce
overall width):

TCP_REQ_RDY_TO_EXECUTE id: N/Aqpair: 0xaaaaed7c1770

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: Id4962e2caf35fb838604d5290359637f2bebdfd5
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18867
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>

show more ...

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date defa

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the 4 digit year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc). Contribution date used
"--follow -C95%" to get the most accurate date.

Note that several files in this patch didn't end the license/(c)
block with a blank comment line so these were added as the vast
majority of files do have this last blank line. Simply there for
consistency.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot

show more ...