scsi: simplify split path

Currently the splitting code for unmap and write_same is a bit complicated,
since it needs to handle case where we get a 0-length unmap descriptor and
spdk_bdev_unmap_block

scsi: simplify split path

Currently the splitting code for unmap and write_same is a bit complicated,
since it needs to handle case where we get a 0-length unmap descriptor and
spdk_bdev_unmap_blocks() didn't handle 0-length calls.

But spdk_bdev_unmap_blocks() has been updated now to handle 0-length calls,
so we can eliminate this extra complexity.

This also alleviates a small regression identified when this splitting code
path was updated.

Fixes issue #3249.
Fixes b735c429 ("scsi: Improve child IO split mechanism").

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I93cdac1c449a17fcc22e9909beb0feafe2b08b54
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21773
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

scsi: Improve child IO split mechanism

Improve the child IO split mechanism with the points:
- simplify error handing for splitting loop.
- ctx->fn() does not have to touch any counter. then
ctx->

scsi: Improve child IO split mechanism

Improve the child IO split mechanism with the points:
- simplify error handing for splitting loop.
- ctx->fn() does not have to touch any counter. then
ctx->remaining_count is removed from _bdev_scsi_unmap and
_bdev_scsi_write_same.

Change-Id: I543fcbb6eede662ec248e68c2d377d3b3a488961
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20559
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

scsi: Drop 'name' field in spdk_bdev_scsi_split_ctx

Child IO split mechanism[1] uses 'name' field to dump the necessary
message on failure, now we can use spdk_scsi_sbc_opcode_string
instead.

[1]SP

scsi: Drop 'name' field in spdk_bdev_scsi_split_ctx

Child IO split mechanism[1] uses 'name' field to dump the necessary
message on failure, now we can use spdk_scsi_sbc_opcode_string
instead.

[1]SPDK Commit: f6613e370d75 ("scsi: Abstract child IO split mechanism")
Change-Id: I6f7cca10f7340d6008022671a990ff8b5d157b62
Suggested-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20465
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

vhost-scsi: support SBC-3 compare_and_write IO

Support compare_and_write from SBC-3 for 1 block since
spdk_bdev_comparev_and_writev_blocks function supports
compare_and_write of only 1 block current

vhost-scsi: support SBC-3 compare_and_write IO

Support compare_and_write from SBC-3 for 1 block since
spdk_bdev_comparev_and_writev_blocks function supports
compare_and_write of only 1 block currently.

Change-Id: I1069fa6c9070a5f16b8867f62740a2dce8a282da
Signed-off-by: Haoqian He <haoqian.he@smartx.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19873
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

scsi: Refine split processing for unmap

If any child I/O failed, we should set the status of the SCSI task
to failed and stop further split processing.

However, ctx->count meant number of outstandi

scsi: Refine split processing for unmap

If any child I/O failed, we should set the status of the SCSI task
to failed and stop further split processing.

However, ctx->count meant number of outstanding children I/Os. We
could not stop further split processing. We updated the status of the
SCSI task only if child I/O submission failed.

Fix these in this patch. Verify the changes by refining unit tests
except for error cases.

This idea was derived from the splitting process of the generic bdev
layer.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ifc74c09c349567b0311fe2a7435a5452d4c68251
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19437
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

test/unit: use spdk_ut_run_tests()

Replaced direct calls to the CUnit's functions to run the tests with
spdk_ut_run_tests(). That way, each test will have the ability to run
a specific test case.

test/unit: use spdk_ut_run_tests()

Replaced direct calls to the CUnit's functions to run the tests with
spdk_ut_run_tests(). That way, each test will have the ability to run
a specific test case.

The blob.c unit test wasn't changed, because it runs all tests multiple
times with different parameter combinations, so it cannot be easily
converted. In the future, each such combination could be split into a
separate test suite, which would make it compatible with
spdk_ut_run_tests().

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I4463f808f89844e9bf32b5b31eda197c5d729d1d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19288
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

test/unit: move spdk_cunit.h to include/spdk_internal

It'll make it easier to include this file outside of unit tests.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I171ddb864

test/unit: move spdk_cunit.h to include/spdk_internal

It'll make it easier to include this file outside of unit tests.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I171ddb8649f67b5786f08647560e2907603d0574
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19284
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

lib/util/dif: Added support for CRC-64 guard

Extend the DIF/DIX library with the CRC-64
format of the Protection Information

Change-Id: I762db9aa2e9cfa58cb5b81843c2eff32f60ca264
Signed-off-by: Slaw

lib/util/dif: Added support for CRC-64 guard

Extend the DIF/DIX library with the CRC-64
format of the Protection Information

Change-Id: I762db9aa2e9cfa58cb5b81843c2eff32f60ca264
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18584
Community-CI: Mellanox Build Bot
Reviewed-by: Xiaodong Liu <xiaodong.liu@intel.com>
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

show more ...

lib/util/dif: Wrappers for DIF fields access

Introduced wrappers for the DIF structure
fields access, in order to prepare for
extending the DIF structure with
additional formats.

Change-Id: I5592f5

lib/util/dif: Wrappers for DIF fields access

Introduced wrappers for the DIF structure
fields access, in order to prepare for
extending the DIF structure with
additional formats.

Change-Id: I5592f59d05a4bfecbfb88a5fad2815a38d965ea0
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18174
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>

show more ...

lib/util/dif: Add an ext_opts param to spdk_dif_ctx_init

The extended options structure for the dif context
initialization allows for adding new arguments
without the function signature change. The

lib/util/dif: Add an ext_opts param to spdk_dif_ctx_init

The extended options structure for the dif context
initialization allows for adding new arguments
without the function signature change. The first
extended parameter is the DIF Protection Information
format (CRC-16).

Change-Id: I6a32e8570676265d757fc7251441e5547bbb475d
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18146
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date defa

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the 4 digit year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc). Contribution date used
"--follow -C95%" to get the most accurate date.

Note that several files in this patch didn't end the license/(c)
block with a blank comment line so these were added as the vast
majority of files do have this last blank line. Simply there for
consistency.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot

show more ...