ut/json: add tests for UUID decode/write functionsThese functions were added recently, but were missing unit tests, so acouple of small test cases were added to verify them.Signed-off-by: Konrad
ut/json: add tests for UUID decode/write functionsThese functions were added recently, but were missing unit tests, so acouple of small test cases were added to verify them.Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>Change-Id: I2dd5b617970e9738b7b5e2059900258b38e9dbc4Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20533Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Jim Harris <jim.harris@samsung.com>Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>Community-CI: Mellanox Build Bot
show more ...
test/unit: use spdk_ut_run_tests()Replaced direct calls to the CUnit's functions to run the tests withspdk_ut_run_tests(). That way, each test will have the ability to runa specific test case.
test/unit: use spdk_ut_run_tests()Replaced direct calls to the CUnit's functions to run the tests withspdk_ut_run_tests(). That way, each test will have the ability to runa specific test case.The blob.c unit test wasn't changed, because it runs all tests multipletimes with different parameter combinations, so it cannot be easilyconverted. In the future, each such combination could be split into aseparate test suite, which would make it compatible withspdk_ut_run_tests().Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>Change-Id: I4463f808f89844e9bf32b5b31eda197c5d729d1dReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19288Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>Community-CI: Mellanox Build BotReviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
test/unit: move spdk_cunit.h to include/spdk_internalIt'll make it easier to include this file outside of unit tests.Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>Change-Id: I171ddb864
test/unit: move spdk_cunit.h to include/spdk_internalIt'll make it easier to include this file outside of unit tests.Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>Change-Id: I171ddb8649f67b5786f08647560e2907603d0574Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19284Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
json: add spdk_json_write_named_doubleSigned-off-by: Thanos Makatos <thanos.makatos@nutanix.com>Suggested-by: Jim Harris <james.r.harris@intel.com>Change-Id: I2439cd739240fb2d95c5cdaccc557ba9a8f6
json: add spdk_json_write_named_doubleSigned-off-by: Thanos Makatos <thanos.makatos@nutanix.com>Suggested-by: Jim Harris <james.r.harris@intel.com>Change-Id: I2439cd739240fb2d95c5cdaccc557ba9a8f6501bReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15490Reviewed-by: Jim Harris <james.r.harris@intel.com>Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>Reviewed-by: John Levon <levon@movementarian.org>Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
update Intel copyright noticesper Intel policy to include file commit date using git cmdbelow. The policy does not apply to non-Intel (C) notices.git log --follow -C90% --format=%ad --date defa
update Intel copyright noticesper Intel policy to include file commit date using git cmdbelow. The policy does not apply to non-Intel (C) notices.git log --follow -C90% --format=%ad --date default <file> | tail -1and then pull just the 4 digit year from the result.Intel copyrights were not added to files where Intel either hadno contribution ot the contribution lacked substance (ie licenseheader updates, formatting changes, etc). Contribution date used"--follow -C95%" to get the most accurate date.Note that several files in this patch didn't end the license/(c)block with a blank comment line so these were added as the vastmajority of files do have this last blank line. Simply there forconsistency.Signed-off-by: paul luse <paul.e.luse@intel.com>Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Jim Harris <james.r.harris@intel.com>Reviewed-by: Ben Walker <benjamin.walker@intel.com>Community-CI: Mellanox Build Bot
check_format: For C files only, fix return type breaksIn SPDK, declarations have the return type on the same line. Definitionshave the return type on a separate line. Astyle has an option forenfo
check_format: For C files only, fix return type breaksIn SPDK, declarations have the return type on the same line. Definitionshave the return type on a separate line. Astyle has an option forenforcing this. Unfortunately, it seems to have two bugs:1) It doesn't work correctly at all on C++ files.2) It often fails on functions that return enums, or long type namesDeal with 1) by adjusting the check_format.sh script to only tell astyleto fix return type line breaks for C files and not C++. Deal with 2) byadding a few typedefs to work around the problem.Change-Id: Idf28281466cab8411ce252d5f02ab384166790c6Signed-off-by: Ben Walker <benjamin.walker@intel.com>Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13437Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Jim Harris <james.r.harris@intel.com>Reviewed-by: Dong Yi <dongx.yi@intel.com>Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Replace most BSD 3-clause license text with SPDX identifier.Many open source projects have moved to using SPDX identifiersto specify license information, reducing the amount ofboilerplate code in
Replace most BSD 3-clause license text with SPDX identifier.Many open source projects have moved to using SPDX identifiersto specify license information, reducing the amount ofboilerplate code in every source file. This patch replacesthe bulk of SPDK .c, .cpp and Makefiles with the BSD-3-Clauseidentifier.Almost all of these files share the exact same license text,and this patch only modifies the files that contain themost common license text. There can be slight variationsbecause the third clause contains company names - most say"Intel Corporation", but there are instances for Nvidia,Samsung, Eideticom and even "the copyright holder".Used a bash script to automate replacement of the license textwith SPDX identifier which is checked into scripts/spdx.sh.Signed-off-by: Jim Harris <james.r.harris@intel.com>Change-Id: Iaa88ab5e92ea471691dc298cfe41ebfb5d169780Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12904Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>Reviewed-by: Dong Yi <dongx.yi@intel.com>Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>Reviewed-by: Paul Luse <paul.e.luse@intel.com>Reviewed-by: <qun.wan@intel.com>
test: optimize unit test .gitignore filesJust add a single .gitignore file in test/unitthat covers *_ut. That allows us to eliminate100 .gitignore files in the test/unit directoryhierarchy.Si
test: optimize unit test .gitignore filesJust add a single .gitignore file in test/unitthat covers *_ut. That allows us to eliminate100 .gitignore files in the test/unit directoryhierarchy.Signed-off-by: Jim Harris <james.r.harris@intel.com>Change-Id: Ia190587b4d5c6f1847471be27550cbfb843dc01eReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9235Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
json: add the spdk_json_write_uint128 functionAdd the paired spdk_json_write_named_uint128 functionChange-Id: I222f0c5076efe150ab2861c0d915d18476815e37Signed-off-by: GangCao <gang.cao@intel.com>
json: add the spdk_json_write_uint128 functionAdd the paired spdk_json_write_named_uint128 functionChange-Id: I222f0c5076efe150ab2861c0d915d18476815e37Signed-off-by: GangCao <gang.cao@intel.com>Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8797Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>Community-CI: Mellanox Build Bot
ut: make use of CUnit macro to reduce duplicationsCUnit provides a helper macro CU_ADD_TEST() thatsimplifies usage of CU_add_test() function.Test name no longer needs to be provided,as it will b
ut: make use of CUnit macro to reduce duplicationsCUnit provides a helper macro CU_ADD_TEST() thatsimplifies usage of CU_add_test() function.Test name no longer needs to be provided,as it will be inherited from function name.This is a follow up tohttps://review.spdk.io/gerrit/c/spdk/spdk/+/931Change-Id: I8078f02e08b14f12328ae022d7090ba13fbd64e4Signed-off-by: Vitaliy Mysak <vitaliy.mysak@intel.com>Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1239Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Ben Walker <benjamin.walker@intel.com>Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
ut: simplify error handling at initializationThis patch changes the way that unittests initialize.The new way is shorter and simpler.It assumes that error during initialization is a fatal error,
ut: simplify error handling at initializationThis patch changes the way that unittests initialize.The new way is shorter and simpler.It assumes that error during initialization is a fatal error,but in our cases it always is.This patch is a followp up tohttps://review.spdk.io/gerrit/c/spdk/spdk/+/930lvol_ut.c is the only test that skipped becauseit runs same tests multiple times which is not allowedby new method.Change-Id: I0baf7ad09a35d5fca2dc4a03b4453c12c14f38a7Signed-off-by: Vitaliy Mysak <vitaliy.mysak@intel.com>Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1238Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Ben Walker <benjamin.walker@intel.com>Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
test: forbid use of CU_ASSERT_FATALStatic analyzers don't see CU_ASSERT_FATAL as truly fatal,and will complain that code later in the function may tryto dereference a NULL pointer. So we added S
test: forbid use of CU_ASSERT_FATALStatic analyzers don't see CU_ASSERT_FATAL as truly fatal,and will complain that code later in the function may tryto dereference a NULL pointer. So we added SPDK_CU_ASSERT_FATALwhich should be used instead.This still trips people up sometimes though - the static analyzercomplains and then the developer will add other checks thatpointers are not NULL.So instead, forbid use of CU_ASSERT_FATAL through check_format.shand explain why. While here, fix up all of the existing CU_ASSERT_FATALusages to either CU_ASSERT or SPDK_CU_ASSERT_FATAL.Signed-off-by: Jim Harris <james.r.harris@intel.com>Change-Id: I7974c8c85ddb89ed1b7d882db3a2eb0882ea0217Reviewed-on: https://review.gerrithub.io/418111Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>Reviewed-by: Seth Howell <seth.howell5141@gmail.com>Reviewed-by: Ben Walker <benjamin.walker@intel.com>
ut/json: add missing UT for int64/uint64 writeChange-Id: Ia5e963d1ec23a4d58bf8ebb46d024a6e588ca5d7Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>Reviewed-on: https://review.gerrithub.
ut/json: add missing UT for int64/uint64 writeChange-Id: Ia5e963d1ec23a4d58bf8ebb46d024a6e588ca5d7Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>Reviewed-on: https://review.gerrithub.io/400599Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>Reviewed-by: Jim Harris <james.r.harris@intel.com>
test: use spdk.unittest.mk for json unit testsThis includes removing the json.unittest.mk that theseunit tests were using previously.Signed-off-by: Jim Harris <james.r.harris@intel.com>Change-I
test: use spdk.unittest.mk for json unit testsThis includes removing the json.unittest.mk that theseunit tests were using previously.Signed-off-by: Jim Harris <james.r.harris@intel.com>Change-Id: Icfa2e5a5554b686002407d1ef5328a0aecb442f1Reviewed-on: https://review.gerrithub.io/399723Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
json: add function to write UTF-16LE stringsspdk_json_write_string_utf16le() writes a UTF-16LE string to aJSON write context.Change-Id: I413ffb8a3dee6e1b44ec96ce2415fd1b9c36320fSigned-off-by: D
json: add function to write UTF-16LE stringsspdk_json_write_string_utf16le() writes a UTF-16LE string to aJSON write context.Change-Id: I413ffb8a3dee6e1b44ec96ce2415fd1b9c36320fSigned-off-by: Daniel Verkamp <daniel.verkamp@intel.com>Reviewed-on: https://review.gerrithub.io/368625Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>Reviewed-by: Ben Walker <benjamin.walker@intel.com>Reviewed-by: Jim Harris <james.r.harris@intel.com>
test: move JSON library unit tests to test/unitThe jsoncat test tool is left where it is (test/lib/json/jsoncat) sinceit is not a unit test.Change-Id: I3d7dd9786c271dcd4e4002a05c3d0618c807e5d6S
test: move JSON library unit tests to test/unitThe jsoncat test tool is left where it is (test/lib/json/jsoncat) sinceit is not a unit test.Change-Id: I3d7dd9786c271dcd4e4002a05c3d0618c807e5d6Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>Reviewed-on: https://review.gerrithub.io/366162Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>Reviewed-by: Ben Walker <benjamin.walker@intel.com>Reviewed-by: Jim Harris <james.r.harris@intel.com>