trace: do not define fn in SPDK_TRACE_REGISTER_FN

Newer lcov try to detect issues with function definitions, and throw
warnings if function definitions have overlapping lines. Since
SPDK_TRACE_REGIS

trace: do not define fn in SPDK_TRACE_REGISTER_FN

Newer lcov try to detect issues with function definitions, and throw
warnings if function definitions have overlapping lines. Since
SPDK_TRACE_REGISTER_FN defines both the constructor function and
the trace function, it treats this as an overlap.

Note this is the only one of our REGISTER functions in SPDK that
effectively defines two functions in the same macro.

So change the macro so that the user actually defines the
trace function instead.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Ib9d0d1af7674c5ff9b65c12c1e4a5b05e6e110f5
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24836
Reviewed-by: Michal Berger <michal.berger@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot

show more ...

env: add SPDK_ENV_NUMA_ID_ANY and replace socket_id with numa_id

We will try to avoid further proliferation of "SOCKET_ID" to refer
to a NUMA socket ID moving forward, and just use "NUMA_ID" to avoi

env: add SPDK_ENV_NUMA_ID_ANY and replace socket_id with numa_id

We will try to avoid further proliferation of "SOCKET_ID" to refer
to a NUMA socket ID moving forward, and just use "NUMA_ID" to avoid
confusion with TCP sockets.

Change all of the existing in-tree SPDK_ENV_SOCKET_ID_ANY uses to
SPDK_ENV_NUMA_ID_ANY, but keep the old #define around, at least for
now. Also change all 'socket_id' parameters to 'numa_id'.

We still have spdk_env_get_socket_id(), we will need to keep this
but next patch will add spdk_env_get_numa_id().

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Idc31c29e32b708c24d88f9c6fecaf9a99e34ba1e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24607
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

sock: remove "socket" from "numa_socket_id"

We will just use "numa_id" to refer to a NUMA socket ID (also
called NUMA node ID). This will eliminate any confusion over conflicts
with "socket" used to

sock: remove "socket" from "numa_socket_id"

We will just use "numa_id" to refer to a NUMA socket ID (also
called NUMA node ID). This will eliminate any confusion over conflicts
with "socket" used to describe TCP sockets.

These APIs were all added since last release, so we can change
this freely.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Ifb8591c1066a61a78c31ad0e40745a59abb2759f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24606
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

sock: change socket_id to int32_t

These changes were added since last release, so it's safe to just
change them now without breaking API/ABI.

I mistakenly used uint32_t for the socket_id, when in f

sock: change socket_id to int32_t

These changes were added since last release, so it's safe to just
change them now without breaking API/ABI.

I mistakenly used uint32_t for the socket_id, when in fact DPDK and
our env layer really treat it as an int. This mostly shows up
with the SPDK_ENV_SOCKET_ID_ANY that is defined as -1, which forces
a lot of annoying casting if we're trying to pass this value through
a uint32_t interface.

This socket_id concept will be getting plumbed into
nvme, bdev and nvmf layers, so instead of proliferating the
uint32_t socket_id there, just change sock layer to use
int32_t instead.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I573ba7f9aeed3b216bef72f39fc671c9c6688d3a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24577
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

sock: add spdk_sock_get_numa_socket_id

Elsewhere in SPDK/DPDK, we always just say "socket_id", but since
this is the sock module for TCP sockets, we clarify the name with
"numa".

Signed-off-by: Jim

sock: add spdk_sock_get_numa_socket_id

Elsewhere in SPDK/DPDK, we always just say "socket_id", but since
this is the sock module for TCP sockets, we clarify the name with
"numa".

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I792c29e4db5094c88b6ced5f5e017cdee31c8fb8
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24124
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

sock: add spdk_sock_get_interface_name

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Ibccfac4350afba1e687edca40139316809ec1d00
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/

sock: add spdk_sock_get_interface_name

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Ibccfac4350afba1e687edca40139316809ec1d00
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24081
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

sock: add option to specify source addr/port when connecting

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ib4904a60755f87776bd2480eb56cb4a2814f57e3
Reviewed-on: https://review

sock: add option to specify source addr/port when connecting

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ib4904a60755f87776bd2480eb56cb4a2814f57e3
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24065
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot

show more ...

sock: fix wrong impl_opts_size check

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I0af6eb4bdc76b2c821de0e1cb7621981689fbace
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/s

sock: fix wrong impl_opts_size check

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I0af6eb4bdc76b2c821de0e1cb7621981689fbace
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24064
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

sock: Add interrupt APIs for socket groups

Add spdk_sock_group_register_interrupt() API for setting interrupts on
the socket groups.
Only POSIX and SSL sockets are supported.

Change-Id: I4201de7650

sock: Add interrupt APIs for socket groups

Add spdk_sock_group_register_interrupt() API for setting interrupts on
the socket groups.
Only POSIX and SSL sockets are supported.

Change-Id: I4201de7650cff8f97e0cb7d4ad4d2c31a7e9a79f
Signed-off-by: Krzysztof Goreczny <krzysztof.goreczny@dell.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22744
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Boris Glimcher <Boris.Glimcher@emc.com>
Community-CI: Mellanox Build Bot

show more ...

sock: replace sock impl priorities

Instead of using socket priorities, use a macro to set the default
implementation.
POSIX is the simplest impl compared to other sockets in SPDK and it
should be us

sock: replace sock impl priorities

Instead of using socket priorities, use a macro to set the default
implementation.
POSIX is the simplest impl compared to other sockets in SPDK and it
should be used as default (POSIX is most likely to be present at all
times and has the minimal requirements to work).

Change-Id: I8f0dc47777183154773ac6905aa9306418657e06
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22139
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

sock: add sock_get_default_impl RPC

Default socket implementation may be set without explicitly calling
`sock_set_default_impl` RPC (POSIX impl is registered as default),
but we currently have no wa

sock: add sock_get_default_impl RPC

Default socket implementation may be set without explicitly calling
`sock_set_default_impl` RPC (POSIX impl is registered as default),
but we currently have no way of letting user know what type of
implementation is the default one via RPC.
Considering above and that we already have `set` option, we should
add `sock_get_default_impl`, so users can check the socket impl.

Fixes #3280

Change-Id: I50145770a74874f3e19f1f5685c9717bcb82672e
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22140
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

trace: rename owner to owner_type

We will be adding the real concept of an "owner" in upcoming patches. So change
the existing "owner" to "owner_type" which more accurate reflects its meaning.
For e

trace: rename owner to owner_type

We will be adding the real concept of an "owner" in upcoming patches. So change
the existing "owner" to "owner_type" which more accurate reflects its meaning.
For example, an "owner_type" can be OWNER_BDEV, but an actual "owner" would
be some specific bdev identified by its name.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Ieb25eb5a574a88b3812291f2345796e5bb66a54f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22645
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

sock: add trace points for sock requests

Add tracepoints for queue/pend/complete for each sock request.

Note that we don't want to calculate the total request length when the
SOCK_REQ_QUEUE tracepo

sock: add trace points for sock requests

Add tracepoints for queue/pend/complete for each sock request.

Note that we don't want to calculate the total request length when the
SOCK_REQ_QUEUE tracepoint is not enabled, so we use the new spdk_trace_tpoint_enabled()
macro to do that calculation only when necessary.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I54d112cd0926c2e683968b17ba05b2da97061355
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22099
Reviewed-by: Seung yeon Shin <syeon.shin@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to preve

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components

Due to patch below being introduced after v24.01 code freeze,
bdev lib version should not be increased:
61623c5ca9 bdev: add spdk_bdev_io padding in place of io_submit_ch

Short reference to how the versions were changed:
MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)
for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \
sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; done
find . -name "Makefile" -exec \
sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I0166d6be6c17bbbf985d48b5dfcb36f1d4af1b48
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21582
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

build: enable Wpointer-arith in selected libraries

There's an organization, called Timerland SIG [1], that uses SPDK's NVMe
driver to implement NVMe Boot Specification under UEFI. The UEFI EDK2
bui

build: enable Wpointer-arith in selected libraries

There's an organization, called Timerland SIG [1], that uses SPDK's NVMe
driver to implement NVMe Boot Specification under UEFI. The UEFI EDK2
build environment uses both gcc and msvc. While SPDK can be built
without any issues with gcc, msvc complains about a few things, one of
which is void pointer arithmetic. So, to make Timberland's effort
easier, Wpointer-arith is enabled in the libraries they're using.

[1] https://github.com/timberland-sig

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ic90330baa4e69ee72f7e040de91893093b96f476
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18529
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

sock: add spdk_sock_get_impl_name() function

Add a function to retrieve socket impl name. This method
is going to be used during TCP TLS operations.

Change-Id: Iafaa47b77ea16dcb686364b7206e667ae579

sock: add spdk_sock_get_impl_name() function

Add a function to retrieve socket impl name. This method
is going to be used during TCP TLS operations.

Change-Id: Iafaa47b77ea16dcb686364b7206e667ae5798231
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16671
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Community-CI: Mellanox Build Bot

show more ...

sock: Add spdk_sock_get_default_impl

Sometimes code wants to set a socket option, but it doesn't know which
impl the user has selected. Add a way to get it.

Change-Id: Iecfb9b9776d8e8729dda11459eda

sock: Add spdk_sock_get_default_impl

Sometimes code wants to set a socket option, but it doesn't know which
impl the user has selected. Add a way to get it.

Change-Id: Iecfb9b9776d8e8729dda11459eda47a18366cba8
Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18006
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

sock: Remove spdk_sock_readv_async

Prefer to use spdk_sock_recv_zcopy instead.

Change-Id: Ia1920c2cbda4f787094e939ad91e52b4b4bb4ac2
Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-on

sock: Remove spdk_sock_readv_async

Prefer to use spdk_sock_recv_zcopy instead.

Change-Id: Ia1920c2cbda4f787094e939ad91e52b4b4bb4ac2
Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16609
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

sock: remove global PSK related code

We will no longer support setting global PSK and PSK
identity via sock_impl_set_options RPC - PSK related
operations are now handled by TCP transport.

Change-Id

sock: remove global PSK related code

We will no longer support setting global PSK and PSK
identity via sock_impl_set_options RPC - PSK related
operations are now handled by TCP transport.

Change-Id: I41d28dafc25696f98fd68239675bb1ce85629045
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17603
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

sock: Add a zero copy receive interface

This is not implemented by any sock module just yet.

The basic concept is that the user provides buffers to a socket group.
These get filled in with the next

sock: Add a zero copy receive interface

This is not implemented by any sock module just yet.

The basic concept is that the user provides buffers to a socket group.
These get filled in with the next portions of the stream on each socket.
The user then calls spdk_sock_recv_next() to get the pointer to the
buffer holding the next part of the stream. When the user is done, they
can put the buffer back to the group to be used again.

The provided buffers are held in a pool on the socket group.
Implementations can request a buffer from the pool or set up
a notification any time a buffer is returned.

Change-Id: I236fca43c6e3e11aafeb58caba0e4798654124be
Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16105
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

sock: Allow flushing even if the socket is in a poll group

If we call flush, we want to flush regardless of whether there is a poll
group.

Change-Id: I88680105d999a909f3f1fe75be9caff31a8555ff
Signe

sock: Allow flushing even if the socket is in a poll group

If we call flush, we want to flush regardless of whether there is a poll
group.

Change-Id: I88680105d999a909f3f1fe75be9caff31a8555ff
Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16420
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

so_ver: increase all major versions

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where

so_ver: increase all major versions

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

Disabled test for increasing SO version without ABI change, as
that is goal of this patch. This check shall be removed with SPDK 23.05
release.
Looks like this was left over from prior LTS, to avoid that
make sure it is only skipped when running against v23.01.x as latest
release.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components
- removes suppressions for ABI tests


Short reference to how the versions were changed:
MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)
for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \
sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; done
find . -name "Makefile" -exec \
sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +

Change-Id: I3e5681802c0a5ac6d7d652a18896997cd07cc8bf
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16419
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...