scripts: switch from go fmt to gofmt

Neither "go fmt" nor "gofmt" return a status code when the format check
fails. We can only rely on their stdout. "go fmt" invokes "gofmt -w -l"
on every file in

scripts: switch from go fmt to gofmt

Neither "go fmt" nor "gofmt" return a status code when the format check
fails. We can only rely on their stdout. "go fmt" invokes "gofmt -w -l"
on every file in the target package and pulls in dependencies. These
dependencies are not verified, but they pollute stdout and increase
format check time.

Therefore, we switch to "gofmt", which only checks files within the
target package.

It turns out that not all files from the target package were checked.
Compare "go fmt -n ." to "go fmt -n ./...". Switching to "gofmt ."
addresses this issue, and we've added fixes to client.go accordingly.

Finally, instead of fixing the formatting, we print out the diff by
switching from "-w" to "-d".

Change-Id: Ifb1c339bdd1703c7d9e1b0cfa0b0ad0df7cff683
Signed-off-by: Emilia Haligowska <emilia.haligowska@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22832
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot

show more ...

go/rpc: 1.21 is too new and too restrictive

project that uses it will be forced to update

go: upgraded go 1.19 => 1.21
go: added toolchain go1.21.3

which is not always disireble

Change-Id: I0878b

go/rpc: 1.21 is too new and too restrictive

project that uses it will be forced to update

go: upgraded go 1.19 => 1.21
go: added toolchain go1.21.3

which is not always disireble

Change-Id: I0878b353a7ee12371a6399894eb9b56cd3a597d9
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20398
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Maciej Miś <maciej.mis@intel.com>
Reviewed-by: Artek Koltun <artsiom.koltun@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

go/rpc: add mockery for Client

this help for users of this package
to mock this interface for unit testing

See more documentation here:
https://github.com/vektra/mockery

Example:

```
import (

go/rpc: add mockery for Client

this help for users of this package
to mock this interface for unit testing

See more documentation here:
https://github.com/vektra/mockery

Example:

```
import (
"log"
"errors"
"testing"
"github.com/stretchr/testify/mock"
"github.com/spdk/spdk/go/rpc/client"
"github.com/spdk/spdk/go/rpc/client/mocks"
)

func SpdkGetVersion(c *client.IClient) error {
// a lot of logic before the call
resp1, err1 := c.Call("spdk_get_version", nil)
// a lot of logic after the call
log.Print(resp1)
resp2, err2 := c.Call("bdev_get_bdevs", nil)
// a lot of logic after the call
log.Print(resp2)
return err
}

func Test_Example(t *testing.T) {
mockSpdk := mocks.NewIClient(t)
mockSpdk.EXPECT().Call("spdk_get_version", mock.Anything).Return(errors.New("my error")).Once()
mockSpdk.EXPECT().Call("bdev_get_bdevs", mock.Anything).Return(errors.New("my error")).Once()

err := SpdkGetVersion(mockSpdk)
if err != nil {
t.Error("unexpected error received")
}
}
```

Change-Id: I2747472def0cd73075f52ec678ca45e981bdf0b8
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20143
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Artek Koltun <artsiom.koltun@intel.com>
Reviewed-by: Maciej Miś <maciej.mis@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

go: add badges to readme

Change-Id: Icfedf6e49133d64215dbbdd878f65dbdf2256b88
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21395
Co

go: add badges to readme

Change-Id: Icfedf6e49133d64215dbbdd878f65dbdf2256b88
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21395
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <ben@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

go/rpc: add first unit test for golang

more to come

Change-Id: I1bb090fd5597c692f31d620dbda210febf0bee5e
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/g

go/rpc: add first unit test for golang

more to come

Change-Id: I1bb090fd5597c692f31d620dbda210febf0bee5e
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20160
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Maciej Miś <maciej.mis@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

go/rpc: add interface for Client

this is mostly going to be used with mockery

Change-Id: I2d7205c10ab9d628f5874114c860a69ede478c7c
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on

go/rpc: add interface for Client

this is mostly going to be used with mockery

Change-Id: I2d7205c10ab9d628f5874114c860a69ede478c7c
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20251
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Maciej Miś <maciej.mis@intel.com>
Community-CI: Mellanox Build Bot

show more ...

go/rpc: add bsd-3 license file

without this file pkg.go.dev
is not displaying any content
due to license restrictions.

This file is auto-genrated from github template
filename=LICENSE&template=bsd-

go/rpc: add bsd-3 license file

without this file pkg.go.dev
is not displaying any content
due to license restrictions.

This file is auto-genrated from github template
filename=LICENSE&template=bsd-3-clause

pkg.go.dev didn;t accept symlink to licenses/bsd-3-clause.txt
That's why have to add new file here in this folder.

Change-Id: I4fa18abbf3ef3f878a2f6c9b0b97c3d0168cfa09
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20395
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot

show more ...

go/rpc: check return code for RPC call

Change-Id: I8493649b0d333f35fd6ae918527ad7f3599b5584
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/s

go/rpc: check return code for RPC call

Change-Id: I8493649b0d333f35fd6ae918527ad7f3599b5584
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20237
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Yibo Cai <yibo.cai@arm.com>

show more ...

go/rpc: add TCP to documentation

Change-Id: I9cf5daeaa40d1d4263ab1066dd9afccfa426f1f0
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/

go/rpc: add TCP to documentation

Change-Id: I9cf5daeaa40d1d4263ab1066dd9afccfa426f1f0
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20140
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

go/rpc: check mismatch IDs

Change-Id: Iedc23ff8f1bd1f90ff4bbd799c280a89883b9010
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20036

go/rpc: check mismatch IDs

Change-Id: Iedc23ff8f1bd1f90ff4bbd799c280a89883b9010
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20036
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Maciej Miś <maciej.mis@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

go/rpc: add support for TCP connection

Change-Id: I3431ef2b9cfeabddd358322b15f17248ca003b04
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/s

go/rpc: add support for TCP connection

Change-Id: I3431ef2b9cfeabddd358322b15f17248ca003b04
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20037
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

go/rpc: README for Go client

Change-Id: Ibec77819c3f6113ff03cdfff98b28364a98ffabc
Signed-off-by: Maciej Mis <maciej.mis@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19814
Revi

go/rpc: README for Go client

Change-Id: Ibec77819c3f6113ff03cdfff98b28364a98ffabc
Signed-off-by: Maciej Mis <maciej.mis@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19814
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Pawel Piatek <pawelx.piatek@intel.com>

show more ...

go/rpc: Build configuration for go-rpc folder

Introduces new flags in configuration:
--with-golang
--without-golang

Change-Id: I5783b4ddfa53fc34ef7e921a6ee2aae0f4aadd44
Signed-off-by: Maciej Mis <m

go/rpc: Build configuration for go-rpc folder

Introduces new flags in configuration:
--with-golang
--without-golang

Change-Id: I5783b4ddfa53fc34ef7e921a6ee2aae0f4aadd44
Signed-off-by: Maciej Mis <maciej.mis@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19774
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

go/rpc: Implementation of JSON-RPC go client as a shared library

Change-Id: I728fb1b7685b3034579923b960f4ede262099388
Signed-off-by: Maciej Mis <maciej.mis@intel.com>
Reviewed-on: https://review.spd

go/rpc: Implementation of JSON-RPC go client as a shared library

Change-Id: I728fb1b7685b3034579923b960f4ede262099388
Signed-off-by: Maciej Mis <maciej.mis@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19394
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

go/rpc: Implementation of JSON-RPC 2.0 client

Change-Id: I6b57907e7569fc9bb58e8f4c2c1144ee83c3fbc3
Signed-off-by: Maciej Mis <maciej.mis@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/

go/rpc: Implementation of JSON-RPC 2.0 client

Change-Id: I6b57907e7569fc9bb58e8f4c2c1144ee83c3fbc3
Signed-off-by: Maciej Mis <maciej.mis@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19013
Community-CI: Mellanox Build Bot
Reviewed-by: Yibo Cai <yibo.cai@arm.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

go/rpc: Removal of spdk.go file

This is the original commit message with this file creation:
"The only purpose at the moment is to allow vendoring of the SPDK
source code into Go projects which mana

go/rpc: Removal of spdk.go file

This is the original commit message with this file creation:
"The only purpose at the moment is to allow vendoring of the SPDK
source code into Go projects which manage dependencies with the "dep"
tool. That tool is designed for Go projects and as a sanity check
rejects any dependency which does not have at least one Go file, at
least at the moment"

Since we introduced new Go files there is no need to keep this file anymore.

Change-Id: Ia6f56a8e56a14f6ef00a2302002fb21f0832a95e
Signed-off-by: Maciej Mis <maciej.mis@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19012
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot

show more ...

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date defa

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the 4 digit year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc). Contribution date used
"--follow -C95%" to get the most accurate date.

Note that several files in this patch didn't end the license/(c)
block with a blank comment line so these were added as the vast
majority of files do have this last blank line. Simply there for
consistency.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot

show more ...