replace strtok with strtok_r

The strtok function is not reentrant. To address this issue in a
multithreaded environment, the strtok_r function should be used,
which is the reentrant version of strto

replace strtok with strtok_r

The strtok function is not reentrant. To address this issue in a
multithreaded environment, the strtok_r function should be used,
which is the reentrant version of strtok.

Signed-off-by: XuQi <1530865185@qq.com>
Change-Id: I35c07c7cf4e20bacb7b1e7c7adaedfcd1a81f86e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25492
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot

show more ...

thread: add enable_numa parameter to iobuf_set_options RPC

This parameter does not yet actually enable per-NUMA node iobuf
buffer pools. It only checks that the application was built with
support fo

thread: add enable_numa parameter to iobuf_set_options RPC

This parameter does not yet actually enable per-NUMA node iobuf
buffer pools. It only checks that the application was built with
support for the number of NUMA nodes reported by the system.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I1b9d11ccb8f6914280874a40754c51625d21645d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24539
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot

show more ...

nvmf: dump allowed digests/dhgroups configuration

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I7cb6fe79b54578aaf535ef08d90ae8fe6320c6c3
Reviewed-on: https://review.spdk.io/ge

nvmf: dump allowed digests/dhgroups configuration

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I7cb6fe79b54578aaf535ef08d90ae8fe6320c6c3
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24228
Community-CI: Mellanox Build Bot
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

event/fsdev: Add fsdev subsystem

Change-Id: Ib8badf7fdc7be88751f7acc41574f37e30922e36
Signed-off-by: Evgeniy Kochetov <evgeniik@nvidia.com>
Signed-off-by: Anton Nayshtut <anayshtut@nvidia.com>
Revie

event/fsdev: Add fsdev subsystem

Change-Id: Ib8badf7fdc7be88751f7acc41574f37e30922e36
Signed-off-by: Evgeniy Kochetov <evgeniik@nvidia.com>
Signed-off-by: Anton Nayshtut <anayshtut@nvidia.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22532
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

general: fix misspells and typos

Signed-off-by: Kamil Godzwon <kamilx.godzwon@intel.com>
Change-Id: Iab206ef526eb7032c6681a3145450010c91705a4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+

general: fix misspells and typos

Signed-off-by: Kamil Godzwon <kamilx.godzwon@intel.com>
Change-Id: Iab206ef526eb7032c6681a3145450010c91705a4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24120
Community-CI: Mellanox Build Bot
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

module/event: Add missing keyring dep to event_bdev

Looks like for the event_bdev the subdirs_rule was never called for
the module/event/subsystems/keyring since its DEPDIRS was missing it.

This wa

module/event: Add missing keyring dep to event_bdev

Looks like for the event_bdev the subdirs_rule was never called for
the module/event/subsystems/keyring since its DEPDIRS was missing it.

This was noticed while building SPDK with a single make job where
all the deps are compiled one by one. See:

https://github.com/spdk/spdk/issues/3434

Fixes: #3434

Change-Id: Iedf23efe2cb45e7fe6d5e84341b48ad4f922f6b0
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24252
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvmf/auth: set allowed digests/dhgroups

It's now possible to limit the allowed digests/dhgroups used during the
DH-HMAC-CHAP authentication on the target side.

Signed-off-by: Konrad Sztyber <konrad

nvmf/auth: set allowed digests/dhgroups

It's now possible to limit the allowed digests/dhgroups used during the
DH-HMAC-CHAP authentication on the target side.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I636afba765075df2a6c71e7287cbe47550446120
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22909
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

nvmf: unify target options handling

These options are already part of spdk_nvmf_target_opts, so it doesn't
make sense to have separate global variables to store them.

Signed-off-by: Konrad Sztyber

nvmf: unify target options handling

These options are already part of spdk_nvmf_target_opts, so it doesn't
make sense to have separate global variables to store them.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ia7566d254d5201daac7a39b3da81a210fff31f4c
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22908
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvmf: track spdk_nvmf_target_opts's size

We'll be adding more fields to this structure in the future, so let's
track its size for ensuring ABI compatibility.

Signed-off-by: Konrad Sztyber <konrad.s

nvmf: track spdk_nvmf_target_opts's size

We'll be adding more fields to this structure in the future, so let's
track its size for ensuring ABI compatibility.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Id3cb8185968a3cd2950d5e0a4ca7b5f4247a7f0d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22907
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

nvmf: change type of discover_filter to uint32_t

We treat it as a bitmask of multiple discovery filter rules rather than
a value describing a single filter.

Signed-off-by: Konrad Sztyber <konrad.sz

nvmf: change type of discover_filter to uint32_t

We treat it as a bitmask of multiple discovery filter rules rather than
a value describing a single filter.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ibea52a87b89548702b100433499324e4346e0522
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22906
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

sock: add default impl override

Read environmental variable 'SPDK_SOCK_IMPL_DEFAULT' and override the
default socket implementation (POSIX) with its value during
sock_subsystem_init().

This is done

sock: add default impl override

Read environmental variable 'SPDK_SOCK_IMPL_DEFAULT' and override the
default socket implementation (POSIX) with its value during
sock_subsystem_init().

This is done mainly to enable original behavior where a socket with
highest priority would be used by default (e.g. uring if configure
was run with '--with-uring' option). That way we may explicitly enable
chosen implementation as default, without relying on RPC interface.

As part of this patch, link sock modules into the app_repeat test app.
The method used here works even when for the app repeat case, so let's test it.
This allows us to just generally declare this flag for all tests and not have
to worry about apps like app_repeat that link in the sock library but none of
the sock modules.

Change-Id: I6af633cbe5bfba065580ba6c501169cbb5b64541
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22691
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

nvmf: always use 3 digits for nvmf_tgt_poll_group thread name

This helps with consistency on the names, including sorting.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I8ea48b2620f

nvmf: always use 3 digits for nvmf_tgt_poll_group thread name

This helps with consistency on the names, including sorting.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I8ea48b2620f67fabfa9bb482d6b1947440145517
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23017
Reviewed-by: Ankit Kumar <ankit.kumar@samsung.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

harmonize spdk_*_get/set_opts()

spdk_bdev_get/set_opts() is careful to check its size argument, so that
it can add options in a backwards-compatible manner. However,
spdk_iobuf_get/set_opts() and sp

harmonize spdk_*_get/set_opts()

spdk_bdev_get/set_opts() is careful to check its size argument, so that
it can add options in a backwards-compatible manner. However,
spdk_iobuf_get/set_opts() and spdk_accel_get/set_opts() both have
slightly different interfaces to the bdev variant, and are less careful.

Make all three variants operate in the same manner instead.

For spdk_iobuf_set_opts(), make all validation consistently return an
error instead of trying to adjust automatically.

Signed-off-by: John Levon <john.levon@nutanix.com>
Change-Id: I4077a5f1df7039992a556544acdcb1ef379887ae
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22093
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvmf/tcp: use keyring for retrieving PSKs

It is now possible to retrieve TLS PSKs from the keyring. The previous
method of specifying a path to a file containing the key is still
functional, but it

nvmf/tcp: use keyring for retrieving PSKs

It is now possible to retrieve TLS PSKs from the keyring. The previous
method of specifying a path to a file containing the key is still
functional, but it's deprecated and will be removed in the future.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Iea1ff6918056f910f0fc3e030886cdba1e24b7e9
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21757
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvmf: stop listen before destroying poll groups

Handling new connections can race with destroying the poll groups so
stop listening before that.

Fixes #3273

Signed-off-by: Artur Paszkiewicz <artur

nvmf: stop listen before destroying poll groups

Handling new connections can race with destroying the poll groups so
stop listening before that.

Fixes #3273

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-Id: I055b5a5335ec61b6f6d9f8aee785f746fdbc5d9b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22168
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

bdev/nvme: use keyring for PSKs

It is now possible to specify NVMe/TLS PSKs via keys attached to the
keyring. For now, the old method is also available, but it's deprecated
and will be removed in t

bdev/nvme: use keyring for PSKs

It is now possible to specify NVMe/TLS PSKs via keys attached to the
keyring. For now, the old method is also available, but it's deprecated
and will be removed in the future. No new RPC parameters have been
added, instead the PSK is first interpreted as a key name and, if that
fails, as path to the key file.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I663e67ff11a3943c3c11d2f4ba4e31473fcc2e67
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21749
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

keyring: support for writing config

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I326512277231f57957a6d6992d62edf692650905
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/sp

keyring: support for writing config

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I326512277231f57957a6d6992d62edf692650905
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21740
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

event: add keyring subsystem

It's a place to initialize the keyring library and dump its
configuration.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I75af040c286d1ca838c8ef03

event: add keyring subsystem

It's a place to initialize the keyring library and dump its
configuration.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I75af040c286d1ca838c8ef0381876a8a81ae67fe
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21736
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to preve

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components

Due to patch below being introduced after v24.01 code freeze,
bdev lib version should not be increased:
61623c5ca9 bdev: add spdk_bdev_io padding in place of io_submit_ch

Short reference to how the versions were changed:
MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)
for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \
sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; done
find . -name "Makefile" -exec \
sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I0166d6be6c17bbbf985d48b5dfcb36f1d4af1b48
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21582
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

include: Remove duplicate includes in source files

Change-Id: I7dd6ae6fa11603a956c3d178b9b23d2c755913d1
Signed-off-by: Pierre Lestringant <plestringant@kalray.eu>
Reviewed-on: https://review.spdk.io

include: Remove duplicate includes in source files

Change-Id: I7dd6ae6fa11603a956c3d178b9b23d2c755913d1
Signed-off-by: Pierre Lestringant <plestringant@kalray.eu>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20106
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

thread: add iobuf stats

These could help to find quickly misconfig and misbehavior of overall
system under workload.

Change-Id: I0d90afbeeb6f73ef83a849619350eca9995105e3
Signed-off-by: Jacek Kalwas

thread: add iobuf stats

These could help to find quickly misconfig and misbehavior of overall
system under workload.

Change-Id: I0d90afbeeb6f73ef83a849619350eca9995105e3
Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18465
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

lib/nvmf: TP 8014 - Current Discovery Subsystem

Added support for the Current Discovery Subsystem
value of the Subsystem Type in the Discovery
Log Page Entry.

Change introduced in TP 8014

Change-I

lib/nvmf: TP 8014 - Current Discovery Subsystem

Added support for the Current Discovery Subsystem
value of the Subsystem Type in the Discovery
Log Page Entry.

Change introduced in TP 8014

Change-Id: I9a35ba24ecfdc2bbcc81baae80575e37ae1a866d
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19839
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

iobuf: always dump config

Previously, the config was only dumped, if the iobuf_set_options RPC has
been received. It used to work that way, because when iobuf was
initially introduced, these option

iobuf: always dump config

Previously, the config was only dumped, if the iobuf_set_options RPC has
been received. It used to work that way, because when iobuf was
initially introduced, these options could also be configured via
spdk_bdev_set_opts, for backwards compatibility. However, this behavior
was removed in v23.05, so the config can be dumped indiscriminately now.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Id2fb4a47ff6da2eb770b1339e9afe6fc18c4f64d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19681
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@gmail.com>
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>

show more ...