nvmf: Expose DIF type of namespace to host again

We disabled exposing DIF type of namespaces to host because nvmf library
did not support PRACT.
https://github.com/spdk/spdk/commit/a438718fc25a5298f

nvmf: Expose DIF type of namespace to host again

We disabled exposing DIF type of namespaces to host because nvmf library
did not support PRACT.
https://github.com/spdk/spdk/commit/a438718fc25a5298f0bfc9daf2be0abc885b54be

nvmf library support PRACT now.

Let's expose DIF type of namespaces to host again.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I9c30c3c50791ade18fb46c2be807984c934d3788
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25438
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>

show more ...

nvmf: Set bdev_ext_io_opts::dif_check_flags_exclude_mask for read/write

Fill opts->dif_check_flags_exclude_mask when nvmf submits read or write
I/O to bdev layer. Furthremore, get CDW12 value for re

nvmf: Set bdev_ext_io_opts::dif_check_flags_exclude_mask for read/write

Fill opts->dif_check_flags_exclude_mask when nvmf submits read or write
I/O to bdev layer. Furthremore, get CDW12 value for read I/O because it
has PRACT bit.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Icfa5b9c9b3ca8a0d6d9b08ba447e06ebe0986443
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23629
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvmf: Get metadata config by not bdev but bdev_desc

This is a preparation to enable no_metadata option to each bdev for DIF
insert/strip.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Cha

nvmf: Get metadata config by not bdev but bdev_desc

This is a preparation to enable no_metadata option to each bdev for DIF
insert/strip.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I018ccbdba662fa71489ae9664fc9d41bf79cf7d7
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25412
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

test: Comparison operator fixes

Change-Id: I1296b19b590c2c6cbb75b9362e441cd6219d7a9f
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2

test: Comparison operator fixes

Change-Id: I1296b19b590c2c6cbb75b9362e441cd6219d7a9f
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25198
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>

show more ...

nvmf: Identify command supports IOCS NVM NS data structure

Add minimum change to support and verify it by writing unit tests.
We will revisit this feature when we find any OS uses Storage Tag.

Sign

nvmf: Identify command supports IOCS NVM NS data structure

Add minimum change to support and verify it by writing unit tests.
We will revisit this feature when we find any OS uses Storage Tag.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I0a9456d099f8fcf735ed773bec18e82dfbe1112e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24112
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

nvmf: pass command dword 12 and 13 for write

For write requests extract and add command dword 12 and 13 to
spdk_bdev_ext_io_opts.
Add a unit test to verify the same.

Change-Id: I2f63387dccd144dc4a7

nvmf: pass command dword 12 and 13 for write

For write requests extract and add command dword 12 and 13 to
spdk_bdev_ext_io_opts.
Add a unit test to verify the same.

Change-Id: I2f63387dccd144dc4a725986887e652ad7d103d7
Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22791
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvmf: allow setting custom handlers for namespace reservation operations

Currently, namespace reservation persistence is enabled by storing the
reservation information in a file. Make it possible to

nvmf: allow setting custom handlers for namespace reservation operations

Currently, namespace reservation persistence is enabled by storing the
reservation information in a file. Make it possible to override the
default behavior by providing custom handlers for reservation
operations.

Change-Id: I247ea2d6cd41ae808030886d70172fad7a04291b
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21360
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot

show more ...

util: add SPDK_IOV_ONE macro

Having that spdk_iov_one fn is marked deprecated. The issue with that
function is that it enforce iovcnt type which might not be of type int
but u32 or u8 etc. Having th

util: add SPDK_IOV_ONE macro

Having that spdk_iov_one fn is marked deprecated. The issue with that
function is that it enforce iovcnt type which might not be of type int
but u32 or u8 etc. Having that compiler would complain when using the
function with other types than int.

It is a pre-work for layout optmz of nvmf request (iovcnt change there
from int to u8).

Change-Id: Id1534f4d3f60d35c58c26e4f4cf0d605ae11398a
Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21433
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

nvmf: set max discard size and max write_zeroes size

For Linux kernel version >= 5.13, when host connects the admin
queue successfully, it will call nvme_init_non_mdts_limits() to
post a NVME_ID_CNS

nvmf: set max discard size and max write_zeroes size

For Linux kernel version >= 5.13, when host connects the admin
queue successfully, it will call nvme_init_non_mdts_limits() to
post a NVME_ID_CNS_CS_CTRL identify cmd and init max discard size
with dmrl, dmrsl and max write_zeroes size with wzsl in response.

So we add the NVME_ID_CNS_CS_CTRL identify cmd handler in the nvmf
target side and add two new parameters to RPC nvmf_create_subsystem.

Change-Id: Ib72d6caa34fced68d63df9c01760a58effa5ca34
Signed-off-by: Haoqian He <haoqian.he@smartx.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19632
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvme: add iovec passthru

This is used for sending big passthru commands, like Report Zones, over nvmf.

Change-Id: I83188367e0266e093faadd49cdb2e051eae71829
Signed-off-by: Karl Bonde Torp <k.torp@sa

nvme: add iovec passthru

This is used for sending big passthru commands, like Report Zones, over nvmf.

Change-Id: I83188367e0266e093faadd49cdb2e051eae71829
Signed-off-by: Karl Bonde Torp <k.torp@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20498
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

nvmf: add memory domain and its ctx to spdk_nvmf_request

This allows to support memory domains on nvmf layer for read/write.
Support for plain compare or compare & write (fused) is still missing
tho

nvmf: add memory domain and its ctx to spdk_nvmf_request

This allows to support memory domains on nvmf layer for read/write.
Support for plain compare or compare & write (fused) is still missing
though.

Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com>
Change-Id: I9a365fcf6b7e722025d36c9f798ec2b766fa61a1
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17527
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvmf: remove req->data field

Now all code has been adapted to use req->iov, and the deprecation
period has elapsed, remove the legacy ->data field altogether, along
with spdk_nvmf_request_get_data()

nvmf: remove req->data field

Now all code has been adapted to use req->iov, and the deprecation
period has elapsed, remove the legacy ->data field altogether, along
with spdk_nvmf_request_get_data().

Signed-off-by: John Levon <john.levon@nutanix.com>
Change-Id: I22db8a7d8e086d9bcba3e784bf9dd19da147470f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16201
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@gmail.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

test/unit: use spdk_ut_run_tests()

Replaced direct calls to the CUnit's functions to run the tests with
spdk_ut_run_tests(). That way, each test will have the ability to run
a specific test case.

test/unit: use spdk_ut_run_tests()

Replaced direct calls to the CUnit's functions to run the tests with
spdk_ut_run_tests(). That way, each test will have the ability to run
a specific test case.

The blob.c unit test wasn't changed, because it runs all tests multiple
times with different parameter combinations, so it cannot be easily
converted. In the future, each such combination could be split into a
separate test suite, which would make it compatible with
spdk_ut_run_tests().

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I4463f808f89844e9bf32b5b31eda197c5d729d1d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19288
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

test/unit: move spdk_cunit.h to include/spdk_internal

It'll make it easier to include this file outside of unit tests.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I171ddb864

test/unit: move spdk_cunit.h to include/spdk_internal

It'll make it easier to include this file outside of unit tests.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I171ddb8649f67b5786f08647560e2907603d0574
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19284
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

lib/util/dif: Added support for CRC-64 guard

Extend the DIF/DIX library with the CRC-64
format of the Protection Information

Change-Id: I762db9aa2e9cfa58cb5b81843c2eff32f60ca264
Signed-off-by: Slaw

lib/util/dif: Added support for CRC-64 guard

Extend the DIF/DIX library with the CRC-64
format of the Protection Information

Change-Id: I762db9aa2e9cfa58cb5b81843c2eff32f60ca264
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18584
Community-CI: Mellanox Build Bot
Reviewed-by: Xiaodong Liu <xiaodong.liu@intel.com>
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

show more ...

lib/util/dif: Wrappers for DIF fields access

Introduced wrappers for the DIF structure
fields access, in order to prepare for
extending the DIF structure with
additional formats.

Change-Id: I5592f5

lib/util/dif: Wrappers for DIF fields access

Introduced wrappers for the DIF structure
fields access, in order to prepare for
extending the DIF structure with
additional formats.

Change-Id: I5592f59d05a4bfecbfb88a5fad2815a38d965ea0
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18174
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>

show more ...

lib/util/dif: Add an ext_opts param to spdk_dif_ctx_init

The extended options structure for the dif context
initialization allows for adding new arguments
without the function signature change. The

lib/util/dif: Add an ext_opts param to spdk_dif_ctx_init

The extended options structure for the dif context
initialization allows for adding new arguments
without the function signature change. The first
extended parameter is the DIF Protection Information
format (CRC-16).

Change-Id: I6a32e8570676265d757fc7251441e5547bbb475d
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18146
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

bdev: Add default copy command support in bdev

Add default copy command support in bdev layer for backing devices that
does not support copy command.

Signed-off-by: Rui Chang <rui.chang@arm.com>
Ch

bdev: Add default copy command support in bdev

Add default copy command support in bdev layer for backing devices that
does not support copy command.

Signed-off-by: Rui Chang <rui.chang@arm.com>
Change-Id: I5632e25544e95ac0c53ff91c4cd135dac53323ae
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16638
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>

show more ...