env: add spdk_pci_device_get_numa_id()

This effectively replaces spdk_pci_device_get_socket_id(), which is
marked obsolete in this patch.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-I

env: add spdk_pci_device_get_numa_id()

This effectively replaces spdk_pci_device_get_socket_id(), which is
marked obsolete in this patch.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I1b32adf4f357221e6ae4b98c234ac70a2192b9bc
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24609
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to preve

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components

Due to patch below being introduced after v24.01 code freeze,
bdev lib version should not be increased:
61623c5ca9 bdev: add spdk_bdev_io padding in place of io_submit_ch

Short reference to how the versions were changed:
MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)
for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \
sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; done
find . -name "Makefile" -exec \
sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I0166d6be6c17bbbf985d48b5dfcb36f1d4af1b48
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21582
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

vmd: fix comments around resetting root ports

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I169cef4b795dc5c3910140e9b4111958352731db
Reviewed-on: https://review.spdk.io/gerrit

vmd: fix comments around resetting root ports

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I169cef4b795dc5c3910140e9b4111958352731db
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20188
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

vmd: read domain's config space to get BAR's physical address

Since commit a36bc251d ("env_dpdk: Automatically map PCI BARs into
VFIO") the physical address of the BAR returned by
spdk_pci_device_ma

vmd: read domain's config space to get BAR's physical address

Since commit a36bc251d ("env_dpdk: Automatically map PCI BARs into
VFIO") the physical address of the BAR returned by
spdk_pci_device_map_bar() can be either an actual physical address or a
virtual one (if IOMMU is enabled). Since the VMD driver always needs an
actual physical address to fill out the base/limit registers and the
BARs of the devices behind the VMD, we read config space to get the
correct address, regardless of IOVA configuration.

Fixes #3117.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I16bc221a9621bb1a08950697ba4537ae2274277f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20187
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

vmd: use a variable to reference current domain in vmd_enum_cb()

This function spelled out vmd_c->vmd[i] 12 times.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ida991a05739fb

vmd: use a variable to reference current domain in vmd_enum_cb()

This function spelled out vmd_c->vmd[i] 12 times.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ida991a05739fbd9a3228c03362d495181e44bfdd
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20255
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

vmd: rename vmd_map_bars -> vmd_domain_map_bars

There already is a function called vmd_dev_map_bar(), but it's used in a
different context (it maps BARs of the devices behind the VMD), so
vmd_map_ba

vmd: rename vmd_map_bars -> vmd_domain_map_bars

There already is a function called vmd_dev_map_bar(), but it's used in a
different context (it maps BARs of the devices behind the VMD), so
vmd_map_bars() was renamed to better reflect its purpose.

Additionally, this patch removes the spdk_pci_device argument from this
function, as it's available from struct vmd_adapter.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I8de03c159653a04286e71e9adf226eee40ef06ae
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20186
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

vmd: don't map bar with MSI-X table

It wasn't used for anything.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I8f78256a68e399bba442b7a7e00f2bf4f09dcda7
Reviewed-on: https://r

vmd: don't map bar with MSI-X table

It wasn't used for anything.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I8f78256a68e399bba442b7a7e00f2bf4f09dcda7
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20185
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

vmd: clean up the code mapping BARs

It's cleaner to return from the function as soon as an error is
encountered.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I0f2a08ad7b9bf59

vmd: clean up the code mapping BARs

It's cleaner to return from the function as soon as an error is
encountered.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I0f2a08ad7b9bf5949261d7b58419058a05141497
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20184
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

so_ver: increase all major versions

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where

so_ver: increase all major versions

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

Disabled test for increasing SO version without ABI change, as
that is goal of this patch. This check shall be removed with SPDK 23.05
release.
Looks like this was left over from prior LTS, to avoid that
make sure it is only skipped when running against v23.01.x as latest
release.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components
- removes suppressions for ABI tests


Short reference to how the versions were changed:
MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)
for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \
sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; done
find . -name "Makefile" -exec \
sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +

Change-Id: I3e5681802c0a5ac6d7d652a18896997cd07cc8bf
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16419
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

lib/vmd: fix build with clang 15

Used (void) on cmd and removed increment to fix
clang 15 werror.
vmd.c:368:11: error: variable 'cmd' set but not used [-Werror,-Wunused-but-set-variable]
u

lib/vmd: fix build with clang 15

Used (void) on cmd and removed increment to fix
clang 15 werror.
vmd.c:368:11: error: variable 'cmd' set but not used [-Werror,-Wunused-but-set-variable]
uint16_t cmd = dev->header->zero.command;
^
1 error generated.

Signed-off-by: Kamil Godzwon <kamilx.godzwon@intel.com>
Change-Id: I4e383ac41b46d13df0210bf90f11f6130290f243
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16127
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date defa

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the 4 digit year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc). Contribution date used
"--follow -C95%" to get the most accurate date.

Note that several files in this patch didn't end the license/(c)
block with a blank comment line so these were added as the vast
majority of files do have this last blank line. Simply there for
consistency.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot

show more ...