event: use extended version of fd group add

Since both the reactor file descriptors are of type eventfd we can set
fd type in the event handler opts and use SPDK_FD_GROUP_ADD_EXT.
This way we don't

event: use extended version of fd group add

Since both the reactor file descriptors are of type eventfd we can set
fd type in the event handler opts and use SPDK_FD_GROUP_ADD_EXT.
This way we don't need to explicitly read those fds, which will be done
during the fd group wait.

Change-Id: Ic966919a9b2ce83395f98e7c6c6a883b1ffd9a0d
Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25431
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

replace strtok with strtok_r

The strtok function is not reentrant. To address this issue in a
multithreaded environment, the strtok_r function should be used,
which is the reentrant version of strto

replace strtok with strtok_r

The strtok function is not reentrant. To address this issue in a
multithreaded environment, the strtok_r function should be used,
which is the reentrant version of strtok.

Signed-off-by: XuQi <1530865185@qq.com>
Change-Id: I35c07c7cf4e20bacb7b1e7c7adaedfcd1a81f86e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25492
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot

show more ...

scheduler: save scheduler period in microseconds (in addition to tsc)

We need to use TSC internally to determine when to do the scheduling,
but the user interface is in microseconds. To avoid roundi

scheduler: save scheduler period in microseconds (in addition to tsc)

We need to use TSC internally to determine when to do the scheduling,
but the user interface is in microseconds. To avoid rounding errors
when converting from microseconds => TSC => microseconds, save the
user specified value in microseconds instead.

Fixes issue #3546.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I01143b047c5db58163b013fb58ca0364634e6365
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25223
Reviewed-by: GangCao <gang.cao@intel.com>
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Michal Berger <michal.berger@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

event: add new 'mappings' parameter to static scheduler

This is useful for testing purposes, to place specific spdk_threads
on specific cores. Specified core must be in the thread's cpumask.

Usage:

event: add new 'mappings' parameter to static scheduler

This is useful for testing purposes, to place specific spdk_threads
on specific cores. Specified core must be in the thread's cpumask.

Usage:

scripts/rpc.py framework_set_scheduler --mappings='2:0,5:1'

This will move thread 2 to core 0 and thread 5 to core 1.

Note: checking for failure when setting core-limit parameter on
static scheduler has been removed. The whole mechanism for determine
which optional parameters are accepted for different schedulers needs
to be rethought, the current mechanism is not really working.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I16000805b8e2512f7ec6d84ee812d32bfcb2fd6d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24766
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Anisa Su <anisa.su@samsung.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

show more ...

event: enable changing back to static scheduler

This requires saving the original core for each thread. Thankfully
it is very easy to just store it in the spdk_lw_thread. Then we
just run ->balance(

event: enable changing back to static scheduler

This requires saving the original core for each thread. Thankfully
it is very easy to just store it in the spdk_lw_thread. Then we
just run ->balance() once after the static scheduler is re-installed
to put all of the threads back to their original lcores, and take
all cores out of interrupt mode.

Note: 82c466 required bumping SO_VER due to adding trace_id to
struct spdk_reactor. But that didn't change the size of the structure.
For some unexplained reason, adding initial_lcore to the private
struct lw_thread in this patch results in abidiff no longer reporting
the trace_id change, and check_so_deps.sh fails saying the SO_VER
bump is no longer needed. A patch that simply adds the initial_lcore
member, with no other code changes, triggers the same error.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I9d1ace726617d95f89f42959c9c2c36602fb7f77
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24765
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

event: move struct spdk_lw_thread to internal header

This does not need to be exposed through public API.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I7f2f1bf5d47e9b0ded011a4f3f83

event: move struct spdk_lw_thread to internal header

This does not need to be exposed through public API.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I7f2f1bf5d47e9b0ded011a4f3f832320b106b3ec
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25032
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

event: don't print core unlock warnings if cores were never locked

If we fail app init path, we try to unlock any cores that happened
to be locked. But the code path was only checking for -1, and by

event: don't print core unlock warnings if cores were never locked

If we fail app init path, we try to unlock any cores that happened
to be locked. But the code path was only checking for -1, and by
default the core lock array would have 0 values. So only try to
unlock if the core lock fd is not -1 nor 0.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I3a2f7bb8bf11c5bc3d8c59b213a356aff87b30d0
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25059
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

event: help user if env initialization fails as non-root

env_dpdk usually cannot initialize successfully without running as
root. If env init fails and the uid isn't root, print an error message
to

event: help user if env initialization fails as non-root

env_dpdk usually cannot initialize successfully without running as
root. If env init fails and the uid isn't root, print an error message
to help the user if they forgot to run as root.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I15be366ed2c7f67a9f99232ad2dbdf641b58b8d6
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25058
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

event: move function declarations to inside of extern "C" guard

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I7f804752e30b00930a86e430c907afdce083f780
Reviewed-on: https://review.sp

event: move function declarations to inside of extern "C" guard

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I7f804752e30b00930a86e430c907afdce083f780
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25031
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Anisa Su <anisa.su@samsung.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

event: shrink size of event message pool

These spdk_event structures are used for passing messages between
reactors. When it was first created, we did not have the concept
of spdk_threads, so this p

event: shrink size of event message pool

These spdk_event structures are used for passing messages between
reactors. When it was first created, we did not have the concept
of spdk_threads, so this pool needed to be very large since all
"per-thread" messaging was done using this pool. But now spdk_threads
are the primary mechanism for per-thread messaging. This event
pool in the reactor code is only for messages sent between cores which
is basically for the scheduler and interrupt mode.

256K pool size was way too big, and ends up consuming over 50MB of
memory. Shrink it to 16K, which is probably still an order of
magnitude more than needed, but still significantly cuts the amount
of memory wasted by this mempool.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Id46aeae7fd6a495d90ab40ed90f2dcb89b6ef885
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24998
Reviewed-by: Pawel Piatek <pawelx.piatek@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

show more ...

lib/event: implement scheduler trace events

Change-Id: I284b54b6a92aa330b5a95700101a928b9d83d46f
Signed-off-by: Anisa Su <anisa.su@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk

lib/event: implement scheduler trace events

Change-Id: I284b54b6a92aa330b5a95700101a928b9d83d46f
Signed-off-by: Anisa Su <anisa.su@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24873
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

lib/event: setup tracing before creating app_thread

If app_thread is created before tracing is set up,
the THREAD_STATS scheduler tracepoint has an issue with
reading the app_thread's name (it appea

lib/event: setup tracing before creating app_thread

If app_thread is created before tracing is set up,
the THREAD_STATS scheduler tracepoint has an issue with
reading the app_thread's name (it appears blank).

Change-Id: Ia1c3c8e4aa6ed73243f535e420b6d12a25aa6744
Signed-off-by: Anisa Su <anisa.su@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24999
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot

show more ...

event: add --enforce_numa app option

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Id840ef8b9ae27f60fc0086f176e9e2c0d3a3cb4f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/

event: add --enforce_numa app option

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Id840ef8b9ae27f60fc0086f176e9e2c0d3a3cb4f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24041
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

lib/event: free json data memory earlier

There is no good reason to keep that memory allocated until app_stop
other than negative path handling. After spdk_subsystem_load_config
function called for

lib/event: free json data memory earlier

There is no good reason to keep that memory allocated until app_stop
other than negative path handling. After spdk_subsystem_load_config
function called for runtime RPCs json data is no longer used hence
can be released sooner.

Change-Id: I48ded7684f372ea5b801fb59ca79354fb5eb61ee
Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24746
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot

show more ...

event: fix double free on app stop

App stop can be called multiple times and there is a flag to protect
against that however free of the json data was the very first thing to
be done hence chance fo

event: fix double free on app stop

App stop can be called multiple times and there is a flag to protect
against that however free of the json data was the very first thing to
be done hence chance for double free there. Fix by moving free after the
flag checked.

Change-Id: I85057e556c28dafb82883d80899fcc71bb2f9802
Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24725
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

env: add SPDK_ENV_NUMA_ID_ANY and replace socket_id with numa_id

We will try to avoid further proliferation of "SOCKET_ID" to refer
to a NUMA socket ID moving forward, and just use "NUMA_ID" to avoi

env: add SPDK_ENV_NUMA_ID_ANY and replace socket_id with numa_id

We will try to avoid further proliferation of "SOCKET_ID" to refer
to a NUMA socket ID moving forward, and just use "NUMA_ID" to avoid
confusion with TCP sockets.

Change all of the existing in-tree SPDK_ENV_SOCKET_ID_ANY uses to
SPDK_ENV_NUMA_ID_ANY, but keep the old #define around, at least for
now. Also change all 'socket_id' parameters to 'numa_id'.

We still have spdk_env_get_socket_id(), we will need to keep this
but next patch will add spdk_env_get_numa_id().

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Idc31c29e32b708c24d88f9c6fecaf9a99e34ba1e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24607
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

lib/event: Add support for core isolation in scheduling

Added new 'scheduler_set_options' RPC.
1. isolated_core_mask: Users are allowed to select cores to isolate during scheduling
2. scheduling_cor

lib/event: Add support for core isolation in scheduling

Added new 'scheduler_set_options' RPC.
1. isolated_core_mask: Users are allowed to select cores to isolate during scheduling
2. scheduling_core: Users are allowed to select main core of scheduling
This RPC can only be called before SPDK subsystems have been initialized.
These parameters can only be set once.

The following options are for general mechanisms.
For example, dynamic scheduler now allows specific cores to be isolated from scheduling
through the newly added isolated_core_mask. This means that no threads can enter
or leave the cores designated as isolated cores.

Core isolation can be useful in the following situation:
The user may want the main core to be dedicated to orchestration tasks(such as RPCs, etc.)
and does not want any IO work to be assigned to it while running dynamic scheduler.
These changes allow user to dedicate main thread for RPC, assign nvmf poll groups to
non-main thread cores, and then ensure that dynamic(or any other) scheduler will
not place any other spdk_threads on the main core.

Change-Id: Idb5e564150d014cec7106d48d609d83490561a94
Signed-off-by: SeungYeon Shin <syeon.shin@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23156
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

show more ...

lib/event: Modify spdk_reactor_set_interrupt_mode() to be called from scheduling reactor

The previous behavior of spdk_reactor_set_interrupt_mode()
returning an error when called from a non-app_thre

lib/event: Modify spdk_reactor_set_interrupt_mode() to be called from scheduling reactor

The previous behavior of spdk_reactor_set_interrupt_mode()
returning an error when called from a non-app_thread context
has been changed to return an error when called from a
non-scheduling reactor context. As a result,
spdk_reactor_set_interrupt_mode() must now be executed from a
scheduling core rather than an app thread. Modifications have
been made to address instances where this requirement was not met.

There is no issue when the app thread operates on the scheduling
core, but if it runs on a different core, changing the interrupt
mode will result in an error stating that it can only be modified
on the scheduling core. This could cause scheduling operations
to malfunction. To address this, modifications have been made.

Change-Id: I1f73c84191f5cab877a29405756f106cfb410932
Signed-off-by: syeon.shin <syeon.shin@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24324
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

env: add opts_size to spdk_env_opts

This will help with ABI compatibility as new fields get added
to this structure.

User is responsible for setting opts_size. Major version has been
bumped, so use

env: add opts_size to spdk_env_opts

This will help with ABI compatibility as new fields get added
to this structure.

User is responsible for setting opts_size. Major version has been
bumped, so users will need to rebuild against latest code, if they
do not set opts_size we will just treat that as if the structure
ends right before opts_size. We will also print an ERRLOG to warn
user to set opts_size appropriately.

As part of this patch, update all in-tree callers of
spdk_env_opts_init() to set the opts_size.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: If2611eccc8b3c43e1dc1654028d000a8a12a544e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23940
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz@tzawadzki.com>

show more ...

event/rpc: Remove newline at the end of error messages

Change-Id: I6f02ac416e986bf4ba26dadf3bf3512b7efe3fa7
Signed-off-by: Pierre Lestringant <plestringant@kalray.eu>
Reviewed-on: https://review.spd

event/rpc: Remove newline at the end of error messages

Change-Id: I6f02ac416e986bf4ba26dadf3bf3512b7efe3fa7
Signed-off-by: Pierre Lestringant <plestringant@kalray.eu>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24240
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz@tzawadzki.com>

show more ...

lib/event: remove unnecessary log.flag checks

Change-Id: Iabf5f8a825117d1088ff8c6ed79246bf704cef88
Signed-off-by: Anisa Su <anisa.su@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/sp

lib/event: remove unnecessary log.flag checks

Change-Id: Iabf5f8a825117d1088ff8c6ed79246bf704cef88
Signed-off-by: Anisa Su <anisa.su@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24336
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

general: fix misspells and typos

Signed-off-by: Kamil Godzwon <kamilx.godzwon@intel.com>
Change-Id: Iab206ef526eb7032c6681a3145450010c91705a4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+

general: fix misspells and typos

Signed-off-by: Kamil Godzwon <kamilx.godzwon@intel.com>
Change-Id: Iab206ef526eb7032c6681a3145450010c91705a4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24120
Community-CI: Mellanox Build Bot
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

event/scheduler: remove custom opts from static scheduler

Static scheduler does not take any opts. Remove them in order to
return failure when passed.

See (6371dd6) event/scheduler: do not accept p

event/scheduler: remove custom opts from static scheduler

Static scheduler does not take any opts. Remove them in order to
return failure when passed.

See (6371dd6) event/scheduler: do not accept params for scheduler without set_opts
This scenario is tested in scheduler_opts().

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I9b0dc723b96b98113ae4b3c2f6a00da7191ea5df
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24302
Community-CI: Mellanox Build Bot

show more ...

event/scheduler: do not accept params for scheduler without set_opts

Scheduler should not accept any parameters if set_opts is not implemented.
This looks awful, as the decode is done just to check

event/scheduler: do not accept params for scheduler without set_opts

Scheduler should not accept any parameters if set_opts is not implemented.
This looks awful, as the decode is done just to check if more opts were
provided. Yet it does work.

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I31c2385244557ac08de281553cad82eb3b3228ba
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23958
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

event/scheduler: allow framework_get_scheduler before initialization

It was always possible to configure scheduler before subsystem
initialization, but never possible to retrieve its configuration
a

event/scheduler: allow framework_get_scheduler before initialization

It was always possible to configure scheduler before subsystem
initialization, but never possible to retrieve its configuration
at that time.
Reason for this mismatch might have been omission or 'null'
scheduler pointing to the default one until subsystems are initialized.

Leave it as it is for now, but allow to retrieve scheduler configuration
at the same time as it is possible to configure it.

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: Id5a896b2dc329e891690099e9ad45bf3f01a09bd
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23955
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...