examples: remove unnecessary thread_is_idle check in nvmf and thread_exRelated to GitHub issue #3545. Checking spdk_thread_is_idle beforespdk_thread_destroy may cause confusion and imply that a th
examples: remove unnecessary thread_is_idle check in nvmf and thread_exRelated to GitHub issue #3545. Checking spdk_thread_is_idle beforespdk_thread_destroy may cause confusion and imply that a thread must beidle before it can exit, which would cause a thread with timed pollersto hang when exiting. This is not the case; a thread does not need towait for timed pollers to expire before exiting. Cleaning up theseexamples will improve clarity.Change-Id: I16aff7eb7c27aa6bc20d76b1894312b520717a7fSigned-off-by: Anisa Su <anisa.su@samsung.com>Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25295Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>Reviewed-by: GangCao <gang.cao@intel.com>Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>Reviewed-by: Jim Harris <jim.harris@samsung.com>Community-CI: Mellanox Build BotCommunity-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
show more ...
env: add SPDK_ENV_NUMA_ID_ANY and replace socket_id with numa_idWe will try to avoid further proliferation of "SOCKET_ID" to referto a NUMA socket ID moving forward, and just use "NUMA_ID" to avoi
env: add SPDK_ENV_NUMA_ID_ANY and replace socket_id with numa_idWe will try to avoid further proliferation of "SOCKET_ID" to referto a NUMA socket ID moving forward, and just use "NUMA_ID" to avoidconfusion with TCP sockets.Change all of the existing in-tree SPDK_ENV_SOCKET_ID_ANY uses toSPDK_ENV_NUMA_ID_ANY, but keep the old #define around, at least fornow. Also change all 'socket_id' parameters to 'numa_id'.We still have spdk_env_get_socket_id(), we will need to keep thisbut next patch will add spdk_env_get_numa_id().Signed-off-by: Jim Harris <jim.harris@samsung.com>Change-Id: Idc31c29e32b708c24d88f9c6fecaf9a99e34ba1eReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24607Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>Reviewed-by: Ben Walker <ben@nvidia.com>Community-CI: Mellanox Build Bot
env: add opts_size to spdk_env_optsThis will help with ABI compatibility as new fields get addedto this structure.User is responsible for setting opts_size. Major version has beenbumped, so use
env: add opts_size to spdk_env_optsThis will help with ABI compatibility as new fields get addedto this structure.User is responsible for setting opts_size. Major version has beenbumped, so users will need to rebuild against latest code, if theydo not set opts_size we will just treat that as if the structureends right before opts_size. We will also print an ERRLOG to warnuser to set opts_size appropriately.As part of this patch, update all in-tree callers ofspdk_env_opts_init() to set the opts_size.Signed-off-by: Jim Harris <jim.harris@samsung.com>Change-Id: If2611eccc8b3c43e1dc1654028d000a8a12a544eReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23940Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>Reviewed-by: Tomasz Zawadzki <tomasz@tzawadzki.com>
examples: add a thread example applicationCurrently we do not have any examples on how towrite and use thread library, other thanin examples/nvmf/nvmf. Adding a new applicationwill help general
examples: add a thread example applicationCurrently we do not have any examples on how towrite and use thread library, other thanin examples/nvmf/nvmf. Adding a new applicationwill help general understanding of thread library.Change-Id: Ib1cca88d128fe3254c8a57cda1f2f7193d3d2e31Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14846Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>Reviewed-by: Jim Harris <jim.harris@gmail.com>