kern - Make lseek(2) generic

* Extend fileops with fo_seek function allowing pluggable lseek(2)
implementations. Part of preparation for linux DMA-BUF compat API.

* Move current vnode lseek imple

kern - Make lseek(2) generic

* Extend fileops with fo_seek function allowing pluggable lseek(2)
implementations. Part of preparation for linux DMA-BUF compat API.

* Move current vnode lseek implementation into vnode and devfs fileops.
Code is exactly the same in both, note about duplication added.

* Set remaining fileops to badfo_seek.

Mentored-By: dillon

show more ...

Various minor whitespace cleanups

Accumulated along the way.

opencrypto: Update crypto_copyback() to use m_copyback2(how=M_WAITOK)

crypto_copyback() has no return value and isn't expected to fail by the
caller, e.g., swcr_compdec(), so update it to use m_copy

opencrypto: Update crypto_copyback() to use m_copyback2(how=M_WAITOK)

crypto_copyback() has no return value and isn't expected to fail by the
caller, e.g., swcr_compdec(), so update it to use m_copyback2() with
how=M_WAITOK.

Note that caller swcr_compdec() uses 'M_INTWAIT' for kmalloc(), but that
doesn't make sense to mbuf functions, so use M_WAITOK instead for the
moment.

Discussed-with: dillon

show more ...

opencrypto: Update aes_ctr_setkey() to validate key bits to avoid panic

AES rijndaelKeySetupEnc() only accepts key of length 128/192/256 bits
and it uses a KASSERT() to assert this. However, aes_ct

opencrypto: Update aes_ctr_setkey() to validate key bits to avoid panic

AES rijndaelKeySetupEnc() only accepts key of length 128/192/256 bits
and it uses a KASSERT() to assert this. However, aes_ctr_setkey() can
be given an improper key via ioctl() and thus panic the system. Fix
this panic by validating the key in aes_ctr_setkey() before calling
rijndaelKeySetupEnc().

This partially resolves bug #3311.

Bug: https://bugs.dragonflybsd.org/issues/3311

show more ...

opencrypto: Update auth_hash.Setkey() to return an error code

The Setkey() method can fail, so better to change it return an error
code for the caller to properly handle it. This also makes it like

opencrypto: Update auth_hash.Setkey() to return an error code

The Setkey() method can fail, so better to change it return an error
code for the caller to properly handle it. This also makes it like
enc_xform.setkey(), which also returns an error code.

Update AES_GMAC_Setkey() accordingly.

show more ...

opencrypto: Manage context memory within cryptosoft

Each algorithm declares its context size and let cryptosoft allocate and
free the context memory. This greatly simplifies the setkey() routine
of

opencrypto: Manage context memory within cryptosoft

Each algorithm declares its context size and let cryptosoft allocate and
free the context memory. This greatly simplifies the setkey() routine
of each algorithm and removes the unnecessary zerokey() routine.

Derived from OpenBSD:
https://github.com/openbsd/src/commit/2dbd8e13008692ff92b9560da7b770daf2889930

show more ...

opencrypto: Minor style cleanups / tweaks

libkern: Remove karc4rand() in favor of karc4random_buf()

The latter karc4random_buf()/arc4random_buf() sees more adoptions in
other BSDs as well as the userland. So only reserve the latter and
rem

libkern: Remove karc4rand() in favor of karc4random_buf()

The latter karc4random_buf()/arc4random_buf() sees more adoptions in
other BSDs as well as the userland. So only reserve the latter and
remove the former.

Update the kernel code accordingly to use karc4random_buf() only.

show more ...