Whitespace cleanups

ping(8): Add check for negative wait timeout

Meanwhile, fix the error message.

ping(8): Relax the interval restriction for normal users

The ping interval was restricted to be >= 1 second for normal users to
prevent from performing DoS attacks. This restriction was added by
Ma

ping(8): Relax the interval restriction for normal users

The ping interval was restricted to be >= 1 second for normal users to
prevent from performing DoS attacks. This restriction was added by
Matt Dillon in 1998 during the BEST days [0]. It has become less
meaningful now. Following the Linux behavior, relax the interval to be
>= 2 milliseconds for normal users.

In addition, add a check for negative interval numbers.

[0] https://github.com/freebsd/freebsd-src/commit/526f06b278d9252add168aa18b60242c08771165

Discussed-with: dillon

show more ...

ping(8): Allow normal users to specify larger packets

Before this change, only super-user could specify a packet size larger
than the default 56 bytes. This restriction was added by Matt Dillon in

ping(8): Allow normal users to specify larger packets

Before this change, only super-user could specify a packet size larger
than the default 56 bytes. This restriction was added by Matt Dillon in
1998 during the BEST days [0].

Nowadays, it doesn't make much sense to limit the packet size. In
addition, this restriction doesn't exist in ping6(8) and on NetBSD,
OpenBSD and Linux.

And one more interesting thing, UMS [1] uses this feature to estimate
the client's bandwidth to optimize the streaming experience.

[0] https://github.com/freebsd/freebsd-src/commit/526f06b278d9252add168aa18b60242c08771165
[1] UMS: https://github.com/UniversalMediaServer/UniversalMediaServer

Discussed-with: dillon

show more ...

network - Remove ip_len header-length adjustment

* This should remove the last main code path modifications to packet
mbuf contents. The IP header in the mbuf is now basically left alone
whenev

network - Remove ip_len header-length adjustment

* This should remove the last main code path modifications to packet
mbuf contents. The IP header in the mbuf is now basically left alone
whenever possible, bringing us in-line with FreeBSD and Linux and
removing cache-line bounces between cpus and between a cpu and the
related PCIe DMA.

* Do not adjust ip_len to remove the IP header length.

* Various protocol stacks do the subtraction themselves, when needed.

* Various bits of code that added the length back in to execute a function
then removed it again cleaned up.

* IP reassembly (in ip_input.c and pf_norm.c) cleaned up.

show more ...