scripts/perf: Dump cpu-temp data to stdout

This was missed and the actual output was being dumped only to a
file upon termination. As with any other perf/pm/ tool, make sure
each reading is dumped t

scripts/perf: Dump cpu-temp data to stdout

This was missed and the actual output was being dumped only to a
file upon termination. As with any other perf/pm/ tool, make sure
each reading is dumped to stdout by default as well.

Change-Id: I3ec6199ca7c998573cdec07d1d5b344f2b00e4d6
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23743
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

scripts/perf: Include per-node hugepages stats in collect-vmstat

This may help in debugging how hugepages are distributed across
different numa nodes during tests. Example:

# old
... ----extra

scripts/perf: Include per-node hugepages stats in collect-vmstat

This may help in debugging how hugepages are distributed across
different numa nodes during tests. Example:

# old
... ----extra info----
... avail shmem ahp_total hp_free hp_size test
... 46938928 5997040 2048 1778 2048 N/A

# new
... ----extra info----
... avail shmem hp_total hp_free hp_size hp_per_node test
... 46938928 5997040 2048 1778 2048 N/A N0-1048576kB_f=0,N0-1048576kB_t=0,N0-2048kB_f=1778,N0-2048kB_t=2048,N1-1048576kB_f=0,N1-1048576kB_t=0,N1-2048kB_f=0,N1-2048kB_t=0 N/A

Granted it's a mouthful, but it does improve view of the system's
resources.

Change-Id: Ib7737752c9df9a67c32b656a5df294ce32b65ef6
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24180
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz@tzawadzki.com>

show more ...

general: fix misspells and typos

Signed-off-by: Kamil Godzwon <kamilx.godzwon@intel.com>
Change-Id: Iab206ef526eb7032c6681a3145450010c91705a4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+

general: fix misspells and typos

Signed-off-by: Kamil Godzwon <kamilx.godzwon@intel.com>
Change-Id: Iab206ef526eb7032c6681a3145450010c91705a4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24120
Community-CI: Mellanox Build Bot
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

scripts/perf: Use sudo only when needed

Most of the monitoring tools can be executed as non-root so use
sudo only for those that explicitly require it.

Change-Id: I0044abd888284c0b368cfb5f214098502

scripts/perf: Use sudo only when needed

Most of the monitoring tools can be executed as non-root so use
sudo only for those that explicitly require it.

Change-Id: I0044abd888284c0b368cfb5f21409850261ce4cb
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22699
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

scripts/perf: Drop MONITOR_RESOURCES_PIDS[@]

This list is in practice available only to a process which started
the monitors - every other process that calls to
signal_monitor_resources() relies sol

scripts/perf: Drop MONITOR_RESOURCES_PIDS[@]

This list is in practice available only to a process which started
the monitors - every other process that calls to
signal_monitor_resources() relies solely on the .pid file.

Change-Id: Ie239c1ae9e921d6babca45deba79febdba3dabad
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22698
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

scripts/perf/pm: Add minimal FreeBSD support to vmstat collector

Change-Id: If30ba474193c24c610bfc4619525726c46516dcc
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://revi

scripts/perf/pm: Add minimal FreeBSD support to vmstat collector

Change-Id: If30ba474193c24c610bfc4619525726c46516dcc
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21548
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

scripts/perf/pm: Add $TEST_TAG to collect-bmc-pm's output

As we are at it, align some printouts and redirect them to stderr
as initially intended.

Change-Id: I3c26240bd72ad3ebecba657a8f6b8865f96c4a

scripts/perf/pm: Add $TEST_TAG to collect-bmc-pm's output

As we are at it, align some printouts and redirect them to stderr
as initially intended.

Change-Id: I3c26240bd72ad3ebecba657a8f6b8865f96c4a00
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21536
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

autotest: Add helpers for controling pm tools

And use them to hook collect-* perf scripts into autobuild,autopackage.

This is meant to serve as a debug exposing impact of the full SPDK build
on the

autotest: Add helpers for controling pm tools

And use them to hook collect-* perf scripts into autobuild,autopackage.

This is meant to serve as a debug exposing impact of the full SPDK build
on the underlying system.

Change-Id: I7e0fe48927dd5725ea415e99752fa33e608710ec
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21494
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

scripts/perf: Align date's format across the PM tools

vmstat uses 24h timestamp and it cannot be changed so let other
tools follow suit.

Change-Id: I34d2d0d0b6ec551ef71d9e24539f62eb368a6346
Signed-

scripts/perf: Align date's format across the PM tools

vmstat uses 24h timestamp and it cannot be changed so let other
tools follow suit.

Change-Id: I34d2d0d0b6ec551ef71d9e24539f62eb368a6346
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21187
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Pawel Piatek <pawelx.piatek@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

scripts/perf: Tag PM data with current run_test() instance

Add signal handler to catch USR1 and drive re-tagging of the PM data.
This should allow for a quick cross-reference while troubleshooting
t

scripts/perf: Tag PM data with current run_test() instance

Add signal handler to catch USR1 and drive re-tagging of the PM data.
This should allow for a quick cross-reference while troubleshooting
target test and its potential impact on the system.

Change-Id: I6eb7ff0ed0fc4d0162db0166543a070a4ad90de4
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21179
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

scripts/perf: Add tool for collecting vmstat

Wrap it around actual vmstat but include extra info, relevant for the
CI pool.

Change-Id: I5a02a1735bfa4149e0e0376bc8a0ee688631701a
Signed-off-by: Micha

scripts/perf: Add tool for collecting vmstat

Wrap it around actual vmstat but include extra info, relevant for the
CI pool.

Change-Id: I5a02a1735bfa4149e0e0376bc8a0ee688631701a
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21178
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

scripts/perf: Allow to define interval for collect-cpu-load

Change-Id: I35d53128dff8cbd0483b9c972f6baf356e46d221
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.sp

scripts/perf: Allow to define interval for collect-cpu-load

Change-Id: I35d53128dff8cbd0483b9c972f6baf356e46d221
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21177
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

scripts/perf: Add tool for collecting cpu load

As we are at it, remove bottleneck in get_cpu_time() - avoid reading
/proc/stat line by line to find target cpu as in case of systems with
hundreds of

scripts/perf: Add tool for collecting cpu load

As we are at it, remove bottleneck in get_cpu_time() - avoid reading
/proc/stat line by line to find target cpu as in case of systems with
hundreds of cpus this increases the get_cpu_time()'s runtime quite
significantly. Instead, slurp all cpu stats with a single read and
expose them as _cpuN[].

On a system with 144 cpus single get_cpu_time()'s iteration dropped
from ~5s to ~1s.

Note that this tool uses plain integer arithmetic so the results per
cpu time may be a bit off due to lacking precision. Nevertheless,
they should serve nicely as an approximation.

Change-Id: I64fecb593c5c38e3db79f75dcc4f23a9069c701a
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21173
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

scripts/perf: Add tool for checking CPU throttling|temp data

Change-Id: I0f6f02609413bea41abd654b85a5d257eb390582
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.s

scripts/perf: Add tool for checking CPU throttling|temp data

Change-Id: I0f6f02609413bea41abd654b85a5d257eb390582
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21146
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

scripts/perf: Fix help's usage

-l doesn't take any extra arguments so indicate that.

Change-Id: I96b41606c71a5ba65e871ceee1972b0fdb7e0539
Signed-off-by: Michal Berger <michal.berger@intel.com>
Revi

scripts/perf: Fix help's usage

-l doesn't take any extra arguments so indicate that.

Change-Id: I96b41606c71a5ba65e871ceee1972b0fdb7e0539
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21176
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Mateusz Kozlowski <mateusz.kozlowski@solidigm.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Pawel Piatek <pawelx.piatek@intel.com>

show more ...

perf/pm: Fix reading check

Since we use precision with bc to calculate the reading, the actual
value may include decimal point (".") in its string. This breaks
the arithmetic check. Replace it with

perf/pm: Fix reading check

Since we use precision with bc to calculate the reading, the actual
value may include decimal point (".") in its string. This breaks
the arithmetic check. Replace it with a string check to see if the
value we got is indeed negative.

Change-Id: I2b24c661e4201e33179fd44591af0c0d42d7ac44
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18437
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

perf/pm: Discard < 0 readings coming from RAPL

Signed-off-by: Michal Berger <michal.berger@intel.com>
Change-Id: I5a4071441b6eed53553624c5ee587b7c91360eb5
Reviewed-on: https://review.spdk.io/gerrit/

perf/pm: Discard < 0 readings coming from RAPL

Signed-off-by: Michal Berger <michal.berger@intel.com>
Change-Id: I5a4071441b6eed53553624c5ee587b7c91360eb5
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16633
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

perf/pm: Use bc while dumping all the readings

This is done to calculate readings with better precision and fix
the case where calculation of total reading from given entity would
fail if it was < 1

perf/pm: Use bc while dumping all the readings

This is done to calculate readings with better precision and fix
the case where calculation of total reading from given entity would
fail if it was < 1 (as bc drops the leading 0, leaving e.g. .42).

Signed-off-by: Michal Berger <michal.berger@intel.com>
Change-Id: I68f2df89c340dba28d15c4aaac3e106c9f8057d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16586
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

scripts/perf: replace spaces for BMC's sensor names

Replace spaces with undescores for each sensor name
to avoid dealing with filenames with spaces later.

Change-Id: I2115cc14a15a53a7d92a7dae5cb6d1

scripts/perf: replace spaces for BMC's sensor names

Replace spaces with undescores for each sensor name
to avoid dealing with filenames with spaces later.

Change-Id: I2115cc14a15a53a7d92a7dae5cb6d1bfa7fb4402
Signed-off-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15352
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jaroslaw Chachulski <jaroslawx.chachulski@intel.com>
Reviewed-by: Michal Berger <michal.berger@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

add (c) and SPDX header to bash files as needed

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --forma

add (c) and SPDX header to bash files as needed

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc)

For intel copyrights added, --follow and -C95% were used.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: I2ef86976095b88a9bf5b1003e59f3943cd6bbe4c
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15209
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...