window(1): Multiple minor cleanupsThe updates to window.1 man page are mostly obtained from NetBSD.
window(1): Add some format safety.While there, add some FALLTHROUGH too.
Add __attribute__((__noreturn__)) to various function prototypes in usr.bin/.This general cleanup is useful in various ways. It helps the compileroptimize better and it also helps later GCCs detec
Add __attribute__((__noreturn__)) to various function prototypes in usr.bin/.This general cleanup is useful in various ways. It helps the compileroptimize better and it also helps later GCCs detect better when to give-Wimplicit-fallthrough warnings and when not.Found-with: -Wsuggest-attribute=noreturn
show more ...
window - Fix Graphics capability enable test* Fix Graphics capability enable test, code type-o, logical OR has to be AND.Dragonfly-bugs: 3005 (dcb)
Relocate readline and ncurses headers to /usr/include/privHaving public headers for private libraries can cause confusion forsoftware that assumes the presence of headers leads to the availability
Relocate readline and ncurses headers to /usr/include/privHaving public headers for private libraries can cause confusion forsoftware that assumes the presence of headers leads to the availabilityof the libraries.Discussed-with: dillon
LIBPRIV: Add common PRIVATELIB_LDFLAGS definitions.Simply being able to change it in two places is easier than everywhere.Also add PRIVATELIB_BLDFLAGS that is intended for bootsrapping only.While
LIBPRIV: Add common PRIVATELIB_LDFLAGS definitions.Simply being able to change it in two places is easier than everywhere.Also add PRIVATELIB_BLDFLAGS that is intended for bootsrapping only.While there, perform some cleanup for dup entries.
ncurses solidation: Remove all references to libtermcapThe termlib, termcap, and tinfo libraries are all symlinked to ncurseslibrary. There's no reason to have four aliases for the same libraryw
ncurses solidation: Remove all references to libtermcapThe termlib, termcap, and tinfo libraries are all symlinked to ncurseslibrary. There's no reason to have four aliases for the same librarywhen none of them are exposed outside base.termlib and tinfo aren't referenced anywhere, but libtermcap is.This commit changes all the references to libtermcap to libncurses,and removes the private aliases of ncurses.
privatize libncurses (touches many, many programs)The ncurses software produces 8 libraries: normal and wide versions ofncurses, forms, menu, and panel. The dragonfly base doesn't use formsor me
privatize libncurses (touches many, many programs)The ncurses software produces 8 libraries: normal and wide versions ofncurses, forms, menu, and panel. The dragonfly base doesn't use formsor menu at all so we can remove 4 libraries immediately and theirassociated man pages.The panel library is only used in one place, so technically libpanelwis no longer required, but let's keep building it anyway.While here, delete references to libcurses. It was just symlinked toncurses, so let's take the opportunity to only reference ncurses fromthis point forward and not install a private version of libcurses.
Remove advertising header from usr.bin/Correct BSD License clause numbering from 1-2-4 to 1-2-3.
Remove unnecessary whitespace in macro arguments in some manual pages.
Remove main() prototypes.
usr.bin: fix more mandoc(1) warningsUnfortunately, most other man pages come from the contrib/ dir,each with a couple of associated warnings that even sed(1) can'tcompletely amend.
window.1: unbreak macros, hyphens are `-' not minus `\-'
Sweep-fix comparing pointers with 0 (and assigning 0 to pointers).For better readability, don't compare pointers with 0 or assign 0to them. Use NULL instead.The change was done with coccinelle.
window(1): Fix a gcc44 warning.While here, remove an unused file which I missed when I upgraded it toNetBSD's.
Add __printflike's where possible and fix all related bugs & issues.
window(1): Perform NULL check before strcmp() rather than after.Fixes segfault upon TERM=cons25.
window(1): Remove __RCSID & friends.
window(1): Sync with NetBSD (which is cleaner than FreeBSD's).Raise WARNS to 6.
Generally use NULL instead of explicitly casting 0 to some pointer type (part2).
Generally use NULL instead of explicitly casting 0 to some pointer type.
Silence warnings and rearrange the includes a bit.
Remove four files which where probably accidentally committed. They haveno actual use.Seen-on: freebsd-cvs
Don't #include <sys/select.h> from sys/types.h, to conform to SUS.Some old BSD programs assume that sys/types.h is basically enoughto get all types and even functions declared, so adjust these.sy
Don't #include <sys/select.h> from sys/types.h, to conform to SUS.Some old BSD programs assume that sys/types.h is basically enoughto get all types and even functions declared, so adjust these.sys/param.h still works as kitchensink and includes sys/select.h.
Pull WARNS6 into usr.bin/Makefile.inc.Most of usr.bin is marked as WARNS6, so add exceptions in individualMakefiles. Also, remove any warning flags from CFLAGS in those Makefiles.
12