1 //===--- UseAnonymousNamespaceCheck.cpp - clang-tidy ----------------------===//
2 //
3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4 // See https://llvm.org/LICENSE.txt for license information.
5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6 //
7 //===----------------------------------------------------------------------===//
8
9 #include "UseAnonymousNamespaceCheck.h"
10 #include "clang/AST/ASTContext.h"
11 #include "clang/ASTMatchers/ASTMatchFinder.h"
12
13 using namespace clang::ast_matchers;
14
15 namespace clang::tidy::misc {
16 namespace {
AST_POLYMORPHIC_MATCHER_P(isInHeaderFile,AST_POLYMORPHIC_SUPPORTED_TYPES (FunctionDecl,VarDecl),FileExtensionsSet,HeaderFileExtensions)17 AST_POLYMORPHIC_MATCHER_P(isInHeaderFile,
18 AST_POLYMORPHIC_SUPPORTED_TYPES(FunctionDecl,
19 VarDecl),
20 FileExtensionsSet, HeaderFileExtensions) {
21 return utils::isExpansionLocInHeaderFile(
22 Node.getBeginLoc(), Finder->getASTContext().getSourceManager(),
23 HeaderFileExtensions);
24 }
25
AST_MATCHER(FunctionDecl,isMemberFunction)26 AST_MATCHER(FunctionDecl, isMemberFunction) {
27 return llvm::isa<CXXMethodDecl>(&Node);
28 }
AST_MATCHER(VarDecl,isStaticDataMember)29 AST_MATCHER(VarDecl, isStaticDataMember) { return Node.isStaticDataMember(); }
30 } // namespace
31
UseAnonymousNamespaceCheck(StringRef Name,ClangTidyContext * Context)32 UseAnonymousNamespaceCheck::UseAnonymousNamespaceCheck(
33 StringRef Name, ClangTidyContext *Context)
34 : ClangTidyCheck(Name, Context),
35 HeaderFileExtensions(Context->getHeaderFileExtensions()) {}
36
registerMatchers(MatchFinder * Finder)37 void UseAnonymousNamespaceCheck::registerMatchers(MatchFinder *Finder) {
38 Finder->addMatcher(
39 functionDecl(isStaticStorageClass(),
40 unless(anyOf(isInHeaderFile(HeaderFileExtensions),
41 isInAnonymousNamespace(), isMemberFunction())))
42 .bind("x"),
43 this);
44 Finder->addMatcher(
45 varDecl(isStaticStorageClass(),
46 unless(anyOf(isInHeaderFile(HeaderFileExtensions),
47 isInAnonymousNamespace(), isStaticLocal(),
48 isStaticDataMember(), hasType(isConstQualified()))))
49 .bind("x"),
50 this);
51 }
52
check(const MatchFinder::MatchResult & Result)53 void UseAnonymousNamespaceCheck::check(const MatchFinder::MatchResult &Result) {
54 if (const auto *MatchedDecl = Result.Nodes.getNodeAs<NamedDecl>("x")) {
55 StringRef Type = llvm::isa<VarDecl>(MatchedDecl) ? "variable" : "function";
56 diag(MatchedDecl->getLocation(),
57 "%0 %1 declared 'static', move to anonymous namespace instead")
58 << Type << MatchedDecl;
59 }
60 }
61
62 } // namespace clang::tidy::misc
63