1 //===----------------------------------------------------------------------===//
2 //
3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4 // See https://llvm.org/LICENSE.txt for license information.
5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6 //
7 //===----------------------------------------------------------------------===//
8
9 #include "clang-tidy/ClangTidyCheck.h"
10 #include "clang-tidy/ClangTidyModuleRegistry.h"
11
12 #include "robust_against_adl.hpp"
13
14 #include <algorithm>
15
16 namespace {
AST_MATCHER(clang::UnresolvedLookupExpr,requiresADL)17 AST_MATCHER(clang::UnresolvedLookupExpr, requiresADL) { return Node.requiresADL(); }
18
AST_MATCHER(clang::CallExpr,isOperator)19 AST_MATCHER(clang::CallExpr, isOperator) { return llvm::isa<clang::CXXOperatorCallExpr>(Node); }
20
AST_MATCHER(clang::UnresolvedLookupExpr,isCustomizationPoint)21 AST_MATCHER(clang::UnresolvedLookupExpr, isCustomizationPoint) {
22 return std::ranges::any_of(
23 std::array{"swap", "make_error_code", "make_error_condition", "begin", "end", "size", "rend", "rbegin"},
24 [&](const char* func) { return Node.getName().getAsString() == func; });
25 }
26
AST_MATCHER(clang::CXXMethodDecl,isStatic)27 AST_MATCHER(clang::CXXMethodDecl, isStatic) { return Node.isStatic(); }
28
29 } // namespace
30
31 namespace libcpp {
robust_against_adl_check(llvm::StringRef name,clang::tidy::ClangTidyContext * context)32 robust_against_adl_check::robust_against_adl_check(llvm::StringRef name, clang::tidy::ClangTidyContext* context)
33 : clang::tidy::ClangTidyCheck(name, context) {}
34
registerMatchers(clang::ast_matchers::MatchFinder * finder)35 void robust_against_adl_check::registerMatchers(clang::ast_matchers::MatchFinder* finder) {
36 using namespace clang::ast_matchers;
37 finder->addMatcher(
38 callExpr(unless(isOperator()),
39 unless(argumentCountIs(0)),
40 has(unresolvedLookupExpr(requiresADL(), unless(isCustomizationPoint()))),
41 unless(callee(cxxMethodDecl(isStatic()))))
42 .bind("ADLcall"),
43 this);
44 }
45
check(const clang::ast_matchers::MatchFinder::MatchResult & result)46 void robust_against_adl_check::check(const clang::ast_matchers::MatchFinder::MatchResult& result) {
47 if (const auto* call = result.Nodes.getNodeAs<clang::CallExpr>("ADLcall"); call != nullptr) {
48 diag(call->getBeginLoc(), "ADL lookup");
49 }
50 }
51 } // namespace libcpp
52