| e0001c6e | 01-Aug-2024 |
Michal Berger <michal.berger@intel.com> |
test/vhost: Drop HUGENODE from vhost/common.sh
vhost/common.sh is used by different entities, including perf-based ones. Having it inside common.sh affects overall setup which for perf should not be
test/vhost: Drop HUGENODE from vhost/common.sh
vhost/common.sh is used by different entities, including perf-based ones. Having it inside common.sh affects overall setup which for perf should not be touched in any way.
To that end, make sure single-node setup is requested explicitly from autotest.
Change-Id: I8cbfa480bc960f404670fe9d2e3e838ae35c4ea5 Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24406 Reviewed-by: Jim Harris <jim.harris@samsung.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
show more ...
|
| 0070858e | 17-Jul-2024 |
Michal Berger <michal.berger@intel.com> |
scripts/setup.sh: Use HUGE_EVEN_ALLOC logic by default
To that end, remove it altogether and allow setup.sh to always split requested amount of hugepages across all available nodes. Custom setups pe
scripts/setup.sh: Use HUGE_EVEN_ALLOC logic by default
To that end, remove it altogether and allow setup.sh to always split requested amount of hugepages across all available nodes. Custom setups per node are still available through the HUGENODE var.
Adjust some of the hugepages.sh tests to adhere to the new default. This change allows us to remove the per_node_1G_alloc() test since its flow is now covered by the custom_alloc().
By default, autotest.sh sets HUGEMEM=4096 and by spreading it across all the nodes, for the minimal scenario, we get only 2GB on a single node. For vhost tests, the default alloc per VM via vm_setup() is set to 1GB so sharing that 2GB between qemu and SPDK spreads it a bit too thin.
Case in point, for vhost.vhost_blk_packed_ring_integrity test roughly > 600 hugepages is used for vhost. Since it slurps everything from node0, only < 512 remains. Since VMs are assigned per node, the most basic setups keep VM_*_qemu_numa_node set to 0. This is then used by qemu to bind to a specific node. With 1G, < 512 hugepages is simply not enough.
With that in mind, for vhost tests, keep all allocations on a single node instead of trying to figure out right amount of memory per node to keep the old behavior in (this may change in the future when SPDK/vhost becomes numa-aware).
Change-Id: I83e18bfa4cc6de0a777804b354de083ae6ae9d8c Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24176 Community-CI: Mellanox Build Bot Reviewed-by: Tomasz Zawadzki <tomasz@tzawadzki.com> Reviewed-by: Jim Harris <jim.harris@samsung.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
show more ...
|
| f20a4abe | 13-Jan-2024 |
Michal Berger <michal.berger@intel.com> |
test/vhost: Properly distribute cpus in lvol_test
Currently, the spdk_mask erroneously includes cpu which belongs to one of the VMs. This may block QEMU from booting the VM in time. In fact, under n
test/vhost: Properly distribute cpus in lvol_test
Currently, the spdk_mask erroneously includes cpu which belongs to one of the VMs. This may block QEMU from booting the VM in time. In fact, under newer QEMU, the affected VM, which shares the cpu with SPDK, is struggling to boot often leading to a timeout.
Change-Id: If50adfa7d75f74c5ff8348c1b54df6a1fb32115d Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21421 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
show more ...
|
| d2b59ff6 | 19-Sep-2023 |
Tomasz Zawadzki <tomasz.zawadzki@intel.com> |
test/vhost: remove fsync_on_close from fio job
Please see #3133 for details.
fsync_on_close in some cases calls actual fsync. This does not work with SPDK fio plugins as they do not open any files.
test/vhost: remove fsync_on_close from fio job
Please see #3133 for details.
fsync_on_close in some cases calls actual fsync. This does not work with SPDK fio plugins as they do not open any files. Starting with fio-3.35 this error is now propagated to fail the job.
As of right now, fsync_on_close should not be used with fio SPDK plugins. This particular job file was used test/vhost/shared/shared.sh, where it will not work as SPDK virtio_blk does not support flush.
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Change-Id: I66f2b7b9d0d9e04b5c01bda281344c0eb4e6c2cc Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19930 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Michal Berger <michal.berger@intel.com> Reviewed-by: Ben Walker <ben@nvidia.com>
show more ...
|
| d546e5ba | 14-Sep-2023 |
Michal Berger <michal.berger@intel.com> |
test/vhost: Do proper cleanup in shared test suite
Otherwise, in case first fio fails (i.e. the one that is being put into a background job), the error_exit() kills the vhost app, leaving the second
test/vhost: Do proper cleanup in shared test suite
Otherwise, in case first fio fails (i.e. the one that is being put into a background job), the error_exit() kills the vhost app, leaving the second fio hanging for indefinite amount of time.
Instead, kill it immediately when the trap is raised.
Also, simply trap on EXIT, don't overwrite the ERR trap that's set from autotest_common.sh.
Change-Id: Icfe851235ff78024b3f288c91e4a2e122502bd4b Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19892 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Ben Walker <ben@nvidia.com>
show more ...
|
| 2d8b9911 | 18-Sep-2023 |
Michal Berger <michal.berger@intel.com> |
test/vhost: Add nullglob, extglob to run.sh
https://review.spdk.io/gerrit/c/spdk/spdk/+/19551 moved these opts to autotest_common.sh which this interim script is not using. This was silently failing
test/vhost: Add nullglob, extglob to run.sh
https://review.spdk.io/gerrit/c/spdk/spdk/+/19551 moved these opts to autotest_common.sh which this interim script is not using. This was silently failing after the change, hence it was not noticed at the time.
Change-Id: If5c8de8ed49dabef5e4b72892da5a48f33bd6dd7 Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19923 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Pawel Piatek <pawelx.piatek@intel.com>
show more ...
|
| bea9ace0 | 24-Aug-2023 |
Michal Berger <michal.berger@intel.com> |
test/vhost: Perform verify only for the write job
Since fio-3.33, due to the following commit (bisect + revert):
https://github.com/axboe/fio/commit/191d6634e8a692bef15143715c88920987ecaa89
usin
test/vhost: Perform verify only for the write job
Since fio-3.33, due to the following commit (bisect + revert):
https://github.com/axboe/fio/commit/191d6634e8a692bef15143715c88920987ecaa89
using verification for *read jobs is foobar. For currently existing configuration, fio >= 3.33 exits almost immediately causing the migration test to fail - before VM is migrated, we check if fio is actually running, however, due to this issue, it's not.
To mitigate, verify only the write job, allowing the randread job to block for expected amount of time (20s).
Change-Id: I7c36e8f56635292426a15aeeb2395cecd454058a Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19543 Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <jim.harris@gmail.com>
show more ...
|
| b1263050 | 24-Aug-2023 |
Michal Berger <michal.berger@intel.com> |
test/vhost: Remove {RDMA,MGMT}* opts from migration.sh
These are not used in any capacity.
Change-Id: Idd729025d0c14084c3505b1fed58c6c90f3acfa9 Signed-off-by: Michal Berger <michal.berger@intel.com
test/vhost: Remove {RDMA,MGMT}* opts from migration.sh
These are not used in any capacity.
Change-Id: Idd729025d0c14084c3505b1fed58c6c90f3acfa9 Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19542 Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Karol Latecki <karol.latecki@intel.com> Reviewed-by: Kamil Godzwon <kamilx.godzwon@intel.com> Reviewed-by: Jim Harris <jim.harris@gmail.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
show more ...
|
| c7a40fcb | 20-Jul-2023 |
Michal Berger <michal.berger@intel.com> |
test/vhost: Make sure reboot over ssh does not block
In case it does, it can force vm_os_booted() to enter infinite loop at the time ssh finally returns (since the VM would be back online at that ti
test/vhost: Make sure reboot over ssh does not block
In case it does, it can force vm_os_booted() to enter infinite loop at the time ssh finally returns (since the VM would be back online at that time).
Make sure reboot is forced and that ssh will bail as soon as the remote end stops being online.
Change-Id: Ib4494edd44352a2069e359e03b4380669096112a Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19158 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Pawel Piatek <pawelx.piatek@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Marek Chomnicki <marek.chomnicki@intel.com>
show more ...
|
| a4a04624 | 09-Mar-2023 |
Michal Berger <michal.berger@intel.com> |
test/common: Don't use $HOME as base for $DEPENDENCY_DIR
This is a source of problems especially in context of sudo so replace it with a dedicated path instead.
Also, simplify fio selection - these
test/common: Don't use $HOME as base for $DEPENDENCY_DIR
This is a source of problems especially in context of sudo so replace it with a dedicated path instead.
Also, simplify fio selection - these tests should not depend, by default, on some specific binary. Instead, always fallback to using what given VM image provides.
Signed-off-by: Michal Berger <michal.berger@intel.com> Change-Id: I33be30a53725338f36d31a4c1eea82f1ec56b2c9 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17093 Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Pawel Piatek <pawelx.piatek@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
show more ...
|