nvmf: Clean unassociated_qpairs on connect error

When spdk_nvmf_poll_group_add returns an error,
qpair is in uninitialized state and spdk_nvmf_qpair_disconnect
handles this state in a special way, i

nvmf: Clean unassociated_qpairs on connect error

When spdk_nvmf_poll_group_add returns an error,
qpair is in uninitialized state and spdk_nvmf_qpair_disconnect
handles this state in a special way, i.e. we don't decrement
the `group->current_unassociated_qpairs` counter. That is not
a critical error but may lead to uneven qpairs distribution.

Signed-off-by: Alexey Marchuk <alexeymar@nvidia.com>
Change-Id: If68c4c4c8f3a99a690ba15694b5568940a7e0c21
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25012
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvmf: Get metadata config by not bdev but bdev_desc

This is a preparation to enable no_metadata option to each bdev for DIF
insert/strip.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Cha

nvmf: Get metadata config by not bdev but bdev_desc

This is a preparation to enable no_metadata option to each bdev for DIF
insert/strip.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I018ccbdba662fa71489ae9664fc9d41bf79cf7d7
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25412
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvmf: Block ctrlr-only admin cmds if NSID is set

According to NVMe spec rev1.3d, Section4, Figure12:
If admin cmd is not using NSID field - host should set it to 0h.
Otherwise - such command should

nvmf: Block ctrlr-only admin cmds if NSID is set

According to NVMe spec rev1.3d, Section4, Figure12:
If admin cmd is not using NSID field - host should set it to 0h.
Otherwise - such command should be returned with
INVALID FIELD IN COMMAND error.

With recent change that added passthrough command caps
to nvmf - SPDK engine is forwarding all admin commands
with NSID set to the bdev - even the incorrectly formed ones.
For example - commit firmware with NSID set to 1.

Validate if requested command's opcode is using NSID,
Return appropriate error if not - for request with NSID set.

Fixes issue #3564.

Change-Id: Id2fce050eeaf96ff039073f439d6444ecd55c0b3
Signed-off-by: Pawel Baldysiak <pawel.baldysiak@dell.com>
Signed-off-by: Marcin Galecki <marcin.galecki@dell.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25151
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

test: Comparison operator fixes

Change-Id: I1296b19b590c2c6cbb75b9362e441cd6219d7a9f
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2

test: Comparison operator fixes

Change-Id: I1296b19b590c2c6cbb75b9362e441cd6219d7a9f
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25198
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>

show more ...

lib/nvmf: Handle RGO field in ANA log

When RGO is set, we should set the number of namespace ids to 0 and the
list of namespace ids should be empty.

Change-Id: I1c1f6282e261ddf00a7cc40b1f301edf407f

lib/nvmf: Handle RGO field in ANA log

When RGO is set, we should set the number of namespace ids to 0 and the
list of namespace ids should be empty.

Change-Id: I1c1f6282e261ddf00a7cc40b1f301edf407f02b4
Signed-off-by: Alex Michon <amichon@kalrayinc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24872
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvmf: large IU and atomic write unit reporting

Added spdk_nvmf_ctrlr_identify_ns_ext() to request the identify
namespace data and populate performance and atomic operations fields.

Change-Id: Ib809

nvmf: large IU and atomic write unit reporting

Added spdk_nvmf_ctrlr_identify_ns_ext() to request the identify
namespace data and populate performance and atomic operations fields.

Change-Id: Ib809b174e08a4b8a26bbc6d396ff3fb4798fae98
Signed-off-by: Atul Malakar <a.malakar@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24094
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvmf: Identify command supports IOCS NVM NS data structure

Add minimum change to support and verify it by writing unit tests.
We will revisit this feature when we find any OS uses Storage Tag.

Sign

nvmf: Identify command supports IOCS NVM NS data structure

Add minimum change to support and verify it by writing unit tests.
We will revisit this feature when we find any OS uses Storage Tag.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I0a9456d099f8fcf735ed773bec18e82dfbe1112e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24112
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

general: fix misspells and typos

Signed-off-by: Kamil Godzwon <kamilx.godzwon@intel.com>
Change-Id: Iab206ef526eb7032c6681a3145450010c91705a4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+

general: fix misspells and typos

Signed-off-by: Kamil Godzwon <kamilx.godzwon@intel.com>
Change-Id: Iab206ef526eb7032c6681a3145450010c91705a4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24120
Community-CI: Mellanox Build Bot
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

nvmf: Add LBAFEE to Host Behavior Support features

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I910476470b6106b2b9935f208df0292b80f09b87
Reviewed-on: https://review.spdk.io/ge

nvmf: Add LBAFEE to Host Behavior Support features

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I910476470b6106b2b9935f208df0292b80f09b87
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24111
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot

show more ...

nvmf: remove subsystem->zone_append_supported

Instead, use a function to check all namespaces for ZONE_APPEND support.
It ensures that support for ZONE_APPEND isn't listed in command effects
log aft

nvmf: remove subsystem->zone_append_supported

Instead, use a function to check all namespaces for ZONE_APPEND support.
It ensures that support for ZONE_APPEND isn't listed in command effects
log after the last zoned namespace is removed from a subsystem.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I028b8b29471cbe4e4eb2632d76e4cf5716fa9c2a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23438
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvmf: process in-band authentication

The target will request the host to authenticate if its dhchap_key is
set. Until the authentication is completed, any commands besides
AUTHENTICATION_{SEND,RECV

nvmf: process in-band authentication

The target will request the host to authenticate if its dhchap_key is
set. Until the authentication is completed, any commands besides
AUTHENTICATION_{SEND,RECV} will result in an AUTH_REQUIRED error.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I8e68f0b81d841bfdc2e42b8f1bfad00af7058b25
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22656
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvmf: allow commands depending on qpair state

The state of a qpair is now used to determine whether a command is
allowed to execute. This replaces checks testing qpair->ctrlr == NULL
to see if the

nvmf: allow commands depending on qpair state

The state of a qpair is now used to determine whether a command is
allowed to execute. This replaces checks testing qpair->ctrlr == NULL
to see if the CONNECT command has been received. Relying on the state
will make it easy to add checks for more states (e.g. authentication) in
the future.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I49274f3525d4f2fc267cef32a9c68824ea5d4705
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22589
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvmf: add QPAIR_CONNECTING state

A qpair is in this state while it's waiting for the CONNECT command.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I9b14174b634e00838bcbb59b65

nvmf: add QPAIR_CONNECTING state

A qpair is in this state while it's waiting for the CONNECT command.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I9b14174b634e00838bcbb59b6542349bae263405
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22588
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

nvmf: rename QPAIR_ACTIVE -> QPAIR_ENABLED

This state indicates that a qpair has been added to a poll group and can
be used to execute commands. However, in the future, we'll want to add
more fine-

nvmf: rename QPAIR_ACTIVE -> QPAIR_ENABLED

This state indicates that a qpair has been added to a poll group and can
be used to execute commands. However, in the future, we'll want to add
more fine-grained states to track the state of qpair initialization
(e.g. waiting for CONNECT, authentication in progress, etc.), so
QPAIR_ACTIVE is renamed to QPAIR_ENABLED to make it more distinct from
spdk_nvmf_qpair_is_active().

That way, spdk_nvmf_qpair_is_active() can be used to check whether a
qpair is capable of executing commands (i.e. it's equivalent to the old
QPAIR_ACTIVE state), while individual qpair states will provide more
information about the initialization.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I48795fd5a507740222e021249b0e63fff720dfd4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22587
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

nvmf/tcp: register and use trace owners

We now use the new trace owner functionality in the nvmf/tcp layer.

When a tcp qpair is initially created, we will register it as a trace owner,
with a descr

nvmf/tcp: register and use trace owners

We now use the new trace owner functionality in the nvmf/tcp layer.

When a tcp qpair is initially created, we will register it as a trace owner,
with a description that just contains the host's IP/port. Later once the
CONNECT specifies the subsys, we add that and update the description. This
ensures we get meaningful events on a qpair even before the CONNECT is
established.

Now that we are using the owner_id, we no longer need to specify the qpair
pointer as an extra parameter to any of the nvmf/tcp trace events, so remove
them.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I7c01e061106b824ebbc5f12bd556806a1f5788fa
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22650
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

show more ...

nvmf: remove cb_fn/cb_arg from spdk_nvmf_qpair_disconnect()

These were deprecated for a long time, so it's finally time to remove
them.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Chan

nvmf: remove cb_fn/cb_arg from spdk_nvmf_qpair_disconnect()

These were deprecated for a long time, so it's finally time to remove
them.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ia10242b36c3560df4dae8f6bd9fd4ff931179e22
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22945
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot

show more ...

nvmf: per-host namespace masking

This patch introduces namespace masking for NVMe-over-fabrics
targets by allowing to (dynamically) add or remove hosts for a given
namespace on a given subsystem. A

nvmf: per-host namespace masking

This patch introduces namespace masking for NVMe-over-fabrics
targets by allowing to (dynamically) add or remove hosts for a given
namespace on a given subsystem. A host can only
perform operations to a namespace it has been given access.

To preserve current behavior all namespaces are automatically visible.
To control visibility on a per-host basis, the nvmf_subsystem_add_ns RPC
shall be called with "--no-auto-visible". We introduce two new
RPC calls:
- nvmf_ns_add_host <subsysNQN> <NSID> <hostNQN>
- nvmf_ns_remove_host <subsysNQN> <NSID> <hostNQN>
These RPCs apply both to existing and future controllers for the given
subsystem/hostnqn pair.

The list in spdk_nvmf_ns is used to keep track of hostNQNs
which controllers should be attached on connect.

The visible_ns array in spdk_nvmf_ctrlr is used for fast lookup
to check whether a NSID is visible on command execution.

Change-Id: I1c3a3c2bf3615fa76e7bfe3aaf08e2b82d6b4ec0
Signed-off-by: Jonas Pfefferle <pepperjo@japf.ch>
Signed-off-by: Jim Harris <jim.haris@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7821
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvmf: fix admin qpair null dereference

It will happen, for example, when we try to connect an IO qpair after the admin qpair was destroyed.
Currently observed only with ESX initiators.

Signed-off-b

nvmf: fix admin qpair null dereference

It will happen, for example, when we try to connect an IO qpair after the admin qpair was destroyed.
Currently observed only with ESX initiators.

Signed-off-by: Ziv Hirsch <zivhirsch13@gmail.com>
Change-Id: I58617e29241170f0ec3db52e49936c9064a543da
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21167
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

nvmf: allow setting custom handlers for namespace reservation operations

Currently, namespace reservation persistence is enabled by storing the
reservation information in a file. Make it possible to

nvmf: allow setting custom handlers for namespace reservation operations

Currently, namespace reservation persistence is enabled by storing the
reservation information in a file. Make it possible to override the
default behavior by providing custom handlers for reservation
operations.

Change-Id: I247ea2d6cd41ae808030886d70172fad7a04291b
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21360
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot

show more ...

util: add SPDK_IOV_ONE macro

Having that spdk_iov_one fn is marked deprecated. The issue with that
function is that it enforce iovcnt type which might not be of type int
but u32 or u8 etc. Having th

util: add SPDK_IOV_ONE macro

Having that spdk_iov_one fn is marked deprecated. The issue with that
function is that it enforce iovcnt type which might not be of type int
but u32 or u8 etc. Having that compiler would complain when using the
function with other types than int.

It is a pre-work for layout optmz of nvmf request (iovcnt change there
from int to u8).

Change-Id: Id1534f4d3f60d35c58c26e4f4cf0d605ae11398a
Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21433
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

nvmf: set max discard size and max write_zeroes size

For Linux kernel version >= 5.13, when host connects the admin
queue successfully, it will call nvme_init_non_mdts_limits() to
post a NVME_ID_CNS

nvmf: set max discard size and max write_zeroes size

For Linux kernel version >= 5.13, when host connects the admin
queue successfully, it will call nvme_init_non_mdts_limits() to
post a NVME_ID_CNS_CS_CTRL identify cmd and init max discard size
with dmrl, dmrsl and max write_zeroes size with wzsl in response.

So we add the NVME_ID_CNS_CS_CTRL identify cmd handler in the nvmf
target side and add two new parameters to RPC nvmf_create_subsystem.

Change-Id: Ib72d6caa34fced68d63df9c01760a58effa5ca34
Signed-off-by: Haoqian He <haoqian.he@smartx.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19632
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

lib/nvmf: TP 8014 - Current Discovery Subsystem

Added support for the Current Discovery Subsystem
value of the Subsystem Type in the Discovery
Log Page Entry.

Change introduced in TP 8014

Change-I

lib/nvmf: TP 8014 - Current Discovery Subsystem

Added support for the Current Discovery Subsystem
value of the Subsystem Type in the Discovery
Log Page Entry.

Change introduced in TP 8014

Change-Id: I9a35ba24ecfdc2bbcc81baae80575e37ae1a866d
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19839
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

nvmf: remove req->data field

Now all code has been adapted to use req->iov, and the deprecation
period has elapsed, remove the legacy ->data field altogether, along
with spdk_nvmf_request_get_data()

nvmf: remove req->data field

Now all code has been adapted to use req->iov, and the deprecation
period has elapsed, remove the legacy ->data field altogether, along
with spdk_nvmf_request_get_data().

Signed-off-by: John Levon <john.levon@nutanix.com>
Change-Id: I22db8a7d8e086d9bcba3e784bf9dd19da147470f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16201
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@gmail.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

test/unit: use spdk_ut_run_tests()

Replaced direct calls to the CUnit's functions to run the tests with
spdk_ut_run_tests(). That way, each test will have the ability to run
a specific test case.

test/unit: use spdk_ut_run_tests()

Replaced direct calls to the CUnit's functions to run the tests with
spdk_ut_run_tests(). That way, each test will have the ability to run
a specific test case.

The blob.c unit test wasn't changed, because it runs all tests multiple
times with different parameter combinations, so it cannot be easily
converted. In the future, each such combination could be split into a
separate test suite, which would make it compatible with
spdk_ut_run_tests().

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I4463f808f89844e9bf32b5b31eda197c5d729d1d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19288
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

test/unit: move spdk_cunit.h to include/spdk_internal

It'll make it easier to include this file outside of unit tests.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I171ddb864

test/unit: move spdk_cunit.h to include/spdk_internal

It'll make it easier to include this file outside of unit tests.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I171ddb8649f67b5786f08647560e2907603d0574
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19284
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...