test/unit: add mixed busy/idle mock poller function in reactor_ut

Change-Id: I054b58c7b2734ab1ec279df4a0e565bfe2abf0bc
Signed-off-by: Anisa Su <anisa.su@samsung.com>
Reviewed-on: https://review.spdk

test/unit: add mixed busy/idle mock poller function in reactor_ut

Change-Id: I054b58c7b2734ab1ec279df4a0e565bfe2abf0bc
Signed-off-by: Anisa Su <anisa.su@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24794
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

test/unit: update poller_run_idle/busy return values to use correct enum
in reactor_ut

Change-Id: Ic4565fcf41e12f5f6b791f09dd4ed06296028b6d
Signed-off-by: Anisa Su <anisa.su@samsung.com>
Reviewed-on

test/unit: update poller_run_idle/busy return values to use correct enum
in reactor_ut

Change-Id: Ic4565fcf41e12f5f6b791f09dd4ed06296028b6d
Signed-off-by: Anisa Su <anisa.su@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24914
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

test/unit: clean reactor_ut memory leak

Change-Id: I3b519332e930cf8751882f055fdc4fa4b27d457c
Signed-off-by: Anisa Su <anisa.su@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2

test/unit: clean reactor_ut memory leak

Change-Id: I3b519332e930cf8751882f055fdc4fa4b27d457c
Signed-off-by: Anisa Su <anisa.su@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24802
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

init: remove spdk_subsystem_init_from_json_config

This was deprecated and marked for removal in v24.09 release, so it
is time to remove it.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change

init: remove spdk_subsystem_init_from_json_config

This was deprecated and marked for removal in v24.09 release, so it
is time to remove it.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Ib76e7acd61c4067711be1a7c22aa0b43aba04f4f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24664
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

test/unit: Add unit test for scheduler_set_isolated_core_mask

Change-Id: Iacd606ed649486d3452299a5e5cffc113a532afc
Signed-off-by: SeungYeon Shin <syeon.shin@samsung.com>
Reviewed-on: https://review.

test/unit: Add unit test for scheduler_set_isolated_core_mask

Change-Id: Iacd606ed649486d3452299a5e5cffc113a532afc
Signed-off-by: SeungYeon Shin <syeon.shin@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23146
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

show more ...

lib/event: Modify spdk_reactor_set_interrupt_mode() to be called from scheduling reactor

The previous behavior of spdk_reactor_set_interrupt_mode()
returning an error when called from a non-app_thre

lib/event: Modify spdk_reactor_set_interrupt_mode() to be called from scheduling reactor

The previous behavior of spdk_reactor_set_interrupt_mode()
returning an error when called from a non-app_thread context
has been changed to return an error when called from a
non-scheduling reactor context. As a result,
spdk_reactor_set_interrupt_mode() must now be executed from a
scheduling core rather than an app thread. Modifications have
been made to address instances where this requirement was not met.

There is no issue when the app thread operates on the scheduling
core, but if it runs on a different core, changing the interrupt
mode will result in an error stating that it can only be modified
on the scheduling core. This could cause scheduling operations
to malfunction. To address this, modifications have been made.

Change-Id: I1f73c84191f5cab877a29405756f106cfb410932
Signed-off-by: syeon.shin <syeon.shin@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24324
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

event: do not call reactor events from spdk_thread context

There are no remaining events that require running in an spdk_thread
context, so remove that code so that spdk_events are explicitly *not*

event: do not call reactor events from spdk_thread context

There are no remaining events that require running in an spdk_thread
context, so remove that code so that spdk_events are explicitly *not*
called from an spdk_thread context.

This is the desired behavior, there should be a clear delineation between
reactor context and spdk_thread context, and this change ensures that we
can send events that will not be run in an spdk_thread context.

So now spdk_reactor_set_interrupt_mode() checks that it was called on the
scheduling reactor, and not from the context of an spdk_thread.

This also requires changing the interrupt_tgt's reactor_set_interrupt_mode
RPC that is used for testing purposes. That RPC would just call
spdk_reactor_set_interrupt_mode() from its spdk_thread context, but
we need to use spdk_event_call() instead so that it gets called from
reactor context.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Signed-off-by: syeon.shin <syeon.shin@samsung.com>
Change-Id: Iadfae6f0943ad77076ffb8e81e5154d998e7a6f4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23261
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

event: don't NOTICELOG when no RPC server started

This message will be confusing to new users - so make it a DEBUGLOG
instead.

If user specified an RPC listen address that cannot be opened, we
will

event: don't NOTICELOG when no RPC server started

This message will be confusing to new users - so make it a DEBUGLOG
instead.

If user specified an RPC listen address that cannot be opened, we
will exit with error now, so this message should just be removed.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I17d57ce0cca6d82ef9b883a99041a0c3f87a59d9
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22814
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot

show more ...

lib/event: remove outdated opts

Remove some deprecated opts and comments around opts.

Change-Id: Ic081a53908720ee79494d0cfc29f74f8b54591b1
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>

lib/event: remove outdated opts

Remove some deprecated opts and comments around opts.

Change-Id: Ic081a53908720ee79494d0cfc29f74f8b54591b1
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21997
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

lib/init: Add new API to load JSON config

Add a new function to carry out loading JSON configuration per rpc
state. This API takes raw JSON data and its size to avoid reading
the same file multiple

lib/init: Add new API to load JSON config

Add a new function to carry out loading JSON configuration per rpc
state. This API takes raw JSON data and its size to avoid reading
the same file multiple times inside lib/init, which is problematic
in cases where subsystem configuration is piped to SPDK
(e.g. program substitution), because reading bytes from such a file
object consumes them. The user calling this function will be
responsible for managing JSON configuration file.

Change-Id: I6e369b8dba1cb8fe7449142e5028bba841477d2d
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21194
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

init: add pausing and resuming RPC server polling

Add APIs to pause and resume polling on specified server address.
This will be useful in following patches, where one RPC server is
launched for use

init: add pausing and resuming RPC server polling

Add APIs to pause and resume polling on specified server address.
This will be useful in following patches, where one RPC server is
launched for user interaction (e.g. via rpc.py script) and other
will start to configure subsystems from JSON config.

Change-Id: I08ce0107a59e50c5c83a49fcd34109584819fd85
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21193
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

lib/init: manage multiple RPC servers

RPC library now encapsulates RPC server specific data, so it is
possible to run multiple servers at the same time. To utilize that
in init poll each server that

lib/init: manage multiple RPC servers

RPC library now encapsulates RPC server specific data, so it is
possible to run multiple servers at the same time. To utilize that
in init poll each server that was launched through this library and
tie registering/unregistering of the poller to the existence of at
least one RPC server.

Modifications to existing APIs' behavior:
* spdk_rpc_initialize() launches a new server instead of
overwriting existing one,
* spdk_rpc_finish() stops all existing servers instead of
stopping a single, global server instance,

Addition of new API:
* spdk_rpc_server_finish() will stop a server listening
on a given address (if it exists).

Change-Id: I9c794e31f7ee27eb5607925b6c7a8446387670b7
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21080
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot

show more ...

init: Add options to spdk_rpc_initialize() for log_file/level params

Add log_file and log_level parameters to spdk_rpc_initialize() via a
new options structure spdk_rpc_opts.

spdk_rpc_initialize()

init: Add options to spdk_rpc_initialize() for log_file/level params

Add log_file and log_level parameters to spdk_rpc_initialize() via a
new options structure spdk_rpc_opts.

spdk_rpc_initialize() calls spdk_jsonrpc_set_log_file() and
_set_log_level() with these parameters.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I084ed5b76849e06ab3419a115234d2d9b44f820b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18830
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

test/unit: remove unused stubs

It seems that these stubs were not used.

Signed-off-by: Pierre Lestringant <plestringant@kalray.eu>
Change-Id: I8ce423ca3448db34be7cdfc1920d53be66b9ca82
Reviewed-on:

test/unit: remove unused stubs

It seems that these stubs were not used.

Signed-off-by: Pierre Lestringant <plestringant@kalray.eu>
Change-Id: I8ce423ca3448db34be7cdfc1920d53be66b9ca82
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18474
Reviewed-by: Jim Harris <jim.harris@gmail.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

test/unit: use posix_memalign() to allocate reactor

As mentioned in 771a7b879, there seems to be a bug with gcc and asan
where it doesn't properly align structures declared on the stack.

It also lo

test/unit: use posix_memalign() to allocate reactor

As mentioned in 771a7b879, there seems to be a bug with gcc and asan
where it doesn't properly align structures declared on the stack.

It also looks like declaring the variable with the aligned attribute
doesn't work either, so just use posix_memalign() to work around this.

Fixes #3004.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I4af902af0384cbd429334433c291ead23eba8293
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18855
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Kamil Godzwon <kamilx.godzwon@intel.com>

show more ...

test/unit: use spdk_ut_run_tests()

Replaced direct calls to the CUnit's functions to run the tests with
spdk_ut_run_tests(). That way, each test will have the ability to run
a specific test case.

test/unit: use spdk_ut_run_tests()

Replaced direct calls to the CUnit's functions to run the tests with
spdk_ut_run_tests(). That way, each test will have the ability to run
a specific test case.

The blob.c unit test wasn't changed, because it runs all tests multiple
times with different parameter combinations, so it cannot be easily
converted. In the future, each such combination could be split into a
separate test suite, which would make it compatible with
spdk_ut_run_tests().

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I4463f808f89844e9bf32b5b31eda197c5d729d1d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19288
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

test/unit: move spdk_cunit.h to include/spdk_internal

It'll make it easier to include this file outside of unit tests.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I171ddb864

test/unit: move spdk_cunit.h to include/spdk_internal

It'll make it easier to include this file outside of unit tests.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I171ddb8649f67b5786f08647560e2907603d0574
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19284
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

test/unit/event: explicitly align reactor on stack

This seems to be a bug in Fedora 38 gcc - if struct
is declared with alignment, then it should get
allocated with alignment on stack.

But work aro

test/unit/event: explicitly align reactor on stack

This seems to be a bug in Fedora 38 gcc - if struct
is declared with alignment, then it should get
allocated with alignment on stack.

But work around it for now by explicitly declaring
the variable as aligned.

Fixes issue #3004.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: I52d6051815ea55c67f5c0a27648a108c232013e5
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18214
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

lib/thread: add func to not reschedule spdk_thread

spdk_thread_bind is used to bind it to its current CPU core.
spdk_thread_is_bound will return whether spdk_thread is bound.

Signed-off-by: Yifan B

lib/thread: add func to not reschedule spdk_thread

spdk_thread_bind is used to bind it to its current CPU core.
spdk_thread_is_bound will return whether spdk_thread is bound.

Signed-off-by: Yifan Bian <yifan.bian@intel.com>
Signed-off-by: Liu, Xiaodong <xiaodong.liu@intel.com>
Change-Id: I7b63c824257df8bee5e2cc8810f46539b42e3b8d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15102
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>

show more ...

thread: use spdk_thread_get_app_thread instead of _spdk_get_app_thread

Signed-off-by: Ziv Hirsch <zivhirsch13@gmail.com>
Change-Id: I68754dcd9c87e9f9a595f134de345d42e7d09e70
Reviewed-on: https://rev

thread: use spdk_thread_get_app_thread instead of _spdk_get_app_thread

Signed-off-by: Ziv Hirsch <zivhirsch13@gmail.com>
Change-Id: I68754dcd9c87e9f9a595f134de345d42e7d09e70
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16783
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...