|
Revision tags: v24.05, v24.09-pre, v24.05-rc1, LTS, v24.01, v24.05-pre, v24.01-rc1, v23.09, v24.01-pre, v23.09-rc1, v23.05, v23.09-pre, v23.01.1, v23.01, v23.05-pre, v23.01-rc1, v22.01.2 |
|
| #
eb53c232 |
| 02-Nov-2022 |
paul luse <paul.e.luse@intel.com> |
add (c) and SPDX header to bash files as needed
per Intel policy to include file commit date using git cmd below. The policy does not apply to non-Intel (C) notices.
git log --follow -C90% --forma
add (c) and SPDX header to bash files as needed
per Intel policy to include file commit date using git cmd below. The policy does not apply to non-Intel (C) notices.
git log --follow -C90% --format=%ad --date default <file> | tail -1
and then pull just the year from the result.
Intel copyrights were not added to files where Intel either had no contribution ot the contribution lacked substance (ie license header updates, formatting changes, etc)
For intel copyrights added, --follow and -C95% were used.
Signed-off-by: paul luse <paul.e.luse@intel.com> Change-Id: I2ef86976095b88a9bf5b1003e59f3943cd6bbe4c Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15209 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
show more ...
|
|
Revision tags: v22.09, v23.01-pre, v22.09-rc1 |
|
| #
29784f35 |
| 06-Sep-2022 |
Krzysztof Karas <krzysztof.karas@intel.com> |
bdevperf: promote bdevperf from test to example application
bdevperf application is utilized in multiple test scenarios and most prominently in SPDK performance reports. Similar to perf and fio_plug
bdevperf: promote bdevperf from test to example application
bdevperf application is utilized in multiple test scenarios and most prominently in SPDK performance reports. Similar to perf and fio_plugins, it is used to measure performance. It is intended to represent the expected behavior of users application that use SPDK bdev layer.
Applications under --enable-tests are intended for specific test scenarios and user interaction is usually via a test scripts. Meanwhile --enable-examples are used more broadly to teach and show usage of SPDK libraries.
As an added benefit with this patch, its possible to compile bdevperf without need to satisfy additional requirements to compile all the test applications.
Change-Id: I9aaec1f9d729a1cdee89b5fdc365d61c19b03f82 Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14558 Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot
show more ...
|
| #
0af934b3 |
| 20-Oct-2022 |
Krzysztof Karas <krzysztof.karas@intel.com> |
event: add CPU lock files
When running SPDK application on a given set of CPU cores, create lock files for each of them. This wil prevent user misconfiguration and assigning a core to more than one
event: add CPU lock files
When running SPDK application on a given set of CPU cores, create lock files for each of them. This wil prevent user misconfiguration and assigning a core to more than one SPDK instance.
The introduced mechanism is based on device locks implemented in spdk_pci_device_claim() function.
Add a command line option to disable lock files. This feature will be useful in cases where differing CPU cores is impossible (eg. setup with only one core available).
The patch also fixes all existing cases of overlapping core masks.
Change-Id: Ie9aacb7523a3597b9aa20f2c3fa9efe4db92c44c Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14919 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
show more ...
|
| #
eaebf841 |
| 02-Jun-2022 |
Krzysztof Karas <krzysztof.karas@intel.com> |
autotest_common.sh: change rpc_py to rpc_cmd
Change rpc_py to use rpc_cmd function. The former needs to be defined explicitly in the scripts that uses function, while the latter is a function alread
autotest_common.sh: change rpc_py to rpc_cmd
Change rpc_py to use rpc_cmd function. The former needs to be defined explicitly in the scripts that uses function, while the latter is a function already available in autotest_common.sh. Additionally delete unnecessary rpc_py declarations and override rpc_cmd where additional arguments are needed (like -s sock_name.sock).
Change-Id: I835f7eb308cd77658a2a425e153ab7ca460b5b61 Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12872 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
show more ...
|
|
Revision tags: v22.05, v22.09-pre, v22.05-rc1, v22.01.1, v22.01, v22.01-rc1, v21.10, v21.10-rc1, v21.07, v21.07-rc1, v21.04, v21.04-rc1, v21.01.1, v21.01, v21.01-rc1, v20.10, v20.10-rc1, v20.07 |
|
| #
f6fcba38 |
| 30-Jul-2020 |
Tomasz Zawadzki <tomasz.zawadzki@intel.com> |
test/nvmf: only disable test cases in top-level script
Some of the tests are skipped when using Soft-RoCE. Test executed as part of run_test should never skip a test, as it results in false assumpti
test/nvmf: only disable test cases in top-level script
Some of the tests are skipped when using Soft-RoCE. Test executed as part of run_test should never skip a test, as it results in false assumption that it was executed. See supplemental logs in CI output.
Before this patch bdevperf and srq_overwhelm (if executed), resulted in misreporting this.
This patch moves all check for Soft-RoCE to top-level nvmf test script.
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Change-Id: I6d8941bbadaca2dbf8ab178e30e87d3786fea94c Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3597 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
show more ...
|
| #
31d22408 |
| 30-Jul-2020 |
Tomasz Zawadzki <tomasz.zawadzki@intel.com> |
test/nvmf: only check for rxe when testing RDMA
Using Soft-RoCE is only relevant when testing RDMA transport. For all other cases, we might treat the IP address as non-rxe.
This simplifies the chec
test/nvmf: only check for rxe when testing RDMA
Using Soft-RoCE is only relevant when testing RDMA transport. For all other cases, we might treat the IP address as non-rxe.
This simplifies the checks a little bit in couple places.
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Change-Id: I996afb364070fbe107bbe97207952f99e4089308 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3596 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
show more ...
|
|
Revision tags: v20.07-rc1, v20.04.1, v20.01.2, v20.04 |
|
| #
8cc72fe4 |
| 28-Apr-2020 |
Michal Berger <michalx.berger@intel.com> |
test/nvmf: Handle multiple arguments in nvmfappstart()
Change-Id: Ibc75320b2de8885125e0835ead9e208fcace976d Signed-off-by: Michal Berger <michalx.berger@intel.com> Reviewed-on: https://review.spdk.i
test/nvmf: Handle multiple arguments in nvmfappstart()
Change-Id: Ibc75320b2de8885125e0835ead9e208fcace976d Signed-off-by: Michal Berger <michalx.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2092 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
show more ...
|
| #
844c8ec3 |
| 07-May-2020 |
Michal Berger <michalx.berger@intel.com> |
check_format: Reformat the Bash code in compliance with shfmt
Change-Id: I93e7b9d355870b0528a0ac3382fba1a10a558d45 Signed-off-by: Michal Berger <michalx.berger@intel.com> Reviewed-on: https://review
check_format: Reformat the Bash code in compliance with shfmt
Change-Id: I93e7b9d355870b0528a0ac3382fba1a10a558d45 Signed-off-by: Michal Berger <michalx.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1718 Community-CI: Mellanox Build Bot Reviewed-by: Karol Latecki <karol.latecki@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
show more ...
|
|
Revision tags: v20.04-rc1, v20.01.1 |
|
| #
1f7d7a78 |
| 18-Mar-2020 |
Michal Berger <michalx.berger@intel.com> |
test/nvmf: Drop .ini config in favor of json
Change-Id: I08e8c124258bc95603bd6e954944eb66bde4f31b Signed-off-by: Michal Berger <michalx.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c
test/nvmf: Drop .ini config in favor of json
Change-Id: I08e8c124258bc95603bd6e954944eb66bde4f31b Signed-off-by: Michal Berger <michalx.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1378 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
show more ...
|
|
Revision tags: v20.01 |
|
| #
e0f63b96 |
| 29-Jan-2020 |
Seth Howell <seth.howell@intel.com> |
test/nvmf: disable bdevperf tests on soft-roce
Github issue 1165 details some issues we have with soft-roce and these tests. Right now we are disabling them for build stability.
Change-Id: I3a9e28f
test/nvmf: disable bdevperf tests on soft-roce
Github issue 1165 details some issues we have with soft-roce and these tests. Right now we are disabling them for build stability.
Change-Id: I3a9e28ff3cc1c6ac7d9aa91d93541e295514bb7b Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/483300 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Alexey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Community-CI: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com> Community-CI: SPDK CI Jenkins <sys_sgci@intel.com>
show more ...
|
|
Revision tags: v20.01-rc1, v19.10.1 |
|
| #
1fafd71b |
| 04-Dec-2019 |
Seth Howell <seth.howell@intel.com> |
test: add timing calls to run_test
And clean out the corresponding calls to timing_enter and timing_exit from the various test scripts.
Change-Id: I0759417b5a529e4c3649ce04cca1799c089da278 Signed-o
test: add timing calls to run_test
And clean out the corresponding calls to timing_enter and timing_exit from the various test scripts.
Change-Id: I0759417b5a529e4c3649ce04cca1799c089da278 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/476804 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Community-CI: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com>
show more ...
|
| #
a816afaa |
| 08-Nov-2019 |
Seth Howell <seth.howell@intel.com> |
bdev_nvme: check for admin queue failures.
This will allow us to reset the controller when we get disconnect events from the underying transports.
Change-Id: I825985219f98ff65cfcf7581757bd26db5bd08
bdev_nvme: check for admin queue failures.
This will allow us to reset the controller when we get disconnect events from the underying transports.
Change-Id: I825985219f98ff65cfcf7581757bd26db5bd08ba Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/473762 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
show more ...
|
| #
d115518b |
| 08-Nov-2019 |
Seth Howell <seth.howell@intel.com> |
test/nvmf: use nvmfappstart in bdevperf.
just a little cleanup.
This patch series is aimed at enabling reset handling in the spdk nvme bdev module and demonstrating how it will work using a test in
test/nvmf: use nvmfappstart in bdevperf.
just a little cleanup.
This patch series is aimed at enabling reset handling in the spdk nvme bdev module and demonstrating how it will work using a test in bdevperf.
Change-Id: I1f9108aa2e6f197c8e1c138f0e3205d78fa89dce Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/473760 Community-CI: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
show more ...
|
|
Revision tags: v19.10, v19.10-rc1, v19.07.1 |
|
| #
19baaa9a |
| 23-Sep-2019 |
Maciej Wawryk <maciejx.wawryk@intel.com> |
RPC: rename delete_nvmf_subsystem to nvmf_delete_subsystem
Signed-off-by: Maciej Wawryk <maciejx.wawryk@intel.com> Change-Id: I4654f254cae78b0def789b13754af7c70c73dabb Reviewed-on: https://review.ge
RPC: rename delete_nvmf_subsystem to nvmf_delete_subsystem
Signed-off-by: Maciej Wawryk <maciejx.wawryk@intel.com> Change-Id: I4654f254cae78b0def789b13754af7c70c73dabb Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/469111 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
show more ...
|
| #
7538af70 |
| 20-Sep-2019 |
Maciej Wawryk <maciejx.wawryk@intel.com> |
RPC: rename nvmf_subsystem_create to nvmf_create_subsystem
Signed-off-by: Maciej Wawryk <maciejx.wawryk@intel.com> Change-Id: Ic3aa9f168b2e612e461c450ef1e5e1ae81fa5635 Reviewed-on: https://review.ge
RPC: rename nvmf_subsystem_create to nvmf_create_subsystem
Signed-off-by: Maciej Wawryk <maciejx.wawryk@intel.com> Change-Id: Ic3aa9f168b2e612e461c450ef1e5e1ae81fa5635 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/468963 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
show more ...
|
| #
7964f1df |
| 09-Aug-2019 |
Pawel Kaminski <pawelx.kaminski@intel.com> |
scripts/rpc: Change rpc construct_malloc_bdev to bdev_malloc_create
This is patch that implements changes according to proposal submitted in https://review.gerrithub.io/c/spdk/spdk/+/453036
Change-
scripts/rpc: Change rpc construct_malloc_bdev to bdev_malloc_create
This is patch that implements changes according to proposal submitted in https://review.gerrithub.io/c/spdk/spdk/+/453036
Change-Id: I5423cd34cb5fc111b34cab2b7f7c6c5f11898af8 Signed-off-by: Pawel Kaminski <pawelx.kaminski@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/464677 Reviewed-by: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
show more ...
|
| #
90c84ec5 |
| 09-Aug-2019 |
Karol Latecki <karol.latecki@intel.com> |
test: use single quotes in trap instruction
Fix SC2064 issue. Use single quotes, otherwise trap expands now rather than when signalled.
Change-Id: I0b3a9157f52eed037e8d217f639c64d6876ec1e1 Signed-o
test: use single quotes in trap instruction
Fix SC2064 issue. Use single quotes, otherwise trap expands now rather than when signalled.
Change-Id: I0b3a9157f52eed037e8d217f639c64d6876ec1e1 Signed-off-by: Karol Latecki <karol.latecki@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/464655 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Pawel Kaminski <pawelx.kaminski@intel.com>
show more ...
|
|
Revision tags: v19.07 |
|
| #
015ef22a |
| 15-Jul-2019 |
Seth Howell <seth.howell@intel.com> |
test/nvmf: add NVMF_TRANSPORT_OPTS global
For a lot of the tests, we may want to specify different options for each transport. I believe this will be more prevalent as we add more transport specific
test/nvmf: add NVMF_TRANSPORT_OPTS global
For a lot of the tests, we may want to specify different options for each transport. I believe this will be more prevalent as we add more transport specific options.
Change-Id: I83a915629460d1d869eaba4bc86822d7563402ac Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/461740 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
show more ...
|
|
Revision tags: v19.04.1 |
|
| #
887aff4d |
| 10-Jun-2019 |
Darek Stojaczyk <dariusz.stojaczyk@intel.com> |
test: remove duplicated `set -ex` from tests
It's always set in autotest_common.sh, there's no need to set it again in each test script.
Change-Id: Ib14c4189c553dad54a3065c1a1d413a5fc5a5347 Signed-
test: remove duplicated `set -ex` from tests
It's always set in autotest_common.sh, there's no need to set it again in each test script.
Change-Id: Ib14c4189c553dad54a3065c1a1d413a5fc5a5347 Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/457466 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
show more ...
|
| #
aa7a1398 |
| 03-Jun-2019 |
Jim Harris <james.r.harris@intel.com> |
test/nvmf: use TEST_TRANSPORT instead of 'rdma'
This prepares for using scripts for tcp testing as well. Note that this patch just hardcoded TEST_TRANSPORT to 'rdma' for now. An upcoming patch will
test/nvmf: use TEST_TRANSPORT instead of 'rdma'
This prepares for using scripts for tcp testing as well. Note that this patch just hardcoded TEST_TRANSPORT to 'rdma' for now. An upcoming patch will require the caller to pass --transport=rdma instead.
Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I085fdf51910aaf960959c71c73a187be41fd7ee8
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/456667 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
show more ...
|
| #
cddfe002 |
| 03-Jun-2019 |
Jim Harris <james.r.harris@intel.com> |
test/nvmf: use NVMF_PORT consistently
A lot of places were still hardcoding 4420 directly.
Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Iff8a549addeb05e441fe3b035a84a0f8a6bf2205
test/nvmf: use NVMF_PORT consistently
A lot of places were still hardcoding 4420 directly.
Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Iff8a549addeb05e441fe3b035a84a0f8a6bf2205
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/456666 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
show more ...
|
| #
d0201cb1 |
| 03-Jun-2019 |
Jim Harris <james.r.harris@intel.com> |
test/nvmf: remove NVMF_FIRST_TARGET_IP duplication from host tests
These scripts already call nvmftestinit which sets up the NVMF_FIRST_TARGET_IP variable.
Signed-off-by: Jim Harris <james.r.harris
test/nvmf: remove NVMF_FIRST_TARGET_IP duplication from host tests
These scripts already call nvmftestinit which sets up the NVMF_FIRST_TARGET_IP variable.
Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Id732e2e7c981bf557518489776aaacebeeecdfa8
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/456652 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
show more ...
|
| #
6a8a1b6b |
| 23-May-2019 |
Jim Harris <james.r.harris@intel.com> |
test: always parse common script args
Good suggestion from Darek - let's just always parse common script args from autotest_common.sh. These arguments follow common arg naming conventions (i.e. --is
test: always parse common script args
Good suggestion from Darek - let's just always parse common script args from autotest_common.sh. These arguments follow common arg naming conventions (i.e. --iso) so there's no harm just doing this for any test that sources autotest_common.sh. This has the nice effect of not requiring scripts to explicitly call this function.
Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Id89b68c22557a5a771be407873d0e57843f0d05a
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/455552 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
show more ...
|
| #
390b3641 |
| 16-May-2019 |
Jim Harris <james.r.harris@intel.com> |
test: add parse_common_script_args function
iscsi test scripts can now take two arguments - "iso" and then the sock type (posix or vpp). They need to be in that specific order too. nvmf test scrip
test: add parse_common_script_args function
iscsi test scripts can now take two arguments - "iso" and then the sock type (posix or vpp). They need to be in that specific order too. nvmf test scripts also support "iso" and we want to add the transport type (rdma or tcp) as well. Even further out, we may want to use a sock type for nvmf, i.e. tcp transport with vpp.
We also have the iscsi_tgt fio_remove_nvme.sh test that does both iscsi and nvmf.
So to make this all work a bit nicer, add a new function called parse_common_script_args that will take the command line arguments to a script and set the appropriate variables, including defaults when a specific parameter isn't specified. We will use getopt-like behavior for this also, instead of enforcing a specific parameter order. Then a script could be called like this:
test/nvmf/target/shutdown.sh --iso --transport=tcp --sock=vpp
Individual test scripts then just need to do this after sourcing autotest_common.sh:
parse_common_script_args $@
Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Ifb8d7666384991482a2d425e26ffa7525b9ac15a
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/455283 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
show more ...
|
| #
d96abc9f |
| 16-May-2019 |
Jim Harris <james.r.harris@intel.com> |
test/nvmf: remove -p num_queues restrictions
There's a bug in Linux 5.1 (possibly 5.0 too) where the kernel initiator driver crashes if it can't get one queue per CPU. This will get fixed eventuall
test/nvmf: remove -p num_queues restrictions
There's a bug in Linux 5.1 (possibly 5.0 too) where the kernel initiator driver crashes if it can't get one queue per CPU. This will get fixed eventually, but for now we need to remove the cases where we restrict the number of queues per controller so that we can test on newer kernels.
Even on cases where we're testing the SPDK initiator, there's no real need to restrict the number of queue pairs.
The kernel will eventually get fixed, but we should be testing with default behavior anyways (the kernel wants lots of queues). We'll also want to add some regression tests to make sure the kernel doesn't break again. But that will all come later.
Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I9979e6d94456e075688b822b042936b63e518a4a
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/454819 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
show more ...
|