test/nvmf: Tweak nvme_connect()

Make sure nvme-cli doesn't write anything to stdout since that's
where the function returns ctrl devices. In newer releases of
nvme-cli (e.g. 2.8), the following prom

test/nvmf: Tweak nvme_connect()

Make sure nvme-cli doesn't write anything to stdout since that's
where the function returns ctrl devices. In newer releases of
nvme-cli (e.g. 2.8), the following prompt is written to stdout
upon successful connect:

connecting to device: nvme0

Explicitly return from the function with proper status.

Change-Id: Ic33c99eb3eabb7a69893596b9cde1a8ab91e2d03
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25410
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>

show more ...

nvmf: use bdev's nsid for admin command passthru

The ID of a namespace exposed by an NVMe-oF subsystem can differ from
the nsid of the underlying namespace that backs a given bdev. For
instance, th

nvmf: use bdev's nsid for admin command passthru

The ID of a namespace exposed by an NVMe-oF subsystem can differ from
the nsid of the underlying namespace that backs a given bdev. For
instance, the following:

$ scripts/rpc.py bdev_nvme_attach_controller -b nvme0 ...
nvme0n1
nvme0n2
$ scripts/rpc.py nvmf_subsystem_add_ns -n 2 nqn nvme0n1
$ scripts/rpc.py nvmf_subsystem_add_ns -n 1 nqn nvme0n2

results in nvme0n1 being exposed with nsid=2, while nvme0n2 with nsid=1.
In this scenario, admin commands targeting a namespace (e.g. identify
namespace) would get sent to the wrong namespace.

Fixes: 05632afd77dd ("nvmf: large IU and atomic write unit reporting")
Reported-by: Maciej Szulik <maciej.szulik@intel.com>
Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ib4f7071afb10691c88def880fadc5f4d7e134b07
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25364
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Maciej Szulik <maciej.szulik@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot

show more ...

test/nvmf: Clarify comment about lack of support for iWARP in tests

Change-Id: I3179df3c9edb89b7c15f5788df9d18dc4d982ea4
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://r

test/nvmf: Clarify comment about lack of support for iWARP in tests

Change-Id: I3179df3c9edb89b7c15f5788df9d18dc4d982ea4
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25190
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

nvmf: clear visible_ns flag when no_auto_visible is unset

This ensures that these flags are always set correctly and aren't
affected by prior calls to spdk_nvmf_subsystem_add_ns_ext().

Fixes: #3544

nvmf: clear visible_ns flag when no_auto_visible is unset

This ensures that these flags are always set correctly and aren't
affected by prior calls to spdk_nvmf_subsystem_add_ns_ext().

Fixes: #3544

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I3d4f8bc822841ac788eceb1e271b474c59dc2045
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25244
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>

show more ...

bdev/nvme: ctrl config consistency check

All controllers created with the same name shall be configured either
for multipath or for failover. Otherwise we have configuration mismatch.
This patch add

bdev/nvme: ctrl config consistency check

All controllers created with the same name shall be configured either
for multipath or for failover. Otherwise we have configuration mismatch.
This patch adds cofiguration consistency check, and all controllers
created with the same name will be forced to have consistent setting,
either '-x multipath' or '-x failover'. No mixing of '-x' options is
allowed.
Deprecation warning has been removed as we are now implementing the
advertised change.

Change-Id: I1bc472f95950e4326ca67bed33a1bf9523683843
Signed-off-by: Marcin Spiewak <marcin.spiewak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25028
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

test/nvmf: add ConnectX-6 (w/o Dx) to list of RDMA devices

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I3013f9b2242eabd023fdc6f4db8302f1c2be95fe
Reviewed-on: https://review.spdk.io

test/nvmf: add ConnectX-6 (w/o Dx) to list of RDMA devices

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I3013f9b2242eabd023fdc6f4db8302f1c2be95fe
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25070
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

show more ...

test/nvmf: disable nvmf_shutdown_tc4 on e810

Temporarily disable this test due to issue #3523.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I5efd588c516cc40effa2ced63e5f3d24d

test/nvmf: disable nvmf_shutdown_tc4 on e810

Temporarily disable this test due to issue #3523.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I5efd588c516cc40effa2ced63e5f3d24d0d3daf2
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24996
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Michal Berger <michal.berger@intel.com>

show more ...

test/nvmf: Make sure crashes are not ignored in nvmf_shutdown_tc*

Change-Id: I97151f955fa6fd3077679fbb65b595ecae8e40d7
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://rev

test/nvmf: Make sure crashes are not ignored in nvmf_shutdown_tc*

Change-Id: I97151f955fa6fd3077679fbb65b595ecae8e40d7
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24848
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

bdev/nvme: add method for changing DH-HMAC-CHAP keys

This method will change the keys on all multipath controllers and force
reauthentication on all qpairs. The high level flow looks like this:

1

bdev/nvme: add method for changing DH-HMAC-CHAP keys

This method will change the keys on all multipath controllers and force
reauthentication on all qpairs. The high level flow looks like this:

1) Set the keys on the first multipath controller.
2) Authenticate admin qpair.
3) Go over all IO channels and authenticate IO qpairs on each one.
4) If there's no next multipath controller, we're done, otherwise set
keys on that controller and go to 2).

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Iec0de19f1a9326cf32c9b27acaab117100616770
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24236
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

show more ...

sock/posix: fix busy poller in the interrupt mode

Setting EPOLLOUT flag makes the epoll_wait exit immidiately on the
tqpair socket as it's always ready for the write operation.
This was a bad fix fo

sock/posix: fix busy poller in the interrupt mode

Setting EPOLLOUT flag makes the epoll_wait exit immidiately on the
tqpair socket as it's always ready for the write operation.
This was a bad fix for the async writes in the interrupt mode. Proper
fix is to flush async writes on nvmf/tcp level.

Extend test script for the interrupt mode to include case of idle
initiator in which CPU cores shall not be busy looping.

Change-Id: I17a97a74be9740dd67531f6e3b72bf38f0850edd
Signed-off-by: Krzysztof Goreczny <krzysztof.goreczny@dell.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24959
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

nvme: require TLS PSKs to be specified via keyring

It's no longer possible to pass the key directly in spdk_nvme_ctrl_opts.
This method was deprecated and was supposed to be removed in the
upcoming

nvme: require TLS PSKs to be specified via keyring

It's no longer possible to pass the key directly in spdk_nvme_ctrl_opts.
This method was deprecated and was supposed to be removed in the
upcoming release.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: If06e087abb83da6b2f22c4a9f7129720f26e6f0d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24810
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

nvmf/auth: add method for changing keys

This allows users to change the DH-HMAC-CHAP keys without
removing/re-adding hosts to a subsystem. That means that keys can be
changed without terminating ex

nvmf/auth: add method for changing keys

This allows users to change the DH-HMAC-CHAP keys without
removing/re-adding hosts to a subsystem. That means that keys can be
changed without terminating existing connections.

Once the keys are changed, new connections, as well as reauthentication
requests on the already established connections, will be required to use
the new keys.

Change-Id: I09e112ae73e4afebd452a3ebd19264cc8217d1f8
Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23822
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

test/nvmf: try to make reactors more busy in interrupt test

This test verifies that reactors are idle when there's no IO and that
they're idle when handling IO. The latter check can be a problem,
b

test/nvmf: try to make reactors more busy in interrupt test

This test verifies that reactors are idle when there's no IO and that
they're idle when handling IO. The latter check can be a problem,
because the business of a core when handling IOs varies and can never
reach the threshold that we use to consider a core to be busy.

To make that second check more reliable, let's do a couple of things:
increase queue depth to 256 and decrease busy threshold to 30. Also,
while here, use double parenthesis for arithmetic comparisons.

Fixes: #3520

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I2937b46471d523bb496e7b3878f43c541047adaf
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24827
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

test/fips: store TLS PSK in tmpfs

It makes it possible to run this test with repo mounted over nfs, as
keyring_file checks the ownership of the file, which can be different
with nfs (due to squashin

test/fips: store TLS PSK in tmpfs

It makes it possible to run this test with repo mounted over nfs, as
keyring_file checks the ownership of the file, which can be different
with nfs (due to squashing).

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ib05804f116498f137b1499d8eb10fcd60cf18f0e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24806
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvmf/tcp: require TLS PSKs to be specified via keyring

It's no longer possible to set TLS PSKs by specifying a path to the file
containing the key. This method was deprecated and was supposed to be

nvmf/tcp: require TLS PSKs to be specified via keyring

It's no longer possible to set TLS PSKs by specifying a path to the file
containing the key. This method was deprecated and was supposed to be
removed in the upcoming release.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Idfa4c935bd97f20c020779d90b186607f24bb525
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24805
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

nvmf/rdma: Correctly remove req from the pending_rdma_read_queue

This patch fixes qpair cleanup with rdma_req in
the pending_rdma_read_queue.
1. When a WC with error is reaped, we should remove
the

nvmf/rdma: Correctly remove req from the pending_rdma_read_queue

This patch fixes qpair cleanup with rdma_req in
the pending_rdma_read_queue.
1. When a WC with error is reaped, we should remove
the request from the queue if there are remaining data WRs
2. When qpair is in error state and a request in the state
RDMA_REQUEST_STATE_TRANSFERRING_HOST_TO_CONTROLLER is being
processed, we should check if it has remaining data WRs and
remove it from the queue
3. We should not process requests in the pending_rdma_read_queue
(nvmf_rdma_qpair_process_pending function) which are are not
in the RDMA_REQUEST_STATE_TRANSFERRING_HOST_TO_CONTROLLER state,
e.g. a request might be transferring data over the network, and
qpair might be in error state and we could complete such request
in nvmf_rdma_qpair_process_pending and then reap completion for
this request and complete it again.

Also, when we are handling WC with error for DATA request, we
must call nvmf_rdma_request_process for the req in COMPLETED
state to release resources and decrement qpair's counters

Signed-off-by: Alexey Marchuk <alexeymar@nvidia.com>
Change-Id: Ifc26c3e9bd0e006aa8cc35bf6ae5fd913f452538
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24477
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot

show more ...

test/nvmf: Explicitly load sch_mqprio module under ADQ tests

This is a dependency for the mqprio qdisc which is used in the tc
setup.

Under newer kernels, we need to do this explicitly, especially

test/nvmf: Explicitly load sch_mqprio module under ADQ tests

This is a dependency for the mqprio qdisc which is used in the tc
setup.

Under newer kernels, we need to do this explicitly, especially under
a distro which ships with blacklists targeted at sch_* modules (all
rhel-based distros currently, e.g. fedora). This is due to:

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=2c15a5aee2

and accompanying changes. Since blacklist is applied in alias
context, and since the above commit introduced aliases for all
the net/sched drivers, the request_module(), which essentially
falls onto modrobe, won't bring required module into the kernel.
Under < 6.9 kernels this "just" worked, since aliases were not
in place (so essentially, the rhel sch_* blacklists were broken
until this particular change in the kernel happened).

To mitigate, it's best to load this drivers on our own to jump
over any potential blacklists.

Change-Id: I8941a49cc16915b319867aee171bd5f9c606f4b1
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24713
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

nvmf/tcp: Add support for the interrupt mode in NVMe-of TCP

Add one dedicated test interrupt.sh that checks if all pollers are
indeed working in the interrupt mode.
Also, run entire nvmf_target_core

nvmf/tcp: Add support for the interrupt mode in NVMe-of TCP

Add one dedicated test interrupt.sh that checks if all pollers are
indeed working in the interrupt mode.
Also, run entire nvmf_target_core.sh scope in both polling and
interrupt mode to check if from functional perspective everything works
in both cases.
Most tests will (for now) still have busy pollers for the backend
storage as only aio supports the interrupt mode but that's ok.

Change-Id: I0a61e82cd6372fe1bf97ae4c912f6f3266207f99
Signed-off-by: Krzysztof Goreczny <krzysztof.goreczny@dell.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22746
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

test/nvmf: add helper functions for establishing connections

Most of the parameters (e.g. subnqn, hostnqn, traddr, trsvcid, etc.) are
always the same, so we can reduce the size of the test by hiding

test/nvmf: add helper functions for establishing connections

Most of the parameters (e.g. subnqn, hostnqn, traddr, trsvcid, etc.) are
always the same, so we can reduce the size of the test by hiding them in
a helper function.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ife9039725162c1d105db386f258135de86cd909f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23800
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

nvmf/tcp: replace pending_buf_queue with nvmf_tcp_request_get_buffers

Use iobuf internal queuing capability exposed via new
nvmf_tcp_request_get_buffers callback mechanism for the TCP requests
that

nvmf/tcp: replace pending_buf_queue with nvmf_tcp_request_get_buffers

Use iobuf internal queuing capability exposed via new
nvmf_tcp_request_get_buffers callback mechanism for the TCP requests
that awaits free buffers instead of queuing them internally.

Introduce new spdk_nvmf_tcp_req_state that clearly indicates if all
requested buffers are allocated for the request.

TCP requests could also wait for the spdk_nvmf_tcp_control_msg_list
buffer for the PDU. Add tcp-only waiting list for such case.

It is the first step in effort to remove pending_buf_queue completely
from the spdk_nvmf_request and rely only on the iobuf and
transport-specific queues.

Change-Id: Ic717d5b8b1090d7703d39f298777d8fdfc30103c
Signed-off-by: Krzysztof Goreczny <krzysztof.goreczny@dell.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23215
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

nvmf/tcp: fix spdk_nvmf_tcp_control_msg_list queuing

control msg buffers are in use when an admin or fabric command has in
capsule data size bigger than the transport->opts.in_capsule_data_size.
Num

nvmf/tcp: fix spdk_nvmf_tcp_control_msg_list queuing

control msg buffers are in use when an admin or fabric command has in
capsule data size bigger than the transport->opts.in_capsule_data_size.
Number of buffers is limited and when there are no free ones request is
queued in the pending_buf_queue.
However, PDU processing in nvmf_tcp_sock_process continues ignoring lack
of the buffer, calling nvmf_tcp_capsule_cmd_hdr_handle() again so
another request is queued for the same PDU, again not having the control
msg buffer available and so on.
Fix this by adding one more PDU processing state that indicates lack of
buffer for the PDU. This way PDU processing continues only after
nvmf_tcp_process() acquires the buffer.

Change-Id: I5e16d7fa3931efc45646f8fdd23794a640c75e93
Signed-off-by: Krzysztof Goreczny <krzysztof.goreczny@dell.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24306
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

nvmf: update mDNS PRR listener when discovery listener changes

Previously, user should stop and restart mDNS PRR to update the mDNS PRR listener
list. This requires some expensive avahi API calls, s

nvmf: update mDNS PRR listener when discovery listener changes

Previously, user should stop and restart mDNS PRR to update the mDNS PRR listener
list. This requires some expensive avahi API calls, such as creating and deleting
avahi structures.

Now, when discovery subsystem listener changes, nvmf_tgt_update_mdns_prr
is called to update mDNS PRR listener.

Change-Id: I136fc4057136b59cfda158db3f3e29f34e4a7f4c
Signed-off-by: kyuho.son <kyuho.son@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24169
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

test/nvmf: Always clean iptables rules

Tag them with proper comment for easier tracking and delete them
while finishing the tests.

This is done in order to make sure we don't keep adding same rules

test/nvmf: Always clean iptables rules

Tag them with proper comment for easier tracking and delete them
while finishing the tests.

This is done in order to make sure we don't keep adding same rules
over and over again under the same system.

Change-Id: I240fd23943cb4907fcd3666943cae2449ec3e6a5
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24413
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

test/nvmf: Fix veth cleanup

Change-Id: I91b1f2fe5dccd53286a9215814dc58131bd9e796
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24412

test/nvmf: Fix veth cleanup

Change-Id: I91b1f2fe5dccd53286a9215814dc58131bd9e796
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24412
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

nvme/tcp: respect the src_{addr,svcid} parameters

Previously, both were completely ignored.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I9df0b50038742956e2be0b80ad239e80ac4d

nvme/tcp: respect the src_{addr,svcid} parameters

Previously, both were completely ignored.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I9df0b50038742956e2be0b80ad239e80ac4dcba6
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24070
Reviewed-by: Tomasz Zawadzki <tomasz@tzawadzki.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...