test/dd: Added skip/seek negative tests for spdk_dd app

Change-Id: I5cb8aeb873a1b441da4e9983cece20413fb31696
Signed-off-by: Marcin Suski <marcin.suski@intel.com>
Reviewed-on: https://review.spdk.io/

test/dd: Added skip/seek negative tests for spdk_dd app

Change-Id: I5cb8aeb873a1b441da4e9983cece20413fb31696
Signed-off-by: Marcin Suski <marcin.suski@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21534
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Marek Chomnicki <marek.chomnicki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

general: fix misspells and typos

Signed-off-by: Kamil Godzwon <kamilx.godzwon@intel.com>
Change-Id: Iab206ef526eb7032c6681a3145450010c91705a4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+

general: fix misspells and typos

Signed-off-by: Kamil Godzwon <kamilx.godzwon@intel.com>
Change-Id: Iab206ef526eb7032c6681a3145450010c91705a4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24120
Community-CI: Mellanox Build Bot
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

test/dd: check spdk_dd direct link to liburing

If SPDK is compiled with uring support for bdev or sock
modules, this does NOT have to mean that spdk_dd was too.

check_liburing() was using ld, that

test/dd: check spdk_dd direct link to liburing

If SPDK is compiled with uring support for bdev or sock
modules, this does NOT have to mean that spdk_dd was too.

check_liburing() was using ld, that will list indirect
dependencies, rather than only verifying those directly used.
Despite spdk_dd not actually compiling with liburing,
this function didn't catch that.

This could be resolved by passing empty LD_LIBRARY_PATH,
which would make ld unable to resolve those dependencies.

Instead of that workaround, objdump is used to verify only
directly linked libraries.
Removed the check if liburing actually exists, since objdump
does not point to their actual locations. If it is missing,
that will be caught when running the test anyway.

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I13edc36d9667732c170eecccdcb3b5f334b87b61
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21835
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Michal Berger <michal.berger@intel.com>

show more ...

lvol: remove size parameter from bedv_lvol_{create,resize}

This parameter was replaced with size_in_mib and was deprecated for a
long time, so it's finally time to remove it.

Signed-off-by: Konrad

lvol: remove size parameter from bedv_lvol_{create,resize}

This parameter was replaced with size_in_mib and was deprecated for a
long time, so it's finally time to remove it.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I0c753c535418b43c8a4759d9dac5825da88c8adf
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22951
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

identify: Promote spdk_nvme_identify to the app/ directory

This is a tool we install, so promote it from examples/ to app/

Change-Id: Ida98c78a71268c6769c90c56ecc9d4a415a310a5
Signed-off-by: Ben Wa

identify: Promote spdk_nvme_identify to the app/ directory

This is a tool we install, so promote it from examples/ to app/

Change-Id: Ida98c78a71268c6769c90c56ecc9d4a415a310a5
Signed-off-by: Ben Walker <ben@nvidia.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21197
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Wojciech Panfil <wojciech.panfil@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

test/dd: Negative tests for spdk_dd app

Change-Id: Ia5b7531fc828ce161bba49602cd4a1b97d1076fe
Signed-off-by: Marcin Suski <marcin.suski@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/sp

test/dd: Negative tests for spdk_dd app

Change-Id: Ia5b7531fc828ce161bba49602cd4a1b97d1076fe
Signed-off-by: Marcin Suski <marcin.suski@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20998
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Michal Berger <michal.berger@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

test/dd: paramaeter error in test/dd/common.sh

fix quote error

Change-Id: Icec24dcd346c5a558575811a44d172ed4411f520
Signed-off-by: wumengjin <wumengjin@bytedance.com>
Reviewed-on: https://review.sp

test/dd: paramaeter error in test/dd/common.sh

fix quote error

Change-Id: Icec24dcd346c5a558575811a44d172ed4411f520
Signed-off-by: wumengjin <wumengjin@bytedance.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21166
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

test/dd: Remove workaround for older Bash versions

As per shfmt.md, we have been building centos7 with 4.4 Bash inside
so this workoarund is not needed anymore.

Change-Id: I7c2792184dd9a906eaeb078c

test/dd: Remove workaround for older Bash versions

As per shfmt.md, we have been building centos7 with 4.4 Bash inside
so this workoarund is not needed anymore.

Change-Id: I7c2792184dd9a906eaeb078c6cbe9f4eeee9f0de
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21019
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

add (c) and SPDX header to bash files as needed

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --forma

add (c) and SPDX header to bash files as needed

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc)

For intel copyrights added, --follow and -C95% were used.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: I2ef86976095b88a9bf5b1003e59f3943cd6bbe4c
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15209
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...