nvme/auth: process auth transactions inside transports

We chose to process auth transactions in the common fabrics code to
avoid code duplication. However, it makes it difficult to implement
reauth

nvme/auth: process auth transactions inside transports

We chose to process auth transactions in the common fabrics code to
avoid code duplication. However, it makes it difficult to implement
reauthentication, as the transports are polling for fabrics connect,
which doesn't happen once a connection has been established.

So, polling for the authentication will now be done by the transports.
Also, the next patch will add a transport callback that moves a qpair
back to the AUTHENTICATING state after it's been connected, which will
be used to implement reauthentication.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Idd0e82593f1730b37eec452edc5e0ea49627921d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24232
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

nvme: do port number checking in nvme_parse_addr()

TCP was already range checking the port number, so
move it to the common nvme_parse_addr() so that RDMA
gets the port checking as well.

Note, prev

nvme: do port number checking in nvme_parse_addr()

TCP was already range checking the port number, so
move it to the common nvme_parse_addr() so that RDMA
gets the port checking as well.

Note, previously TCP was checking against MAX_INT,
so change this to reject >= 65536 instead which is
the real IP port limit.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Suggested-by: Alexey Marchuk <alexeymar@nvidia.com>
Change-Id: I91e2f23ac4f4d8ec80cdea95a4bbff73477b8464
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20565
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

nvme: add nvme_parse_addr()

nvme_tcp_parse_addr() and nvme_rdma_parse_addr()
were exact duplicates, so break this out into a
common helper function.

Signed-off-by: Jim Harris <jim.harris@samsung.co

nvme: add nvme_parse_addr()

nvme_tcp_parse_addr() and nvme_rdma_parse_addr()
were exact duplicates, so break this out into a
common helper function.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I5dcf3c218992c41f51a883f020847de36f1652e3
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20564
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date defa

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the 4 digit year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc). Contribution date used
"--follow -C95%" to get the most accurate date.

Note that several files in this patch didn't end the license/(c)
block with a blank comment line so these were added as the vast
majority of files do have this last blank line. Simply there for
consistency.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot

show more ...

Replace most BSD 3-clause license text with SPDX identifier.

Many open source projects have moved to using SPDX identifiers
to specify license information, reducing the amount of
boilerplate code in

Replace most BSD 3-clause license text with SPDX identifier.

Many open source projects have moved to using SPDX identifiers
to specify license information, reducing the amount of
boilerplate code in every source file. This patch replaces
the bulk of SPDK .c, .cpp and Makefiles with the BSD-3-Clause
identifier.

Almost all of these files share the exact same license text,
and this patch only modifies the files that contain the
most common license text. There can be slight variations
because the third clause contains company names - most say
"Intel Corporation", but there are instances for Nvidia,
Samsung, Eideticom and even "the copyright holder".

Used a bash script to automate replacement of the license text
with SPDX identifier which is checked into scripts/spdx.sh.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: Iaa88ab5e92ea471691dc298cfe41ebfb5d169780
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12904
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Dong Yi <dongx.yi@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: <qun.wan@intel.com>

show more ...