Revision tags: v25.01-rc1 |
|
#
61617956 |
| 20-Nov-2024 |
Michal Berger <michal.berger@intel.com> |
test/common: Make sure get_zoned_devs() picks all namespaces
In case given nvme ctrl mixes zoned and not-zoned namespaces, we need to make sure we put ALL of them on the list to inform the caller th
test/common: Make sure get_zoned_devs() picks all namespaces
In case given nvme ctrl mixes zoned and not-zoned namespaces, we need to make sure we put ALL of them on the list to inform the caller that they won't be available - this is necessary since the PCI_BLOCKED list that's built based on the zoned_devs[] will prevent entire ctrl from being used, hence making ALL of the namespaces unavailable for tests in userspace.
Change-Id: I5b0fa2053e8244a97690a1dc69bb053bd733b172 Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25456 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com> Reviewed-by: Jim Harris <jim.harris@nvidia.com> Reviewed-by: Ben Walker <ben@nvidia.com>
show more ...
|
#
8531656d |
| 25-Oct-2024 |
Ankit Kumar <ankit.kumar@samsung.com> |
test/nvmf: Interrupt test for local pcie nvme device
Change-Id: I62196ca5b84a622c60cbea465fb3cb5c7ef680dc Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com> Reviewed-on: https://review.spdk.io/ger
test/nvmf: Interrupt test for local pcie nvme device
Change-Id: I62196ca5b84a622c60cbea465fb3cb5c7ef680dc Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25378 Reviewed-by: Michal Berger <michal.berger@intel.com> Reviewed-by: Jim Harris <jim.harris@samsung.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
show more ...
|
Revision tags: v24.09, v25.01-pre, v24.09-rc1 |
|
#
12fc2abf |
| 09-Sep-2024 |
Michal Berger <michal.berger@intel.com> |
test: Remove autopackage.sh
It was kept only for legacy reasons to handle the last call to timing_finish(). Since build_release is already self-contained and executed within a separate, dedicated jo
test: Remove autopackage.sh
It was kept only for legacy reasons to handle the last call to timing_finish(). Since build_release is already self-contained and executed within a separate, dedicated job we can move timing_finish() where it belongs, i.e., to autorun.sh.
Change-Id: Iae095b4b8e3601b74d3c1655f17364e8b66b1ee0 Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24858 Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Jim Harris <jim.harris@samsung.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
show more ...
|
#
39af5663 |
| 21-Oct-2024 |
Michal Berger <michal.berger@intel.com> |
test: Stop requesting task states dump upon failure
This is extremely expensive operation, especially under bulky bare-metal systems, and its debugging value, from autotest perspective, is really mi
test: Stop requesting task states dump upon failure
This is extremely expensive operation, especially under bulky bare-metal systems, and its debugging value, from autotest perspective, is really minimal.
With that in mind, stop collecting it.
Change-Id: I8f86ab7a2507040f38c5547c63c8d6ba6f3560c0 Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25292 Reviewed-by: Jim Harris <jim.harris@samsung.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
show more ...
|
#
a711f445 |
| 04-Oct-2024 |
Michal Berger <michal.berger@intel.com> |
test/vhost: Attempt to verify vhost status upon termination
This is a bit problematic, since vhost_kill() operates on PID files, meaning, that it may attempt to kill a process which doesn't belong t
test/vhost: Attempt to verify vhost status upon termination
This is a bit problematic, since vhost_kill() operates on PID files, meaning, that it may attempt to kill a process which doesn't belong to the instance that's calling it. So to make it somewhat sensible, we need to check first if vhost is our child - only then attempt to verify it's status.
Change-Id: I9024ab19f62652472ce9113bc3f1cf7326d14454 Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25149 Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Jim Harris <jim.harris@samsung.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
show more ...
|
#
982c2051 |
| 04-Jun-2024 |
Michal Berger <michal.berger@intel.com> |
test/common: Include test/nvme in the reap_spdk_processes() lookup
The nvme suite includes several testing binaries - their processes may be left lingering in the system in case of a crash. Make sur
test/common: Include test/nvme in the reap_spdk_processes() lookup
The nvme suite includes several testing binaries - their processes may be left lingering in the system in case of a crash. Make sure autotest's cleanup picks all their pieces.
See: https://github.com/spdk/spdk/issues/3399
Change-Id: Ie73faeeed97140d5c02bcf1bf0b69f1e1177deac Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23519 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Jim Harris <jim.harris@samsung.com>
show more ...
|
#
6468abf0 |
| 06-Sep-2024 |
Jim Harris <jim.harris@samsung.com> |
test: add geninfo_unexecuted_blocks=1 for lcov
This eliminates some warning messages.
Signed-off-by: Jim Harris <jim.harris@samsung.com> Change-Id: I62335ea68cc98dad979d1c3b8ea30e3da7ba9e87 Reviewe
test: add geninfo_unexecuted_blocks=1 for lcov
This eliminates some warning messages.
Signed-off-by: Jim Harris <jim.harris@samsung.com> Change-Id: I62335ea68cc98dad979d1c3b8ea30e3da7ba9e87 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24841 Reviewed-by: Michal Berger <michal.berger@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
show more ...
|
#
125c6010 |
| 06-Sep-2024 |
Jim Harris <jim.harris@samsung.com> |
test: only specify lcov --no-external when collecting coverage
This eliminates some annoying warning messages.
Signed-off-by: Jim Harris <jim.harris@samsung.com> Change-Id: I5cdbecfad7d34c8d36f8892
test: only specify lcov --no-external when collecting coverage
This eliminates some annoying warning messages.
Signed-off-by: Jim Harris <jim.harris@samsung.com> Change-Id: I5cdbecfad7d34c8d36f88925b3e6400d93b38089 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24840 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
show more ...
|
#
7c65373e |
| 06-Sep-2024 |
Jim Harris <jim.harris@samsung.com> |
test: change some lcov options based on lcov version
lcov_branch_coverage and lcov_function_coverage were deprecated in lcov 2.0, so use the new names for >=2.0 to avoid annoying warning messages.
test: change some lcov options based on lcov version
lcov_branch_coverage and lcov_function_coverage were deprecated in lcov 2.0, so use the new names for >=2.0 to avoid annoying warning messages.
Signed-off-by: Jim Harris <jim.harris@samsung.com> Change-Id: Ieff347f4fa058684d5a407fce49f75f74bd9912f Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24839 Reviewed-by: Michal Berger <michal.berger@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
show more ...
|
#
1ebcd2fd |
| 06-Sep-2024 |
Jim Harris <jim.harris@samsung.com> |
test: move LCOV and LCOV_OPTS definitions to autotest_common.sh
This avoids defining them in multiple places.
Signed-off-by: Jim Harris <jim.harris@samsung.com> Change-Id: I978fbd4f1c0da935eddb2b64
test: move LCOV and LCOV_OPTS definitions to autotest_common.sh
This avoids defining them in multiple places.
Signed-off-by: Jim Harris <jim.harris@samsung.com> Change-Id: I978fbd4f1c0da935eddb2b64872dae20e5f6fc11 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24838 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Michal Berger <michal.berger@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
show more ...
|
#
e2d2ca7c |
| 06-Sep-2024 |
Jim Harris <jim.harris@samsung.com> |
test: teach get_config_params() how to handle non-x86 processors
'vendor' field doesn't exist in at least some ARM /proc/cpuinfo files. Michal recommended rewriting this whole section to make it a l
test: teach get_config_params() how to handle non-x86 processors
'vendor' field doesn't exist in at least some ARM /proc/cpuinfo files. Michal recommended rewriting this whole section to make it a lot more simple while also handling this non-x86 case.
Suggested-by: Michal Berger <michal.berger@intel.com> Signed-off-by: Jim Harris <jim.harris@samsung.com> Change-Id: I62eaa0f404cbe8b59c16a365ecb3c85e241fd21d Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24821 Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com> Reviewed-by: Michal Berger <michal.berger@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
show more ...
|
#
54f9ed4c |
| 06-Sep-2024 |
Jim Harris <jim.harris@samsung.com> |
test: teach autotest_common.sh fns to work with no nvme devices
This allows autorun.sh framework to work when a system has no nvme devices.
Suggested-by: Michal Berger <michal.berger@intel.com> Sig
test: teach autotest_common.sh fns to work with no nvme devices
This allows autorun.sh framework to work when a system has no nvme devices.
Suggested-by: Michal Berger <michal.berger@intel.com> Signed-off-by: Jim Harris <jim.harris@samsung.com> Change-Id: I663cb4bcfbc11cd299247ff8d4fd771c4d9fcaef Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24820 Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Michal Berger <michal.berger@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
show more ...
|
#
47d1bc80 |
| 06-Sep-2024 |
Jim Harris <jim.harris@samsung.com> |
test: teach reap_spdk_processes to handle case where no spdk bins exist
This function is typically always called after SPDK has been built. But if it hasn't, it basically ends up trying to kill all
test: teach reap_spdk_processes to handle case where no spdk bins exist
This function is typically always called after SPDK has been built. But if it hasn't, it basically ends up trying to kill all of the running processes on the system.
Signed-off-by: Jim Harris <jim.harris@samsung.com> Change-Id: I8a0d12606a1aa3a472a9b35a7c294e28be40acda Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24819 Reviewed-by: Michal Berger <michal.berger@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <ben@nvidia.com> Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
show more ...
|
#
26f88ce7 |
| 27-Aug-2024 |
Michal Berger <michal.berger@intel.com> |
test: Fail hard when flamegraph.pl is not found
flamegraph is crucial to represent timing in a more human-readable fashion so make sure timing_finish() fails hard when it's not found.
Change-Id: Ib
test: Fail hard when flamegraph.pl is not found
flamegraph is crucial to represent timing in a more human-readable fashion so make sure timing_finish() fails hard when it's not found.
Change-Id: Ib3b2143d3e6d4984501f08f10e384ef43ec141b9 Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24677 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <jim.harris@samsung.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
show more ...
|
#
59948022 |
| 28-Aug-2024 |
Michal Berger <michal.berger@intel.com> |
test/coverage: Don't reject coverage under FreeBSD
It's a bit awkward situation where we reject coverage for freebsd via the configure step and yet support it in the mk.
Tested coverage collection
test/coverage: Don't reject coverage under FreeBSD
It's a bit awkward situation where we reject coverage for freebsd via the configure step and yet support it in the mk.
Tested coverage collection under freebsd14 using supported lcov (1.15) - seems to be working just fine.
CI's end still needs to arm FreeBSD with proper tools but staging tests look promising for now.
Change-Id: Ie09a70cb894d82c1942e0b1d8d6c516a9a8b21d2 Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24743 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Jim Harris <jim.harris@samsung.com>
show more ...
|
#
6f2b8056 |
| 28-Aug-2024 |
Michal Berger <michal.berger@intel.com> |
autotest: Stop rejecting coverage collection under clang
78d5bfe575 claimed that collecting coverage from a clang build takes signficant amount of time, hence not being collected by the autotest nor
autotest: Stop rejecting coverage collection under clang
78d5bfe575 claimed that collecting coverage from a clang build takes signficant amount of time, hence not being collected by the autotest nor unittest.
However, currently this doesn't seem to be the case anymore. To align coverage and make sure there are no any odd exceptions let's have it always collected.
This also merges llvm coverage into the one collected by the autotest instance as there's no point now to keep it separately.
Change-Id: Ic46408f313fff0273a226adbf3fb5f56c916aedf Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24722 Reviewed-by: Jim Harris <jim.harris@samsung.com> Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
show more ...
|
Revision tags: v24.05, v24.09-pre, v24.05-rc1 |
|
#
81fc34df |
| 11-Apr-2024 |
Krzysztof Goreczny <krzysztof.goreczny@dell.com> |
nvmf/tcp: Add support for the interrupt mode in NVMe-of TCP
Add one dedicated test interrupt.sh that checks if all pollers are indeed working in the interrupt mode. Also, run entire nvmf_target_core
nvmf/tcp: Add support for the interrupt mode in NVMe-of TCP
Add one dedicated test interrupt.sh that checks if all pollers are indeed working in the interrupt mode. Also, run entire nvmf_target_core.sh scope in both polling and interrupt mode to check if from functional perspective everything works in both cases. Most tests will (for now) still have busy pollers for the backend storage as only aio supports the interrupt mode but that's ok.
Change-Id: I0a61e82cd6372fe1bf97ae4c912f6f3266207f99 Signed-off-by: Krzysztof Goreczny <krzysztof.goreczny@dell.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22746 Reviewed-by: Jim Harris <jim.harris@samsung.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
show more ...
|
#
cb7af50c |
| 03-Jun-2024 |
Michal Berger <michal.berger@intel.com> |
test/common: Commonize get_block_dev*() functions
Adjust get_nvme_name_from_bdf() so it calls to get_block_dev_from_nvme().
Change-Id: If5f0eb573878a42e0ad0ab0453c73d39cbdf6020 Signed-off-by: Micha
test/common: Commonize get_block_dev*() functions
Adjust get_nvme_name_from_bdf() so it calls to get_block_dev_from_nvme().
Change-Id: If5f0eb573878a42e0ad0ab0453c73d39cbdf6020 Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23508 Reviewed-by: Jim Harris <jim.harris@samsung.com> Reviewed-by: Marek Chomnicki <marek.chomnicki@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
show more ...
|
#
b4e49c37 |
| 19-Jul-2024 |
Jaroslaw Chachulski <jaroslawx.chachulski@intel.com> |
autotest: add flag to conditionally run setup.sh tests
Introduce a new environment variable SPDK_TEST_SETUP to control the execution of the setup.sh tests
Change-Id: I95601a4e4692931918ab98f52e1903
autotest: add flag to conditionally run setup.sh tests
Introduce a new environment variable SPDK_TEST_SETUP to control the execution of the setup.sh tests
Change-Id: I95601a4e4692931918ab98f52e19034477848a79 Signed-off-by: Jaroslaw Chachulski <jaroslawx.chachulski@intel.com> Signed-off-by: Karol Latecki <karol.latecki@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24253 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Michal Berger <michal.berger@intel.com> Reviewed-by: Jim Harris <jim.harris@samsung.com>
show more ...
|
#
0070858e |
| 17-Jul-2024 |
Michal Berger <michal.berger@intel.com> |
scripts/setup.sh: Use HUGE_EVEN_ALLOC logic by default
To that end, remove it altogether and allow setup.sh to always split requested amount of hugepages across all available nodes. Custom setups pe
scripts/setup.sh: Use HUGE_EVEN_ALLOC logic by default
To that end, remove it altogether and allow setup.sh to always split requested amount of hugepages across all available nodes. Custom setups per node are still available through the HUGENODE var.
Adjust some of the hugepages.sh tests to adhere to the new default. This change allows us to remove the per_node_1G_alloc() test since its flow is now covered by the custom_alloc().
By default, autotest.sh sets HUGEMEM=4096 and by spreading it across all the nodes, for the minimal scenario, we get only 2GB on a single node. For vhost tests, the default alloc per VM via vm_setup() is set to 1GB so sharing that 2GB between qemu and SPDK spreads it a bit too thin.
Case in point, for vhost.vhost_blk_packed_ring_integrity test roughly > 600 hugepages is used for vhost. Since it slurps everything from node0, only < 512 remains. Since VMs are assigned per node, the most basic setups keep VM_*_qemu_numa_node set to 0. This is then used by qemu to bind to a specific node. With 1G, < 512 hugepages is simply not enough.
With that in mind, for vhost tests, keep all allocations on a single node instead of trying to figure out right amount of memory per node to keep the old behavior in (this may change in the future when SPDK/vhost becomes numa-aware).
Change-Id: I83e18bfa4cc6de0a777804b354de083ae6ae9d8c Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24176 Community-CI: Mellanox Build Bot Reviewed-by: Tomasz Zawadzki <tomasz@tzawadzki.com> Reviewed-by: Jim Harris <jim.harris@samsung.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
show more ...
|
#
cac68eec |
| 23-Jul-2024 |
Kamil Godzwon <kamilx.godzwon@intel.com> |
autotest: reduce RAID tests runs
To reduce the number of RAID test executions, keep all of them under SPDK_TEST_RAID flag (bdev raid, spdkcli raid and raid5f)
Use SPDK_TEST_RAID to set proper confi
autotest: reduce RAID tests runs
To reduce the number of RAID test executions, keep all of them under SPDK_TEST_RAID flag (bdev raid, spdkcli raid and raid5f)
Use SPDK_TEST_RAID to set proper config params for raid5f tests (--with-raid5f)
Signed-off-by: Kamil Godzwon <kamilx.godzwon@intel.com> Change-Id: I5349473db2dc14c4699f124a5f76525352477780 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24292 Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com> Reviewed-by: Ben Walker <ben@nvidia.com> Reviewed-by: Tomasz Zawadzki <tomasz@tzawadzki.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Michal Berger <michal.berger@intel.com> Reviewed-by: Karol Latecki <karol.latecki@intel.com>
show more ...
|
#
8711e7e9 |
| 16-Jul-2024 |
Kamil Godzwon <kamilx.godzwon@intel.com> |
autotest: reduce accel tests runs with SPDK_TEST_ACCEL flag
Run accel tests only when SPDK_TEST_ACCEL flag is set. Avoid excessive repetition of the tests execution.
Signed-off-by: Kamil Godzwon <k
autotest: reduce accel tests runs with SPDK_TEST_ACCEL flag
Run accel tests only when SPDK_TEST_ACCEL flag is set. Avoid excessive repetition of the tests execution.
Signed-off-by: Kamil Godzwon <kamilx.godzwon@intel.com> Change-Id: I119e037d98552ea633e59d566d3998dca6e954f4 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24192 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
show more ...
|
#
48e6cc6f |
| 23-Jul-2024 |
Michal Berger <michal.berger@intel.com> |
Revert "test/common: Indicate failure when run_test()'s cmd returns es != 0"
This change negatively affects failure detection in all the suites which don't adhere to:
"For similar scenarios, we nee
Revert "test/common: Indicate failure when run_test()'s cmd returns es != 0"
This change negatively affects failure detection in all the suites which don't adhere to:
"For similar scenarios, we need to force errexit into action by explicitly returning from the run_test() when the command it executes fails".
For instance, wrapper functions which execute unittests got affected by it. See for instance: https://github.com/spdk/spdk/issues/3451
This would require some bulky refactor which is simply not worth the effort, it's better to drop this change altogether.
This reverts commit e516088390b2aad38dde0e5b222692107a7b04a5.
Change-Id: Ifa13e194f498e30a52dc062a5e9f65e169c0bfe8 Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24296 Bypass-Merge-Requirements: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
show more ...
|
#
e5160883 |
| 20-Jun-2024 |
Michal Berger <michal.berger@intel.com> |
test/common: Indicate failure when run_test()'s cmd returns es != 0
This is relevant for a bit more obscure cases (though still valid ones). Consider the following scenario:
$ foo() { false | fal
test/common: Indicate failure when run_test()'s cmd returns es != 0
This is relevant for a bit more obscure cases (though still valid ones). Consider the following scenario:
$ foo() { false | false; } $ NOT run_test "foo" foo $ echo test succeeded
The goal here is to perform a negative test against foo(). Based on the example the test should succeed since the pipeline clearly fails on both ends. However, this test actually fails, i.e. NOT() sees run_test() returning 0.
The reason is that NOT() executes the cmd as part of the || list to preserve the es ("$@" || es=$?). In such a case, errexit won't be triggered inside the run_test() (where foo() is executed) allowing run_test() to successfully complete.
For similar scenarios, we need to force errexit into action by explicitly returning from the run_test() when the command it executes fails. The extra benefit here is that time will have a chance to complete as well, meaning that even in case of a failure, its report will be still returned.
In general, autotest should also consider use of pipefail to narrow down potential issues with missing failures in between the pipes. Such change however needs to be carefuly tested across the entire autotest suite first.
Change-Id: Ic7842f886460a9c1638e5b14d8494001b3ec2958 Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23795 Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
show more ...
|
#
b18e53d4 |
| 20-Jun-2024 |
Michal Berger <michal.berger@intel.com> |
test/common: Make $test_domain nounset friendly
There are some test suites which do use nounset (e.g. test/lvol) so this makes sure they can be executed out of autotest.sh's environment (i.e. standa
test/common: Make $test_domain nounset friendly
There are some test suites which do use nounset (e.g. test/lvol) so this makes sure they can be executed out of autotest.sh's environment (i.e. standalone) where $test_domain may not be initially set.
Change-Id: I297adc26d231f8d709be7c11a5727df2ee376189 Signed-off-by: Michal Berger <michal.berger@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23794 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
show more ...
|