test/raid: wait for examine after re-adding passthru bdev

bdev_passthru_create doesn't wait until the new bdev is examined, so
there's a race between the raid bdev examining it and the bdev_get_bdev

test/raid: wait for examine after re-adding passthru bdev

bdev_passthru_create doesn't wait until the new bdev is examined, so
there's a race between the raid bdev examining it and the bdev_get_bdevs
call.

Fixes: #3498

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I51b24154910a4d57f3665312d46322b95922bca0
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24771
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Michal Berger <michal.berger@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

test/raid: remove some redundant jq calls

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Suggested-by: Michal Berger <michal.berger@intel.com>
Change-Id: I636489a24b1052772fdcb92d7f3

test/raid: remove some redundant jq calls

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Suggested-by: Michal Berger <michal.berger@intel.com>
Change-Id: I636489a24b1052772fdcb92d7f33ae05bcd840f4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24576
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz@tzawadzki.com>

show more ...

test/raid: don't use a temp file for RPCs

Also, inline the configure_raid_bdev function because it doesn't improve
readability now.

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Su

test/raid: don't use a temp file for RPCs

Also, inline the configure_raid_bdev function because it doesn't improve
readability now.

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Suggested-by: Michal Berger <michal.berger@intel.com>
Change-Id: I9df8bc02ad6ff3bda527962ea1d871d3462cde7c
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24575
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Tomasz Zawadzki <tomasz@tzawadzki.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

test/bdev: Fix raid_resize_data_offset_test()

There was a mishap between the following commits:

3cd7b237e6, 141bc565bb

where former didn't include proper changes introduced by the
latter. Adjust t

test/bdev: Fix raid_resize_data_offset_test()

There was a mishap between the following commits:

3cd7b237e6, 141bc565bb

where former didn't include proper changes introduced by the
latter. Adjust the test so it does now.

Change-Id: Ibf3c3496899436659df4e5c7c1fe999aa4f9bd5b
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24666
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Bypass-Merge-Requirements: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

bdev/raid: clear `data_offset` to allow it to be recalculated

If one of the slots of raid bdev is replaced, the optimal
`data_offset` for the new disk added will be recalculated.

Fixes #3419

Chang

bdev/raid: clear `data_offset` to allow it to be recalculated

If one of the slots of raid bdev is replaced, the optimal
`data_offset` for the new disk added will be recalculated.

Fixes #3419

Change-Id: I748ef2d3274f37d0a1e7cd4c443e316b8b0e45bc
Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24339
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>

show more ...

test/raid: use DEFAULT_RPC_ADDR

The custom rpc_server socket is not useful, just use the default.

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-Id: I7a7a9840b7923fd006976234

test/raid: use DEFAULT_RPC_ADDR

The custom rpc_server socket is not useful, just use the default.

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-Id: I7a7a9840b7923fd006976234472c9cc3590288d3
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24574
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

test/raid: use rpc_cmd to optimize RPC calls

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-Id: I1095bf3a544e01c3d0b7d999c12

test/raid: use rpc_cmd to optimize RPC calls

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-Id: I1095bf3a544e01c3d0b7d999c12e50d00b3f8145
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24562
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

autotest: reduce RAID tests runs

To reduce the number of RAID test executions, keep
all of them under SPDK_TEST_RAID flag (bdev raid,
spdkcli raid and raid5f)

Use SPDK_TEST_RAID to set proper confi

autotest: reduce RAID tests runs

To reduce the number of RAID test executions, keep
all of them under SPDK_TEST_RAID flag (bdev raid,
spdkcli raid and raid5f)

Use SPDK_TEST_RAID to set proper config params
for raid5f tests (--with-raid5f)

Signed-off-by: Kamil Godzwon <kamilx.godzwon@intel.com>
Change-Id: I5349473db2dc14c4699f124a5f76525352477780
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24292
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Tomasz Zawadzki <tomasz@tzawadzki.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Michal Berger <michal.berger@intel.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>

show more ...

test/bdev: Add test for resized RAID with superblock

Change-Id: Ia680f4677ba0a151e2dcdeb19c17199e20a7aa50
Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Reviewed-on: https://revi

test/bdev: Add test for resized RAID with superblock

Change-Id: Ia680f4677ba0a151e2dcdeb19c17199e20a7aa50
Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23397
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>

show more ...

bdev/raid1: Support resize when increasing the size of base bdevs

Implement the resize function for RAID1. raid1_resize() calculate the
new raid_bdev's block count and if it is different from the ol

bdev/raid1: Support resize when increasing the size of base bdevs

Implement the resize function for RAID1. raid1_resize() calculate the
new raid_bdev's block count and if it is different from the old block
count, call spdk_bdev_notify_blockcnt_change() with the new block count.

Add a simple functional test for this feature. The test is to create
a raid1 bdev with two null bdevs, resize one null bdev, check if the
raid1 bdev is not resize, resize another null bdev, check if the raid1
bdev is resized.

The commit is an overall copy/adaptation of the work of Shuhei Matsumoto
with raid0.

Change-Id: I0737ba3fe4e1260d35d51e7b022c9cfd1eb6db58
Signed-off-by: Loïc Yavercovski <loic.yavercovski@gmail.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22619
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

test/raid: io error tests

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-Id: I8edd6cf57627dff247c4e1e2d78746da16087346
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+

test/raid: io error tests

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-Id: I8edd6cf57627dff247c4e1e2d78746da16087346
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23186
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

test/raid: improve script cleanup

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-Id: Ia5d0dd1d97901f5cd4d250679b4d6036b4966bbd
Reviewed-on: https://review.spdk.io/gerrit/c/spd

test/raid: improve script cleanup

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-Id: Ia5d0dd1d97901f5cd4d250679b4d6036b4966bbd
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23205
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

raid: examine other bdevs when starting from superblock

When a bdev containing a superblock is examined, search for other base
bdevs and claim them, without having to examine every base bdev
separat

raid: examine other bdevs when starting from superblock

When a bdev containing a superblock is examined, search for other base
bdevs and claim them, without having to examine every base bdev
separately.

For example, if a raid bdev is stopped and we remove one base bdev, then
add it back, this will now cause the raid bdev to be brought back up.
Earlier, we would have to re-add every base bdev.

Related to #3306

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-Id: I71193de1cdb8b3a451aa8490255d4414d81da159
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22641
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

raid: allow re-adding a base bdev with superblock

If a raid bdev is in ONLINE state and a base bdev is added that was a
member of this array, rebuild should start automatically.

Signed-off-by: Artu

raid: allow re-adding a base bdev with superblock

If a raid bdev is in ONLINE state and a base bdev is added that was a
member of this array, rebuild should start automatically.

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-Id: I30583ced59f351658d1c5029faea49fbb2ee9367
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22501
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

test/raid: always create pt bdevs in rebuild test

It doesn't hurt when superblock is not used and the code is a little
simpler this way.

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.co

test/raid: always create pt bdevs in rebuild test

It doesn't hurt when superblock is not used and the code is a little
simpler this way.

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-Id: Ic65b4f0ba4d6bd3aac531d522c35573ef0a01399
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22499
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

test/raid: remove unnecessary recreating of base bdevs

The raid bdev did not start so the superblock hasn't been written yet.

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-I

test/raid: remove unnecessary recreating of base bdevs

The raid bdev did not start so the superblock hasn't been written yet.

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-Id: I2818de16b0be2b5fd24bf3bfbff166b98386fc80
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22498
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

raid: allow re-adding base bdev when in CONFIGURING state

When a base bdev is removed from a raid bdev in CONFIGURING state, make
it possible to add it back.

Signed-off-by: Artur Paszkiewicz <artur

raid: allow re-adding base bdev when in CONFIGURING state

When a base bdev is removed from a raid bdev in CONFIGURING state, make
it possible to add it back.

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-Id: Iaced5234c62015b4a7115f246fd387b556d81146
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22497
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

test/bdev_raid: add tests with metadata

Test some cases with separate and interleaved md.

The rebuild test with interleaved md has to be run without data
verification because nbd does not support i

test/bdev_raid: add tests with metadata

Test some cases with separate and interleaved md.

The rebuild test with interleaved md has to be run without data
verification because nbd does not support interleaved metadata.

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-Id: I1192e3e0bcd8c585914ff1c4494995d671c69a53
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21687
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Mateusz Kozlowski <mateusz.kozlowski@solidigm.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

test/bdev_raid: make base bdev block size configurable

...and add some tests with 4k block.

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-Id: I0e6d2e3f966e8bfca211d37cfb76b9

test/bdev_raid: make base bdev block size configurable

...and add some tests with 4k block.

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-Id: I0e6d2e3f966e8bfca211d37cfb76b9d7a1391ffe
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21685
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

module/raid: wait for base bdev callbacks when creating raid bdev

Errors reported asynchronously (like when reading the superblock) would
be ignored. Now, bdev_raid_create RPC will not return until

module/raid: wait for base bdev callbacks when creating raid bdev

Errors reported asynchronously (like when reading the superblock) would
be ignored. Now, bdev_raid_create RPC will not return until all base
bdev callbacks have completed.

Change-Id: Icc53d88d965b878f18889ed2b6030bf37a2b915c
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20521
Tested-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

module/raid: stop rebuild when a base bdev is removed

Change-Id: Idaa594b65b36e4d80349e1fe27a77055addcfb26
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-on: https://review.

module/raid: stop rebuild when a base bdev is removed

Change-Id: Idaa594b65b36e4d80349e1fe27a77055addcfb26
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20642
Tested-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot

show more ...

module/raid: stop rebuild before the raid bdev is unregistered

Open the raid bdev internally to receive SPDK_BDEV_EVENT_REMOVE and
stop the rebuild process from the event callback. Unregistering wil

module/raid: stop rebuild before the raid bdev is unregistered

Open the raid bdev internally to receive SPDK_BDEV_EVENT_REMOVE and
stop the rebuild process from the event callback. Unregistering will
be performed after the descriptor is closed. The process needs to be
stopped before the destruct callback, because stopping the rebuild
process may require unquiescing a range, which requires the bdev
spin lock, which is destroyed before the bdev module's destruct()
callback is called.

We will look later at trying to fix this problem at bdev layer, to
avoid bdev modules having to open themselves to avoid these kinds of
problems.

Change-Id: Ic9c5bf14f785aaf7629bf1c9d2e1889e254cec5f
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20830
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

raid5f: rebuild support

Change-Id: I311c3a6809f282993d5fd84dd6a95d798b63b353
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1

raid5f: rebuild support

Change-Id: I311c3a6809f282993d5fd84dd6a95d798b63b353
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18820
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

test/bdev_raid: test rebuild with io

Change-Id: I1f7145668267f2fc6bc36eaef900a1cd1b7f47a0
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/

test/bdev_raid: test rebuild with io

Change-Id: I1f7145668267f2fc6bc36eaef900a1cd1b7f47a0
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18743
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

test/bdev_raid: test rebuild

Change-Id: Ia98d2606dfaf7b013c6c05678dc3666ca1ce838b
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spd

test/bdev_raid: test rebuild

Change-Id: Ia98d2606dfaf7b013c6c05678dc3666ca1ce838b
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18742
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...