env: add opts_size to spdk_env_optsThis will help with ABI compatibility as new fields get addedto this structure.User is responsible for setting opts_size. Major version has beenbumped, so use
env: add opts_size to spdk_env_optsThis will help with ABI compatibility as new fields get addedto this structure.User is responsible for setting opts_size. Major version has beenbumped, so users will need to rebuild against latest code, if theydo not set opts_size we will just treat that as if the structureends right before opts_size. We will also print an ERRLOG to warnuser to set opts_size appropriately.As part of this patch, update all in-tree callers ofspdk_env_opts_init() to set the opts_size.Signed-off-by: Jim Harris <jim.harris@samsung.com>Change-Id: If2611eccc8b3c43e1dc1654028d000a8a12a544eReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23940Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>Reviewed-by: Tomasz Zawadzki <tomasz@tzawadzki.com>
show more ...
update Intel copyright noticesper Intel policy to include file commit date using git cmdbelow. The policy does not apply to non-Intel (C) notices.git log --follow -C90% --format=%ad --date defa
update Intel copyright noticesper Intel policy to include file commit date using git cmdbelow. The policy does not apply to non-Intel (C) notices.git log --follow -C90% --format=%ad --date default <file> | tail -1and then pull just the 4 digit year from the result.Intel copyrights were not added to files where Intel either hadno contribution ot the contribution lacked substance (ie licenseheader updates, formatting changes, etc). Contribution date used"--follow -C95%" to get the most accurate date.Note that several files in this patch didn't end the license/(c)block with a blank comment line so these were added as the vastmajority of files do have this last blank line. Simply there forconsistency.Signed-off-by: paul luse <paul.e.luse@intel.com>Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Jim Harris <james.r.harris@intel.com>Reviewed-by: Ben Walker <benjamin.walker@intel.com>Community-CI: Mellanox Build Bot
Replace most BSD 3-clause license text with SPDX identifier.Many open source projects have moved to using SPDX identifiersto specify license information, reducing the amount ofboilerplate code in
Replace most BSD 3-clause license text with SPDX identifier.Many open source projects have moved to using SPDX identifiersto specify license information, reducing the amount ofboilerplate code in every source file. This patch replacesthe bulk of SPDK .c, .cpp and Makefiles with the BSD-3-Clauseidentifier.Almost all of these files share the exact same license text,and this patch only modifies the files that contain themost common license text. There can be slight variationsbecause the third clause contains company names - most say"Intel Corporation", but there are instances for Nvidia,Samsung, Eideticom and even "the copyright holder".Used a bash script to automate replacement of the license textwith SPDX identifier which is checked into scripts/spdx.sh.Signed-off-by: Jim Harris <james.r.harris@intel.com>Change-Id: Iaa88ab5e92ea471691dc298cfe41ebfb5d169780Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12904Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>Reviewed-by: Dong Yi <dongx.yi@intel.com>Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>Reviewed-by: Paul Luse <paul.e.luse@intel.com>Reviewed-by: <qun.wan@intel.com>
test/app: add missed spdk_env_fini() or spdk_app_fini() when exitingChange-Id: I9d511713277ea85d34e0a0e59b570fcbfa014fb1Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>Reviewed-on: https://
test/app: add missed spdk_env_fini() or spdk_app_fini() when exitingChange-Id: I9d511713277ea85d34e0a0e59b570fcbfa014fb1Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10911Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Jim Harris <james.r.harris@intel.com>Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
build: move app rules to spdk.app.mkThis removes a ton of duplicate from a lot ofMakefiles. Note that spdk.unittest.mk still keepsits own app rules, and now just includesspdk.app_vars.mk instea
build: move app rules to spdk.app.mkThis removes a ton of duplicate from a lot ofMakefiles. Note that spdk.unittest.mk still keepsits own app rules, and now just includesspdk.app_vars.mk instead. Fixing Makefiles thatinclude this .mk file requires more work that isdeferred for now. We do need to add the"install: all" rule explicitly to this .mk files.Note that Makefiles need to include spdk.app.mknow at the end of the file, so that things likeAPP and SPDK_LIB_LIST are defined before includingit.Signed-off-by: Jim Harris <james.r.harris@intel.com>Change-Id: If6823cda135180c37690ffc96c91660b7f0718e3Reviewed-on: https://review.gerrithub.io/434283Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>Reviewed-by: Ben Walker <benjamin.walker@intel.com>
build: add ENV_LINKER_ARGS to LINK_C and LINK_CXXThis allows us to remove $(ENV_LINKER_ARGS) from all of theapplication Makefiles.Modify spdk.unittest.mk to explicitly set ENV_LINKER_ARGSto not
build: add ENV_LINKER_ARGS to LINK_C and LINK_CXXThis allows us to remove $(ENV_LINKER_ARGS) from all of theapplication Makefiles.Modify spdk.unittest.mk to explicitly set ENV_LINKER_ARGSto nothing, to avoid DPDK libraries from getting linkedinto unit tests. This seems better than creating separateLINK_C rules for unit tests. Provide a UNIT_TEST_LINK_ENVflag to allow select unit tests to override this behavior -it's needed for some of the env unit tests.Signed-off-by: Jim Harris <james.r.harris@intel.com>Change-Id: I647f2c848cf434023cf5a1f3a45869bbc4fc8102Reviewed-on: https://review.gerrithub.io/434145Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
jsoncat, histogram_perf: add missing dependenciesThese weren't needed for static linking, but poppedup as problems with some upcoming patches enablingindividual shared libraries.Signed-off-by:
jsoncat, histogram_perf: add missing dependenciesThese weren't needed for static linking, but poppedup as problems with some upcoming patches enablingindividual shared libraries.Signed-off-by: Jim Harris <james.r.harris@intel.com>Change-Id: Iba13926bd504831046eeb48da8f35e7df9ef8801Reviewed-on: https://review.gerrithub.io/422442Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>Reviewed-by: Ben Walker <benjamin.walker@intel.com>Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
thread: Move threading abstraction code out of utilThis makes more sense as a first class library.Change-Id: Ibd5c578f8708bd8c7d83fe1629e97c9a3316b56bSigned-off-by: Ben Walker <benjamin.walker@i
thread: Move threading abstraction code out of utilThis makes more sense as a first class library.Change-Id: Ibd5c578f8708bd8c7d83fe1629e97c9a3316b56bSigned-off-by: Ben Walker <benjamin.walker@intel.com>Reviewed-on: https://review.gerrithub.io/414698Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>Reviewed-by: Jim Harris <james.r.harris@intel.com>Reviewed-by: Madhu Pai <mpai@netapp.com>
test: move histogram_perf under the app directoryChange-Id: I3740d1a6744181bb93c07e9a5c58d0c5f4cc404eSigned-off-by: Seth Howell <seth.howell@intel.com>Reviewed-on: https://review.gerrithub.io/404
test: move histogram_perf under the app directoryChange-Id: I3740d1a6744181bb93c07e9a5c58d0c5f4cc404eSigned-off-by: Seth Howell <seth.howell@intel.com>Reviewed-on: https://review.gerrithub.io/404970Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>Reviewed-by: Jim Harris <james.r.harris@intel.com>Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>