module/accel/dsa: add DIX Verify

DIX Verify is not defined as a standard operation with its own OPCODE
and descriptors inside DSA module. This means we cannot submit it as
is to the hardware.
To int

module/accel/dsa: add DIX Verify

DIX Verify is not defined as a standard operation with its own OPCODE
and descriptors inside DSA module. This means we cannot submit it as
is to the hardware.
To introduce support for DIX Verify use DIX Generate on available
source buffer and then compare the resulting protection information
with the one provided inside original metadata buffer.

Change-Id: Ia427e745cfcc13e9e615bf28cce452be415b2acf
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24342
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

test/accel/dif: add DIX Verify/Generate suites

Add DIX Verify and Generate test suites to dif test application.
Additionally, add DIF/DIX strings to test descriptions.

Change-Id: I69989c7cfebc20836

test/accel/dif: add DIX Verify/Generate suites

Add DIX Verify and Generate test suites to dif test application.
Additionally, add DIF/DIX strings to test descriptions.

Change-Id: I69989c7cfebc20836de889f978ebfcdc3754d9ab
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24056
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

dif: Remove alignment requirement from spdk_dif_generate_copy()

spdk_dif_generate_copy() required each iovec of bounce buffer to be
multiple of block size length. This was too strong.

Software impl

dif: Remove alignment requirement from spdk_dif_generate_copy()

spdk_dif_generate_copy() required each iovec of bounce buffer to be
multiple of block size length. This was too strong.

Software implementation should not have strong limitation on
configuration.

Remove the limitation in this patch.

Modify the functional test of the DIF feature of the accel framework
slightly. The total length of the iovec still should be larger than
payload length.

spdk_dif_verify_copy() have the same strong limitation. However, in unit
tests, spdk_dif_generate_copy() and spdk_dif_verify_copy() are a pair
and share the same bounce buffer.

If we add bugs to both of spdk_dif_generate_copy() and
spdk_dif_verify_copy(), it is likely that the bugs are not found in
unit tests. Hence, this patch changes only spdk_dif_generate_copy().
The next patch will change spdk_dif_verify_copy().

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ib50299a8b337a4825708891f9739e72a862fbf49
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23846
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

test/accel_dif: Add DIF generate/verify_copy sequence test cases

Add simple test cases for DIF generate_copy and verify_copy sequence.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change

test/accel_dif: Add DIF generate/verify_copy sequence test cases

Add simple test cases for DIF generate_copy and verify_copy sequence.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I4c94b8dab6548a1280e2ad57608cd55dfd0af096
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23740
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

test/accel: DIF accel functional tests refactor

Modified the names of functions for allocating/freeing buffers
used during DIF tests.
Changed error handling for alloc/free from asserts to return err

test/accel: DIF accel functional tests refactor

Modified the names of functions for allocating/freeing buffers
used during DIF tests.
Changed error handling for alloc/free from asserts to return errors.
Replaced the use of CU_ASSERT to SPDK_CU_ASSERT_FATAL macro.

Change-Id: I2bb8a84be1d989b272eca1bc61d47d57811b03b7
Signed-off-by: Krzysztof Sprzaczkowski <krzysztof.sprzaczkowski@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23041
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

test/accel: DIF verify copy accel functional tests

Add the Accel test application with functional tests
to validate DIF Verify-copy operation.

Change-Id: Ib5ab1b4bd037eb0a50fff1bb992eb8a15e9e8592
S

test/accel: DIF verify copy accel functional tests

Add the Accel test application with functional tests
to validate DIF Verify-copy operation.

Change-Id: Ib5ab1b4bd037eb0a50fff1bb992eb8a15e9e8592
Signed-off-by: Krzysztof Sprzaczkowski <krzysztof.sprzaczkowski@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22097
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

apps: set NULL as RPC address in some apps

Set opts.rpc_addr to NULL in SPDK applications that usually do not
benefit from starting RPC interface. These include programs in app,
examples and test di

apps: set NULL as RPC address in some apps

Set opts.rpc_addr to NULL in SPDK applications that usually do not
benefit from starting RPC interface. These include programs in app,
examples and test directories.

Some of the tests now require that we explicitly set RPC address,
because some apps no longer use the default SPDK address.

Change-Id: I417a3a756581f44c711257e6d2408d933b40386a
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22634
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

test/accel: DIF generate-copy accel functional tests

Extend the Accel test application with DIF Generate-copy operation
functional tests.

Change-Id: Ieede33af582c81cb68cc2acb69f8e0bb86f24c06
Signed

test/accel: DIF generate-copy accel functional tests

Extend the Accel test application with DIF Generate-copy operation
functional tests.

Change-Id: Ieede33af582c81cb68cc2acb69f8e0bb86f24c06
Signed-off-by: Krzysztof Sprzaczkowski <krzysztof.sprzaczkowski@intel.com>
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20283
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

test/accel: DIF verify accel functional tests

Add the Accel test application with functional tests
to validate DIF Verify operation.

Change-Id: Ie285e4cdc4b70fa6323cd4844fad3f179a0f0675
Signed-off-

test/accel: DIF verify accel functional tests

Add the Accel test application with functional tests
to validate DIF Verify operation.

Change-Id: Ie285e4cdc4b70fa6323cd4844fad3f179a0f0675
Signed-off-by: Krzysztof Sprzaczkowski <krzysztof.sprzaczkowski@intel.com>
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20282
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...