scripts/setup.sh: Use HUGE_EVEN_ALLOC logic by default

To that end, remove it altogether and allow setup.sh to always split
requested amount of hugepages across all available nodes. Custom
setups pe

scripts/setup.sh: Use HUGE_EVEN_ALLOC logic by default

To that end, remove it altogether and allow setup.sh to always split
requested amount of hugepages across all available nodes. Custom
setups per node are still available through the HUGENODE var.

Adjust some of the hugepages.sh tests to adhere to the new default.
This change allows us to remove the per_node_1G_alloc() test since
its flow is now covered by the custom_alloc().

By default, autotest.sh sets HUGEMEM=4096 and by spreading it across
all the nodes, for the minimal scenario, we get only 2GB on a single
node. For vhost tests, the default alloc per VM via vm_setup() is set
to 1GB so sharing that 2GB between qemu and SPDK spreads it a bit too
thin.

Case in point, for vhost.vhost_blk_packed_ring_integrity test roughly
> 600 hugepages is used for vhost. Since it slurps everything from
node0, only < 512 remains. Since VMs are assigned per node, the most
basic setups keep VM_*_qemu_numa_node set to 0. This is then used by
qemu to bind to a specific node. With 1G, < 512 hugepages is simply
not enough.

With that in mind, for vhost tests, keep all allocations on a single
node instead of trying to figure out right amount of memory per node
to keep the old behavior in (this may change in the future when
SPDK/vhost becomes numa-aware).

Change-Id: I83e18bfa4cc6de0a777804b354de083ae6ae9d8c
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24176
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz@tzawadzki.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

setup/interactive: Rewrite bdevices()

This option is used to bind a device to a given driver. It was a bit
hard to follow what argument needed to be passed there so split the
dev and driver selectio

setup/interactive: Rewrite bdevices()

This option is used to bind a device to a given driver. It was a bit
hard to follow what argument needed to be passed there so split the
dev and driver selection into separate routines. Add small wrapper
function to print some extra driver info for selected device.

Change-Id: Ia870d8e4314c02f364c2264bf3266cd0077e7e9a
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22316
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

setup/interactive: Silence status()'s stderr

If something happens in the background, i.e. some device goes away,
status() may fail to fetch some info (like numa_node) printing out
an ugly warning. S

setup/interactive: Silence status()'s stderr

If something happens in the background, i.e. some device goes away,
status() may fail to fetch some info (like numa_node) printing out
an ugly warning. Simply ignore it.

Change-Id: I56bc830e5832273c34999adae65e798459aba143
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22315
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>

show more ...

setup/interactive: Add update_status wrapper

Allow for the relevant options to fall through and call to it.

Change-Id: I70d1daa3b9a5ad4c9da79e34545580145c84d93a
Signed-off-by: Michal Berger <michal

setup/interactive: Add update_status wrapper

Allow for the relevant options to fall through and call to it.

Change-Id: I70d1daa3b9a5ad4c9da79e34545580145c84d93a
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22314
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

scripts: Commonize routines for creating map of supported devices

It may be useful to have these outside of setup.sh for various
use-cases, e.g. VMD handling.

This comes with several enhancements:

scripts: Commonize routines for creating map of supported devices

It may be useful to have these outside of setup.sh for various
use-cases, e.g. VMD handling.

This comes with several enhancements:

- drop of the redundant driver lookup; using solely pci_bus_driver[]
- more detailed message regarding the VMD setup and nvme drives that
may be behind it

Change-Id: I5d5289fa8af435d036b75ac1fdcf9fa5ad7e53bf
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21063
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

scripts/setup: Add some extra details to pdevices()

To allow user identify given devices easier, especially when they
are bound to userspace drivers.

Change-Id: I66d4de6204aa62b23a0ddec4ff851fdc614

scripts/setup: Add some extra details to pdevices()

To allow user identify given devices easier, especially when they
are bound to userspace drivers.

Change-Id: I66d4de6204aa62b23a0ddec4ff851fdc61490fc3
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19443
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@gmail.com>

show more ...

scripts/setup: Add quick interactive mode

Change-Id: I08dde2baba4967e1bf5c8944dd7513fc010d6d11
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spd

scripts/setup: Add quick interactive mode

Change-Id: I08dde2baba4967e1bf5c8944dd7513fc010d6d11
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19442
Reviewed-by: Jim Harris <jim.harris@gmail.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot

show more ...

scripts/setup: Add editor mode

This mode is meant to immitate (poorly) git's interactive mode by
allowing user to modify list of devices in the $EDITOR.

For now use it only for overriding the "in u

scripts/setup: Add editor mode

This mode is meant to immitate (poorly) git's interactive mode by
allowing user to modify list of devices in the $EDITOR.

For now use it only for overriding the "in use" state of the device.
Option is hidden under '5e'.

Change-Id: I1739cb7f2cd74b26dd10de9bdf515238d816ba93
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19440
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@gmail.com>

show more ...

scripts/setup: Interactive mode

Present a "hook" which allows setup.sh to enter interactive mode.
In this mode user can inspect setups.sh's view of the system and
adjust it if needed before falling

scripts/setup: Interactive mode

Present a "hook" which allows setup.sh to enter interactive mode.
In this mode user can inspect setups.sh's view of the system and
adjust it if needed before falling back to one of the main modes
(config, reset).

Change-Id: Ia945172fc7d50ffebc2da80310411c85b3957a99
Signed-off-by: Michal Berger <michal.berger@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18356
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benwalker@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot

show more ...