lib/event: Add support for core isolation in scheduling

Added new 'scheduler_set_options' RPC.
1. isolated_core_mask: Users are allowed to select cores to isolate during scheduling
2. scheduling_cor

lib/event: Add support for core isolation in scheduling

Added new 'scheduler_set_options' RPC.
1. isolated_core_mask: Users are allowed to select cores to isolate during scheduling
2. scheduling_core: Users are allowed to select main core of scheduling
This RPC can only be called before SPDK subsystems have been initialized.
These parameters can only be set once.

The following options are for general mechanisms.
For example, dynamic scheduler now allows specific cores to be isolated from scheduling
through the newly added isolated_core_mask. This means that no threads can enter
or leave the cores designated as isolated cores.

Core isolation can be useful in the following situation:
The user may want the main core to be dedicated to orchestration tasks(such as RPCs, etc.)
and does not want any IO work to be assigned to it while running dynamic scheduler.
These changes allow user to dedicate main thread for RPC, assign nvmf poll groups to
non-main thread cores, and then ensure that dynamic(or any other) scheduler will
not place any other spdk_threads on the main core.

Change-Id: Idb5e564150d014cec7106d48d609d83490561a94
Signed-off-by: SeungYeon Shin <syeon.shin@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23156
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

show more ...

scheduler/dynamic: adjust frequency when core goes to sleep or wakes

When all spdk_threads have been moved to the scheduling core because
they are all idle, we will try to reduce frequency on the sc

scheduler/dynamic: adjust frequency when core goes to sleep or wakes

When all spdk_threads have been moved to the scheduling core because
they are all idle, we will try to reduce frequency on the scheduling
core if it is still idle. But the frequency changes don't take effect
if it has an SMT sibling which is still set to max frequency.

So when we have moved the last thread off of a core, set its frequency
to min. And conversely, when we move the first thread onto a core,
set its frequency to max.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I034194d553aa678d387b1b5448631ba4ffcbb3d3
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23649
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

event: enforce 1 second default scheduling period

Currently the scheduling period was an optional parameter for
the framework_set_scheduler RPC. The 'dynamic' scheduler
enforced its own default by e

event: enforce 1 second default scheduling period

Currently the scheduling period was an optional parameter for
the framework_set_scheduler RPC. The 'dynamic' scheduler
enforced its own default by explicitly setting the period
to 1 second during init, if no value had been specified.

But other schedulers (gscheduler) didn't have that same code.
We could add it, but it's better to just enforce this when
the scheduler is first set - if user didn't pass a period,
set it to 1s.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Ie2e1b3326438b34ebe0f3f65bf568e16621a288b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22593
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to preve

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components

Due to patch below being introduced after v24.01 code freeze,
bdev lib version should not be increased:
61623c5ca9 bdev: add spdk_bdev_io padding in place of io_submit_ch

Short reference to how the versions were changed:
MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)
for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \
sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; done
find . -name "Makefile" -exec \
sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I0166d6be6c17bbbf985d48b5dfcb36f1d4af1b48
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21582
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

scheduler/dynamic: Add assert to check for operation success

spdk_reactor_get() may return NULL if it's unable to get the reactor. It is a critical error, so we can safely add assert there.

Change-

scheduler/dynamic: Add assert to check for operation success

spdk_reactor_get() may return NULL if it's unable to get the reactor. It is a critical error, so we can safely add assert there.

Change-Id: Iba10178b45891ece2e71626b16c75d956902a78d
Signed-off-by: Wojciech Panfil <wojciech.panfil@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18926
Reviewed-by: Kamuda Szymon <szymon.kamuda@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jacek Kalwas <jacek.kalwas@intel.com>

show more ...

so_ver: increase all major versions

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where

so_ver: increase all major versions

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

Disabled test for increasing SO version without ABI change, as
that is goal of this patch. This check shall be removed with SPDK 23.05
release.
Looks like this was left over from prior LTS, to avoid that
make sure it is only skipped when running against v23.01.x as latest
release.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components
- removes suppressions for ABI tests


Short reference to how the versions were changed:
MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)
for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \
sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; done
find . -name "Makefile" -exec \
sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +

Change-Id: I3e5681802c0a5ac6d7d652a18896997cd07cc8bf
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16419
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date defa

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the 4 digit year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc). Contribution date used
"--follow -C95%" to get the most accurate date.

Note that several files in this patch didn't end the license/(c)
block with a blank comment line so these were added as the vast
majority of files do have this last blank line. Simply there for
consistency.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot

show more ...