replace strtok with strtok_r

The strtok function is not reentrant. To address this issue in a
multithreaded environment, the strtok_r function should be used,
which is the reentrant version of strto

replace strtok with strtok_r

The strtok function is not reentrant. To address this issue in a
multithreaded environment, the strtok_r function should be used,
which is the reentrant version of strtok.

Signed-off-by: XuQi <1530865185@qq.com>
Change-Id: I35c07c7cf4e20bacb7b1e7c7adaedfcd1a81f86e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25492
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot

show more ...

nvmf: dump allowed digests/dhgroups configuration

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I7cb6fe79b54578aaf535ef08d90ae8fe6320c6c3
Reviewed-on: https://review.spdk.io/ge

nvmf: dump allowed digests/dhgroups configuration

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I7cb6fe79b54578aaf535ef08d90ae8fe6320c6c3
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24228
Community-CI: Mellanox Build Bot
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvmf/auth: set allowed digests/dhgroups

It's now possible to limit the allowed digests/dhgroups used during the
DH-HMAC-CHAP authentication on the target side.

Signed-off-by: Konrad Sztyber <konrad

nvmf/auth: set allowed digests/dhgroups

It's now possible to limit the allowed digests/dhgroups used during the
DH-HMAC-CHAP authentication on the target side.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I636afba765075df2a6c71e7287cbe47550446120
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22909
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

nvmf: unify target options handling

These options are already part of spdk_nvmf_target_opts, so it doesn't
make sense to have separate global variables to store them.

Signed-off-by: Konrad Sztyber

nvmf: unify target options handling

These options are already part of spdk_nvmf_target_opts, so it doesn't
make sense to have separate global variables to store them.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ia7566d254d5201daac7a39b3da81a210fff31f4c
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22908
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvmf: track spdk_nvmf_target_opts's size

We'll be adding more fields to this structure in the future, so let's
track its size for ensuring ABI compatibility.

Signed-off-by: Konrad Sztyber <konrad.s

nvmf: track spdk_nvmf_target_opts's size

We'll be adding more fields to this structure in the future, so let's
track its size for ensuring ABI compatibility.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Id3cb8185968a3cd2950d5e0a4ca7b5f4247a7f0d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22907
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

nvmf: change type of discover_filter to uint32_t

We treat it as a bitmask of multiple discovery filter rules rather than
a value describing a single filter.

Signed-off-by: Konrad Sztyber <konrad.sz

nvmf: change type of discover_filter to uint32_t

We treat it as a bitmask of multiple discovery filter rules rather than
a value describing a single filter.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ibea52a87b89548702b100433499324e4346e0522
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22906
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

nvmf: always use 3 digits for nvmf_tgt_poll_group thread name

This helps with consistency on the names, including sorting.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I8ea48b2620f

nvmf: always use 3 digits for nvmf_tgt_poll_group thread name

This helps with consistency on the names, including sorting.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I8ea48b2620f67fabfa9bb482d6b1947440145517
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23017
Reviewed-by: Ankit Kumar <ankit.kumar@samsung.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvmf/tcp: use keyring for retrieving PSKs

It is now possible to retrieve TLS PSKs from the keyring. The previous
method of specifying a path to a file containing the key is still
functional, but it

nvmf/tcp: use keyring for retrieving PSKs

It is now possible to retrieve TLS PSKs from the keyring. The previous
method of specifying a path to a file containing the key is still
functional, but it's deprecated and will be removed in the future.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Iea1ff6918056f910f0fc3e030886cdba1e24b7e9
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21757
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

nvmf: stop listen before destroying poll groups

Handling new connections can race with destroying the poll groups so
stop listening before that.

Fixes #3273

Signed-off-by: Artur Paszkiewicz <artur

nvmf: stop listen before destroying poll groups

Handling new connections can race with destroying the poll groups so
stop listening before that.

Fixes #3273

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Change-Id: I055b5a5335ec61b6f6d9f8aee785f746fdbc5d9b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22168
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to preve

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components

Due to patch below being introduced after v24.01 code freeze,
bdev lib version should not be increased:
61623c5ca9 bdev: add spdk_bdev_io padding in place of io_submit_ch

Short reference to how the versions were changed:
MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)
for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \
sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; done
find . -name "Makefile" -exec \
sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I0166d6be6c17bbbf985d48b5dfcb36f1d4af1b48
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21582
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

lib/nvmf: TP 8014 - Current Discovery Subsystem

Added support for the Current Discovery Subsystem
value of the Subsystem Type in the Discovery
Log Page Entry.

Change introduced in TP 8014

Change-I

lib/nvmf: TP 8014 - Current Discovery Subsystem

Added support for the Current Discovery Subsystem
value of the Subsystem Type in the Discovery
Log Page Entry.

Change introduced in TP 8014

Change-Id: I9a35ba24ecfdc2bbcc81baae80575e37ae1a866d
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19839
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

nvmf: add spdk_nvmf_request_copy_*_buf()

Also deprecate the existing spdk_nvmf_request_data() API, which is
incompatible with iovecs.

Signed-off-by: John Levon <john.levon@nutanix.com>
Change-Id: I

nvmf: add spdk_nvmf_request_copy_*_buf()

Also deprecate the existing spdk_nvmf_request_data() API, which is
incompatible with iovecs.

Signed-off-by: John Levon <john.levon@nutanix.com>
Change-Id: I44df8ff30a431873a0c2f34b0cdb58df858fd7e3
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16200
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

so_ver: increase all major versions

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where

so_ver: increase all major versions

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

Disabled test for increasing SO version without ABI change, as
that is goal of this patch. This check shall be removed with SPDK 23.05
release.
Looks like this was left over from prior LTS, to avoid that
make sure it is only skipped when running against v23.01.x as latest
release.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components
- removes suppressions for ABI tests


Short reference to how the versions were changed:
MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)
for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \
sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; done
find . -name "Makefile" -exec \
sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +

Change-Id: I3e5681802c0a5ac6d7d652a18896997cd07cc8bf
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16419
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...