bdev/rbd: Discard zero block size, to avoid dividing by 0.

Fixes issue #3263.

Change-Id: Ib2d291f88cece2d0915510d6ee370aab966acadd
Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>

bdev/rbd: Discard zero block size, to avoid dividing by 0.

Fixes issue #3263.

Change-Id: Ib2d291f88cece2d0915510d6ee370aab966acadd
Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21934
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to preve

so_ver: increase all major versions after SPDK 24.01

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components

Due to patch below being introduced after v24.01 code freeze,
bdev lib version should not be increased:
61623c5ca9 bdev: add spdk_bdev_io padding in place of io_submit_ch

Short reference to how the versions were changed:
MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)
for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \
sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; done
find . -name "Makefile" -exec \
sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I0166d6be6c17bbbf985d48b5dfcb36f1d4af1b48
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21582
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

lib, module: use spdk_json_write_named_uuid

Use spdk_json_write_named_uuid everywhere possible, instead of the older
spdk_uuid_fmt_lower+spdk_json_write_named_string approach.

Signed-off-by: Jim Ha

lib, module: use spdk_json_write_named_uuid

Use spdk_json_write_named_uuid everywhere possible, instead of the older
spdk_uuid_fmt_lower+spdk_json_write_named_string approach.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I75f97efb6e88fdb032f7ae94f11039457ba70f2a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20562
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

rpc: use spdk_json_decode_uuid() to decode UUIDs

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I99e5d44d2cea4d50219b44e4595379a3a17bd11f
Reviewed-on: https://review.spdk.io/ger

rpc: use spdk_json_decode_uuid() to decode UUIDs

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I99e5d44d2cea4d50219b44e4595379a3a17bd11f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20475
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

bdev/rbd: use spdk_bdev to get a handle to bdev_rbd

Previously, the code used to get an IO channel to get a handle to
bdev_rbd, but that's not necessary (and can potentially fail), as we can
get the

bdev/rbd: use spdk_bdev to get a handle to bdev_rbd

Previously, the code used to get an IO channel to get a handle to
bdev_rbd, but that's not necessary (and can potentially fail), as we can
get the bdev_rbd pointer from spdk_bdev (it's safe to do because we
already check that bdev->module points at rbd_if).

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I4bedf187b3ee328d4238030e9057ffa39a05f7a5
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20078
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

bdev/rbd: react to size change on rbd

Change-Id: I6d69c1b2badc1029b4f9e48c83bdffef595c3c44
Signed-Off-By: Philipp Riederer <priederer@genesiscloud.com>
Reviewed-on: https://review.spdk.io/gerrit/c/s

bdev/rbd: react to size change on rbd

Change-Id: I6d69c1b2badc1029b4f9e48c83bdffef595c3c44
Signed-Off-By: Philipp Riederer <priederer@genesiscloud.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18945
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

bdev/rbd: Do not access rbd pool ctx list when no shared cluster used

When a rbd bdev does not use shared rados object, we do not
need to access the rbd pool ctx list. This can save the memory space

bdev/rbd: Do not access rbd pool ctx list when no shared cluster used

When a rbd bdev does not use shared rados object, we do not
need to access the rbd pool ctx list. This can save the memory space.

Signed-off-by: Ziye Yang <ziye.yang@intel.com>
Change-Id: Ieffc1a9e2290a89ba06f3fdfe308a3774bd4492f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18589
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>

show more ...

bdev/rbd: Share the rados_ioctx_t if images are from same pool

For rbd images belonging to the same rados pool,
we can share the rados_ioctx_t structure, then it
can save the librados related resour

bdev/rbd: Share the rados_ioctx_t if images are from same pool

For rbd images belonging to the same rados pool,
we can share the rados_ioctx_t structure, then it
can save the librados related resource in client side.

Because there is a configuration parameter `librados_thread_count`
which is reponsible for io_context_pool. Then if
we can share the same rados_ioctx_t if we have the same rados
pool under shared rados_t. It can save the client resources when
there are multiple images in the same pool.

Change-Id: I7f71191d7dd72eec359840a5767da74ff6e4ec92
Signed-off-by: Ziye Yang <ziye.yang@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18107
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>

show more ...

bdev/rbd: Remove main_td field in struct bdev_rbd

Because we always create bdev_rbd instance in
spdk_thread_get_app_thread() thread.

This patch fixes the issue found in another ongoing patch:
In mo

bdev/rbd: Remove main_td field in struct bdev_rbd

Because we always create bdev_rbd instance in
spdk_thread_get_app_thread() thread.

This patch fixes the issue found in another ongoing patch:
In most cases, rbd->main_td was set, meaning that td
did not equal spdk_get_thread() here. But now this this
patch completely fixes this issue.

Signed-off-by: Ziye Yang <ziye.yang@intel.com>
Change-Id: Ieaf9dd6a95bb63b51623070822b36a0ee32fe2a5
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18271
Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

rbd_bdev: add core mask for librbd/librados threads

Add core_mask option to allow specify core mask for librbd/librados
threads (non-spdk threads), when registering rbd cluster via bdev_rbd_register

rbd_bdev: add core mask for librbd/librados threads

Add core_mask option to allow specify core mask for librbd/librados
threads (non-spdk threads), when registering rbd cluster via bdev_rbd_register_cluster.
Also, update bdev_rbd_get_clusters_info to get librbd/librados core mask.

Signed-off-by: Yue-Zhu <yue.zhu@ibm.com>
Change-Id: Iedeb508bbcf2ec97c3fdd81a6564bbddb4fc660a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16451
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot

show more ...

bdev/rbd: add compare and write support

This patch adds native support for compare and write
through librbd (>=17.2.6).

Change-Id: Iac83d0b9cefddaed5df8b1985d07d72bf2217bf5
Signed-off-by: Jonas Pfe

bdev/rbd: add compare and write support

This patch adds native support for compare and write
through librbd (>=17.2.6).

Change-Id: Iac83d0b9cefddaed5df8b1985d07d72bf2217bf5
Signed-off-by: Jonas Pfefferle <pepperjo@japf.ch>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17981
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ziye Yang <ziye.yang@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

bdev/rbd: refactor rbd start aio switch/case

Use switch/case instead of if/else for io types when starting
rbd aio.

Change-Id: I4f8b8deb73fbf95f12da96f162125512d676338c
Signed-off-by: Jonas Pfeffer

bdev/rbd: refactor rbd start aio switch/case

Use switch/case instead of if/else for io types when starting
rbd aio.

Change-Id: I4f8b8deb73fbf95f12da96f162125512d676338c
Signed-off-by: Jonas Pfefferle <pepperjo@japf.ch>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18088
Community-CI: Mellanox Build Bot
Reviewed-by: Ziye Yang <ziye.yang@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>

show more ...

bdev/rbd: Do not submit IOs through thread sending.

Currently, we send IOs to the main_td thread.
It is not needed, because all the read/write functions
provided by librbd are thread safe, so we can

bdev/rbd: Do not submit IOs through thread sending.

Currently, we send IOs to the main_td thread.
It is not needed, because all the read/write functions
provided by librbd are thread safe, so we can eliminate the
thread send messaging policy for read/write related functions.

And with this patch, users can observe the load balance
distribution of I/Os on each CPU core owned by spdk applications
through spdk_top tool.

In this patch, we did the following work:

1 Move rbd_open when create the bdev since we will create once.
2 Simplify the channel management.
3 Do not use thread send messaging to do the read/write I/Os.

According to our experiment results showed in
https://github.com/spdk/spdk/issues/2204

There will be more than 15% performance improvment in IOPS aspect
for different write I/O patterns, and it also addresses the I/O Load
balance issues.

Fixes issue: #2204

Change-Id: I9d2851c3d772261c131f9678f4b1bf722328aabb
Signed-off-by: Ziye Yang <ziye.yang@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17644
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

bdev: delete UUID generation from ephemeral bdevs

Ensure no ephemeral bdev will generate its own UUID,
unless this value has been specified via RPC.
Generation is now being done by the bdev layer it

bdev: delete UUID generation from ephemeral bdevs

Ensure no ephemeral bdev will generate its own UUID,
unless this value has been specified via RPC.
Generation is now being done by the bdev layer itself.

Change-Id: I11efe819a28a137b738959a96a7bdf8c79cfaf64
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17109
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

bdev/rbd: fix double-free when failing to initialize cluster

When bdev_rados_cluster_init encounters an error, it shuts down the cluster
before returning, but since the pointer is still set, bdev_rb

bdev/rbd: fix double-free when failing to initialize cluster

When bdev_rados_cluster_init encounters an error, it shuts down the cluster
before returning, but since the pointer is still set, bdev_rbd_free will
attempt to shut it down again, which causes a crash.
Therefore, set the pointer to NULL after the first shutdown to indicate
that the cluster object does not exist anymore.

Change-Id: Ie403471e8aba881cb6380e74bd1a4ca8d67cbc68
Signed-off-by: Lukas Stockner <lstockner@genesiscloud.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16203
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

show more ...

so_ver: increase all major versions

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where

so_ver: increase all major versions

To allow SO_MINOR updates on LTS for the whole year it is supported,
the major version for all components needs to be increased.
This is to prevent scenario where two versions exists with matching
versions, but conflicting ABI.
Ex. Next SPDK release adds an API call increasing the minor version,
then LTS needs just a subset of those additions.

Increasing major so version after LTS, allows the future releases
to update versions as needed. Yet allowing LTS to increase minor
version separately.

Disabled test for increasing SO version without ABI change, as
that is goal of this patch. This check shall be removed with SPDK 23.05
release.
Looks like this was left over from prior LTS, to avoid that
make sure it is only skipped when running against v23.01.x as latest
release.

This patch:
- increases SO_VER by 1 for all components
- resets SO_MINOR to 0 for all components
- removes suppressions for ABI tests


Short reference to how the versions were changed:
MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)
for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \
sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; done
find . -name "Makefile" -exec \
sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +

Change-Id: I3e5681802c0a5ac6d7d652a18896997cd07cc8bf
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16419
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

bdev/rbd: limit operations performed on main thread

Previously, it was possible to execute spdk_bdev_io_get_buf() on a
different thread than the one that the IO was submitted on, which is
unsafe. N

bdev/rbd: limit operations performed on main thread

Previously, it was possible to execute spdk_bdev_io_get_buf() on a
different thread than the one that the IO was submitted on, which is
unsafe. Now, the buffers are always allocated on the correct thread and
we do spdk_thread_send_msg() only for the rbd library functions.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I07be5a4d0bd1463e0b7cf1aaee146edc575df387
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15671
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date defa

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the 4 digit year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc). Contribution date used
"--follow -C95%" to get the most accurate date.

Note that several files in this patch didn't end the license/(c)
block with a blank comment line so these were added as the vast
majority of files do have this last blank line. Simply there for
consistency.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot

show more ...