module/compress: Cleanup vol data, when claim fails

When vbdev_compress_claim fails, we should cleanup vol data

Change-Id: Iceb523b06a3ff13ea5a9197c37ebef3f32d0eb82
Signed-off-by: Yankun Li <yankun

module/compress: Cleanup vol data, when claim fails

When vbdev_compress_claim fails, we should cleanup vol data

Change-Id: Iceb523b06a3ff13ea5a9197c37ebef3f32d0eb82
Signed-off-by: Yankun Li <yankun@staff.sina.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25176
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: GangCao <gang.cao@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot

show more ...

bdev/compress: Print allocated_io_units for vol

Change-Id: I456cad3fa7ef23f29d846187614aed414bf1df65
Signed-off-by: Yankun Li <yankun@staff.sina.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spd

bdev/compress: Print allocated_io_units for vol

Change-Id: I456cad3fa7ef23f29d846187614aed414bf1df65
Signed-off-by: Yankun Li <yankun@staff.sina.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25208
Reviewed-by: GangCao <gang.cao@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Reviewed-by: Alliswell <hisunzhenliang@outlook.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>

show more ...

bdev/compress: unmap support.

Change-Id: Ibdb98f02725615532ebac2e5536d5db55d76c886
Signed-off-by: Yalong Wang <yalong9@staff.sina.com.cn>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/247

bdev/compress: unmap support.

Change-Id: Ibdb98f02725615532ebac2e5536d5db55d76c886
Signed-off-by: Yalong Wang <yalong9@staff.sina.com.cn>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24798
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: GangCao <gang.cao@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

module/bdev: dump more info about compress

Change-Id: I86db56cd7cb485048ed0d785370f97234ec764c6
Signed-off-by: Yankun Li <yankun@staff.sina.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spd

module/bdev: dump more info about compress

Change-Id: I86db56cd7cb485048ed0d785370f97234ec764c6
Signed-off-by: Yankun Li <yankun@staff.sina.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25055
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

show more ...

bdev/compress: Call vbdev_compress_delete_done to response caller

Change-Id: I06e070ae45c32befaede1ec8cb1e3c74ac171379
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io

bdev/compress: Call vbdev_compress_delete_done to response caller

Change-Id: I06e070ae45c32befaede1ec8cb1e3c74ac171379
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24943
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: GangCao <gang.cao@intel.com>

show more ...

bdev/compress: Set I/O SPDK_BDEV_IO_STATUS_NOMEM on ENOMEM

Change-Id: I9a40a7efe2be2816f1cc23e9de02198847bf564a
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit

bdev/compress: Set I/O SPDK_BDEV_IO_STATUS_NOMEM on ENOMEM

Change-Id: I9a40a7efe2be2816f1cc23e9de02198847bf564a
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24824
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot

show more ...

bdev/compress: Supports the specified compression algorithm

compress bdev Indicates that compression uses the synchronization
mechanism and only deflate is supported. However, for some business
scen

bdev/compress: Supports the specified compression algorithm

compress bdev Indicates that compression uses the synchronization
mechanism and only deflate is supported. However, for some business
scenarios, it is more concerned with compression performance than
compression rate. So we provide extensions that support multiple
compression algorithms

Change-Id: I36b93875eed3069aa0c74843d98e4a0c90412b9e
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24452
Reviewed-by: GangCao <gang.cao@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

bdev/compress: Fix log print format errors

Change-Id: I5f1215b12fbd83548150123c379969b69194be03
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2

bdev/compress: Fix log print format errors

Change-Id: I5f1215b12fbd83548150123c379969b69194be03
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24744
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: GangCao <gang.cao@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

bdev/compress: queue the request when no bdev_io

Request backing bdev If there is no bdev_io, put the request
in a waiting queue.

Change-Id: Ie4ddd10ebb023b835f863bece8bb84b1f842f8be
Signed-off-by:

bdev/compress: queue the request when no bdev_io

Request backing bdev If there is no bdev_io, put the request
in a waiting queue.

Change-Id: Ie4ddd10ebb023b835f863bece8bb84b1f842f8be
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24424
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: GangCao <gang.cao@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

bdev/compress: change the calling mode of vol and comp module

Use struct spdk_reduce_backing_io to encapsulate request parameters
for backing bdev. Easy to put in wait queue when no bdev_io.

Use _c

bdev/compress: change the calling mode of vol and comp module

Use struct spdk_reduce_backing_io to encapsulate request parameters
for backing bdev. Easy to put in wait queue when no bdev_io.

Use _comp_reduce_submit_backing_io instead of _comp_reduce_unmap,
_comp_reduce_writev, and _comp_reduce_readv.

Change-Id: Ie8d6043a20e601558260323409702163ea1c0f17
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24259
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: GangCao <gang.cao@intel.com>

show more ...

bdev/compress: unload vol, when comp bdev fails to load.

Change-Id: Id71fc809bee0a44c36bbe08a1374b53584c10e6b
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c

bdev/compress: unload vol, when comp bdev fails to load.

Change-Id: Id71fc809bee0a44c36bbe08a1374b53584c10e6b
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24331
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: GangCao <gang.cao@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

bdev/compress: unload vol, when comp bdev fails to create

Change-Id: I4f842112dd1b48472df062a53497398af38ed649
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/

bdev/compress: unload vol, when comp bdev fails to create

Change-Id: I4f842112dd1b48472df062a53497398af38ed649
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24419
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: GangCao <gang.cao@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

bdev/compress: change comp bdev creation logic to asynchronous

Change-Id: Icb57244c2e0b52026ebdd73f9f42326ba8b96570
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/ge

bdev/compress: change comp bdev creation logic to asynchronous

Change-Id: Icb57244c2e0b52026ebdd73f9f42326ba8b96570
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24403
Reviewed-by: GangCao <gang.cao@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot

show more ...

bdev/compress: rename meta_ctx to comp_bdev

Change-Id: I45cde55332d0a4459c6f11340a3bb0364de668bf
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/

bdev/compress: rename meta_ctx to comp_bdev

Change-Id: I45cde55332d0a4459c6f11340a3bb0364de668bf
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24299
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

bdev/compress: add more error code information

Change-Id: I7663d669eeb3123cb1e2739078d92730a260b043
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk

bdev/compress: add more error code information

Change-Id: I7663d669eeb3123cb1e2739078d92730a260b043
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24329
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

bdev/compress: check pm path for creating compress bdev

Change-Id: Iaca21fef5a8d5845e79b3ddd9b6df3dac977ddef
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/

bdev/compress: check pm path for creating compress bdev

Change-Id: Iaca21fef5a8d5845e79b3ddd9b6df3dac977ddef
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24184
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

bdev/compress: Output the pm_path entry for bdev_get_bdevs()

Change-Id: I8671a8903d2729b37552e156a6d9db57ff1852a9
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerr

bdev/compress: Output the pm_path entry for bdev_get_bdevs()

Change-Id: I8671a8903d2729b37552e156a6d9db57ff1852a9
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24210
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: GangCao <gang.cao@intel.com>
Community-CI: Mellanox Build Bot

show more ...

bdev/compress: remove the code about the config json

Nothing to dump as compress bdev configuration is saved
on physical device.

Change-Id: I19c53f7ca6c83411d55501b82ef3d614f51e4cf1
Signed-off-by:

bdev/compress: remove the code about the config json

Nothing to dump as compress bdev configuration is saved
on physical device.

Change-Id: I19c53f7ca6c83411d55501b82ef3d614f51e4cf1
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24132
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

bdev/compress: improve error logging in _reduce_rw_blocks_cb

Change-Id: I5e0925ca2715c28c58719d0dd9e9656322bb6067
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerr

bdev/compress: improve error logging in _reduce_rw_blocks_cb

Change-Id: I5e0925ca2715c28c58719d0dd9e9656322bb6067
Signed-off-by: Yankun Li <845245370@qq.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22827
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

accel: remove flags

They were unused, deprecated, and scheduled for removal in v24.05.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I48e7e59df56cf2368f23e925360644665948585a

accel: remove flags

They were unused, deprecated, and scheduled for removal in v24.05.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I48e7e59df56cf2368f23e925360644665948585a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22950
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot

show more ...

accel: add the spdk_ prefix to accel_opcode

This enum is part of the public interface, so it should have the spdk_
prefix.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ie1d4a

accel: add the spdk_ prefix to accel_opcode

This enum is part of the public interface, so it should have the spdk_
prefix.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ie1d4aee707ede70c7f181561e1002ce443628ca4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19685
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@gmail.com>
Reviewed-by: Jacek Kalwas <jacek.kalwas@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

bdev/compress: generate UUID from parent bdev UUID

Use base bdev UUID to generate new UUID for compress bdev.

Change-Id: I4dc055739b625c6fe910d01cafe3f8fffa4a0858
Signed-off-by: Krzysztof Karas <kr

bdev/compress: generate UUID from parent bdev UUID

Use base bdev UUID to generate new UUID for compress bdev.

Change-Id: I4dc055739b625c6fe910d01cafe3f8fffa4a0858
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Signed-off-by: Jim Harris <james.r.harris@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17126
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

accel: move accel_module.h to include/spdk

This file should be external to enable out-of-tree accel modules.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I2e973d0e88d7145d0fc

accel: move accel_module.h to include/spdk

This file should be external to enable out-of-tree accel modules.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I2e973d0e88d7145d0fc9714f56db48486b00f3b7
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17419
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jacek Kalwas <jacek.kalwas@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

bdev/compress: Port to use accel_fw instead of compressdev
directly

This patch removes hardcoded compressdev code from the
vbdev module and instead uses the accel_fw. The port required
a few changes

bdev/compress: Port to use accel_fw instead of compressdev
directly

This patch removes hardcoded compressdev code from the
vbdev module and instead uses the accel_fw. The port required
a few changes based on how things are plumbed and accessed,
nothing that isn't be too obscure. CI tests were updated to
run ISAL accel_fw module as well as DPDK compressdev with QAT.

Unit tests for the new module will follow in a separate patch.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: I769cbc888658fb846d89f6f0bfeeb1a2a820767e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13610
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

module/accel: Add compressDev accel_module

This is the port of the vbdev compress logic into the accel
framework. It includes just one enhancement, to only fill each
mbuf in either src or dst array

module/accel: Add compressDev accel_module

This is the port of the vbdev compress logic into the accel
framework. It includes just one enhancement, to only fill each
mbuf in either src or dst array with max "window size" param to
avoid QAT errors. Note that DPDK ISAL PMD was not ported as we
have native ISAL compression in accel now.

Note: ISAL w/DPDK is still built w/this patch, that can't be
removed until the vbdev module moves to accel fw as it still
depends on DPDK ISAL PMD.

Follow-on patches will include addition C API for PMD selection,
this patch just gets equivalent functionality going. Upcoming
patches will also convert the vbdev compress module to use the
accel framework instead of talking directly to compressdev.

More patches will also address comments on vbdev common code
that addressed here would make the review challenging.

This patch also fixes a bug in the ported code that needs to
be fixed here to pass CI. Capability discovery was incorrect
causing all devices to appear to not support chained mbufs,
with the mbuf splitting code this is important to get right.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: I7f526404819b145ef26e40877122ba80a02fcf51
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15178
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...