lib/scsi: fixed potential expression overflow.

Fixed potential issue found by Coverity.
The function _bytes_to_blocks() takes num_bytes parameter,
which is 64-bit long (uint64_t). In bdev_scsi_write

lib/scsi: fixed potential expression overflow.

Fixed potential issue found by Coverity.
The function _bytes_to_blocks() takes num_bytes parameter,
which is 64-bit long (uint64_t). In bdev_scsi_write_same()
function, the parameter was calculated as
task->length * xfer_len
Both of the values are 32-bit long, so the expression is
evaluated using 32-bit arithmetic potentially overflowing
the result (truncating to 32-bit). To avoid this, we need
to cast at least one parameter to 64-bit value.

Change-Id: Idd8a52d088a0c971158515a0a542a44595633321
Signed-off-by: Marcin Spiewak <marcin.spiewak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22219
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

scsi: simplify split path

Currently the splitting code for unmap and write_same is a bit complicated,
since it needs to handle case where we get a 0-length unmap descriptor and
spdk_bdev_unmap_block

scsi: simplify split path

Currently the splitting code for unmap and write_same is a bit complicated,
since it needs to handle case where we get a 0-length unmap descriptor and
spdk_bdev_unmap_blocks() didn't handle 0-length calls.

But spdk_bdev_unmap_blocks() has been updated now to handle 0-length calls,
so we can eliminate this extra complexity.

This also alleviates a small regression identified when this splitting code
path was updated.

Fixes issue #3249.
Fixes b735c429 ("scsi: Improve child IO split mechanism").

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I93cdac1c449a17fcc22e9909beb0feafe2b08b54
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21773
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

scsi: Improve child IO split mechanism

Improve the child IO split mechanism with the points:
- simplify error handing for splitting loop.
- ctx->fn() does not have to touch any counter. then
ctx->

scsi: Improve child IO split mechanism

Improve the child IO split mechanism with the points:
- simplify error handing for splitting loop.
- ctx->fn() does not have to touch any counter. then
ctx->remaining_count is removed from _bdev_scsi_unmap and
_bdev_scsi_write_same.

Change-Id: I543fcbb6eede662ec248e68c2d377d3b3a488961
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20559
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

vhost-scsi: fix incorrect parameter in compare_and_write IO

We should not pass task->iov to spdk_bdev_comparev_and_writev_blocks
because it is NULL.

Change-Id: Iac12b5b24e040e6414c7ef9bd2d4e3dc5ec3

vhost-scsi: fix incorrect parameter in compare_and_write IO

We should not pass task->iov to spdk_bdev_comparev_and_writev_blocks
because it is NULL.

Change-Id: Iac12b5b24e040e6414c7ef9bd2d4e3dc5ec31894
Signed-off-by: Haoqian He <haoqian.he@smartx.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20602
Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

show more ...

scsi: Drop 'name' field in spdk_bdev_scsi_split_ctx

Child IO split mechanism[1] uses 'name' field to dump the necessary
message on failure, now we can use spdk_scsi_sbc_opcode_string
instead.

[1]SP

scsi: Drop 'name' field in spdk_bdev_scsi_split_ctx

Child IO split mechanism[1] uses 'name' field to dump the necessary
message on failure, now we can use spdk_scsi_sbc_opcode_string
instead.

[1]SPDK Commit: f6613e370d75 ("scsi: Abstract child IO split mechanism")
Change-Id: I6f7cca10f7340d6008022671a990ff8b5d157b62
Suggested-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20465
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

scsi: Check descriptor count for UNMAP

There is no need to call split IO(bdev_scsi_split) on two case:
- invalid descriptor count
- zero descriptor count(newly added)

Suggested-by: Shuhei Matsumoto

scsi: Check descriptor count for UNMAP

There is no need to call split IO(bdev_scsi_split) on two case:
- invalid descriptor count
- zero descriptor count(newly added)

Suggested-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I80a7bae711fedc957319d5d44c55dac8c59f5ef5
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20513
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

vhost-scsi: support SBC-3 compare_and_write IO

Support compare_and_write from SBC-3 for 1 block since
spdk_bdev_comparev_and_writev_blocks function supports
compare_and_write of only 1 block current

vhost-scsi: support SBC-3 compare_and_write IO

Support compare_and_write from SBC-3 for 1 block since
spdk_bdev_comparev_and_writev_blocks function supports
compare_and_write of only 1 block currently.

Change-Id: I1069fa6c9070a5f16b8867f62740a2dce8a282da
Signed-off-by: Haoqian He <haoqian.he@smartx.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19873
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

scsi: Fix MAXIMUM WRITE SAME LENGTH field

Originally, the 'MAXIMUM WRITE SAME LENGTH' feild has dependence on
Bdev UNMAP, once the Bdev has no support on UNMAP(Ex, AIO), the
initiator side gets 0.

scsi: Fix MAXIMUM WRITE SAME LENGTH field

Originally, the 'MAXIMUM WRITE SAME LENGTH' feild has dependence on
Bdev UNMAP, once the Bdev has no support on UNMAP(Ex, AIO), the
initiator side gets 0.

According to spec:
A MAXIMUM WRITE SAME LENGTH field set to a non-zero value indicates
the maximum value that the device server accepts in the NUMBER OF
LOGICAL BLOCKS field for a WRITE SAME command. A MAXIMUM WRITE SAME
LENGTH field set to zero indicates that the device server does not
report a limit on the number of logical blocks that may be requested
for a single WRITE SAME command.

Unlimited maximum blocks on a single request is not expected for SPDK,
fix 'MAXIMUM WRITE SAME LENGTH' field.

Change-Id: I2005156daa198afe0738236f32bfd61eeb3b8356
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20401
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

scsi: Implement WRITE SAME

Implement SPDK_SBC_WRITE_SAME_10 and SPDK_SBC_WRITE_SAME_16 commands.

Change-Id: Ie1a82cea8e8afd8c8e8e490eadb358c9c825b865
Signed-off-by: zhenwei pi <pizhenwei@bytedance.

scsi: Implement WRITE SAME

Implement SPDK_SBC_WRITE_SAME_10 and SPDK_SBC_WRITE_SAME_16 commands.

Change-Id: Ie1a82cea8e8afd8c8e8e490eadb358c9c825b865
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20400
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

show more ...

scsi: Abstract child IO split mechanism

Child IO split mechanism[1] for UNMAP allows a single SCSI command
to split into several SPDK Bdev IOs.
Separate the common child IO split mechanism from the

scsi: Abstract child IO split mechanism

Child IO split mechanism[1] for UNMAP allows a single SCSI command
to split into several SPDK Bdev IOs.
Separate the common child IO split mechanism from the UNMAP codes,
it's possible to implement SCSI WRITE SAME easily in the next step.

[1] SPDK commit: 73bc324b0df('scsi: Refine split processing for unmap')

Change-Id: I3248f51d2cdc1380e20ddaccc074369bf2b48ec8
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20399
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

scsi: Refine split processing for unmap

If any child I/O failed, we should set the status of the SCSI task
to failed and stop further split processing.

However, ctx->count meant number of outstandi

scsi: Refine split processing for unmap

If any child I/O failed, we should set the status of the SCSI task
to failed and stop further split processing.

However, ctx->count meant number of outstanding children I/Os. We
could not stop further split processing. We updated the status of the
SCSI task only if child I/O submission failed.

Fix these in this patch. Verify the changes by refining unit tests
except for error cases.

This idea was derived from the splitting process of the generic bdev
layer.

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ifc74c09c349567b0311fe2a7435a5452d4c68251
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19437
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

scsi: use notice log for unsupported VPD page

Very new Linux kernel sends VPD 0xb9 (concurrent positioning ranges)
even SPDK doesn't report this page is supported, we can see this
error log in iSCSI

scsi: use notice log for unsupported VPD page

Very new Linux kernel sends VPD 0xb9 (concurrent positioning ranges)
even SPDK doesn't report this page is supported, we can see this
error log in iSCSI and vhost-scsi target, here use a notice log
instead.

Change-Id: I26fd2afaee2152ffbfea6ef4e0f254538360b626
Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19714
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@gmail.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

scsi: Factor out internal of bdev_scsi_unmap() into a helper function

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I789d7dbf6585e7aeb49b888557f940148c6378f3
Reviewed-on: https:

scsi: Factor out internal of bdev_scsi_unmap() into a helper function

Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: I789d7dbf6585e7aeb49b888557f940148c6378f3
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19436
Reviewed-by: Jim Harris <jim.harris@gmail.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

lib/scsi: Calculate blocks for WRITE SAME

Rather than hard coded 512 blocks for a single WRITE SAME command,
calculate it by:
blocks = SPDK_WORK_BLOCK_SIZE / block_size
This is as same as 'MAXIM

lib/scsi: Calculate blocks for WRITE SAME

Rather than hard coded 512 blocks for a single WRITE SAME command,
calculate it by:
blocks = SPDK_WORK_BLOCK_SIZE / block_size
This is as same as 'MAXIMUM TRANSFER LENGTH'.

Change-Id: I5f7457cc526aad83f64addde2beb667e4ae6cf53
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19352
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Community-CI: Mellanox Build Bot

show more ...

dif: remove packed attribute from spdk_dif_ctx_init_ext_opts

Following the recommendation introduced in 1d77eec82, the packed
attribute was removed from spdk_dif_ctx_init_ext_opts and the way its
si

dif: remove packed attribute from spdk_dif_ctx_init_ext_opts

Following the recommendation introduced in 1d77eec82, the packed
attribute was removed from spdk_dif_ctx_init_ext_opts and the way its
size is calculated was changed to use SPDK_SIZEOF().

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I8dab3ee5afcd2afe803dacc563bee9b029c7cbf6
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18597
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot

show more ...

lib/util/dif: Add an ext_opts param to spdk_dif_ctx_init

The extended options structure for the dif context
initialization allows for adding new arguments
without the function signature change. The

lib/util/dif: Add an ext_opts param to spdk_dif_ctx_init

The extended options structure for the dif context
initialization allows for adding new arguments
without the function signature change. The first
extended parameter is the DIF Protection Information
format (CRC-16).

Change-Id: I6a32e8570676265d757fc7251441e5547bbb475d
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18146
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

misc: Fix spelling mistakes

Found with misspell-fixer.

Signed-off-by: Michal Berger <michal.berger@intel.com>
Change-Id: If062df0189d92e4fb2da3f055fb981909780dc04
Reviewed-on: https://review.spdk.i

misc: Fix spelling mistakes

Found with misspell-fixer.

Signed-off-by: Michal Berger <michal.berger@intel.com>
Change-Id: If062df0189d92e4fb2da3f055fb981909780dc04
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15207
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date defa

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the 4 digit year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc). Contribution date used
"--follow -C95%" to get the most accurate date.

Note that several files in this patch didn't end the license/(c)
block with a blank comment line so these were added as the vast
majority of files do have this last blank line. Simply there for
consistency.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot

show more ...

lib/scsi: use bkdr hash to avoid naa identifier collision

fix: If the first six characters of two scsi lun's name are the same,
such as aaaaaa0 and aaaaaa1, so do theirs naa identifier

Signed-off-b

lib/scsi: use bkdr hash to avoid naa identifier collision

fix: If the first six characters of two scsi lun's name are the same,
such as aaaaaa0 and aaaaaa1, so do theirs naa identifier

Signed-off-by: Bin Yang <bin.yang@jaguarmicro.com>
Change-Id: I4e0541b372a0e20e95e0a24d62dd3d85b7abe230
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13824
Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

Replace most BSD 3-clause license text with SPDX identifier.

Many open source projects have moved to using SPDX identifiers
to specify license information, reducing the amount of
boilerplate code in

Replace most BSD 3-clause license text with SPDX identifier.

Many open source projects have moved to using SPDX identifiers
to specify license information, reducing the amount of
boilerplate code in every source file. This patch replaces
the bulk of SPDK .c, .cpp and Makefiles with the BSD-3-Clause
identifier.

Almost all of these files share the exact same license text,
and this patch only modifies the files that contain the
most common license text. There can be slight variations
because the third clause contains company names - most say
"Intel Corporation", but there are instances for Nvidia,
Samsung, Eideticom and even "the copyright holder".

Used a bash script to automate replacement of the license text
with SPDX identifier which is checked into scripts/spdx.sh.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: Iaa88ab5e92ea471691dc298cfe41ebfb5d169780
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12904
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Dong Yi <dongx.yi@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: <qun.wan@intel.com>

show more ...

spelling: lib

Part of #2256

* accessible
* activation
* additional
* allocate
* association
* attempt
* barrier
* broadcast
* buffer
* calculate
* cases
* channel
* children
* command
* completion

spelling: lib

Part of #2256

* accessible
* activation
* additional
* allocate
* association
* attempt
* barrier
* broadcast
* buffer
* calculate
* cases
* channel
* children
* command
* completion
* connect
* copied
* currently
* descriptor
* destroy
* detachment
* doesn't
* enqueueing
* exceeds
* execution
* extended
* fallback
* finalize
* first
* handling
* hugepages
* ignored
* implementation
* in_capsule
* initialization
* initialized
* initializing
* initiator
* negotiated
* notification
* occurred
* original
* outstanding
* partially
* partition
* processing
* receive
* received
* receiving
* redirected
* regions
* request
* requested
* response
* retrieved
* running
* satisfied
* should
* snapshot
* status
* succeeds
* successfully
* supplied
* those
* transferred
* translate
* triggering
* unregister
* unsupported
* urlsafe
* virtqueue
* volumes
* workaround
* zeroed

Change-Id: I569218754bd9d332ba517d4a61ad23d29eedfd0c
Signed-off-by: Josh Soref <jsoref@gmail.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10405
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

scsi: Report LUNs use spdk_scsi_dev_get_first/next_lun() to iterate LUNs

Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: Ib812c1f4c180f4173c3b3d668a98e3b23ed32899
Review

scsi: Report LUNs use spdk_scsi_dev_get_first/next_lun() to iterate LUNs

Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: Ib812c1f4c180f4173c3b3d668a98e3b23ed32899
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9629
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

util: Add macro SPDK_SIZEOF_MEMBER to get size of a member of a struct

We find a few files to get the size of a member of a struct. How to
do it is a little complex. So add a macro to do it will be

util: Add macro SPDK_SIZEOF_MEMBER to get size of a member of a struct

We find a few files to get the size of a member of a struct. How to
do it is a little complex. So add a macro to do it will be helpful
to read the current code and develop new features.

lib/dif had used member_size() internally but Linux use sizeof_member()
as the macro. Besides, SPDK have used upper case letters for similar
macros, SPDK_CONTAINEROF() and SPDK_COUNTOF(). Hence spdk_member_size()
may be good but propose SPDK_SIZEOF_MEMBER() as the macro.

Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: I2179c845a3b75fb71aa039075cc4dfd30617b898
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8738
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>

show more ...

scsi: Cache physical block size locally

Addressing review comment from 6cebe9d0.
Minor optimisation to cache result of spdk_u32log2() into local variable
instead of calling it multiple times.

Signe

scsi: Cache physical block size locally

Addressing review comment from 6cebe9d0.
Minor optimisation to cache result of spdk_u32log2() into local variable
instead of calling it multiple times.

Signed-off-by: Swapnil Ingle <swapnil.ingle@nutanix.com>
Change-Id: I2fd6afd1e3ee461662de3f9d278958664224e106
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7806
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: sunshihao <sunshihao@huawei.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI

show more ...

scsi: don't include bdev_module.h

The library itself doesn't need it. The unit tests
do need it, so just include it there.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: I9aefd303a

scsi: don't include bdev_module.h

The library itself doesn't need it. The unit tests
do need it, so just include it there.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: I9aefd303ae12928d45141029436509f185105bd3
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7812
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Michal Berger <michalx.berger@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>

show more ...