scripts: switch from go fmt to gofmt

Neither "go fmt" nor "gofmt" return a status code when the format check
fails. We can only rely on their stdout. "go fmt" invokes "gofmt -w -l"
on every file in

scripts: switch from go fmt to gofmt

Neither "go fmt" nor "gofmt" return a status code when the format check
fails. We can only rely on their stdout. "go fmt" invokes "gofmt -w -l"
on every file in the target package and pulls in dependencies. These
dependencies are not verified, but they pollute stdout and increase
format check time.

Therefore, we switch to "gofmt", which only checks files within the
target package.

It turns out that not all files from the target package were checked.
Compare "go fmt -n ." to "go fmt -n ./...". Switching to "gofmt ."
addresses this issue, and we've added fixes to client.go accordingly.

Finally, instead of fixing the formatting, we print out the diff by
switching from "-w" to "-d".

Change-Id: Ifb1c339bdd1703c7d9e1b0cfa0b0ad0df7cff683
Signed-off-by: Emilia Haligowska <emilia.haligowska@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22832
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot

show more ...

go/rpc: add first unit test for golang

more to come

Change-Id: I1bb090fd5597c692f31d620dbda210febf0bee5e
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/g

go/rpc: add first unit test for golang

more to come

Change-Id: I1bb090fd5597c692f31d620dbda210febf0bee5e
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20160
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Maciej Miś <maciej.mis@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

go/rpc: add interface for Client

this is mostly going to be used with mockery

Change-Id: I2d7205c10ab9d628f5874114c860a69ede478c7c
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on

go/rpc: add interface for Client

this is mostly going to be used with mockery

Change-Id: I2d7205c10ab9d628f5874114c860a69ede478c7c
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20251
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Maciej Miś <maciej.mis@intel.com>
Community-CI: Mellanox Build Bot

show more ...

go/rpc: check return code for RPC call

Change-Id: I8493649b0d333f35fd6ae918527ad7f3599b5584
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/s

go/rpc: check return code for RPC call

Change-Id: I8493649b0d333f35fd6ae918527ad7f3599b5584
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20237
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Yibo Cai <yibo.cai@arm.com>

show more ...

go/rpc: add TCP to documentation

Change-Id: I9cf5daeaa40d1d4263ab1066dd9afccfa426f1f0
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/

go/rpc: add TCP to documentation

Change-Id: I9cf5daeaa40d1d4263ab1066dd9afccfa426f1f0
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20140
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot

show more ...

go/rpc: check mismatch IDs

Change-Id: Iedc23ff8f1bd1f90ff4bbd799c280a89883b9010
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20036

go/rpc: check mismatch IDs

Change-Id: Iedc23ff8f1bd1f90ff4bbd799c280a89883b9010
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20036
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Maciej Miś <maciej.mis@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

go/rpc: add support for TCP connection

Change-Id: I3431ef2b9cfeabddd358322b15f17248ca003b04
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/s

go/rpc: add support for TCP connection

Change-Id: I3431ef2b9cfeabddd358322b15f17248ca003b04
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20037
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

go/rpc: Implementation of JSON-RPC 2.0 client

Change-Id: I6b57907e7569fc9bb58e8f4c2c1144ee83c3fbc3
Signed-off-by: Maciej Mis <maciej.mis@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/

go/rpc: Implementation of JSON-RPC 2.0 client

Change-Id: I6b57907e7569fc9bb58e8f4c2c1144ee83c3fbc3
Signed-off-by: Maciej Mis <maciej.mis@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19013
Community-CI: Mellanox Build Bot
Reviewed-by: Yibo Cai <yibo.cai@arm.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Boris Glimcher <Boris.Glimcher@emc.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...