env: add SPDK_ENV_NUMA_ID_ANY and replace socket_id with numa_id

We will try to avoid further proliferation of "SOCKET_ID" to refer
to a NUMA socket ID moving forward, and just use "NUMA_ID" to avoi

env: add SPDK_ENV_NUMA_ID_ANY and replace socket_id with numa_id

We will try to avoid further proliferation of "SOCKET_ID" to refer
to a NUMA socket ID moving forward, and just use "NUMA_ID" to avoid
confusion with TCP sockets.

Change all of the existing in-tree SPDK_ENV_SOCKET_ID_ANY uses to
SPDK_ENV_NUMA_ID_ANY, but keep the old #define around, at least for
now. Also change all 'socket_id' parameters to 'numa_id'.

We still have spdk_env_get_socket_id(), we will need to keep this
but next patch will add spdk_env_get_numa_id().

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Idc31c29e32b708c24d88f9c6fecaf9a99e34ba1e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24607
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

env: add opts_size to spdk_env_opts

This will help with ABI compatibility as new fields get added
to this structure.

User is responsible for setting opts_size. Major version has been
bumped, so use

env: add opts_size to spdk_env_opts

This will help with ABI compatibility as new fields get added
to this structure.

User is responsible for setting opts_size. Major version has been
bumped, so users will need to rebuild against latest code, if they
do not set opts_size we will just treat that as if the structure
ends right before opts_size. We will also print an ERRLOG to warn
user to set opts_size appropriately.

As part of this patch, update all in-tree callers of
spdk_env_opts_init() to set the opts_size.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: If2611eccc8b3c43e1dc1654028d000a8a12a544e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23940
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz@tzawadzki.com>

show more ...

bdevperf/nvme_perf/hello_world: Add fflush(stdout)

In case the app hangs in cleanup/fini, most likely stdout will not get
printed out (buffered) therefore no logs will be visible.
This change should

bdevperf/nvme_perf/hello_world: Add fflush(stdout)

In case the app hangs in cleanup/fini, most likely stdout will not get
printed out (buffered) therefore no logs will be visible.
This change shouldn't harm performance as fflush() is performed after
the test itself.

Change-Id: I7d12ae037de5b686c776de8d66c5cbec5df6a544
Signed-off-by: Wojciech Panfil <wojciech.panfil@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23022
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jacek Kalwas <jacek.kalwas@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot

show more ...

hello_world: Move vmd_fini to exit

In case no ctrlr has been found, vmd_fini() has not
been called even though vmd_init() has been.
In addition calling cleanup() twice is not required.

Change-Id: I

hello_world: Move vmd_fini to exit

In case no ctrlr has been found, vmd_fini() has not
been called even though vmd_init() has been.
In addition calling cleanup() twice is not required.

Change-Id: Ib47a9b1ed48ec1017d0d08338c266e3a93add10a
Signed-off-by: Wojciech Panfil <wojciech.panfil@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23057
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jacek Kalwas <jacek.kalwas@intel.com>

show more ...

hello_world: Add -h argument

For now in case user requested help hello_world printed out
that such argument was wrong, which is misleading. Adjust to
spdk_app_parse_args(), where it has been impleme

hello_world: Add -h argument

For now in case user requested help hello_world printed out
that such argument was wrong, which is misleading. Adjust to
spdk_app_parse_args(), where it has been implemented properly.

Change-Id: Ib47a9b1ed48ec1017d0d08338c266e3a93add10f
Signed-off-by: Wojciech Panfil <wojciech.panfil@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23021
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot

show more ...

examples/nvme/hello_world: add data check

Without data check application exits with 0 code even when running on
top of null bdev.

Additionally removed \n char from the write data to simplify c-stri

examples/nvme/hello_world: add data check

Without data check application exits with 0 code even when running on
top of null bdev.

Additionally removed \n char from the write data to simplify c-string
meant for comparison.

Change-Id: Ie9ad11f1b7bdbaab80e28ee9b77ce81cacc46b7e
Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20238
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date defa

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the 4 digit year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc). Contribution date used
"--follow -C95%" to get the most accurate date.

Note that several files in this patch didn't end the license/(c)
block with a blank comment line so these were added as the vast
majority of files do have this last blank line. Simply there for
consistency.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot

show more ...