replace strtok with strtok_r

The strtok function is not reentrant. To address this issue in a
multithreaded environment, the strtok_r function should be used,
which is the reentrant version of strto

replace strtok with strtok_r

The strtok function is not reentrant. To address this issue in a
multithreaded environment, the strtok_r function should be used,
which is the reentrant version of strtok.

Signed-off-by: XuQi <1530865185@qq.com>
Change-Id: I35c07c7cf4e20bacb7b1e7c7adaedfcd1a81f86e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25492
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeliu@tencent.com>
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Mellanox Build Bot

show more ...

env: add SPDK_ENV_NUMA_ID_ANY and replace socket_id with numa_id

We will try to avoid further proliferation of "SOCKET_ID" to refer
to a NUMA socket ID moving forward, and just use "NUMA_ID" to avoi

env: add SPDK_ENV_NUMA_ID_ANY and replace socket_id with numa_id

We will try to avoid further proliferation of "SOCKET_ID" to refer
to a NUMA socket ID moving forward, and just use "NUMA_ID" to avoid
confusion with TCP sockets.

Change all of the existing in-tree SPDK_ENV_SOCKET_ID_ANY uses to
SPDK_ENV_NUMA_ID_ANY, but keep the old #define around, at least for
now. Also change all 'socket_id' parameters to 'numa_id'.

We still have spdk_env_get_socket_id(), we will need to keep this
but next patch will add spdk_env_get_numa_id().

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Idc31c29e32b708c24d88f9c6fecaf9a99e34ba1e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24607
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

env: add opts_size to spdk_env_opts

This will help with ABI compatibility as new fields get added
to this structure.

User is responsible for setting opts_size. Major version has been
bumped, so use

env: add opts_size to spdk_env_opts

This will help with ABI compatibility as new fields get added
to this structure.

User is responsible for setting opts_size. Major version has been
bumped, so users will need to rebuild against latest code, if they
do not set opts_size we will just treat that as if the structure
ends right before opts_size. We will also print an ERRLOG to warn
user to set opts_size appropriately.

As part of this patch, update all in-tree callers of
spdk_env_opts_init() to set the opts_size.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: If2611eccc8b3c43e1dc1654028d000a8a12a544e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23940
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz@tzawadzki.com>

show more ...

general: fix misspells and typos

Signed-off-by: Kamil Godzwon <kamilx.godzwon@intel.com>
Change-Id: Iab206ef526eb7032c6681a3145450010c91705a4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+

general: fix misspells and typos

Signed-off-by: Kamil Godzwon <kamilx.godzwon@intel.com>
Change-Id: Iab206ef526eb7032c6681a3145450010c91705a4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24120
Community-CI: Mellanox Build Bot
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

bdevperf/nvme_perf/hello_world: Add fflush(stdout)

In case the app hangs in cleanup/fini, most likely stdout will not get
printed out (buffered) therefore no logs will be visible.
This change should

bdevperf/nvme_perf/hello_world: Add fflush(stdout)

In case the app hangs in cleanup/fini, most likely stdout will not get
printed out (buffered) therefore no logs will be visible.
This change shouldn't harm performance as fflush() is performed after
the test itself.

Change-Id: I7d12ae037de5b686c776de8d66c5cbec5df6a544
Signed-off-by: Wojciech Panfil <wojciech.panfil@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23022
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jacek Kalwas <jacek.kalwas@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot

show more ...

hello_world: Move vmd_fini to exit

In case no ctrlr has been found, vmd_fini() has not
been called even though vmd_init() has been.
In addition calling cleanup() twice is not required.

Change-Id: I

hello_world: Move vmd_fini to exit

In case no ctrlr has been found, vmd_fini() has not
been called even though vmd_init() has been.
In addition calling cleanup() twice is not required.

Change-Id: Ib47a9b1ed48ec1017d0d08338c266e3a93add10a
Signed-off-by: Wojciech Panfil <wojciech.panfil@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23057
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jacek Kalwas <jacek.kalwas@intel.com>

show more ...

hello_world: Add -h argument

For now in case user requested help hello_world printed out
that such argument was wrong, which is misleading. Adjust to
spdk_app_parse_args(), where it has been impleme

hello_world: Add -h argument

For now in case user requested help hello_world printed out
that such argument was wrong, which is misleading. Adjust to
spdk_app_parse_args(), where it has been implemented properly.

Change-Id: Ib47a9b1ed48ec1017d0d08338c266e3a93add10f
Signed-off-by: Wojciech Panfil <wojciech.panfil@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23021
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot

show more ...

fio: Promote the spdk_nvme fio plugin to app

In the future we will install this.

Change-Id: I5fbeb87b897b90df662c30784b8857b334ddfb2f
Signed-off-by: Ben Walker <ben@nvidia.com>
Reviewed-on: https:/

fio: Promote the spdk_nvme fio plugin to app

In the future we will install this.

Change-Id: I5fbeb87b897b90df662c30784b8857b334ddfb2f
Signed-off-by: Ben Walker <ben@nvidia.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21388
Tested-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

include: Remove duplicate includes in source files

Change-Id: I7dd6ae6fa11603a956c3d178b9b23d2c755913d1
Signed-off-by: Pierre Lestringant <plestringant@kalray.eu>
Reviewed-on: https://review.spdk.io

include: Remove duplicate includes in source files

Change-Id: I7dd6ae6fa11603a956c3d178b9b23d2c755913d1
Signed-off-by: Pierre Lestringant <plestringant@kalray.eu>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20106
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

discovery_aer: Promote to app directory

And rename to spdk_nvme_discover. This is a tool we install that can be
used to perform NVMe-oF discovery.

Change-Id: Icf4eb1b74b129f7146dd95c5b9b0bd4b7882b9

discovery_aer: Promote to app directory

And rename to spdk_nvme_discover. This is a tool we install that can be
used to perform NVMe-oF discovery.

Change-Id: Icf4eb1b74b129f7146dd95c5b9b0bd4b7882b9e7
Signed-off-by: Ben Walker <ben@nvidia.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21198
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Wojciech Panfil <wojciech.panfil@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

identify: Promote spdk_nvme_identify to the app/ directory

This is a tool we install, so promote it from examples/ to app/

Change-Id: Ida98c78a71268c6769c90c56ecc9d4a415a310a5
Signed-off-by: Ben Wa

identify: Promote spdk_nvme_identify to the app/ directory

This is a tool we install, so promote it from examples/ to app/

Change-Id: Ida98c78a71268c6769c90c56ecc9d4a415a310a5
Signed-off-by: Ben Walker <ben@nvidia.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21197
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Wojciech Panfil <wojciech.panfil@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

show more ...

perf: Promote spdk_nvme_perf to the app/ directory

This is a tool that we install, so move it to app/ instead of examples/

Change-Id: Ie73e4a448e9ac6ae12d1291ef54f7fbabbaa3f62
Signed-off-by: Ben Wa

perf: Promote spdk_nvme_perf to the app/ directory

This is a tool that we install, so move it to app/ instead of examples/

Change-Id: Ie73e4a448e9ac6ae12d1291ef54f7fbabbaa3f62
Signed-off-by: Ben Walker <ben@nvidia.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21196
Reviewed-by: Wojciech Panfil <wojciech.panfil@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

lib/trace : Unregister tracing support for user created threads

Cleanup the tracing support whenever the user created threads
are exited.

fio_plugin is modified to verify the cleanup of tracing sup

lib/trace : Unregister tracing support for user created threads

Cleanup the tracing support whenever the user created threads
are exited.

fio_plugin is modified to verify the cleanup of tracing support
for the user created threads.

Change-Id: Ifebdf5d76f6cc190bde75d542797ce4455860c1a
Signed-off-by: Krishna Kanth Reddy <krish.reddy@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21304
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

perf: properly account for aio and io_uring errors

We've had two bugs around error handling for aio and io_uring, both are
fixed in this patch:

1) EIO indicates the block device went away - we abso

perf: properly account for aio and io_uring errors

We've had two bugs around error handling for aio and io_uring, both are
fixed in this patch:

1) EIO indicates the block device went away - we absolutely need to stop
sending I/O to the block device at that point. Note we already did the
equivalent for NVMe.
2) Don't return error early. All submitted I/O need to be accounted for
before perf will exit, so we must call task_complete() even for error.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Iea8d9fc52465a6a7a0c949f20c7da4e33ff11c0d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21372
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Mateusz Kozlowski <mateusz.kozlowski@solidigm.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

example/perf: report errors when submitting I/O

Perf app correctly tracked the I/O errors when handling completions,
yet errors during submissions were ignored.

Found when debugging #3126.
This pat

example/perf: report errors when submitting I/O

Perf app correctly tracked the I/O errors when handling completions,
yet errors during submissions were ignored.

Found when debugging #3126.
This patch will result in 100% reproduction of the issue above.

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: Ie897f01a0e50e6420cae76ebd0e7aac4c0c86942
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20323
Community-CI: Mellanox Build Bot
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Mateusz Kozlowski <mateusz.kozlowski@solidigm.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

show more ...

examples/hotplug: add spdk_rpc_close call

Close RPC server in case it was opened by
wait_for_rpc_call() function.

This change is not directly related to the
rest of the series, but without it we ca

examples/hotplug: add spdk_rpc_close call

Close RPC server in case it was opened by
wait_for_rpc_call() function.

This change is not directly related to the
rest of the series, but without it we can
expect errors in hotplug application, so it
should be introduced before other patches.

Change-Id: I9c960e7960cf88f60f9764b1fce7af538d25028f
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21316
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>

show more ...

lib/trace : Enable tracing support for user created threads

Only the environment created threads have the tracing support.
Added tracing support for the user created threads by reserving
lcore_histo

lib/trace : Enable tracing support for user created threads

Only the environment created threads have the tracing support.
Added tracing support for the user created threads by reserving
lcore_history entries.

fio_plugin is modified to verify the tracing support for the user
created threads.

This allows all SPDK applications to use SPDK tracing,
even if they are not using the SPDK app framework.

Change-Id: Ib7831b30d7de420fcc4a5849f3757733755a5406
Signed-off-by: Krishna Kanth Reddy <krish.reddy@samsung.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20852
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

test/nvmf: Add no-hugepages functionality to NVMf tests

Adding no-hugepages to the existing NVMf tests will enable the tests
to run without hugepages. These tests check the functionality of
NVMf ove

test/nvmf: Add no-hugepages functionality to NVMf tests

Adding no-hugepages to the existing NVMf tests will enable the tests
to run without hugepages. These tests check the functionality of
NVMf over TCP running on a target without hugepages.

Change-Id: I7bdd1afeafd888cb52530d43fc0c1d1bda926a96
Signed-off-by: Sarvesh Lanke <sarvesh.lanke@nutanix.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20339
Reviewed-by: Michal Berger <michal.berger@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Abhineet Pandey <abhineet.pandey@nutanix.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

perf: accept unit suffixes for some options

Unit suffixes (e.g. 1K, 1M, 1G) are now supported for the options where
it makes sense.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-I

perf: accept unit suffixes for some options

Unit suffixes (e.g. 1K, 1M, 1G) are now supported for the options where
it makes sense.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ib6874078aab0ae23f29932c75c87b65b95865733
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20580
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot

show more ...

example/perf: remove exit() on polling errors

Fixes #3158

Whenever there is error on polling certain backend,
exit is called immediately. Resulting in memory leaks
for quite a lot of structures all

example/perf: remove exit() on polling errors

Fixes #3158

Whenever there is error on polling certain backend,
exit is called immediately. Resulting in memory leaks
for quite a lot of structures allocated by the application.

Instead allow for more graceful failure by indicating
failed status.

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: If4042066e0bcae98233a5c899ac01b8000c39be5
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20727
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

examples/identify: don't read PMPCAP and CMBSZ if not support in CAP

I got error logs when running `identify` utility with NVMe-oF for above
2 registers access, so add a check before reading them in

examples/identify: don't read PMPCAP and CMBSZ if not support in CAP

I got error logs when running `identify` utility with NVMe-oF for above
2 registers access, so add a check before reading them in `identify`.

Change-Id: Ifb31c3d2ab2b0426c6af7b69f189ea2f1cdde846
Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20471
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

nvme/identify: add option to set socket implementation

Added option to set socket implementation.
Now, using -S option, the user can specify which socket
implementation (e.g. uring) shall be used wh

nvme/identify: add option to set socket implementation

Added option to set socket implementation.
Now, using -S option, the user can specify which socket
implementation (e.g. uring) shall be used when
a socket is created to connect to remote target.
Default socket implementation is posix.

Fixes #3144

Change-Id: I104fb957980ce26646c59101a6d3b589a0554c94
Signed-off-by: Marcin Spiewak <marcin.spiewak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20501
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

lib/nvmf: NVMeoF referrals in NVMeoF target

NVMeoF Discovery Service referrals implementation
in the NVMeoF target. Added three new RPC methods for
referral management: nvmf_discovery_add_referral,

lib/nvmf: NVMeoF referrals in NVMeoF target

NVMeoF Discovery Service referrals implementation
in the NVMeoF target. Added three new RPC methods for
referral management: nvmf_discovery_add_referral,
nvmf_discovery_remove_referral, nvmf_discovery_get_referrals.

Change-Id: I0f4810c6ac8d401bc619d21a26376b7e3c3373bd
Signed-off-by: Slawomir Ptak <slawomir.ptak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19500
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Ben Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

examples/perf: Adjust possibly misleading printf

Without comma, this printf might have suggested that the dislayed value
is delta between g_queue_depth*entries and opts.io_queue_size.
Now, it's clea

examples/perf: Adjust possibly misleading printf

Without comma, this printf might have suggested that the dislayed value
is delta between g_queue_depth*entries and opts.io_queue_size.
Now, it's clear that it's the controller IO queue size that is printed
out.

Change-Id: I1492f183878ae2bce9a246f0ee41eb4d516e77b7
Signed-off-by: Wojciech Panfil <wojciech.panfil@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19882
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

examples/nvme/hello_world: add data check

Without data check application exits with 0 code even when running on
top of null bdev.

Additionally removed \n char from the write data to simplify c-stri

examples/nvme/hello_world: add data check

Without data check application exits with 0 code even when running on
top of null bdev.

Additionally removed \n char from the write data to simplify c-string
meant for comparison.

Change-Id: Ie9ad11f1b7bdbaab80e28ee9b77ce81cacc46b7e
Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20238
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...