spdk-top: Increase number of CPU cores supported to 1024

This patch increases the number of cores supported by spdk-top to 1024
to support systems with more lcores.

Not using SPDK_CONFIG_MAX_LCORES

spdk-top: Increase number of CPU cores supported to 1024

This patch increases the number of cores supported by spdk-top to 1024
to support systems with more lcores.

Not using SPDK_CONFIG_MAX_LCORES so spdk-top can be used independently on a different system
and connect over network instead of RPC.

Fixes: #3425

Change-Id: I00b4412301447ae539012263e9323dbf63e5bc6a
Signed-off-by: Michael Piszczek <mpiszczek@ddn.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24006
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

spdk_top: shorten Frequency column name

The numbers in this column are never more than 4 digits (until we have
a 10GHz processor), so shorten this column name to "Freq [MHz]".

Signed-off-by: Jim Ha

spdk_top: shorten Frequency column name

The numbers in this column are never more than 4 digits (until we have
a 10GHz processor), so shorten this column name to "Freq [MHz]".

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I5032e3920c207bbed4bb2fc8027822102ffb8903
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23387
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>

show more ...

spdk_top: add POLLER_TYPE_COUNT_STR_LEN

We previously had just POLLER_COUNT_STR_LEN, which was used both for
the threads tab, which has columns "Active Pollers", "Timed Pollers"
and "Paused Pollers"

spdk_top: add POLLER_TYPE_COUNT_STR_LEN

We previously had just POLLER_COUNT_STR_LEN, which was used both for
the threads tab, which has columns "Active Pollers", "Timed Pollers"
and "Paused Pollers", as well as the cores tab which just has
"Pollers".

The cores tab suffers here, because it doesn't need the larger width
since the column name is much shorter.

So add a new POLLER_TYPE_COUNT_STR_LEN which the threads tab will use,
with the existing length. And change POLLER_COUNT_STR_LEN to better
match the column name width.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Ic29031ad41847250978ce48dc1f1b3af611d7839
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23386
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>

show more ...

spdk_top: decrease cores tab threads width from 14 to 10

The number of threads is a relatively small number, we really only need
width to match the "Threads" column name.

Signed-off-by: Jim Harris

spdk_top: decrease cores tab threads width from 14 to 10

The number of threads is a relatively small number, we really only need
width to match the "Threads" column name.

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: Iad92a6e470b6bf7055cd2fa9eb811e005afcd9d9
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23385
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

spdk_top: add 'tid' field to framework_get_reactors decoders

When 'tid' was added to the framework_get_reactors output, we missed
adding it to the spdk_top decoders for that RPC.

Fixes: f16e9f4 ("l

spdk_top: add 'tid' field to framework_get_reactors decoders

When 'tid' was added to the framework_get_reactors output, we missed
adding it to the spdk_top decoders for that RPC.

Fixes: f16e9f4 ("lib/event: framework_get_reactors supports getting pid and tid")

Signed-off-by: Jim Harris <jim.harris@samsung.com>
Change-Id: I854d92afa0bf5a9d6677321fe2e62d27eca81a2e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23648
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>

show more ...

app/spdk_top: gather information about cores interrupt time

Display informations provided by `framework_get_reactors` about time
spend in kernel mode and time spend servicing interrupts on each core

app/spdk_top: gather information about cores interrupt time

Display informations provided by `framework_get_reactors` about time
spend in kernel mode and time spend servicing interrupts on each core.

This patch adds debugging information to spdk_top that are intended to
help determine core that process tasks other than spdk.

Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Change-Id: Ie836f6073dc9fce844b81b098388a974843945c0
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20555
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

app/spdk_top: rearrange the spdk_top core-tab fields

Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Change-Id: I5120641db7b8ad48a907abd09ea8129683fb97d7
Reviewed-on: https://revi

app/spdk_top: rearrange the spdk_top core-tab fields

Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Change-Id: I5120641db7b8ad48a907abd09ea8129683fb97d7
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21160
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>

show more ...

spdk_top: Remove unused window elements

mvwaddach(WINDOW*, y, x, sign) was given y=-1 which resulted in an error,
which was not detected, because retval of it has not been checked.
The window render

spdk_top: Remove unused window elements

mvwaddach(WINDOW*, y, x, sign) was given y=-1 which resulted in an error,
which was not detected, because retval of it has not been checked.
The window renders the same without these as they were tried to be rendered outside of the window.

Change-Id: Ice2f50e08da13b403a66427412cbe4164f541ef7
Signed-off-by: Wojciech Panfil <wojciech.panfil@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18932
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

spdk_top: fix the cpu usage display issue in thread tab

Fix the issue that the cpu usage in thread tab shows empty when the CPUMASK does not start from zero.

Signed-off-by: Jaylyn Ren <jaylyn.ren@a

spdk_top: fix the cpu usage display issue in thread tab

Fix the issue that the cpu usage in thread tab shows empty when the CPUMASK does not start from zero.

Signed-off-by: Jaylyn Ren <jaylyn.ren@arm.com>
Change-Id: Ifd22feefd22a5dd0f87b20ff6c47bd196eb1a39a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17289
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

spdk_top: move core_busy_period and core_idle_period

Move these two variables below check for core_num boundary.
This ensures core_num's value can be used as index for g_cores_info
array.

Change-Id

spdk_top: move core_busy_period and core_idle_period

Move these two variables below check for core_num boundary.
This ensures core_num's value can be used as index for g_cores_info
array.

Change-Id: I118a4b3a3ec61c9ccd818f3f3bd2ff013d2d7b14
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17175
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

spdk_top: fix the core usage display issue

Fix the incorrect cpu usage display in core page.

Signed-off-by: Jaylyn Ren <jaylyn.ren@arm.com>
Change-Id: I073f4b16ed4c829f7713b2cb67bde54be5def783
Revi

spdk_top: fix the core usage display issue

Fix the incorrect cpu usage display in core page.

Signed-off-by: Jaylyn Ren <jaylyn.ren@arm.com>
Change-Id: I073f4b16ed4c829f7713b2cb67bde54be5def783
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17288
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

app/spdk_top: check the valid pointer earlier

Change-Id: I162d90257e7bf23cff9b9adc84b811f79c404da2
Signed-off-by: GangCao <gang.cao@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/

app/spdk_top: check the valid pointer earlier

Change-Id: I162d90257e7bf23cff9b9adc84b811f79c404da2
Signed-off-by: GangCao <gang.cao@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16178
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

spdk_top: In THREAD tab and CORES tab, the status of the CPU does not match the utilization.

eg. when CPU utilization is more than 95%, the status of CPU is Idle which should be Busy.

Signed-off-by

spdk_top: In THREAD tab and CORES tab, the status of the CPU does not match the utilization.

eg. when CPU utilization is more than 95%, the status of CPU is Idle which should be Busy.

Signed-off-by: YafeiWangAlice <yafei.wang@samsung.com>
Change-Id: I20ecacf1ed53c188cb12ca4d14cf22986a4740cc
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15783
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

spdk_top: add scheduler pop-up details window

Adds global scheduler pop-up details window displaying current
scheduler name, scheduler period and governor name.

Modify help window to include newly

spdk_top: add scheduler pop-up details window

Adds global scheduler pop-up details window displaying current
scheduler name, scheduler period and governor name.

Modify help window to include newly added scheduler pop-up.

Mofdify parameter "string" of print_left() function to take
const char* instead of char* - the string is not modified
in that function.

Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Change-Id: Icc0bdf55f716e5eed71a472f2c77c47ee2fc1b3d
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6459
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>

show more ...

spdk_top: add support for scrolling pages with arrow keys

Currently user can only use PgDn and PgUp to scroll pages,
which may be confusing.

Change-Id: I61632a9eba35bcc2c817d202935ef5999ba00bbb
Sig

spdk_top: add support for scrolling pages with arrow keys

Currently user can only use PgDn and PgUp to scroll pages,
which may be confusing.

Change-Id: I61632a9eba35bcc2c817d202935ef5999ba00bbb
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15656
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

spdk_top: fix display issues

Current issues:
-tab buttons do not show on app startup,
-interface not refreshing properly after closing help
window

Fix for the first bullet point is to change color

spdk_top: fix display issues

Current issues:
-tab buttons do not show on app startup,
-interface not refreshing properly after closing help
window

Fix for the first bullet point is to change color pair ID
from 2 to 10 (the colors WHITE and BLACK were swapped).

The new helper function has been added to remedy the problems
with refreshing interface after the pop-ups close. It is being
called after details windows and help window are closed.

Fixes: #2793

Change-Id: Ic91fc1ea8f858869c658b7803f6116fc4738aa63
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15655
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

show more ...

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date defa

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the 4 digit year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc). Contribution date used
"--follow -C95%" to get the most accurate date.

Note that several files in this patch didn't end the license/(c)
block with a blank comment line so these were added as the vast
majority of files do have this last blank line. Simply there for
consistency.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot

show more ...