spdk_dd: simplify `io_uring_peek_cqe` return code processing

`io_uring_peek_cqe` will only return `-EAGAIN` as an error, or
there is a valid CQE entry, then we can check `cqe->res` for
further proce

spdk_dd: simplify `io_uring_peek_cqe` return code processing

`io_uring_peek_cqe` will only return `-EAGAIN` as an error, or
there is a valid CQE entry, then we can check `cqe->res` for
further processing. Also return correct value for pollers.

Change-Id: If82744291b1b0bf42cb1cf2d9ab1524732ff8b40
Signed-off-by: Changpeng Liu <changpeliu@tencent.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25486
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@nvidia.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: GangCao <gang.cao@intel.com>
Reviewed-by: Ben Walker <ben@nvidia.com>

show more ...

apps: set NULL as RPC address in some apps

Set opts.rpc_addr to NULL in SPDK applications that usually do not
benefit from starting RPC interface. These include programs in app,
examples and test di

apps: set NULL as RPC address in some apps

Set opts.rpc_addr to NULL in SPDK applications that usually do not
benefit from starting RPC interface. These include programs in app,
examples and test directories.

Some of the tests now require that we explicitly set RPC address,
because some apps no longer use the default SPDK address.

Change-Id: I417a3a756581f44c711257e6d2408d933b40386a
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22634
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

app/spdk_dd: use configure option to build with uring

The support for uring in spdk_dd app was not actually compiled
in as the relevant configure option went unused.

This was not caught as there is

app/spdk_dd: use configure option to build with uring

The support for uring in spdk_dd app was not actually compiled
in as the relevant configure option went unused.

This was not caught as there is no way to force spdk_dd
to use uring, and relevant test function to check the
linking was broken.

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: If744ada604c270975b1814c3d4a7d3668a4cc8b9
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21836
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Community-CI: Mellanox Build Bot

show more ...

app/spdk_dd: unaffinitize SQ_POLL thread

Turns out that kernel SQ_POLL thread inherits the same
CPU mask as the thread it was called from. In case of SPDK
that would cover the CPU mask of the applic

app/spdk_dd: unaffinitize SQ_POLL thread

Turns out that kernel SQ_POLL thread inherits the same
CPU mask as the thread it was called from. In case of SPDK
that would cover the CPU mask of the application.
This severely limits the throughput, as SPDK and kernel
thread compete for the same core. To the order of less than
1 MiB/s, resulting in test time outs on CI too.

There does not seem to be a way to remove this restriction.
Meanwhile IORING_SETUP_SQ_AFF during ring initialization
only allows to pass a specific core, rather than a mask.

IORING_REGISTER_IOWQ_AFF opcode to io_uring_register() should
have been the solution to this problem, but it does not work
on my system as expected. Leaving unaffinitization as only
solution for now.

This patch unaffinitizes the SPDK thread only for
the ring initialization, so no such restriction is imposed
on the SQ_POLL thread.

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I7146c5e08bcb63219f800a3e0c343bb09fabd9f8
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21880
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>

show more ...

app/spdk_dd: dd was freezing with empty input file and count/skip flags

Previously process had to be killed, because of infinite loop in case
of g_error value assigned to rc.

Fix issue #3213

Chang

app/spdk_dd: dd was freezing with empty input file and count/skip flags

Previously process had to be killed, because of infinite loop in case
of g_error value assigned to rc.

Fix issue #3213

Change-Id: I6f483eb58594e1875c945d8159a9740548ca72ce
Signed-off-by: Marcin Suski <marcin.suski@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21792
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

app/spdk_dd: Added dd_exit() after encountering ERROR: Unknown file flag

Previously error didn't stop execution of process.

Fix issues #3221

Change-Id: If3a88170f0b943846e554d57b81187b0cbbddfda
Si

app/spdk_dd: Added dd_exit() after encountering ERROR: Unknown file flag

Previously error didn't stop execution of process.

Fix issues #3221

Change-Id: If3a88170f0b943846e554d57b81187b0cbbddfda
Signed-off-by: Marcin Suski <marcin.suski@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21704
Community-CI: Mellanox Build Bot
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Reviewed-by: Jim Harris <jim.harris@samsung.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>

show more ...

app/spdk_dd: remove unnecessary initialization value

dd_show_progress() inits speed_type to an empty string,
but that string value itself is never used - it always
gets overwritten by a value from s

app/spdk_dd: remove unnecessary initialization value

dd_show_progress() inits speed_type to an empty string,
but that string value itself is never used - it always
gets overwritten by a value from speed_type_str array.

Found by scan-build.

Signed-off-by: Kamil Godzwon <kamilx.godzwon@intel.com>
Change-Id: I9612fd7f806dc34afecba9e6672488e91f451d85
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18187
Reviewed-by: Michal Berger <michal.berger@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Pawel Piatek <pawelx.piatek@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>

show more ...

spdk_dd: use SPDK_POLLER_REGISTER

This was missed when we created the SPDK_POLLER_REGISTER
macro to use the poller function name as the name of the
poller. All other uses of spdk_poller_register we

spdk_dd: use SPDK_POLLER_REGISTER

This was missed when we created the SPDK_POLLER_REGISTER
macro to use the poller function name as the name of the
poller. All other uses of spdk_poller_register were
switched to SPDK_POLLER_REGISTER except for these.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: Idcb77f14c710dea08e36b1ed01a0eb8f6ab17045
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15755
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Xiaodong Liu <xiaodong.liu@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Community-CI: Mellanox Build Bot

show more ...

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date defa

update Intel copyright notices

per Intel policy to include file commit date using git cmd
below. The policy does not apply to non-Intel (C) notices.

git log --follow -C90% --format=%ad --date default <file> | tail -1

and then pull just the 4 digit year from the result.

Intel copyrights were not added to files where Intel either had
no contribution ot the contribution lacked substance (ie license
header updates, formatting changes, etc). Contribution date used
"--follow -C95%" to get the most accurate date.

Note that several files in this patch didn't end the license/(c)
block with a blank comment line so these were added as the vast
majority of files do have this last blank line. Simply there for
consistency.

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Community-CI: Mellanox Build Bot

show more ...