Remove stylistic differences between arp(8) and ndp(8) delete()
function. This makes it easier to spot real changes in behavior.
OK kn@

Zap unused h_errno

Revision 1.84 removed the last user; no object change.

Simplify function detection

To determine which "function" (get, set, ...) is requested, use getopt(3)'s
result directly as ndp(8) does instead of translating everyting into
internal F_* defines and

Simplify function detection

To determine which "function" (get, set, ...) is requested, use getopt(3)'s
result directly as ndp(8) does instead of translating everyting into
internal F_* defines and back again.

Avoids one level of indirection, chops 22 lines of code and brings both
tools closer together.

OK bluhm

show more ...

The algorithm creating the routing addresses in route(8) and arp(6)
were still not correct. While the values written to the kernel are
fine, the bytes for padding were taken from memory after the so

The algorithm creating the routing addresses in route(8) and arp(6)
were still not correct. While the values written to the kernel are
fine, the bytes for padding were taken from memory after the sockaddr
structs.
In route(8) the union of sockaddrs can be made larger, so that the
padding is taken from there.
In arp(8) the size of the struct is known. Copy only the struct
and advance over the padding. The memory has been zeroed before.
Merge all address size fixes from arp(8) into ndp(8).
OK claudio@

show more ...

The IFP address in arp(8) used some bytes from a location depending
on sizeof(long) as sockaddr_dl. We were lucky and it worked. Use
the correct size and the algorithm from route(8) for arp(8).
OK

The IFP address in arp(8) used some bytes from a location depending
on sizeof(long) as sockaddr_dl. We were lucky and it worked. Use
the correct size and the algorithm from route(8) for arp(8).
OK mpi@

show more ...

Honour -n when deleting entries, sync parse_host() from ndp(8)

arp(8) already has a common getinetaddr() but it ignores -n for delete() and
uses gethostbyname(3), so simply replace it with parse_hos

Honour -n when deleting entries, sync parse_host() from ndp(8)

arp(8) already has a common getinetaddr() but it ignores -n for delete() and
uses gethostbyname(3), so simply replace it with parse_host() from ndp.c
instead of changing behaviour around the old API.

In set(), make host[] and eaddr[] const since all functions receiving those
variables as parameters expect const anyway.

OK bluhm

show more ...

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

show more ...

PF_ROUTE -> AF_ROUTE in the scattered sock()/setsockopt() calls
where the "wrong" #define was used.

ok dlg@

Use <fcntl.h> instead of <sys/file.h> for open() and friends.
Delete a bunch of unnecessary #includes and sort to match style(9)
while doing the above cleanup.

ok deraadt@ krw@

As we only use the .tv_sec field, simplify gettimeofday(2) -> time(3).

ok tb@ jca@

Switch base tools from /dev/bpf0 to /dev/bpf. Now that /dev/bpf has been
around for two releases, it should be safe to do so.

ok bluhm deraadt sthen tb yasuoka

Name global variable for routing socket rtsock like in ndp(8).
OK florian@

Tweak output to keep it aligned when interfaces with big names, like
vether0 are used.

ok jca@, deraadt@

Pull in <sys/time.h> for gettimeofday()

ok deraadt@

Replace the /dev/bpf* open loop with a plain open("/dev/bpf0", ...).
ok deraadt jca

Kill undocumented "pro" command. It's a no-op since the 90s!

Rename 'rtn' to 'error' for coherency.

Remove code to print the never set SIN_PROXY bit. This flag is only used
to set the 33rd bit of a 32bit address in the routing table.

ok millert@

Use an unsigned int rather than an int when iterating through all 32
bits in the form:

for (i = 1; i; i <<= 1)

This avoids undefined operations when shifting into and out of the
highest-order bit.

Use an unsigned int rather than an int when iterating through all 32
bits in the form:

for (i = 1; i; i <<= 1)

This avoids undefined operations when shifting into and out of the
highest-order bit.

ok millert@

show more ...

remove undocumented message about trailers

I messed up reading the call graph. -d delete does use search, so a
late pledge is not possible in this way.

Change all tame callers to namechange to pledge(2).

use new tame "route" feature when possible

correct a rtget() error check
this function could only return 0 or 1, and 1 on error.

avoid to deref an uninitialised variable if rtget() return an error.

ok millert@ benno@ deraadt@

arp uses a non-privileged sockraw to look at the kernel arp tables.
the function to do that is called a number of times, but as needed.
hoist it upwards into initization, then tame "stdio dns inet" i

arp uses a non-privileged sockraw to look at the kernel arp tables.
the function to do that is called a number of times, but as needed.
hoist it upwards into initization, then tame "stdio dns inet" is
possible in most code paths. (there may be further work to do here here)
i believe florian helped me with this.

show more ...