When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

show more ...

add new '-c' option which runs a command instead of an interactive shell

from Paul de Weerd
ok ian@ job@; manpage bits are ok jmc@

bluhm discovered "script < /dev/null" attempts tty operations in violation
of pledge. We can wrap isatty() around those codepaths.
ok bluhm beck

add "proc" to pledge for script(1)

it needs to "forward" SIGWINCH to subprocesses.

ok deraadt@

Change all tame callers to namechange to pledge(2).

move from tame "ioctl" to tame "tty", which provides a better fit for
this program which uses tcgetattr(). the tcsetattr() calls are outside
the tame regions.

Repair tame() error check to be == -1

script is two processes. the main io-loop process can be locked down with
tame "stdio" since all it does is move data back and forth, while the master
process needs "stdio ioctl" to use TCSAFLUSH at

script is two processes. the main io-loop process can be locked down with
tame "stdio" since all it does is move data back and forth, while the master
process needs "stdio ioctl" to use TCSAFLUSH at the very end. TCSAFLUSH is
included in the kernel's rather restrictive ioctl feature lists made
available with the "ioctl" ability.

show more ...

SIGCHLD handler was established before forking into two processes.
As a result it also ran in the child (incorrect).
ok miod

tzfile.h is an internal header that should never have been installed.
What's worse, the tzfile.h that gets installed is over 20 years old
and doesn't match the real tzfile.h in libc/time. This makes

tzfile.h is an internal header that should never have been installed.
What's worse, the tzfile.h that gets installed is over 20 years old
and doesn't match the real tzfile.h in libc/time. This makes the
tree safe for /usr/include/tzfile.h removal. The TM_YEAR_BASE
define has been moved to time.h temporarily until its usage is
replaced by 1900 in the tree. Actual removal of tzfile.h is pending
a ports build. Based on a diff from deraadt@

show more ...

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(th

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

show more ...

in the write codepaths, errors other than EAGAIN are fatal to the loop; ok otto

use STDERR_FILENO; ok cloder

Block SIGALRM during write--we only want it to interrupt read().
OK deraadt@

use err/warn and __progname

ARGSUSED before signal handler with unused signo

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be don

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

show more ...

After a simplistic rewrite, signal flags were not being noticed until a
succesfull read operation. To avoid this, we must use SA_RESTART, and
rewrite most of the guts to handle interrupted read, wri

After a simplistic rewrite, signal flags were not being noticed until a
succesfull read operation. To avoid this, we must use SA_RESTART, and
rewrite most of the guts to handle interrupted read, write, etc, even being
careful to check what library routines are called.... input from millert,
markus, and espie

show more ...

correct type on last arg to execl(); nordin@cse.ogi.edu

comment on a real nasty race

warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant). These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in t

warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant). These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

show more ...

Propagate window size changes to slave.

Make script give correct return values; adapted from FreeBSD